package: fix unmet dependencies (branch yem/misc-fixes)
cover package: fix unmet dependencies (branch yem/misc-fixes)
Hello All!
This series brings in a few cleanups in the propagating of dependencies across packages, to solve various warnings abot "unmet dependencies", which are unfortunately not errors...
The situation is often a bit non-trivial to fix, especially for the openssh and ivi-homescreen cases, and hopefully the heuristic that has been implemented is not too strict.
Regards,
Yann E. MORIN.
----------------------------------------------------------------
Yann E. MORIN (10):
package/util-linux: propagate linux-pam dependencies package/ivi-homescreen: fix dependencies for gstreamer plugin package/openssh: fix dependencies with refpolicy package/re2: propagate dependencies from libabseil-cpp package/petitboot: fix ordering of comments and sub-options package/petitboot: propagate depednencies from kexec/kexec-lite package/python-ml-dtypes: propagate dependencies from numpy, pybind package/opencv4: propagate internal dependencies package/opencv-contrib: propagate opencv4 dependencies package/atkmm: propagate dependency from at-spi2-core
package/atkmm/Config.in | 1 + package/grpc/Config.in | 2 +- package/ivi-homescreen/Config.in | 9 ++++----- package/opencv4-contrib/Config.in | 30 ++++++++++++++++++++++++++++++ package/opencv4/Config.in | 6 ++++++ package/openssh/Config.in | 12 ++++++++++++ package/petitboot/Config.in | 28 ++++++++++++++++++---------- package/python-ml-dtypes/Config.in | 1 + package/qt5/qt5webengine/Config.in | 1 + package/re2/Config.in | 8 ++++++-- package/sshfs/Config.in | 7 +++++++ package/util-linux/Config.in | 27 +++++++++++++++++++-------- 12 files changed, 106 insertions(+), 26 deletions(-)
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
PATCH 1/10 package/util-linux: propagate linux-pam dependencies
Commit c77e25c3f113 (package/linux-pam: needs gcc >= 4.9) forgot to propagate that new dependency to the util-linux runuser and su, yielding unmet dependencies warnings (unfortunately, not errors), such as:
$ KCONFIG_SEED=0x8AE589A3 make randconfig
WARNING: unmet direct dependencies detected for BR2_PACKAGE_LINUX_PAM
Depends on [n]: BR2_ENABLE_LOCALE [=y] && BR2_USE_WCHAR [=y] && !BR2_STATIC_LIBS [=n] && BR2_USE_MMU [=y] && BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 [=n]
Selected by [y]:
- BR2_PACKAGE_UTIL_LINUX_RUNUSER [=y] && BR2_PACKAGE_UTIL_LINUX [=y] && BR2_ENABLE_LOCALE [=y] && BR2_USE_WCHAR [=y] && !BR2_STATIC_LIBS [=n] && !BR2_TOOLCHAIN_USES_MUSL [=n] && BR2_USE_MMU [=y]
- BR2_PACKAGE_UTIL_LINUX_SU [=y] && BR2_PACKAGE_UTIL_LINUX [=y] && BR2_ENABLE_LOCALE [=y] && BR2_USE_WCHAR [=y] && !BR2_STATIC_LIBS [=n] && !BR2_TOOLCHAIN_USES_MUSL [=n] && BR2_USE_MMU [=y]--- package/util-linux/Config.in | 27 +++++++++++++++++++-------- 1 file changed, 19 insertions(+), 8 deletions(-)
package/util-linux/Config.in +19 -8
@@ -88,13 +88,15 @@ config BR2_PACKAGE_UTIL_LINUX_CHFN_CHSH depends on (BR2_ENABLE_LOCALE && BR2_USE_WCHAR) # linux-pam depends on !BR2_STATIC_LIBS depends on BR2_USE_MMU # linux-pam + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # linux-pam select BR2_PACKAGE_LINUX_PAM help Change login shell, real user name and information -comment "chfn/chsh needs a toolchain w/ wchar, locale, dynamic library" +comment "chfn/chsh needs a toolchain w/ wchar, locale, dynamic library, gcc >= 4.9" depends on !(BR2_ENABLE_LOCALE && BR2_USE_WCHAR) \ - || BR2_STATIC_LIBS + || BR2_STATIC_LIBS \ + || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 config BR2_PACKAGE_UTIL_LINUX_CHMEM bool "chmem"
@@ -196,13 +198,16 @@ config BR2_PACKAGE_UTIL_LINUX_LOGIN depends on !BR2_STATIC_LIBS # linux-pam depends on !BR2_TOOLCHAIN_USES_MUSL # linux-pam depends on BR2_USE_MMU # fork(), linux-pam + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # linux-pam select BR2_PACKAGE_LINUX_PAM help Begin a session on the system -comment "login needs a uClibc or glibc toolchain w/ wchar, locale, dynamic library" +comment "login needs a uClibc or glibc toolchain w/ wchar, locale, dynamic library, gcc >= 4.9" depends on !(BR2_ENABLE_LOCALE && BR2_USE_WCHAR) \ - || BR2_STATIC_LIBS || BR2_TOOLCHAIN_USES_MUSL + || BR2_STATIC_LIBS \ + || BR2_TOOLCHAIN_USES_MUSL \ + || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 config BR2_PACKAGE_UTIL_LINUX_LOSETUP bool "losetup"
@@ -343,15 +348,18 @@ config BR2_PACKAGE_UTIL_LINUX_RUNUSER depends on !BR2_STATIC_LIBS depends on !BR2_TOOLCHAIN_USES_MUSL # linux-pam depends on BR2_USE_MMU # fork(), linux-pam + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # linux-pam select BR2_PACKAGE_LINUX_PAM help Run a command with substitute user and group ID (does not need to ask for a password, because it may be executed by the root user only) -comment "runuser needs a uClibc or glibc toolchain w/ wchar, locale, dynamic library" +comment "runuser needs a uClibc or glibc toolchain w/ wchar, locale, dynamic library, gcc >= 4.9" depends on !(BR2_ENABLE_LOCALE && BR2_USE_WCHAR) \ - || BR2_STATIC_LIBS || BR2_TOOLCHAIN_USES_MUSL + || BR2_STATIC_LIBS \ + || BR2_TOOLCHAIN_USES_MUSL \ + || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 config BR2_PACKAGE_UTIL_LINUX_SCHEDUTILS bool "scheduling utilities"
@@ -380,13 +388,16 @@ config BR2_PACKAGE_UTIL_LINUX_SU depends on !BR2_STATIC_LIBS depends on !BR2_TOOLCHAIN_USES_MUSL # linux-pam depends on BR2_USE_MMU # fork(), linux-pam + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # linux-pam select BR2_PACKAGE_LINUX_PAM help Run a command with substitute user and group ID -comment "su needs a uClibc or glibc toolchain w/ wchar, locale, dynamic library" +comment "su needs a uClibc or glibc toolchain w/ wchar, locale, dynamic library, gcc >= 4.9" depends on !(BR2_ENABLE_LOCALE && BR2_USE_WCHAR) \ - || BR2_STATIC_LIBS || BR2_TOOLCHAIN_USES_MUSL + || BR2_STATIC_LIBS \ + || BR2_TOOLCHAIN_USES_MUSL \ + || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 config BR2_PACKAGE_UTIL_LINUX_SULOGIN bool "sulogin"
Signature · 6 lines
2.43.0 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Thomas Petazzoni via buildroot
AppliedRe: [Buildroot] [PATCH 01/10] package/util-linux: propagate linux-pam dependencies
Quoted 11 lines · On Sun, 28 Jan 2024 14:20:50 +0100 "Yann E. MORIN" <[email protected]>…
Commit
c77e25c3f113(package/linux-pam: needs gcc >= 4.9) forgot to propagate that new dependency to the util-linux runuser and su, yielding unmet dependencies warnings (unfortunately, not errors), such as:$ KCONFIG_SEED=0x8AE589A3 make randconfig WARNING: unmet direct dependencies detected for BR2_PACKAGE_LINUX_PAM Depends on [n]: BR2_ENABLE_LOCALE [=y] && BR2_USE_WCHAR [=y] && !BR2_STATIC_LIBS [=n] && BR2_USE_MMU [=y] && BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 [=n] Selected by [y]: - BR2_PACKAGE_UTIL_LINUX_RUNUSER [=y] && BR2_PACKAGE_UTIL_LINUX [=y] && BR2_ENABLE_LOCALE [=y] && BR2_USE_WCHAR [=y] && !BR2_STATIC_LIBS [=n] && !BR2_TOOLCHAIN_USES_MUSL [=n] && BR2_USE_MMU [=y] - BR2_PACKAGE_UTIL_LINUX_SU [=y] && BR2_PACKAGE_UTIL_LINUX [=y] && BR2_ENABLE_LOCALE [=y] && BR2_USE_WCHAR [=y] && !BR2_STATIC_LIBS [=n] && !BR2_TOOLCHAIN_USES_MUSL [=n] && BR2_USE_MMU [=y]
Quoted 5 lines
Signed-off-by Yann E. MORIN <[email protected]>Cc Fabrice Fontaine <[email protected]>--- package/util-linux/Config.in | 27 +++++++++++++++++++-------- 1 file changed, 19 insertions(+), 8 deletions(-)
Applied to master, thanks.
Thomas
Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
PATCH 2/10 package/ivi-homescreen: fix dependencies for gstreamer plugin
In reply to Yann E. MORINThe gstreamer plugin select the EGL backend of gst1-plugins-base, but forgot to propagate all of its dependencies, notably the _HAS_API condition, causing unmet dependencies warnings (unfortunately, not errors), such as;
$ KCONFIG_SEED=0x597D22A8 make randconfig
WARNING: unmet direct dependencies detected for BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL_EGL
Depends on [n]: BR2_PACKAGE_GSTREAMER1 [=y] && BR2_PACKAGE_GST1_PLUGINS_BASE [=y] && BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL [=y] && BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL_HAS_API [=n] && BR2_PACKAGE_HAS_LIBEGL [=y]
Selected by [y]:
- BR2_PACKAGE_IVI_HOMESCREEN_GSTREAMER_EGL_PLUGIN [=y] && BR2_PACKAGE_IVI_HOMESCREEN [=y] && BR2_PACKAGE_FFMPEG_ARCH_SUPPORTS [=y] && BR2_PACKAGE_HAS_LIBEGL [=y]We can't select _HAS_API, because it is a symbol that represents a capability provided by other features of gst1-plugins-base; it's semantically like a virtual package: we can't select it, we can only depend on it.
Add this dependency to fix this situation.
This however causes circular (recursive) dependencies errors:
package/gstreamer1/gst1-plugins-base/Config.in:135:error: recursive dependency detected!
package/gstreamer1/gst1-plugins-base/Config.in:135: symbol BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL is selected by BR2_PACKAGE_IVI_HOMESCREEN_GSTREAMER_EGL_PLUGIN
package/ivi-homescreen/Config.in:221: symbol BR2_PACKAGE_IVI_HOMESCREEN_GSTREAMER_EGL_PLUGIN depends on BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL_HAS_API
package/gstreamer1/gst1-plugins-base/Config.in:149: symbol BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL_HAS_API is selected by BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL_OPENGL
package/gstreamer1/gst1-plugins-base/Config.in:152: symbol BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL_OPENGL depends on BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL
Indeed, _HAS_API is only even set when gstreamer1, gst1-plugins-base, and the gst1-plugins-base's lib-opengl support, are all already enabled. As such, the dependency on _HAS_API already implies those, and there is no need to select them.
--- package/ivi-homescreen/Config.in | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)
package/ivi-homescreen/Config.in +4 -5
@@ -222,10 +222,8 @@ config BR2_PACKAGE_IVI_HOMESCREEN_GSTREAMER_EGL_PLUGIN bool "GStreamer EGL" depends on BR2_PACKAGE_FFMPEG_ARCH_SUPPORTS depends on BR2_PACKAGE_HAS_LIBEGL + depends on BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL_HAS_API # GST1_PLUGINS_BASE_LIB_OPENGL_EGL select BR2_PACKAGE_FFMPEG - select BR2_PACKAGE_GSTREAMER1 - select BR2_PACKAGE_GST1_PLUGINS_BASE - select BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL select BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL_EGL help A GStreamer-powered alternative to Flutter's video_player that
@@ -233,9 +231,10 @@ config BR2_PACKAGE_IVI_HOMESCREEN_GSTREAMER_EGL_PLUGIN https://pub.dev/packages/flutter_gstreamer_player -comment "GStreamer plugin needs an EGL backend" +comment "GStreamer plugin needs gst1-plugins-base with an EGL backend" depends on BR2_PACKAGE_FFMPEG_ARCH_SUPPORTS - depends on !BR2_PACKAGE_HAS_LIBEGL + depends on !BR2_PACKAGE_HAS_LIBEGL \ + || !BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL_HAS_API config BR2_PACKAGE_IVI_HOMESCREEN_OPENGL_TEXTURE_PLUGIN bool "OpenGL Texture"
Signature · 6 lines
2.43.0 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Re: [Buildroot] [PATCH 02/10] package/ivi-homescreen: fix dependencies for gstreamer plugin
Yann;
Quoted 27 lines · Yann E. MORIN
The gstreamer plugin select the EGL backend of gst1-plugins-base, but forgot to propagate all of its dependencies, notably the
_HAS_APIcondition, causing unmet dependencies warnings (unfortunately, not errors), such as;$ KCONFIG_SEED=0x597D22A8 make randconfig WARNING: unmet direct dependencies detected for BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL_EGL Depends on [n]: BR2_PACKAGE_GSTREAMER1 [=y] && BR2_PACKAGE_GST1_PLUGINS_BASE [=y] && BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL [=y] && BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL_HAS_API [=n] && BR2_PACKAGE_HAS_LIBEGL [=y] Selected by [y]: - BR2_PACKAGE_IVI_HOMESCREEN_GSTREAMER_EGL_PLUGIN [=y] && BR2_PACKAGE_IVI_HOMESCREEN [=y] && BR2_PACKAGE_FFMPEG_ARCH_SUPPORTS [=y] && BR2_PACKAGE_HAS_LIBEGL [=y]We can't select
_HAS_API, because it is a symbol that represents a capability provided by other features of gst1-plugins-base; it's semantically like a virtual package: we can't select it, we can only depend on it.Add this dependency to fix this situation.
This however causes circular (recursive) dependencies errors:
package/gstreamer1/gst1-plugins-base/Config.in:135:error: recursive dependency detected!
package/gstreamer1/gst1-plugins-base/Config.in:135: symbolBR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGLis selected byBR2_PACKAGE_IVI_HOMESCREEN_GSTREAMER_EGL_PLUGIN
package/ivi-homescreen/Config.in:221: symbolBR2_PACKAGE_IVI_HOMESCREEN_GSTREAMER_EGL_PLUGINdepends onBR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL_HAS_API
package/gstreamer1/gst1-plugins-base/Config.in:149: symbolBR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL_HAS_APIis selected byBR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL_OPENGL
package/gstreamer1/gst1-plugins-base/Config.in:152: symbolBR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL_OPENGLdepends onBR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL
Quoted 5 lines
Indeed,
_HAS_APIis only even set when gstreamer1, gst1-plugins-base, and the gst1-plugins-base's lib-opengl support, are all already enabled. As such, the dependency on_HAS_APIalready implies those, and there is no need to select them.
Thank you so much for the patch. I didn't even notice this! I'm so sorry!
Quoted 36 lines
Signed-off-by Yann E. MORIN <[email protected]>Cc Adam Duskett <[email protected]>--- package/ivi-homescreen/Config.in | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)package/ivi-homescreen/Config.in +4
-6@@ -222,10 +222,8 @@ config BR2_PACKAGE_IVI_HOMESCREEN_GSTREAMER_EGL_PLUGIN bool "GStreamer EGL" depends on BR2_PACKAGE_FFMPEG_ARCH_SUPPORTS depends on BR2_PACKAGE_HAS_LIBEGL + depends on BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL_HAS_API # GST1_PLUGINS_BASE_LIB_OPENGL_EGL select BR2_PACKAGE_FFMPEG - select BR2_PACKAGE_GSTREAMER1 - select BR2_PACKAGE_GST1_PLUGINS_BASE - select BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL select BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL_EGL help A GStreamer-powered alternative to Flutter's video_player that@@ -233,9 +231,10 @@ config BR2_PACKAGE_IVI_HOMESCREEN_GSTREAMER_EGL_PLUGIN https://pub.dev/packages/flutter_gstreamer_player -comment "GStreamer plugin needs an EGL backend" +comment "GStreamer plugin needs gst1-plugins-base with an EGL backend" depends on BR2_PACKAGE_FFMPEG_ARCH_SUPPORTS - depends on !BR2_PACKAGE_HAS_LIBEGL + depends on !BR2_PACKAGE_HAS_LIBEGL \ + || !BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL_HAS_API config BR2_PACKAGE_IVI_HOMESCREEN_OPENGL_TEXTURE_PLUGIN bool "OpenGL Texture" --
Quoted 2 lines
2.43.0
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Thomas Petazzoni via buildroot
AppliedRe: [Buildroot] [PATCH 02/10] package/ivi-homescreen: fix dependencies for gstreamer plugin
In reply to Yann E. MORINQuoted 31 lines · On Sun, 28 Jan 2024 14:20:51 +0100 "Yann E. MORIN" <[email protected]>…
The gstreamer plugin select the EGL backend of gst1-plugins-base, but forgot to propagate all of its dependencies, notably the
_HAS_APIcondition, causing unmet dependencies warnings (unfortunately, not errors), such as;$ KCONFIG_SEED=0x597D22A8 make randconfig WARNING: unmet direct dependencies detected for BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL_EGL Depends on [n]: BR2_PACKAGE_GSTREAMER1 [=y] && BR2_PACKAGE_GST1_PLUGINS_BASE [=y] && BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL [=y] && BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL_HAS_API [=n] && BR2_PACKAGE_HAS_LIBEGL [=y] Selected by [y]: - BR2_PACKAGE_IVI_HOMESCREEN_GSTREAMER_EGL_PLUGIN [=y] && BR2_PACKAGE_IVI_HOMESCREEN [=y] && BR2_PACKAGE_FFMPEG_ARCH_SUPPORTS [=y] && BR2_PACKAGE_HAS_LIBEGL [=y]We can't select
_HAS_API, because it is a symbol that represents a capability provided by other features of gst1-plugins-base; it's semantically like a virtual package: we can't select it, we can only depend on it.Add this dependency to fix this situation.
This however causes circular (recursive) dependencies errors:
package/gstreamer1/gst1-plugins-base/Config.in:135:error: recursive dependency detected!
package/gstreamer1/gst1-plugins-base/Config.in:135: symbolBR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGLis selected byBR2_PACKAGE_IVI_HOMESCREEN_GSTREAMER_EGL_PLUGIN
package/ivi-homescreen/Config.in:221: symbolBR2_PACKAGE_IVI_HOMESCREEN_GSTREAMER_EGL_PLUGINdepends onBR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL_HAS_API
package/gstreamer1/gst1-plugins-base/Config.in:149: symbolBR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL_HAS_APIis selected byBR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL_OPENGL
package/gstreamer1/gst1-plugins-base/Config.in:152: symbolBR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL_OPENGLdepends onBR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGLIndeed,
_HAS_APIis only even set when gstreamer1, gst1-plugins-base, and the gst1-plugins-base's lib-opengl support, are all already enabled. As such, the dependency on_HAS_APIalready implies those, and there is no need to select them.
Quoted 5 lines
Signed-off-by Yann E. MORIN <[email protected]>Cc Adam Duskett <[email protected]>--- package/ivi-homescreen/Config.in | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)
Applied to master, thanks.
Thomas
Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
PATCH 3/10 package/openssh: fix dependencies with refpolicy
In reply to Yann E. MORINCommit 2c5a82a29ceb(package/openssh: select linux-pam if refpolicy upstream is selected) did not account for the linux-pam dependencies before selecting it, causing unmet dependencies warnings (unfortunately, not errors), such as:
$ KCONFIG_SEED=0x8D55903B make randconfig
WARNING: unmet direct dependencies detected for BR2_PACKAGE_LIBABSEIL_CPP
Depends on [n]: BR2_INSTALL_LIBSTDCPP [=y] && BR2_TOOLCHAIN_GCC_AT_LEAST_8 [=y] && BR2_TOOLCHAIN_HAS_THREADS [=y] && !BR2_STATIC_LIBS [=n] && BR2_PACKAGE_LIBABSEIL_CPP_ARCH_SUPPORTS [=n]
Selected by [y]:
- BR2_PACKAGE_RE2 [=y] && BR2_INSTALL_LIBSTDCPP [=y] && BR2_TOOLCHAIN_GCC_AT_LEAST_8 [=y] && BR2_TOOLCHAIN_HAS_THREADS [=y]Propagate those dependencies, but only when they are required, i.e. only when the upstreram refpolicy is used.
Transitively propagate those also to sshfs, for those two it did not already have; we use a separate coment to cimplify the comment prompt.
--- package/openssh/Config.in | 12 ++++++++++++ package/sshfs/Config.in | 7 +++++++ 2 files changed, 19 insertions(+)
package/openssh/Config.in +12 -0
@@ -1,6 +1,10 @@ config BR2_PACKAGE_OPENSSH bool "openssh" depends on BR2_USE_MMU # fork() + depends on BR2_ENABLE_LOCALE || !BR2_PACKAGE_REFPOLICY_UPSTREAM_VERSION # linux-pam + depends on BR2_USE_WCHAR || !BR2_PACKAGE_REFPOLICY_UPSTREAM_VERSION # linux-pam + depends on !BR2_STATIC_LIBS || !BR2_PACKAGE_REFPOLICY_UPSTREAM_VERSION # linux-pam + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 || !BR2_PACKAGE_REFPOLICY_UPSTREAM_VERSION # linux-pam select BR2_PACKAGE_LINUX_PAM if BR2_PACKAGE_REFPOLICY_UPSTREAM_VERSION select BR2_PACKAGE_OPENSSL select BR2_PACKAGE_ZLIB
@@ -41,3 +45,11 @@ config BR2_PACKAGE_OPENSSH_SANDBOX This is normally preferable, but may cause seccomp problems for certain combinations of C libraries and kernel versions. endif + +comment "openssh w/ refpolicy needs a toolchain w/ gcc >= 4.9, locale, wchar, dynamic library" + depends on BR2_USE_MMU + depends on BR2_PACKAGE_REFPOLICY_UPSTREAM_VERSION + depends on !BR2_ENABLE_LOCALE \ + || !BR2_USE_WCHAR \ + || BR2_STATIC_LIBS \ + || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
package/sshfs/Config.in +7 -0
@@ -4,6 +4,8 @@ config BR2_PACKAGE_SSHFS depends on BR2_TOOLCHAIN_HAS_THREADS # libfuse3, glib2 depends on BR2_USE_MMU # libfuse3, glib2 depends on !BR2_STATIC_LIBS # libfuse3 + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 || !BR2_PACKAGE_REFPOLICY_UPSTREAM_VERSION # openssh + depends on BR2_ENABLE_LOCALE || !BR2_PACKAGE_REFPOLICY_UPSTREAM_VERSION # openssh select BR2_PACKAGE_LIBFUSE3 select BR2_PACKAGE_LIBGLIB2 select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE
@@ -17,3 +19,8 @@ config BR2_PACKAGE_SSHFS comment "sshfs needs a toolchain w/ wchar, threads, dynamic library" depends on BR2_USE_MMU depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS + +comment "sshfs w/ refpolicy needs a toolchain w/ gcc >= 4.9, locale" + depends on BR2_USE_MMU + depends on (!BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 && BR2_PACKAGE_REFPOLICY_UPSTREAM_VERSION) \ + || (!BR2_ENABLE_LOCALE && BR2_PACKAGE_REFPOLICY_UPSTREAM_VERSION)
Signature · 6 lines
2.43.0 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Re: [Buildroot] [PATCH 03/10] package/openssh: fix dependencies with refpolicy
Hello,
Quoted 10 lines · On Sun, 28 Jan 2024 14:20:52 +0100 "Yann E. MORIN" <[email protected]>…
Commit 2c5a82a29ceb(package/openssh: select linux-pam if refpolicy upstream is selected) did not account for the linux-pam dependencies before selecting it, causing unmet dependencies warnings (unfortunately, not errors), such as:
$ KCONFIG_SEED=0x8D55903B make randconfig WARNING: unmet direct dependencies detected for BR2_PACKAGE_LIBABSEIL_CPP Depends on [n]: BR2_INSTALL_LIBSTDCPP [=y] && BR2_TOOLCHAIN_GCC_AT_LEAST_8 [=y] && BR2_TOOLCHAIN_HAS_THREADS [=y] && !BR2_STATIC_LIBS [=n] && BR2_PACKAGE_LIBABSEIL_CPP_ARCH_SUPPORTS [=n] Selected by [y]: - BR2_PACKAGE_RE2 [=y] && BR2_INSTALL_LIBSTDCPP [=y] && BR2_TOOLCHAIN_GCC_AT_LEAST_8 [=y] && BR2_TOOLCHAIN_HAS_THREADS [=y]
Seems like this was copy/pasted from the wrong error :-)
Also, as we discussed during the meeting, it seems like we want to:
- Move this select to the refpolicy package
- Handle it as a "soft select" that selects linux-pam if possible, to not have some crazy dependencies for a quite corner case (using SELinux non a non-glibc system, with a toolchain missing locale/wchar, etc.)
Could you rework according to our discussion?
Thanks a lot!
Thomas
Signature · 7 lines
Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering and training https://bootlin.com _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
PATCH 4/10 package/re2: propagate dependencies from libabseil-cpp
In reply to Yann E. MORINCommit fc7606010e4e (package/re2: bump to version 2023.11.01) forgot to propagate the arch dependency from libabsel-cpp to re2, and transitively to its dependees, causing unmet dependencies warnings (unfortunately, not errors), such as:
$ KCONFIG_SEED=0xCCB17344 make randconfig
WARNING: unmet direct dependencies detected for BR2_PACKAGE_LIBABSEIL_CPP
Depends on [n]: BR2_INSTALL_LIBSTDCPP [=y] && BR2_TOOLCHAIN_GCC_AT_LEAST_8 [=y] && BR2_TOOLCHAIN_HAS_THREADS [=y] && !BR2_STATIC_LIBS [=n] && BR2_PACKAGE_LIBABSEIL_CPP_ARCH_SUPPORTS [=n]
Selected by [y]:
- BR2_PACKAGE_RE2 [=y] && BR2_INSTALL_LIBSTDCPP [=y] && BR2_TOOLCHAIN_GCC_AT_LEAST_8 [=y] && BR2_TOOLCHAIN_HAS_THREADS [=y]Fix that, and propagate the dependency.
Note that qt5webengine depends on glibc, so that implies !static already.
--- package/grpc/Config.in | 2 +- package/qt5/qt5webengine/Config.in | 1 + package/re2/Config.in | 8 ++++++-- 3 files changed, 8 insertions(+), 3 deletions(-)
package/grpc/Config.in +1 -1
@@ -4,7 +4,7 @@ config BR2_PACKAGE_GRPC depends on BR2_TOOLCHAIN_HAS_THREADS # protobuf, re2 depends on BR2_PACKAGE_PROTOBUF_ARCH_SUPPORTS # protobuf depends on BR2_TOOLCHAIN_GCC_AT_LEAST_8 # libabseil-cpp, re2 - depends on !BR2_STATIC_LIBS # protobuf, libabseil-cpp + depends on !BR2_STATIC_LIBS # protobuf, libabseil-cpp, re2 depends on BR2_TOOLCHAIN_HAS_SYNC_4 || BR2_TOOLCHAIN_HAS_ATOMIC depends on BR2_PACKAGE_LIBABSEIL_CPP_ARCH_SUPPORTS select BR2_PACKAGE_C_ARES
package/qt5/qt5webengine/Config.in +1 -0
@@ -9,6 +9,7 @@ config BR2_PACKAGE_QT5WEBENGINE_ARCH_SUPPORTS depends on BR2_PACKAGE_QT5_JSCORE_AVAILABLE # qt5declarative depends on !BR2_BINFMT_FLAT # qt5base-icu depends on BR2_USE_MMU # libglib2, qt5base-dbus + depends on BR2_PACKAGE_LIBABSEIL_CPP_ARCH_SUPPORTS # re2 comment "qt5webengine needs udev /dev management and a glibc toolchain w/ gcc >= 8, host gcc >= 4.9, threads, wchar" depends on BR2_PACKAGE_QT5WEBENGINE_ARCH_SUPPORTS
package/re2/Config.in +6 -2
@@ -1,8 +1,10 @@ config BR2_PACKAGE_RE2 bool "re2" + depends on BR2_PACKAGE_LIBABSEIL_CPP_ARCH_SUPPORTS # libabseil-cpp depends on BR2_INSTALL_LIBSTDCPP depends on BR2_TOOLCHAIN_GCC_AT_LEAST_8 # C++14 depends on BR2_TOOLCHAIN_HAS_THREADS + depends on !BR2_STATIC_LIBS # libabseil-cpp select BR2_PACKAGE_LIBABSEIL_CPP help RE2 is a fast, safe, thread-friendly alternative
@@ -12,7 +14,9 @@ config BR2_PACKAGE_RE2 https://github.com/google/re2 -comment "re2 needs a toolchain w/ C++, threads, gcc >= 8" +comment "re2 needs a toolchain w/ C++, threads, gcc >= 8, dynamic library" + depends on BR2_PACKAGE_LIBABSEIL_CPP_ARCH_SUPPORTS depends on !BR2_INSTALL_LIBSTDCPP || \ !BR2_TOOLCHAIN_HAS_THREADS || \ - !BR2_TOOLCHAIN_GCC_AT_LEAST_8 + !BR2_TOOLCHAIN_GCC_AT_LEAST_8 || \ + BR2_STATIC_LIBS
Signature · 6 lines
2.43.0 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Re: [Buildroot] [PATCH 04/10] package/re2: propagate dependencies from libabseil-cpp
Quoted 20 lines · On Sun, 28 Jan 2024 14:20:53 +0100 "Yann E. MORIN" <[email protected]>…
Commit
fc7606010e4e(package/re2: bump to version 2023.11.01) forgot to propagate the arch dependency from libabsel-cpp to re2, and transitively to its dependees, causing unmet dependencies warnings (unfortunately, not errors), such as:$ KCONFIG_SEED=0xCCB17344 make randconfig WARNING: unmet direct dependencies detected for BR2_PACKAGE_LIBABSEIL_CPP Depends on [n]: BR2_INSTALL_LIBSTDCPP [=y] && BR2_TOOLCHAIN_GCC_AT_LEAST_8 [=y] && BR2_TOOLCHAIN_HAS_THREADS [=y] && !BR2_STATIC_LIBS [=n] && BR2_PACKAGE_LIBABSEIL_CPP_ARCH_SUPPORTS [=n] Selected by [y]: - BR2_PACKAGE_RE2 [=y] && BR2_INSTALL_LIBSTDCPP [=y] && BR2_TOOLCHAIN_GCC_AT_LEAST_8 [=y] && BR2_TOOLCHAIN_HAS_THREADS [=y]Fix that, and propagate the dependency.
Note that qt5webengine depends on glibc, so that implies !static already.
Signed-off-by Yann E. MORIN <[email protected]>Cc Michael Nosthoff <[email protected]>Cc Julien Corjon <[email protected]>Cc Giulio Benetti <[email protected]>
Quoted 5 lines
--- package/grpc/Config.in | 2 +- package/qt5/qt5webengine/Config.in | 1 + package/re2/Config.in | 8 ++++++-- 3 files changed, 8 insertions(+), 3 deletions(-)
There was already a previous patch from Fabrice to fix this, so I applied his patch
https://patchwork.ozlabs.org/project/buildroot/patch/[email protected]/,
with some edits.
Thanks!
Thomas
Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
PATCH 5/10 package/petitboot: fix ordering of comments and sub-options
In reply to Yann E. MORINCurrently, the comment about availability is between the package main symbol and its suboptions, breaking the threading in menuconfig.
Invert the order, and move the comment last. Also enclose the suboptions between an if-block, as it is more customary.
--- package/petitboot/Config.in | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-)
package/petitboot/Config.in +11 -8
@@ -19,17 +19,20 @@ config BR2_PACKAGE_PETITBOOT http://www.kernel.org/pub/linux/kernel/people/geoff/petitboot/petitboot.html +if BR2_PACKAGE_PETITBOOT + +config BR2_PACKAGE_PETITBOOT_GETTY_PORT + string "TTY port(s)" + default "console" + help + Specify a space-separated list of ports to run the petitboot + UI on. Wildcards are allowed. Example: "hvc* ttys0 ttyS*" + +endif # BR2_PACKAGE_PETITBOOT + comment "petitboot needs a toolchain w/ wchar, dynamic library, threads, udev /dev management" depends on BR2_PACKAGE_KEXEC_ARCH_SUPPORTS depends on BR2_USE_MMU depends on !BR2_USE_WCHAR || BR2_STATIC_LIBS || \ !BR2_TOOLCHAIN_HAS_THREADS || \ !BR2_PACKAGE_HAS_UDEV - -config BR2_PACKAGE_PETITBOOT_GETTY_PORT - string "TTY port(s)" - default "console" - depends on BR2_PACKAGE_PETITBOOT - help - Specify a space-separated list of ports to run the petitboot - UI on. Wildcards are allowed. Example: "hvc* ttys0 ttyS*"
Signature · 6 lines
2.43.0 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Thomas Petazzoni via buildroot
AppliedRe: [Buildroot] [PATCH 05/10] package/petitboot: fix ordering of comments and sub-options
Quoted 10 lines · On Sun, 28 Jan 2024 14:20:54 +0100 "Yann E. MORIN" <[email protected]>…
Currently, the comment about availability is between the package main symbol and its suboptions, breaking the threading in menuconfig.
Invert the order, and move the comment last. Also enclose the suboptions between an if-block, as it is more customary.
Signed-off-by Yann E. MORIN <[email protected]>--- package/petitboot/Config.in | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-)
Applied to master, thanks.
Thomas
Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
PATCH 6/10 package/petitboot: propagate depednencies from kexec/kexec-lite
In reply to Yann E. MORINCommit 719921bebe17 (package/kexec: bump to version 2.0.27) forgot to propagate the new dependency on kernel headers to petitboot, which may select kexec, causing unmet dependencies warnings (unfortunately, not errors), such as;
$ KCONFIG_SEED=0x84462FFC make randconfig
WARNING: unmet direct dependencies detected for BR2_PACKAGE_KEXEC
Depends on [n]: BR2_PACKAGE_KEXEC_ARCH_SUPPORTS [=y] && BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_17 [=n]
Selected by [y]:
- BR2_PACKAGE_PETITBOOT [=y] && (BR2_PACKAGE_KEXEC_ARCH_SUPPORTS [=y] || BR2_PACKAGE_KEXEC_LITE_ARCH_SUPPORTS [=n]) && BR2_USE_MMU [=y] && BR2_USE_WCHAR [=y] && !BR2_STATIC_LIBS [=n] && BR2_TOOLCHAIN_HAS_THREADS [=y] && BR2_PACKAGE_HAS_UDEV [=y] && !BR2_PACKAGE_KEXEC_LITE_ARCH_SUPPORTS [=n]Propagate the dependency from kexec, and add comments about dependencies also inherited from kexec-lite.
--- package/petitboot/Config.in | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-)
package/petitboot/Config.in +8 -3
@@ -2,10 +2,11 @@ config BR2_PACKAGE_PETITBOOT bool "petitboot" depends on BR2_PACKAGE_KEXEC_ARCH_SUPPORTS || BR2_PACKAGE_KEXEC_LITE_ARCH_SUPPORTS depends on BR2_USE_MMU # lvm2 - depends on BR2_USE_WCHAR # elfutils - depends on !BR2_STATIC_LIBS # elfutils, lvm2 - depends on BR2_TOOLCHAIN_HAS_THREADS # elfutils, lvm2 + depends on BR2_USE_WCHAR # elfutils, kexec-lite + depends on !BR2_STATIC_LIBS # elfutils, kexec-lite, lvm2 + depends on BR2_TOOLCHAIN_HAS_THREADS # elfutils, kexec-lite, lvm2 depends on BR2_PACKAGE_HAS_UDEV + depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_17 || !BR2_PACKAGE_KEXEC_ARCH_SUPPORTS # kexec select BR2_PACKAGE_ELFUTILS select BR2_PACKAGE_LVM2 # devmapper select BR2_PACKAGE_NCURSES
@@ -36,3 +37,7 @@ comment "petitboot needs a toolchain w/ wchar, dynamic library, threads, udev /d depends on !BR2_USE_WCHAR || BR2_STATIC_LIBS || \ !BR2_TOOLCHAIN_HAS_THREADS || \ !BR2_PACKAGE_HAS_UDEV + +comment "petitboot w/ kexec needs a toolchain w/ headers >= 3.17" + depends on BR2_PACKAGE_KEXEC_ARCH_SUPPORTS && !BR2_PACKAGE_KEXEC_LITE_ARCH_SUPPORTS + depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_17
Signature · 6 lines
2.43.0 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Thomas Petazzoni via buildroot
AppliedRe: [Buildroot] [PATCH 06/10] package/petitboot: propagate depednencies from kexec/kexec-lite
Quoted 14 lines · On Sun, 28 Jan 2024 14:20:55 +0100 "Yann E. MORIN" <[email protected]>…
Commit
719921bebe17(package/kexec: bump to version 2.0.27) forgot to propagate the new dependency on kernel headers to petitboot, which may select kexec, causing unmet dependencies warnings (unfortunately, not errors), such as;$ KCONFIG_SEED=0x84462FFC make randconfig WARNING: unmet direct dependencies detected for BR2_PACKAGE_KEXEC Depends on [n]: BR2_PACKAGE_KEXEC_ARCH_SUPPORTS [=y] && BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_17 [=n] Selected by [y]: - BR2_PACKAGE_PETITBOOT [=y] && (BR2_PACKAGE_KEXEC_ARCH_SUPPORTS [=y] || BR2_PACKAGE_KEXEC_LITE_ARCH_SUPPORTS [=n]) && BR2_USE_MMU [=y] && BR2_USE_WCHAR [=y] && !BR2_STATIC_LIBS [=n] && BR2_TOOLCHAIN_HAS_THREADS [=y] && BR2_PACKAGE_HAS_UDEV [=y] && !BR2_PACKAGE_KEXEC_LITE_ARCH_SUPPORTS [=n]Propagate the dependency from kexec, and add comments about dependencies also inherited from kexec-lite.
Quoted 6 lines
Signed-off-by Yann E. MORIN <[email protected]>Cc Laurent Vivier <[email protected]>Cc Julien Olivain <[email protected]>--- package/petitboot/Config.in | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-)
Applied to master, thanks.
Thomas
Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
PATCH 7/10 package/python-ml-dtypes: propagate dependencies from numpy, pybind
In reply to Yann E. MORINCommit ebe47e7605c6 (package/python-ml-dtypes: new package) forgot to account for all the dependencies from python-pybind and python-numpy, causing unmet dependencies warnings (unfortunately, not errors), such as:
$ KCONFIG_SEED=0x85C244F4 make randconfig
WARNING: unmet direct dependencies detected for BR2_PACKAGE_PYTHON_NUMPY
Depends on [n]: BR2_PACKAGE_PYTHON3 [=y] && BR2_PACKAGE_PYTHON_NUMPY_ARCH_SUPPORTS [=y] && BR2_INSTALL_LIBSTDCPP [=n] && (BR2_TOOLCHAIN_USES_GLIBC [=y] || BR2_TOOLCHAIN_USES_MUSL [=n]) && BR2_TOOLCHAIN_GCC_AT_LEAST_9 [=y]
Selected by [y]:
- BR2_PACKAGE_PYTHON_ML_DTYPES [=y] && BR2_PACKAGE_PYTHON3 [=y] && BR2_PACKAGE_PYTHON_NUMPY_ARCH_SUPPORTS [=y] && (BR2_TOOLCHAIN_USES_GLIBC [=y] || BR2_TOOLCHAIN_USES_MUSL [=n]) && BR2_TOOLCHAIN_GCC_AT_LEAST_9 [=y] && BR2_HOST_GCC_AT_LEAST_9 [=y] WARNING: unmet direct dependencies detected for BR2_PACKAGE_PYTHON_PYBIND
Depends on [n]: BR2_PACKAGE_PYTHON3 [=y] && BR2_INSTALL_LIBSTDCPP [=n]
Selected by [y]:
- BR2_PACKAGE_PYTHON_ML_DTYPES [=y] && BR2_PACKAGE_PYTHON3 [=y] && BR2_PACKAGE_PYTHON_NUMPY_ARCH_SUPPORTS [=y] && (BR2_TOOLCHAIN_USES_GLIBC [=y] || BR2_TOOLCHAIN_USES_MUSL [=n]) && BR2_TOOLCHAIN_GCC_AT_LEAST_9 [=y] && BR2_HOST_GCC_AT_LEAST_9 [=y]
Propagate the C++ dependency from both numpy and pybind.
--- package/python-ml-dtypes/Config.in | 1 + 1 file changed, 1 insertion(+)
package/python-ml-dtypes/Config.in +1 -0
@@ -4,6 +4,7 @@ config BR2_PACKAGE_PYTHON_ML_DTYPES depends on BR2_TOOLCHAIN_USES_GLIBC || BR2_TOOLCHAIN_USES_MUSL # python-numpy depends on BR2_TOOLCHAIN_GCC_AT_LEAST_9 # python-numpy depends on BR2_HOST_GCC_AT_LEAST_9 # host-python-numpy + depends on BR2_INSTALL_LIBSTDCPP # python-numpy, python-pybind select BR2_PACKAGE_PYTHON_NUMPY select BR2_PACKAGE_PYTHON_PYBIND help
Signature · 6 lines
2.43.0 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Re: [Buildroot] [PATCH 07/10] package/python-ml-dtypes: propagate dependencies from numpy, pybind
Quoted 16 lines · On Sun, 28 Jan 2024 14:20:56 +0100 "Yann E. MORIN" <[email protected]>…
Commit
ebe47e7605c6(package/python-ml-dtypes: new package) forgot to account for all the dependencies from python-pybind and python-numpy, causing unmet dependencies warnings (unfortunately, not errors), such as:$ KCONFIG_SEED=0x85C244F4 make randconfig WARNING: unmet direct dependencies detected for BR2_PACKAGE_PYTHON_NUMPY Depends on [n]: BR2_PACKAGE_PYTHON3 [=y] && BR2_PACKAGE_PYTHON_NUMPY_ARCH_SUPPORTS [=y] && BR2_INSTALL_LIBSTDCPP [=n] && (BR2_TOOLCHAIN_USES_GLIBC [=y] || BR2_TOOLCHAIN_USES_MUSL [=n]) && BR2_TOOLCHAIN_GCC_AT_LEAST_9 [=y] Selected by [y]: - BR2_PACKAGE_PYTHON_ML_DTYPES [=y] && BR2_PACKAGE_PYTHON3 [=y] && BR2_PACKAGE_PYTHON_NUMPY_ARCH_SUPPORTS [=y] && (BR2_TOOLCHAIN_USES_GLIBC [=y] || BR2_TOOLCHAIN_USES_MUSL [=n]) && BR2_TOOLCHAIN_GCC_AT_LEAST_9 [=y] && BR2_HOST_GCC_AT_LEAST_9 [=y]WARNING: unmet direct dependencies detected for
BR2_PACKAGE_PYTHON_PYBIND
Depends on [n]:BR2_PACKAGE_PYTHON3[=y] &&BR2_INSTALL_LIBSTDCPP[=n]
Selected by [y]:
-BR2_PACKAGE_PYTHON_ML_DTYPES[=y] &&BR2_PACKAGE_PYTHON3[=y] &&BR2_PACKAGE_PYTHON_NUMPY_ARCH_SUPPORTS[=y] && (BR2_TOOLCHAIN_USES_GLIBC[=y] ||BR2_TOOLCHAIN_USES_MUSL[=n]) &&BR2_TOOLCHAIN_GCC_AT_LEAST_9[=y] &&BR2_HOST_GCC_AT_LEAST_9[=y]
Quoted 7 lines
Propagate the C++ dependency from both numpy and pybind.
Signed-off-by Yann E. MORIN <[email protected]>Cc Julien Olivain <[email protected]>--- package/python-ml-dtypes/Config.in | 1 + 1 file changed, 1 insertion(+)
This has already been fixed by 650c2b83b515bf6941189b837d87819a901ec901, which also added the Config.in comment.
Thomas
Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
PATCH 8/10 package/opencv4: propagate internal dependencies
In reply to Yann E. MORINCommit e22994378553 (package/opencv4: BR2_PACKAGE_OPENCV4_LIB_OBJDETECT requires BR2_PACKAGE_OPENCV4_LIB_DNN) forgot to propagate the dependency to the internal stitching option, and to the contrib options dpm, face, and xobjdetect, causing unmet dependencies warning (unfortunately, not errors) such as:
$ KCONFIG_SEED=0x9F66F854 make randconfig
WARNING: unmet direct dependencies detected for BR2_PACKAGE_OPENCV4_LIB_OBJDETECT
Depends on [n]: BR2_PACKAGE_OPENCV4 [=y] && !BR2_TOOLCHAIN_USES_UCLIBC [=y] && BR2_PACKAGE_PROTOBUF_ARCH_SUPPORTS [=y]
Selected by [y]:
- BR2_PACKAGE_OPENCV4_LIB_STITCHING [=y] && BR2_PACKAGE_OPENCV4 [=y]
- BR2_PACKAGE_OPENCV4_CONTRIB_LIB_XOBJDETECT [=y] && BR2_PACKAGE_OPENCV4_CONTRIB [=y]Propagate the dependencies.
--- package/opencv4-contrib/Config.in | 18 ++++++++++++++++++ package/opencv4/Config.in | 6 ++++++ 2 files changed, 24 insertions(+)
package/opencv4-contrib/Config.in +18 -0
@@ -95,18 +95,30 @@ config BR2_PACKAGE_OPENCV4_CONTRIB_LIB_DNNS_EASILY_FOOLED config BR2_PACKAGE_OPENCV4_CONTRIB_LIB_DPM bool "dpm" + depends on BR2_PACKAGE_PROTOBUF_ARCH_SUPPORTS # opencv4 objdetect + depends on !BR2_TOOLCHAIN_USES_UCLIBC # opencv4 objdetect select BR2_PACKAGE_OPENCV4_LIB_OBJDETECT help Deformable Part Model -- Felzenszwalb's Cascade with deformable parts object recognition code. +comment "dpm needs a glibc or musl toolchain" + depends on BR2_PACKAGE_PROTOBUF_ARCH_SUPPORTS # opencv4 objdetect + depends on BR2_TOOLCHAIN_USES_UCLIBC # opencv4 objdetect + config BR2_PACKAGE_OPENCV4_CONTRIB_LIB_FACE bool "face" + depends on BR2_PACKAGE_PROTOBUF_ARCH_SUPPORTS # opencv4 objdetect + depends on !BR2_TOOLCHAIN_USES_UCLIBC # opencv4 objdetect select BR2_PACKAGE_OPENCV4_LIB_OBJDETECT help Face Recognition -- Face recognition techniques: Eigen, Fisher and Local Binary Pattern Histograms LBPH methods. +comment "face needs a glibc or musl toolchain" + depends on BR2_PACKAGE_PROTOBUF_ARCH_SUPPORTS # opencv4 objdetect + depends on BR2_TOOLCHAIN_USES_UCLIBC # opencv4 objdetect + config BR2_PACKAGE_OPENCV4_CONTRIB_LIB_FREETYPE bool "freetype" help
@@ -317,12 +329,18 @@ config BR2_PACKAGE_OPENCV4_CONTRIB_LIB_XIMGPROC config BR2_PACKAGE_OPENCV4_CONTRIB_LIB_XOBJDETECT bool "xobjdetect" + depends on BR2_PACKAGE_PROTOBUF_ARCH_SUPPORTS # opencv4 objdetect + depends on !BR2_TOOLCHAIN_USES_UCLIBC # opencv4 objdetect select BR2_PACKAGE_OPENCV4_LIB_OBJDETECT help Boosted 2D Object Detection -- Uses a Waldboost cascade and local binary patterns computed as integral features for 2D object detection. +comment "xobjdetect needs a glibc or musl toolchain" + depends on BR2_PACKAGE_PROTOBUF_ARCH_SUPPORTS # opencv4 objdetect + depends on BR2_TOOLCHAIN_USES_UCLIBC # opencv4 objdetect + config BR2_PACKAGE_OPENCV4_CONTRIB_LIB_XPHOTO bool "xphoto" select BR2_PACKAGE_OPENCV4_LIB_PHOTO
package/opencv4/Config.in +6 -0
@@ -203,6 +203,8 @@ config BR2_PACKAGE_OPENCV4_LIB_SHAPE config BR2_PACKAGE_OPENCV4_LIB_STITCHING bool "stitching" + depends on BR2_PACKAGE_PROTOBUF_ARCH_SUPPORTS # objdetect + depends on !BR2_TOOLCHAIN_USES_UCLIBC # objdetect select BR2_PACKAGE_OPENCV4_LIB_CALIB3D select BR2_PACKAGE_OPENCV4_LIB_FEATURES2D select BR2_PACKAGE_OPENCV4_LIB_IMGPROC
@@ -211,6 +213,10 @@ config BR2_PACKAGE_OPENCV4_LIB_STITCHING Include opencv_stitching (images stitching) module into the OpenCV build. +comment "stitching needs a glibc or musl toolchain" + depends on BR2_PACKAGE_PROTOBUF_ARCH_SUPPORTS + depends on BR2_TOOLCHAIN_USES_UCLIBC + config BR2_PACKAGE_OPENCV4_LIB_SUPERRES bool "superres" select BR2_PACKAGE_OPENCV4_LIB_IMGPROC
Signature · 6 lines
2.43.0 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Thomas Petazzoni via buildroot
AppliedRe: [Buildroot] [PATCH 08/10] package/opencv4: propagate internal dependencies
Quoted 15 lines · On Sun, 28 Jan 2024 14:20:57 +0100 "Yann E. MORIN" <[email protected]>…
Commit
e22994378553(package/opencv4:BR2_PACKAGE_OPENCV4_LIB_OBJDETECTrequiresBR2_PACKAGE_OPENCV4_LIB_DNN) forgot to propagate the dependency to the internal stitching option, and to the contrib options dpm, face, and xobjdetect, causing unmet dependencies warning (unfortunately, not errors) such as:$ KCONFIG_SEED=0x9F66F854 make randconfig WARNING: unmet direct dependencies detected for BR2_PACKAGE_OPENCV4_LIB_OBJDETECT Depends on [n]: BR2_PACKAGE_OPENCV4 [=y] && !BR2_TOOLCHAIN_USES_UCLIBC [=y] && BR2_PACKAGE_PROTOBUF_ARCH_SUPPORTS [=y] Selected by [y]: - BR2_PACKAGE_OPENCV4_LIB_STITCHING [=y] && BR2_PACKAGE_OPENCV4 [=y] - BR2_PACKAGE_OPENCV4_CONTRIB_LIB_XOBJDETECT [=y] && BR2_PACKAGE_OPENCV4_CONTRIB [=y]Propagate the dependencies.
Quoted 8 lines
Signed-off-by Yann E. MORIN <[email protected]>Cc Woodrow Douglass <[email protected]>Cc Fabrice Fontaine <[email protected]>Cc Giulio Benetti <[email protected]>--- package/opencv4-contrib/Config.in | 18 ++++++++++++++++++ package/opencv4/Config.in | 6 ++++++ 2 files changed, 24 insertions(+)
Applied to master, thanks.
Thomas
Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
PATCH 9/10 package/opencv-contrib: propagate opencv4 dependencies
In reply to Yann E. MORINCommit a7736afacaef (package/opencv4-contrib: properly note dependencies between modules) forgot to propagate the dependencies of selected symbols, causing unmet dependencies warnings (unfortunately, not errors), such as:
$ KCONFIG_SEED=0x9F66F854 make randconfig
WARNING: unmet direct dependencies detected for BR2_PACKAGE_OPENCV4_LIB_DNN
Depends on [n]: BR2_PACKAGE_OPENCV4 [=y] && !BR2_TOOLCHAIN_USES_UCLIBC [=y] && BR2_PACKAGE_PROTOBUF_ARCH_SUPPORTS [=y]
Selected by [y]:
- BR2_PACKAGE_OPENCV4_CONTRIB_LIB_DNN_OBJDETECT [=y] && BR2_PACKAGE_OPENCV4_CONTRIB [=y]Propagate the dependencies and add associated comments.
--- package/opencv4-contrib/Config.in | 12 ++++++++++++ 1 file changed, 12 insertions(+)
package/opencv4-contrib/Config.in +12 -0
@@ -74,19 +74,31 @@ config BR2_PACKAGE_OPENCV4_CONTRIB_LIB_DATASETS config BR2_PACKAGE_OPENCV4_CONTRIB_LIB_DNN_OBJDETECT bool "dnn_objdetect" + depends on BR2_PACKAGE_PROTOBUF_ARCH_SUPPORTS # opencv4 dnn + depends on !BR2_TOOLCHAIN_USES_UCLIBC # opencv4 dnn select BR2_PACKAGE_OPENCV4_LIB_DNN help Object Detection using CNNs -- Implements compact CNN Model for object detection. Trained using Caffe but uses opencv_dnn module. +comment "dnn_objdetect needs a glibc or musl toolchain" + depends on BR2_PACKAGE_PROTOBUF_ARCH_SUPPORTS + depends on !BR2_TOOLCHAIN_USES_UCLIBC + config BR2_PACKAGE_OPENCV4_CONTRIB_LIB_DNN_SUPERRES bool "dnn_superres" + depends on BR2_PACKAGE_PROTOBUF_ARCH_SUPPORTS # opencv4 dnn + depends on !BR2_TOOLCHAIN_USES_UCLIBC # opencv4 dnn select BR2_PACKAGE_OPENCV4_LIB_DNN help Superresolution using CNNs -- Contains four trained convolutional neural networks to upscale images. +comment "dnn_superres needs a glibc or musl toolchain" + depends on BR2_PACKAGE_PROTOBUF_ARCH_SUPPORTS + depends on !BR2_TOOLCHAIN_USES_UCLIBC + config BR2_PACKAGE_OPENCV4_CONTRIB_LIB_DNNS_EASILY_FOOLED bool "dnns_easily_fooled" help
Signature · 6 lines
2.43.0 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Thomas Petazzoni via buildroot
AppliedRe: [Buildroot] [PATCH 09/10] package/opencv-contrib: propagate opencv4 dependencies
Quoted 11 lines · On Sun, 28 Jan 2024 14:20:58 +0100 "Yann E. MORIN" <[email protected]>…
Commit
a7736afacaef(package/opencv4-contrib: properly note dependencies between modules) forgot to propagate the dependencies of selected symbols, causing unmet dependencies warnings (unfortunately, not errors), such as:$ KCONFIG_SEED=0x9F66F854 make randconfig WARNING: unmet direct dependencies detected for BR2_PACKAGE_OPENCV4_LIB_DNN Depends on [n]: BR2_PACKAGE_OPENCV4 [=y] && !BR2_TOOLCHAIN_USES_UCLIBC [=y] && BR2_PACKAGE_PROTOBUF_ARCH_SUPPORTS [=y] Selected by [y]: - BR2_PACKAGE_OPENCV4_CONTRIB_LIB_DNN_OBJDETECT [=y] && BR2_PACKAGE_OPENCV4_CONTRIB [=y]
Quoted 7 lines
Propagate the dependencies and add associated comments.
Signed-off-by Yann E. MORIN <[email protected]>Cc Woodrow Douglass <[email protected]>--- package/opencv4-contrib/Config.in | 12 ++++++++++++ 1 file changed, 12 insertions(+)
Applied to master, thanks.
Thomas
Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
PATCH 10/10 package/atkmm: propagate dependency from at-spi2-core
In reply to Yann E. MORINCommit 2c3ca7bea1de (package/atk: remove package) forgot to propagate to atkmm, the then just introduced dependency on !static from at-spi2-core, causing unmet dependencies warnings (unfortuantely, not errors), such as:
$ KCONFIG_SEED=0xAFA763CA make randconfig
WARNING: unmet direct dependencies detected for BR2_PACKAGE_AT_SPI2_CORE
Depends on [n]: BR2_TOOLCHAIN_HAS_THREADS [=y] && BR2_USE_MMU [=y] && BR2_USE_WCHAR [=y] && !BR2_STATIC_LIBS [=y]
Selected by [y]:
- BR2_PACKAGE_ATKMM [=y] && BR2_INSTALL_LIBSTDCPP [=y] && BR2_TOOLCHAIN_GCC_AT_LEAST_7 [=y] && BR2_TOOLCHAIN_HAS_THREADS [=y] && BR2_USE_MMU [=y] && BR2_USE_WCHAR [=y]Propagate the dependency now.
--- package/atkmm/Config.in | 1 + 1 file changed, 1 insertion(+)
package/atkmm/Config.in +1 -0
@@ -5,6 +5,7 @@ config BR2_PACKAGE_ATKMM depends on BR2_TOOLCHAIN_HAS_THREADS # at-spi2-core/glibmm -> libglib2 depends on BR2_USE_MMU # at-spi2-core/glibmm -> libglib2 depends on BR2_USE_WCHAR # at-spi2-core/glibmm -> libglib2 + depends on !BR2_STATIC_LIBS # at-spi2-core select BR2_PACKAGE_AT_SPI2_CORE select BR2_PACKAGE_GLIBMM select BR2_PACKAGE_LIBSIGC
Signature · 6 lines
2.43.0 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Re: [Buildroot] [PATCH 10/10] package/atkmm: propagate dependency from at-spi2-core
Quoted 11 lines · On Sun, 28 Jan 2024 14:20:59 +0100 "Yann E. MORIN" <[email protected]>…
Commit
2c3ca7bea1de(package/atk: remove package) forgot to propagate to atkmm, the then just introduced dependency on !static from at-spi2-core, causing unmet dependencies warnings (unfortuantely, not errors), such as:$ KCONFIG_SEED=0xAFA763CA make randconfig WARNING: unmet direct dependencies detected for BR2_PACKAGE_AT_SPI2_CORE Depends on [n]: BR2_TOOLCHAIN_HAS_THREADS [=y] && BR2_USE_MMU [=y] && BR2_USE_WCHAR [=y] && !BR2_STATIC_LIBS [=y] Selected by [y]: - BR2_PACKAGE_ATKMM [=y] && BR2_INSTALL_LIBSTDCPP [=y] && BR2_TOOLCHAIN_GCC_AT_LEAST_7 [=y] && BR2_TOOLCHAIN_HAS_THREADS [=y] && BR2_USE_MMU [=y] && BR2_USE_WCHAR [=y]
Quoted 8 lines
Propagate the dependency now.
Signed-off-by Yann E. MORIN <[email protected]>Cc James Knight <[email protected]>Cc Daniel Lang <[email protected]>--- package/atkmm/Config.in | 1 + 1 file changed, 1 insertion(+)
There's a patch at
https://patchwork.ozlabs.org/project/buildroot/patch/[email protected]/
that propagates many more dependencies of at-spi2-core.
Thomas
Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot