dt-bindings: pwm: Cleanup pwm-cells required twice

PATCH In review Binbin Zhou 5 participants 11 messages Apr 30, 2024 – May 7, 2024

Subsystems (6)

Device tree bindings Arm MediaTek Broadcom BCM2711/BCM2835 Arm architecture PWM +2 more subsystems

lore

Share & tools

lore

Binbin Zhou

author

2024-04-30 07:32 UTC #0 lore raw

cover dt-bindings: pwm: Cleanup pwm-cells required twice

Hi all:

When I was submitting the Loongson PWM dt-binding, Rob reminded me that the pwm-cells property was already required in pwm.yaml and did not need to be repeated.

This patchset attempts to clean up the required pwm-cells attribute twice.

Thanks.

Binbin Zhou (6):
dt-bindings: pwm: bcm2835: Do not require pwm-cells twice
dt-bindings: pwm: google,cros-ec: Do not require pwm-cells twice
dt-bindings: pwm: marvell,pxa: Do not require pwm-cells twice
dt-bindings: pwm: mediatek,mt2712: Do not require pwm-cells twice
dt-bindings: pwm: mediatek,pwm-disp: Do not require pwm-cells twice
dt-bindings: pwm: snps,dw-apb-timers: Do not require pwm-cells twice

 Documentation/devicetree/bindings/pwm/google,cros-ec-pwm.yaml    | 1 -
 Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml       | 1 -
 Documentation/devicetree/bindings/pwm/mediatek,mt2712-pwm.yaml   | 1 -
 Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml     | 1 -
 Documentation/devicetree/bindings/pwm/pwm-bcm2835.yaml           | 1 -
 .../devicetree/bindings/pwm/snps,dw-apb-timers-pwm2.yaml         | 1 -
 6 files changed, 6 deletions(-)

Signature · 1 line

2.43.0

Binbin Zhou

author

2024-04-30 07:32 UTC #1 lore raw

PATCH 1/6 dt-bindings: pwm: bcm2835: Do not require pwm-cells twice

pwm-cells property is already required by pwm.yaml schema.

Signed-off-by Binbin Zhou <[email protected]>

---
 Documentation/devicetree/bindings/pwm/pwm-bcm2835.yaml | 1 -
 1 file changed, 1 deletion(-)

Documentation/devicetree/bindings/pwm/pwm-bcm2835.yaml +0 -1

index 15e7fd98defc..9dc25f38fb94 100644
@@ -29,7 +29,6 @@ required:
   - compatible
   - reg
   - clocks
-  - "#pwm-cells"
 
 additionalProperties: false

Signature · 1 line

2.43.0

Binbin Zhou

author

2024-04-30 07:32 UTC #2 lore raw

PATCH 2/6 dt-bindings: pwm: google,cros-ec: Do not require pwm-cells twice

In reply to Binbin Zhou

pwm-cells property is already required by pwm.yaml schema.

Signed-off-by Binbin Zhou <[email protected]>

---
 Documentation/devicetree/bindings/pwm/google,cros-ec-pwm.yaml | 1 -
 1 file changed, 1 deletion(-)

Documentation/devicetree/bindings/pwm/google,cros-ec-pwm.yaml +0 -1

index 3afe1480df52..f7bc84b05a87 100644
@@ -35,7 +35,6 @@ properties:
 
 required:
   - compatible
-  - '#pwm-cells'
 
 additionalProperties: false

Signature · 1 line

2.43.0

Binbin Zhou

author

2024-04-30 07:32 UTC #3 lore raw

PATCH 3/6 dt-bindings: pwm: marvell,pxa: Do not require pwm-cells twice

In reply to Binbin Zhou

pwm-cells property is already required by pwm.yaml schema.

Signed-off-by Binbin Zhou <[email protected]>

---
 Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml | 1 -
 1 file changed, 1 deletion(-)

Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml +0 -1

index ba6325575ea0..9ee1946dc2e1 100644
@@ -34,7 +34,6 @@ properties:
 required:
   - compatible
   - reg
-  - "#pwm-cells"
   - clocks
 
 additionalProperties: false

Signature · 1 line

2.43.0

Binbin Zhou

author

2024-04-30 07:32 UTC #4 lore raw

PATCH 4/6 dt-bindings: pwm: mediatek,mt2712: Do not require pwm-cells twice

In reply to Binbin Zhou

pwm-cells property is already required by pwm.yaml schema.

Signed-off-by Binbin Zhou <[email protected]>

---
 Documentation/devicetree/bindings/pwm/mediatek,mt2712-pwm.yaml | 1 -
 1 file changed, 1 deletion(-)

Documentation/devicetree/bindings/pwm/mediatek,mt2712-pwm.yaml +0 -1

index a5c308801619..d515c09e1021 100644
@@ -66,7 +66,6 @@ properties:
 required:
   - compatible
   - reg
-  - "#pwm-cells"
   - clocks
   - clock-names

Signature · 1 line

2.43.0

Binbin Zhou

author

2024-04-30 07:32 UTC #5 lore raw

PATCH 5/6 dt-bindings: pwm: mediatek,pwm-disp: Do not require pwm-cells twice

In reply to Binbin Zhou

pwm-cells property is already required by pwm.yaml schema.

Signed-off-by Binbin Zhou <[email protected]>

---
 Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml | 1 -
 1 file changed, 1 deletion(-)

Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml +0 -1

index bc813fe74fab..415730f078f5 100644
@@ -58,7 +58,6 @@ properties:
 required:
   - compatible
   - reg
-  - "#pwm-cells"
   - clocks
   - clock-names

Signature · 1 line

2.43.0

Binbin Zhou

author

2024-04-30 07:32 UTC #6 lore raw

PATCH 6/6 dt-bindings: pwm: snps,dw-apb-timers: Do not require pwm-cells twice

In reply to Binbin Zhou

pwm-cells property is already required by pwm.yaml schema.

Signed-off-by Binbin Zhou <[email protected]>

---
 .../devicetree/bindings/pwm/snps,dw-apb-timers-pwm2.yaml         | 1 -
 1 file changed, 1 deletion(-)

Documentation/devicetree/bindings/pwm/snps,dw-apb-timers-pwm2.yaml +0 -1

index 4d0b5964443d..7523a89a1773 100644
@@ -51,7 +51,6 @@ properties:
 required:
   - compatible
   - reg
-  - "#pwm-cells"
   - clocks
   - clock-names

Signature · 1 line

2.43.0

Conor Dooley

Acked-by on the v1 series

2024-04-30 16:58 UTC #7 lore raw

In reply to Binbin Zhou

Quoted 7 lines · Binbin Zhou

Hi all:
When I was submitting the Loongson PWM dt-binding, Rob reminded me that the pwm-cells property was already required in pwm.yaml and did not need to be repeated.
This patchset attempts to clean up the required pwm-cells attribute twice.

Acked-by Conor Dooley <[email protected]>

Cheers,
Conor.

Rob Herring

2024-04-30 17:16 UTC #8 lore raw

In reply to Binbin Zhou

Quoted 8 lines · Binbin Zhou

Hi all:
When I was submitting the Loongson PWM dt-binding, Rob reminded me that the pwm-cells property was already required in pwm.yaml and did not need to be repeated.
This patchset attempts to clean up the required pwm-cells attribute twice.

Thanks for this.

Quoted 9 lines

Thanks.
Binbin Zhou (6):
dt-bindings: pwm: bcm2835: Do not require pwm-cells twice
dt-bindings: pwm: google,cros-ec: Do not require pwm-cells twice
dt-bindings: pwm: marvell,pxa: Do not require pwm-cells twice
dt-bindings: pwm: mediatek,mt2712: Do not require pwm-cells twice
dt-bindings: pwm: mediatek,pwm-disp: Do not require pwm-cells twice
dt-bindings: pwm: snps,dw-apb-timers: Do not require pwm-cells twice

This could really just be one patch. It's the same repeated change and it's all going to 1 maintainer. No need to respin for that though.

Rob

Uwe Kleine-König

2024-05-01 09:58 UTC #9 lore raw

In reply to Binbin Zhou

Hello,

Quoted 16 lines · Binbin Zhou

When I was submitting the Loongson PWM dt-binding, Rob reminded me that the pwm-cells property was already required in pwm.yaml and did not need to be repeated.
This patchset attempts to clean up the required pwm-cells attribute twice.
Thanks.
Binbin Zhou (6):
dt-bindings: pwm: bcm2835: Do not require pwm-cells twice
dt-bindings: pwm: google,cros-ec: Do not require pwm-cells twice
dt-bindings: pwm: marvell,pxa: Do not require pwm-cells twice
dt-bindings: pwm: mediatek,mt2712: Do not require pwm-cells twice
dt-bindings: pwm: mediatek,pwm-disp: Do not require pwm-cells twice
dt-bindings: pwm: snps,dw-apb-timers: Do not require pwm-cells twice

Quoted 7 lines

 Documentation/devicetree/bindings/pwm/google,cros-ec-pwm.yaml    | 1 -
 Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml       | 1 -
 Documentation/devicetree/bindings/pwm/mediatek,mt2712-pwm.yaml   | 1 -
 Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml     | 1 -
 Documentation/devicetree/bindings/pwm/pwm-bcm2835.yaml           | 1 -
 .../devicetree/bindings/pwm/snps,dw-apb-timers-pwm2.yaml         | 1 -
 6 files changed, 6 deletions(-)

Applied the series to
https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git pwm/for-next

Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.yaml seems to be another candidate for a similar cleanup.

Thanks for your cleanup,
Uwe

Signature · 2 lines

Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Binbin Zhou

2024-05-07 05:32 UTC #10 lore raw

Quoted 28 lines · Uwe Kleine-König

Hello,
Quoted 16 lines · Binbin Zhou
When I was submitting the Loongson PWM dt-binding, Rob reminded me that the pwm-cells property was already required in pwm.yaml and did not need to be repeated.
This patchset attempts to clean up the required pwm-cells attribute twice.
Thanks.
Binbin Zhou (6):
dt-bindings: pwm: bcm2835: Do not require pwm-cells twice
dt-bindings: pwm: google,cros-ec: Do not require pwm-cells twice
dt-bindings: pwm: marvell,pxa: Do not require pwm-cells twice
dt-bindings: pwm: mediatek,mt2712: Do not require pwm-cells twice
dt-bindings: pwm: mediatek,pwm-disp: Do not require pwm-cells twice
dt-bindings: pwm: snps,dw-apb-timers: Do not require pwm-cells twice
Quoted 7 lines
 Documentation/devicetree/bindings/pwm/google,cros-ec-pwm.yaml    | 1 -
 Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml       | 1 -
 Documentation/devicetree/bindings/pwm/mediatek,mt2712-pwm.yaml   | 1 -
 Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml     | 1 -
 Documentation/devicetree/bindings/pwm/pwm-bcm2835.yaml           | 1 -
 .../devicetree/bindings/pwm/snps,dw-apb-timers-pwm2.yaml         | 1 -
 6 files changed, 6 deletions(-)

Quoted 5 lines

Applied the series to
https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git pwm/for-next
Documentation/devicetree/bindings/pwm/renesas,tpu-pwm.yaml seems to be another candidate for a similar cleanup.

Hi Uwe:

Sorry for the late reply.
Indeed, I missed this file. I'll post another patch later to clean it up.

Thanks.
Binbin

Quoted 7 lines

Thanks for your cleanup,
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |