arm64: dts: k3: Resolve remaining dtbs_check warnings
Subsystems (2)
v4 cover arm64: dts: k3: Resolve remaining dtbs_check warnings
Changes in v4:
- drop no longer applicable mux-controller
- model dss-oldi-io-ctrl@41e0 and clock-controller@4140 as regular property
Changes in v3:
- convert mux-controller from patternProperties to regular one
- dropped k3-j72xx-mcu-wakeup patch after simple-bus conversion
Changes in v2:
- reference reg-mux.yaml in am654-system-controller child node
- base on top of dedicated am654-serdes-ctrl schema patch
This goes on top of
https://patchwork.kernel.org/project/linux-arm-kernel/cover/[email protected]/
As we are working in this area, having a zero-warning baseline helps a lot finding own issues quicker. Maybe not all of the suggested resolutions are optimal, open for feedback, just want to have them all fixed now soon.
Jan
Jan Kiszka (3):
arm64: dts: ti: k3-am642-evm: Silence schema warning
dt-bindings: soc: ti: am645-system-controller: add child nodes used by
main domain
arm64: dts: ti: k3-am65-main: add system controller compatible
.../soc/ti/ti,am654-system-controller.yaml | 19 +++++++++++++++++++ arch/arm64/boot/dts/ti/k3-am642-evm.dts | 4 ++++ arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 2 +- 3 files changed, 24 insertions(+), 1 deletion(-)
Signature · 1 line
2.43.0
PATCH v4 1/3 arm64: dts: ti: k3-am642-evm: Silence schema warning
From: Jan Kiszka <[email protected]>
The resolves
k3-am642-evm.dtb: adc: 'ti,adc-channels' is a required property
from schema $id: http://devicetree.org/schemas/iio/adc/ti,am3359-adc.yaml#
As the adc is reserved, thus not used by Linux, this has no practical impact.
--- arch/arm64/boot/dts/ti/k3-am642-evm.dts | 4 ++++ 1 file changed, 4 insertions(+)
arch/arm64/boot/dts/ti/k3-am642-evm.dts +4 -0
@@ -646,6 +646,10 @@ cpsw3g_phy0: ethernet-phy@0 { &tscadc0 { /* ADC is reserved for R5 usage */ status = "reserved"; + + adc { + ti,adc-channels = <0 1 2 3 4 5 6 7>; + }; }; &ospi0 {
Signature · 1 line
2.43.0
PATCH v4 2/3 dt-bindings: soc: ti: am645-system-controller: add child nodes used by main domain
In reply to Jan KiszkaFrom: Jan Kiszka <[email protected]>
Expand bindings to cover both the MCU and the main usage of the AM654 system controller.
--- .../soc/ti/ti,am654-system-controller.yaml | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)
Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml +19 -0
@@ -29,11 +29,30 @@ properties: ranges: true + dss-oldi-io-ctrl@41e0: + type: object + $ref: /schemas/mfd/syscon.yaml# + properties: + compatible: + items: + - const: ti,am654-dss-oldi-io-ctrl + - const: syscon + + clock-controller@4140: + type: object + $ref: /schemas/clock/ti,am654-ehrpwm-tbclk.yaml# + description: + Clock provider for TI EHRPWM nodes. + patternProperties: "^phy@[0-9a-f]+$": type: object $ref: /schemas/phy/ti,phy-gmii-sel.yaml# + "^clock@[0-9a-f]+$": + type: object + $ref: /schemas/soc/ti/ti,am654-serdes-ctrl.yaml# + required: - compatible - reg
Signature · 1 line
2.43.0
Re: [PATCH v4 2/3] dt-bindings: soc: ti: am645-system-controller: add child nodes used by main domain
Quoted 6 lines · Jan Kiszka
From: Jan Kiszka <[email protected]>
Expand bindings to cover both the MCU and the main usage of the AM654 system controller.
Signed-off-by Jan Kiszka <[email protected]>
Nishanth Menon
maintainerRe: [PATCH v4 2/3] dt-bindings: soc: ti: am645-system-controller: add child nodes used by main domain
In reply to Jan KiszkaDocumentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml
Quoted 14 lines · Jan Kiszka
From: Jan Kiszka <[email protected]>
Expand bindings to cover both the MCU and the main usage of the AM654 system controller.
Signed-off-by Jan Kiszka <[email protected]>--- .../soc/ti/ti,am654-system-controller.yaml | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml +0
-0
As per linux-next, this file does not exist? looks like you might need to rebase on latest next?
Quoted 34 lines
Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml +19
-0@@ -29,11 +29,30 @@ properties: ranges: true + dss-oldi-io-ctrl@41e0: + type: object + $ref: /schemas/mfd/syscon.yaml# + properties: + compatible: + items: + - const: ti,am654-dss-oldi-io-ctrl + - const: syscon + + clock-controller@4140: + type: object + $ref: /schemas/clock/ti,am654-ehrpwm-tbclk.yaml# + description: + Clock provider for TI EHRPWM nodes. + patternProperties: "^phy@[0-9a-f]+$": type: object $ref: /schemas/phy/ti,phy-gmii-sel.yaml# + "^clock@[0-9a-f]+$": + type: object + $ref: /schemas/soc/ti/ti,am654-serdes-ctrl.yaml# + required: - compatible - regSignature · 1 line
2.43.0
Signature · 3 lines
Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
Re: [PATCH v4 2/3] dt-bindings: soc: ti: am645-system-controller: add child nodes used by main domain
Quoted 11 lines · Nishanth Menon
Quoted 10 lines · Jan Kiszka
From: Jan Kiszka <[email protected]>
Expand bindings to cover both the MCU and the main usage of the AM654 system controller.
Signed-off-by Jan Kiszka <[email protected]>--- .../soc/ti/ti,am654-system-controller.yaml | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)
Quoted 8 lines
Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml
Quoted 4 lines
Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml +0
-0As per linux-next, this file does not exist? looks like you might need to rebase on latest next?
"This goes on top of
https://patchwork.kernel.org/project/linux-arm-kernel/cover/[email protected]/"
Is that series obsolete by now?
Jan
Quoted 35 lines
Quoted 34 lines
Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml +19
-0@@ -29,11 +29,30 @@ properties: ranges: true + dss-oldi-io-ctrl@41e0: + type: object + $ref: /schemas/mfd/syscon.yaml# + properties: + compatible: + items: + - const: ti,am654-dss-oldi-io-ctrl + - const: syscon + + clock-controller@4140: + type: object + $ref: /schemas/clock/ti,am654-ehrpwm-tbclk.yaml# + description: + Clock provider for TI EHRPWM nodes. + patternProperties: "^phy@[0-9a-f]+$": type: object $ref: /schemas/phy/ti,phy-gmii-sel.yaml# + "^clock@[0-9a-f]+$": + type: object + $ref: /schemas/soc/ti/ti,am654-serdes-ctrl.yaml# + required: - compatible - regSignature · 1 line
2.43.0
Signature · 2 lines
Siemens AG, Technology Linux Expert Center
Nishanth Menon
maintainerRe: [PATCH v4 2/3] dt-bindings: soc: ti: am645-system-controller: add child nodes used by main domain
Quoted 21 lines · Jan Kiszka
Quoted 11 lines · Nishanth Menon
Quoted 10 lines · Jan Kiszka
From: Jan Kiszka <[email protected]>
Expand bindings to cover both the MCU and the main usage of the AM654 system controller.
Signed-off-by Jan Kiszka <[email protected]>--- .../soc/ti/ti,am654-system-controller.yaml | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)Quoted 8 lines
Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml
Quoted 4 lines
Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml +0
-0As per linux-next, this file does not exist? looks like you might need to rebase on latest next?
Quoted 4 lines
"This goes on top of
https://patchwork.kernel.org/project/linux-arm-kernel/cover/[email protected]/"Is that series obsolete by now?
This dependency information would have been useful when provided under the diffstat section of the representative patch. :(
Signature · 3 lines
Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
Re: [PATCH v4 2/3] dt-bindings: soc: ti: am645-system-controller: add child nodes used by main domain
Quoted 22 lines · Nishanth Menon
Quoted 21 lines · Jan Kiszka
Quoted 19 lines · Nishanth Menon
Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml
Quoted 14 lines · Jan Kiszka
From: Jan Kiszka <[email protected]>
Expand bindings to cover both the MCU and the main usage of the AM654 system controller.
Signed-off-by Jan Kiszka <[email protected]>--- .../soc/ti/ti,am654-system-controller.yaml | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml +0
-0As per linux-next, this file does not exist? looks like you might need to rebase on latest next?
Quoted 8 lines
Quoted 4 lines
"This goes on top of
https://patchwork.kernel.org/project/linux-arm-kernel/cover/[email protected]/"Is that series obsolete by now?
This dependency information would have been useful when provided under the diffstat section of the representative patch. :(
Yeah, who reads cover letters? ;) Will try to do that next time.
Jan
Signature · 2 lines
Siemens AG, Technology Linux Expert Center
Nishanth Menon
maintainerRe: [PATCH v4 2/3] dt-bindings: soc: ti: am645-system-controller: add child nodes used by main domain
Quoted 26 lines · Jan Kiszka
Quoted 25 lines · Nishanth Menon
Quoted 24 lines · Jan Kiszka
Quoted 11 lines · Nishanth Menon
Quoted 10 lines · Jan Kiszka
From: Jan Kiszka <[email protected]>
Expand bindings to cover both the MCU and the main usage of the AM654 system controller.
Signed-off-by Jan Kiszka <[email protected]>--- .../soc/ti/ti,am654-system-controller.yaml | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)Quoted 8 lines
Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml
Quoted 4 lines
Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml +0
-0As per linux-next, this file does not exist? looks like you might need to rebase on latest next?
"This goes on top of
https://patchwork.kernel.org/project/linux-arm-kernel/cover/[email protected]/"
Quoted 7 lines
Quoted 5 lines
Quoted 1 line
Is that series obsolete by now?
This dependency information would have been useful when provided under the diffstat section of the representative patch. :(
Yeah, who reads cover letters? ;) Will try to do that next time.
Looking at what we included in v6.11, looks like the above series from krystoff will need to be re-thought through.
[1] makes the patches un-necessary to an extent by modelling the node as a simple-bus - Looks like k3-am62-wakeup.dtsi was missed, but it should be trivial enough fixup. Did you try applying the series on latest next? it should not apply anymore (Doesn't apply on master either).
[1] https://lore.kernel.org/all/[email protected]/
Signature · 3 lines
Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
Re: [PATCH v4 2/3] dt-bindings: soc: ti: am645-system-controller: add child nodes used by main domain
Quoted 35 lines · Nishanth Menon
Quoted 26 lines · Jan Kiszka
Quoted 25 lines · Nishanth Menon
Quoted 24 lines · Jan Kiszka
Quoted 11 lines · Nishanth Menon
Quoted 10 lines · Jan Kiszka
From: Jan Kiszka <[email protected]>
Expand bindings to cover both the MCU and the main usage of the AM654 system controller.
Signed-off-by Jan Kiszka <[email protected]>--- .../soc/ti/ti,am654-system-controller.yaml | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)Quoted 8 lines
Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml
Quoted 4 lines
Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml +0
-0As per linux-next, this file does not exist? looks like you might need to rebase on latest next?
"This goes on top of
https://patchwork.kernel.org/project/linux-arm-kernel/cover/[email protected]/"Quoted 7 lines
Quoted 5 lines
Quoted 1 line
Is that series obsolete by now?
This dependency information would have been useful when provided under the diffstat section of the representative patch. :(
Yeah, who reads cover letters? ;) Will try to do that next time.
Quoted 9 lines
Looking at what we included in v6.11, looks like the above series from krystoff will need to be re-thought through.
[1] makes the patches un-necessary to an extent by modelling the node as a simple-bus - Looks likek3-am62-wakeup.dtsiwas missed, but it should be trivial enough fixup. Did you try applying the series on latest next? it should not apply anymore (Doesn't apply on master either).
Krystoff's and my patches still apply on top of master and next.
I don't mind via which patches we finally get to zero dtbs_check warnings, just that we get there.
Jan
Signature · 2 lines
Siemens AG, Technology Linux Expert Center
Nishanth Menon
maintainerRe: [PATCH v4 2/3] dt-bindings: soc: ti: am645-system-controller: add child nodes used by main domain
On 22:13-20240826, Jan Kiszka wrote:
[..]
Quoted 2 lines
I don't mind via which patches we finally get to zero
dtbs_checkwarnings, just that we get there.
Sure. Since we are on the cleanup path towards simple-bus, lets just get there.
Signature · 3 lines
Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
PATCH v4 3/3 arm64: dts: ti: k3-am65-main: add system controller compatible
In reply to Jan KiszkaFrom: Jan Kiszka <[email protected]>
Now that the TI K3 AM654 system controller bindings also cover the usage in the main domain, add its compatible to address dtbs_check complaints:
k3-am654-base-board.dtb: scm-conf@100000: compatible: ['syscon', 'simple-mfd'] is too short
--- arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/ti/k3-am65-main.dtsi +1 -1
@@ -471,7 +471,7 @@ sdhci1: mmc@4fa0000 { }; scm_conf: scm-conf@100000 { - compatible = "syscon", "simple-mfd"; + compatible = "ti,am654-system-controller", "syscon", "simple-mfd"; reg = <0 0x00100000 0 0x1c000>; #address-cells = <1>; #size-cells = <1>;
Signature · 1 line
2.43.0
Nishanth Menon
maintainerRe: (subset) [PATCH v4 0/3] arm64: dts: k3: Resolve remaining dtbs_check warnings
In reply to Jan KiszkaHi Jan Kiszka,
Quoted 9 lines · Jan Kiszka
Changes in v4:
- drop no longer applicable mux-controller
- model dss-oldi-io-ctrl@41e0 and clock-controller@4140 as regular propertyChanges in v3:
- convert mux-controller from patternProperties to regular one
- dropped k3-j72xx-mcu-wakeup patch after simple-bus conversion[...]
I have applied the following to branch ti-k3-dts-next on [1]. I have picked Andrew's fixups, so just 1 patch in this series is relevant. Let me know if you disagree. Thank you!
[1/3] arm64: dts: ti: k3-am642-evm: Silence schema warning
commit: 182a862560097dec7adf774af58076984cd6c1ed
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent up the chain during the next merge window (or sooner if it is a relevant bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
Signature · 3 lines
Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D