Skip to contentSkip to conversation

bootchart2: Fix native build

PATCH In review [email protected] 2 participants 4 messages Nov 11, 2024 – Nov 12, 2024

lore
Share & tools
lore
#0 lore raw

cover bootchart2: Fix native build

From: Robert Yang <[email protected]>

The following changes since commit 6e572580164d06e3af88fd607d9ef32a5e84166a:

local.conf.sample: update IMAGE_FEATURES comments to remove debug-tweaks (2024-11-07 22:16:57 +0000)

are available in the Git repository at:

https://github.com/robertlinux/yocto rbt/bootchart2
https://github.com/robertlinux/yocto/tree/rbt/bootchart2

Robert Yang (1):
bootchart2: Fix native build

 meta/recipes-devtools/bootchart2/bootchart2_0.14.9.bb | 2 ++
 1 file changed, 2 insertions(+)
Signature · 1 line
2.44.1
#1 lore raw

PATCH 1/1 bootchart2: Fix native build

From: Robert Yang <[email protected]>

Fixed:

$ bitbake bootchart2-native
gzip: /path/to/bootchart2-native/0.14.9/recipe-sysroot-native/usr/share/man/man1/*.gz: No such file or directory
---
 meta/recipes-devtools/bootchart2/bootchart2_0.14.9.bb | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-devtools/bootchart2/bootchart2_0.14.9.bb +2 -0
index 8a211366bf..535af94ecd 100644
@@ -138,7 +138,9 @@ do_install () {
 
    # Use python 3 instead of python 2
    sed -i -e '1s,#!.*python.*,#!${USRBINPATH}/env python3,' ${D}${bindir}/pybootchartgui
+}
 
+do_install:append:class-target () {
     # The timestamps embedded in compressed man pages is not reproducible
     gzip -d ${D}${mandir}/man1/*.gz
 }
Signature · 1 line
2.44.1
#2 lore raw
Quoted 6 lines · Robert Yang via lists.openembedded.org

From: Robert Yang <[email protected]>

Fixed:

$ bitbake bootchart2-native
gzip: /path/to/bootchart2-native/0.14.9/recipe-sysroot-native/usr/share/man/man1/*.gz: No such file or directory

The question is why does the manpage not exist in native builds, when there’s nothing in the makefile or recipe to disable the manpage.

/work/ross/build/tmp/work/aarch64-linux/bootchart2-native/0.14.9

$ find image/ -type f
image/etc/bootchartd.conf
image/work/ross/build/tmp/work/aarch64-linux/bootchart2-native/0.14.9/recipe-sysroot-native/etc/bootchartd.conf
image/work/ross/build/tmp/work/aarch64-linux/bootchart2-native/0.14.9/recipe-sysroot-native/etc/init.d/bootchartd_stop.sh
image/work/ross/build/tmp/work/aarch64-linux/bootchart2-native/0.14.9/recipe-sysroot-native/sbin/bootchartd
…
image/work/ross/build/tmp/work/aarch64-linux/bootchart2-native/0.14.9/recipe-sysroot-native/usr/lib/python3.13/site-packages/pybootchartgui/__init__.py
image/work/ross/build/tmp/work/aarch64-linux/bootchart2-native/0.14.9/recipe-sysroot-native/usr/lib/python3.13/site-packages/pybootchartgui/gui.py
image/usr/share/docs/bootchart/README
image/usr/share/docs/bootchart/README.pybootchart
image/usr/share/man/man1/bootchart2.1.gz
image/usr/share/man/man1/bootchartd.1.gz
image/usr/share/man/man1/pybootchartgui.1.gz

It’s because the install is broken, more paths need to be given to the makefile. Fix the cause, don’t work around the symptoms.

Also adding -n to the gzip calls in the Makefile would make the resulting files reproducible, so we don’t need to decompress them.

Ross

#3 lore raw
Quoted 25 lines · Ross Burton via lists.openembedded.org
Quoted 6 lines · Robert Yang via lists.openembedded.org

From: Robert Yang <[email protected]>

Fixed:

$ bitbake bootchart2-native
gzip: /path/to/bootchart2-native/0.14.9/recipe-sysroot-native/usr/share/man/man1/*.gz: No such file or directory

The question is why does the manpage not exist in native builds, when there’s nothing in the makefile or recipe to disable the manpage.

/work/ross/build/tmp/work/aarch64-linux/bootchart2-native/0.14.9

$ find image/ -type f
image/etc/bootchartd.conf
image/work/ross/build/tmp/work/aarch64-linux/bootchart2-native/0.14.9/recipe-sysroot-native/etc/bootchartd.conf
image/work/ross/build/tmp/work/aarch64-linux/bootchart2-native/0.14.9/recipe-sysroot-native/etc/init.d/bootchartd_stop.sh
image/work/ross/build/tmp/work/aarch64-linux/bootchart2-native/0.14.9/recipe-sysroot-native/sbin/bootchartd
…
image/work/ross/build/tmp/work/aarch64-linux/bootchart2-native/0.14.9/recipe-sysroot-native/usr/lib/python3.13/site-packages/pybootchartgui/__init__.py
image/work/ross/build/tmp/work/aarch64-linux/bootchart2-native/0.14.9/recipe-sysroot-native/usr/lib/python3.13/site-packages/pybootchartgui/gui.py
image/usr/share/docs/bootchart/README
image/usr/share/docs/bootchart/README.pybootchart
image/usr/share/man/man1/bootchart2.1.gz
image/usr/share/man/man1/bootchartd.1.gz
image/usr/share/man/man1/pybootchartgui.1.gz
Quoted 1 line

It’s because the install is broken, more paths need to be given to the makefile. Fix the cause, don’t work around the symptoms.

You're right, I just fixed it by hand. I will send a V2 for it.

// Robert

Quoted 15 lines

Also adding -n to the gzip calls in the Makefile would make the resulting files reproducible, so we don’t need to decompress them.

Ross

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#207042): https://lists.openembedded.org/g/openembedded-core/message/207042
Mute This Topic: https://lists.openembedded.org/mt/109517754/7304958
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-