staging: rtl8723bs: Improve readability and clarity of sequence number wrapping
v9 cover staging: rtl8723bs: Improve readability and clarity of sequence number wrapping
The patchset adds spaces around binary operators, breaks long lines to enhance readability and provides clarity on sequence number wrapping by using a modulo operation % 4096u, in place of the bitwise AND(&) operation & 0xfff.
The patches are required to be applied in sequence.
Changes in v8:
* PATCH 1:
- Added Reviewed-by tag to commit message.
* PATCH 2:
- Added Reviewed-by tag to commit message.
Changes in v7:
* PATCH 1:
- Added blank line to enhance readability
* PATCH 2:
- Changed power of 2 to power-of-2 in commit message.
Changes in v6:
- Modified cover letter BLURB to reference newly added line breaks.
* PATCH 1:
- Added line breaks to long lines to improve readability.
- Changed commit message to include the information about the broken lines added to the patch.
- Changed subject line title to also include the newly added line breaks.
* PATCH 2:
- Changed instances of & 0xfff to % 4096u which were now in the broken lines after the broken lines have been done in PATCH 1.
Changes in v5:
- Converted the patch with the subject "Use % 4096 instead of & 0xfff" patch to a patchset.
- Added a patch to add spaces around binary operator.
Changes in v4:
- Corrected patch to use '%' instead of '&'.
- To ensure this change does not affect the functional
behaviour, I compared the generated object files before and
after the change using the cmp which compares the two
object files byte by byte as shown below:
$ make drivers/staging/rtl8723bs/core/rtw_xmit.o $ cmp rtw_xmit_before.o rtw_xmit_after.o
No differences were found in the output, confirming that the change does not alter the compiled output.
Changes in v3:
- Added more description to the commit message.
- Removed blank line in the tag block.
- Added more patch recipients.
Changes in v2:
- Changed the commit message t a more descriptive message which makes it clear why the patch does the change.
- changed the subject title to include 4096u to show that an unsigned module is used.
Changes in v1:
- Added more patch recipients.
Abraham Samuel Adekunle (2):
staging: rtl8723bs: Add spaces and line breaks to improve readability
staging: rtl8723bs: Use % 4096 instead of & 0xfff
drivers/staging/rtl8723bs/core/rtw_xmit.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)
Signature · 1 line
2.34.1
PATCH v9 1/2 staging: rtl8723bs: Add spaces and line breaks to improve readability
The code contains no spaces around binary operators with long lines which reduces readability thereby not adhering to Linux kernel coding style.
Add white spaces around the binary operators and use line breaks to increase readability and ensure adherence to Linux kernel coding styles.
--- drivers/staging/rtl8723bs/core/rtw_xmit.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/staging/rtl8723bs/core/rtw_xmit.c +5 -2
@@ -963,11 +963,14 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr, struct pkt_attrib *pattrif (SN_LESS (pattrib->seqnum, tx_seq)) { pattrib->ampdu_en = false;/* AGG BK */ }else if (SN_EQUAL (pattrib->seqnum, tx_seq)) { - psta->BA_starting_seqctrl[pattrib->priority &0x0f ] = (tx_seq+1 )&0xfff ; + psta->BA_starting_seqctrl[pattrib->priority &0x0f ] = + (tx_seq +1 ) &0xfff ; pattrib->ampdu_en = true;/* AGG EN */ }else { - psta->BA_starting_seqctrl[pattrib->priority &0x0f ] = (pattrib->seqnum+1 )&0xfff ; + psta->BA_starting_seqctrl[pattrib->priority &0x0f ] = + (pattrib->seqnum +1 ) &0xfff ; + pattrib->ampdu_en = true;/* AGG EN */ } }
Signature · 1 line
2.34.1
PATCH v9 2/2 staging: rtl8723bs: Use % 4096 instead of & 0xfff
In reply to Abraham Samuel AdekunleThe sequence number is constrained to a range of [0, 4095], which is a total of 4096 values. The bitmask operation using & 0xfff is used to perform this wrap-around. While this is functionally correct, it obscures the intended semantic of a 4096-based wrap.
Using a modulo operation % 4096u makes the wrap-around logic explicit and easier to understand. It clearly signals that the sequence number cycles through a range of 4096 values.
It also makes the code robust against potential changes of the 4096 upper limit, especially when it becomes a non power-of-2 value while the AND(&) works solely for power-of-2 values.
The use of % 4096u also guarantees that the modulo operation is performed with unsigned arithmetic, preventing potential issues with the signed types.
--- drivers/staging/rtl8723bs/core/rtw_xmit.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/rtl8723bs/core/rtw_xmit.c +3 -3
@@ -943,7 +943,7 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr, struct pkt_attrib *pattrif (psta) { psta->sta_xmitpriv.txseq_tid[pattrib->priority]++; - psta->sta_xmitpriv.txseq_tid[pattrib->priority] &=0xFFF ; + psta->sta_xmitpriv.txseq_tid[pattrib->priority] %=4096u ; pattrib->seqnum = psta->sta_xmitpriv.txseq_tid[pattrib->priority];SetSeqNum (hdr, pattrib->seqnum);
@@ -964,12 +964,12 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr, struct pkt_attrib *pattr pattrib->ampdu_en = false;/* AGG BK */ }else if (SN_EQUAL (pattrib->seqnum, tx_seq)) { psta->BA_starting_seqctrl[pattrib->priority &0x0f ] = - (tx_seq +1 ) &0xfff ; + (tx_seq +1 ) %4096u ; pattrib->ampdu_en = true;/* AGG EN */ }else { psta->BA_starting_seqctrl[pattrib->priority &0x0f ] = - (pattrib->seqnum +1 ) &0xfff ; + (pattrib->seqnum +1 ) %4096u ; pattrib->ampdu_en = true;/* AGG EN */ }
Signature · 1 line
2.34.1