Moto G (2013) DTS updates
cover Moto G (2013) DTS updates
This series improves the accuracy of motorola-falcon's DTS.
As a side note, I wanted to ask how to describe the Hall effect sensor's vdd-supply. The sensor's currently described as part of the gpio-keys node. According to the schematic it's powered by pm8226_lvs1, but I don't see a way to describe this as part of the gpio-keys node (maybe it's always-on because of this? Downstream describes it as gpio-keys too). Any tips?
Stanislav Jakubek (4):
ARM: dts: qcom: msm8226-motorola-falcon: add clocks, power-domain to
simpleFB
ARM: dts: qcom: msm8226-motorola-falcon: add I2C clock frequencies
ARM: dts: qcom: msm8226-motorola-falcon: limit TPS65132 to 5.4V
ARM: dts: qcom: msm8226-motorola-falcon: specify vddio_disp output
voltage
.../boot/dts/qcom/msm8226-motorola-falcon.dts | 22 +++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-)
Signature · 1 line
2.43.0
PATCH 1/4 ARM: dts: qcom: msm8226-motorola-falcon: add clocks, power-domain to simpleFB
Makes the display work without clk_ignore_unused and pd_ignore_unused.
--- arch/arm/boot/dts/qcom/msm8226-motorola-falcon.dts | 9 +++++++++ 1 file changed, 9 insertions(+)
arch/arm/boot/dts/qcom/msm8226-motorola-falcon.dts +9 -0
@@ -31,6 +31,15 @@ framebuffer@3200000 { vsp-supply = <®_lcd_pos>; vsn-supply = <®_lcd_neg>; vddio-supply = <&vddio_disp_vreg>; + clocks = <&mmcc MDSS_AHB_CLK>, + <&mmcc MDSS_AXI_CLK>, + <&mmcc MDSS_BYTE0_CLK>, + <&mmcc MDSS_ESC0_CLK>, + <&mmcc MDSS_MDP_CLK>, + <&mmcc MMSS_MISC_AHB_CLK>, + <&mmcc MDSS_PCLK0_CLK>, + <&mmcc MDSS_VSYNC_CLK>; + power-domains = <&mmcc MDSS_GDSC>; }; };
Signature · 1 line
2.43.0
Re: [PATCH 1/4] ARM: dts: qcom: msm8226-motorola-falcon: add clocks, power-domain to simpleFB
Quoted 4 lines · Stanislav Jakubek
Makes the display work without
clk_ignore_unusedandpd_ignore_unused.Signed-off-by Stanislav Jakubek <[email protected]>---
Konrad
PATCH 2/4 ARM: dts: qcom: msm8226-motorola-falcon: add I2C clock frequencies
In reply to Stanislav JakubekWhile the currently supported hardware works fine with the default clock frequencies of 100000 on both I2C2 and I2C3, downstream sources list the frequencies as 100000 for I2C2 and 400000 for I2C3. Update them as such.
--- arch/arm/boot/dts/qcom/msm8226-motorola-falcon.dts | 2 ++ 1 file changed, 2 insertions(+)
arch/arm/boot/dts/qcom/msm8226-motorola-falcon.dts +2 -0
@@ -106,6 +106,7 @@ reserved@fb00000 { }; &blsp1_i2c2 { + clock-frequency = <100000>; status = "okay"; magnetometer@c {
@@ -135,6 +136,7 @@ accelerometer@19 { }; &blsp1_i2c3 { + clock-frequency = <400000>; status = "okay"; regulator@3e {
Signature · 1 line
2.43.0
Re: [PATCH 2/4] ARM: dts: qcom: msm8226-motorola-falcon: add I2C clock frequencies
Quoted 6 lines · Stanislav Jakubek
While the currently supported hardware works fine with the default clock frequencies of 100000 on both I2C2 and I2C3, downstream sources list the frequencies as 100000 for I2C2 and 400000 for I2C3. Update them as such.
Signed-off-by Stanislav Jakubek <[email protected]>---
Konrad
PATCH 3/4 ARM: dts: qcom: msm8226-motorola-falcon: limit TPS65132 to 5.4V
In reply to Stanislav JakubekAfter some digging in downstream sources, it was found that the TPS65132 outputs are fixed to +5.4V and -5.4V respectively. This is further confirmed on runtime through debugfs, the troubleshooting guide confirms this as well. Specify these limits as such.
--- arch/arm/boot/dts/qcom/msm8226-motorola-falcon.dts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
arch/arm/boot/dts/qcom/msm8226-motorola-falcon.dts +4 -4
@@ -147,8 +147,8 @@ regulator@3e { reg_lcd_pos: outp { regulator-name = "outp"; - regulator-min-microvolt = <4000000>; - regulator-max-microvolt = <6000000>; + regulator-min-microvolt = <5400000>; + regulator-max-microvolt = <5400000>; regulator-active-discharge = <1>; regulator-boot-on; enable-gpios = <&tlmm 31 GPIO_ACTIVE_HIGH>;
@@ -156,8 +156,8 @@ reg_lcd_pos: outp { reg_lcd_neg: outn { regulator-name = "outn"; - regulator-min-microvolt = <4000000>; - regulator-max-microvolt = <6000000>; + regulator-min-microvolt = <5400000>; + regulator-max-microvolt = <5400000>; regulator-active-discharge = <1>; regulator-boot-on; enable-gpios = <&tlmm 33 GPIO_ACTIVE_HIGH>;
Signature · 1 line
2.43.0
Re: [PATCH 3/4] ARM: dts: qcom: msm8226-motorola-falcon: limit TPS65132 to 5.4V
Quoted 7 lines · Stanislav Jakubek
After some digging in downstream sources, it was found that the TPS65132 outputs are fixed to +5.4V and -5.4V respectively. This is further confirmed on runtime through debugfs, the troubleshooting guide confirms this as well. Specify these limits as such.
Signed-off-by Stanislav Jakubek <[email protected]>---
Konrad
PATCH 4/4 ARM: dts: qcom: msm8226-motorola-falcon: specify vddio_disp output voltage
In reply to Stanislav JakubekAfter some digging in downstream sources, it was found that the vddio_disp regulator's output voltage is 1.8V. This is further confirmed by the troubleshooting guide. Specify its output voltage as such. While at it, add a comment specifying the IC, which according to the schematic is the TI TPS22902.
--- arch/arm/boot/dts/qcom/msm8226-motorola-falcon.dts | 3 +++ 1 file changed, 3 insertions(+)
arch/arm/boot/dts/qcom/msm8226-motorola-falcon.dts +3 -0
@@ -62,9 +62,12 @@ key-volume-up { }; }; + /* TI TPS22902 */ vddio_disp_vreg: regulator-vddio-disp { compatible = "regulator-fixed"; regulator-name = "vddio_disp"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; gpio = <&tlmm 34 GPIO_ACTIVE_HIGH>; vin-supply = <&pm8226_l8>; startup-delay-us = <300>;
Signature · 1 line
2.43.0
Re: [PATCH 4/4] ARM: dts: qcom: msm8226-motorola-falcon: specify vddio_disp output voltage
Quoted 8 lines · Stanislav Jakubek
After some digging in downstream sources, it was found that the
vddio_dispregulator's output voltage is 1.8V. This is further confirmed by the troubleshooting guide. Specify its output voltage as such. While at it, add a comment specifying the IC, which according to the schematic is the TI TPS22902.Signed-off-by Stanislav Jakubek <[email protected]>---
Not sure what the troubleshooting guide you're referring to is, but nonetheless
Konrad
Quoted 9 lines · Stanislav Jakubek
This series improves the accuracy of motorola-falcon's DTS.
As a side note, I wanted to ask how to describe the Hall effect sensor's vdd-supply. The sensor's currently described as part of the gpio-keys node. According to the schematic it's powered by
pm8226_lvs1, but I don't see a way to describe this as part of the gpio-keys node (maybe it's always-on because of this? Downstream describes it as gpio-keys too). Any tips?[...]
Applied, thanks!
[1/4] ARM: dts: qcom: msm8226-motorola-falcon: add clocks, power-domain to simpleFB
commit: cbcd04ab82c61dc777a4b56014292b9467f10c4e
[2/4] ARM: dts: qcom: msm8226-motorola-falcon: add I2C clock frequencies
commit: db6e3f2ba0bf6ad069347050ff62f29ef0d88b14
[3/4] ARM: dts: qcom: msm8226-motorola-falcon: limit TPS65132 to 5.4V
commit: 7bce56fd73ee7264ed04418dab1719164e42f113
[4/4] ARM: dts: qcom: msm8226-motorola-falcon: specify vddio_disp output voltage
commit: e41ece7cd173486f6767de050deb2d8f0882a82aBest regards,
Signature · 1 line
Bjorn Andersson <[email protected]>