Some kernel-doc fixes
Subsystems (2)
v2 cover Some kernel-doc fixes
Hi Jon,
That's the second version of the kernel-doc fixup patch series.
I discovered the root cause why Sphinx logger was not working: there was a call there for logger.verbose(). According with:
https://www.sphinx-doc.org/en/master/extdev/logging.html
This is a valid call, but it doesn't verbose messages. Instead, it is crashing with modern Sphinx versions, causing the log to not work.
I got rid of it, replacing by logger.info(). I took the time to also address an issue pointed by Andy: not having the same log message placed everywhere. With such change, we can keep using Sphinx logger (which produces colored messages) inside kernel-doc classes.
With that, we have:
Patch 1: cleanup try/except logic and get rid of logger.verbose();
Patch 2: fix a KeyError when trying to acess data from non-existing files;
Patch 3: makes Lore and kernel-doc ML receive patches related
to kernel-doc.py and get_abi.py.
If you test just patch 1 on the top of next-20250516, you'll see the keyerror message (in red):
ERROR: Cannot find file ./drivers/gpio/gpiolib-acpi.c
ERROR: Cannot find file ./drivers/gpio/gpiolib-acpi.c
WARNING: kernel-doc './scripts/kernel-doc.py -rst -enable-lineno -export ./drivers/gpio/gpiolib-acpi.c' processing failed with: KeyError('./drivers/gpio/gpiolib-acpi.c')
And the script doesn't crash anymore. After patch 2, the try/except warning gets replaced by a proper message:
ERROR: Cannot find file ./drivers/gpio/gpiolib-acpi.c
ERROR: Cannot find file ./drivers/gpio/gpiolib-acpi.c
WARNING: No kernel-doc for file ./drivers/gpio/gpiolib-acpi.c
Please apply it to solve the issues that are reported by Stephen and Akira.
Regards,
Mauro
Mauro Carvalho Chehab (1):
MAINTAINERS: update linux-doc entry to cover new Python scripts
MAINTAINERS | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
Signature · 1 line
2.49.0
PATCH v2 1/1 MAINTAINERS: update linux-doc entry to cover new Python scripts
Changes to ABI and kernel-doc need to be c/c linux-doc. Update the maintainer's entry to cover those files.
--- MAINTAINERS | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
MAINTAINERS +4 -1
@@ -7173,7 +7173,10 @@ T: git git://git.lwn.net/linux.git docs-next F: Documentation/ F: scripts/check-variable-fonts.sh F: scripts/documentation-file-ref-check -F: scripts/kernel-doc +F: scripts/get_abi.py +F: scripts/kernel-doc* +F scripts/lib/abi/* +F scripts/lib/kdoc/* F: scripts/sphinx-pre-install X: Documentation/ABI/ X: Documentation/admin-guide/media/
Signature · 1 line
2.49.0
Em Wed, 21 May 2025 08:50:25 +0200
Mauro Carvalho Chehab <[email protected]> escreveu:
Quoted 3 lines
Hi Jon,
That's the second version of the kernel-doc fixup patch series.
Please ignore this... It got just the last patch... It reminds I didn't trink my usual cup of coffee this morning.
I opted to re-order the series placing the MAINTAINERS patch first, with the hope that Lore would pick the entire series as submissions for linux-doc.
Thanks,
Mauro