Skip to contentSkip to conversation

btrfs: do not poke into bdev's page cache

PATCH Superseded Qu Wenruo 3 participants 8 messages Jul 9, 2025 Btrfs file system

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Qu Wenruo

author
#0 lore raw

cover btrfs: do not poke into bdev's page cache

[CHANGELOG]
v2:
- Make sb_write_pointer() use bdev_rw_virt()
That is the missing location that still uses bdev's page cache, thanks Johannes for exposing this one.

- Replace btrfs_release_disk_super() with kfree()
There is no need to keep that helper, and such replace will help us exposing locations which are still using the old page cache, like the above case.

- Only scratch the magic number of a super block in btrfs_scratch_superblock()
To keep the behavior the same.

- Use GFP_NOFS when allocating memory
This is also to keep the old behavior.

Although I'd say btrfs_read_disk_super() call sites are safe, as they are either scanning a device, or at mount time, thus out of the write path and should be safe.

The sb_write_pointer() one still needs the old GFP_NOFS flag as they can be called when writing the super block.

Btrfs has a long history using bdev's page cache for super block IOs. This looks weird, but is mostly for the sake of concurrency.

However this has already caused problems, for example when the block layer page cache enables large folio support, it triggers an ASSERT() inside btrfs, this is fixed by commit 65f2a3b2323e ("btrfs: remove folio order ASSERT()s in super block writeback path"), but it is already a warning.

Thankfully we're moving away from the bdev's page cache already, starting with commit bc00965dbff7 ("btrfs: count super block write errors in device instead of tracking folio error state"), we no longer relies on page cache to detect super block IO errors.

But we're still using the bdev's page cache for:

- Reading super blocks
This is the easist one to kill, just kmalloc() and bdev_rw_virt() will handle it well.

- Scratching super blocks
Previously we just zero out the magic, but leaving everything else there.
We rely on the block layer to write the involved blocks.

Here we follow btrfs_read_disk_super() by kzalloc()ing a dummy super block, and write the full super block back to disk.

- Writing super blocks
Although write_dev_supers() is alreadying using the bio interface, it still relies on the bdev's page cache.

One of the reason is, we want to submit all super blocks of a device in one go, and each super block of the same block device is slightly different, thus we go using page cache, so that each super block can have its own backing folio.

Here we solve it by pre-allocating super block buffers. This also makes endio function much simpler, no need to iterate the bio to unlock the folio.

- Waiting super blocks
Instead of locking the folio to make sure its IO is done, just use an atomic and wait queue head to do it the usual way.

By this we solve the problem and all IOs are done using bio interface.

But this brings some overhead, thus I marked the series RFC:

- Extra 12K memory usage for each block device
I hope the extra cost is acceptable for modern day systems.

- Extra memory copy for super block writeback
Previously we do the copy into the bdev's page cache, then submit the IO using folio from the bdev page cache.

This updates the page cache and do the IO in one go.

But now we memcpy() into the preallocated super block buffer, not updating the bdev's page cache directly.

Qu Wenruo (2):
btrfs: use bdev_rw_virt() to read and scratch the disk super block
btrfs: do not poke into bdev's page cache for super block write

 fs/btrfs/disk-io.c | 86 +++++++++++++++-------------------------------
 fs/btrfs/super.c   |  4 +--
 fs/btrfs/volumes.c | 83 +++++++++++++++++++++-----------------------
 fs/btrfs/volumes.h | 10 ++++--
 fs/btrfs/zoned.c   | 28 ++++++++-------
 5 files changed, 93 insertions(+), 118 deletions(-)
Signature · 1 line
2.50.0
author
#1 lore raw

PATCH 1/2 btrfs: use bdev_rw_virt() to read and scratch the disk super block

Currently we're using the block device page cache to read and scratch the super block.

This makes btrfs to poking into lower layer unnecessarily.

Modify the following routines by:

- Use kmalloc() + bdev_rw_virt() for btrfs_read_disk_super() This means we can easily replace btrfs_release_disk_super() with a simple kfree().

This also means there will no longer be any cached read for btrfs_read_disk_super(), thus we can drop the @drop_cache parameter.

However this change brings a slightly behavior change for btrfs_scan_one_device(), now every time the device is scanned, btrfs will submit a read request, no more cached scan.

- Use bdev_rw_virt() for btrfs_scratch_superblock()
Just use the memory returned by btrfs_read_disk_super() and reset the magic number.
Then use bdev_rw_virt() to do the write.

Since we're here, also make the error message cover the initial disk super read error.

- Use kmalloc() and bdev_rw_virt() for sb_writer_pointer() In zoned mode we have a corner case that both super block zones are full, and we need to determine which zone to reuse.

In that case we need to read the last super block of both zones and compare their generations.

Here we just use regular kmalloc() + bdev_rw_virt() to do the read.

And since we're here, simplify the error handling path by always calling kfree() on both super blocks.
Since both super block pointers are initialized to NULL, we're safe to call kfree() on them.

---
 fs/btrfs/disk-io.c | 10 +++----
 fs/btrfs/super.c   |  4 +--
 fs/btrfs/volumes.c | 70 ++++++++++++++++++----------------------------
 fs/btrfs/volumes.h |  4 +--
 fs/btrfs/zoned.c   | 28 +++++++++++--------
 5 files changed, 51 insertions(+), 65 deletions(-)
fs/btrfs/disk-io.c +5 -5
index 44e7ae4a2e0b..c4b020187249 100644
@@ -3320,7 +3320,7 @@ int __cold open_ctree(struct super_block *sb, struct btrfs_fs_devices *fs_device
 	/*
 	 * Read super block and check the signature bytes only
 	 */
-	disk_super = btrfs_read_disk_super(fs_devices->latest_dev->bdev, 0, false);
+	disk_super = btrfs_read_disk_super(fs_devices->latest_dev->bdev, 0);
 	if (IS_ERR(disk_super)) {
 		ret = PTR_ERR(disk_super);
 		goto fail_alloc;
@@ -3336,7 +3336,7 @@ int __cold open_ctree(struct super_block *sb, struct btrfs_fs_devices *fs_device
 		btrfs_err(fs_info, "unsupported checksum algorithm: %u",
 			  csum_type);
 		ret = -EINVAL;
-		btrfs_release_disk_super(disk_super);
+		kfree(disk_super);
 		goto fail_alloc;
 	}
 
@@ -3344,7 +3344,7 @@ int __cold open_ctree(struct super_block *sb, struct btrfs_fs_devices *fs_device
 
 	ret = btrfs_init_csum_hash(fs_info, csum_type);
 	if (ret) {
-		btrfs_release_disk_super(disk_super);
+		kfree(disk_super);
 		goto fail_alloc;
 	}
 
@@ -3355,7 +3355,7 @@ int __cold open_ctree(struct super_block *sb, struct btrfs_fs_devices *fs_device
 	if (btrfs_check_super_csum(fs_info, disk_super)) {
 		btrfs_err(fs_info, "superblock checksum mismatch");
 		ret = -EINVAL;
-		btrfs_release_disk_super(disk_super);
+		kfree(disk_super);
 		goto fail_alloc;
 	}
 
@@ -3365,7 +3365,7 @@ int __cold open_ctree(struct super_block *sb, struct btrfs_fs_devices *fs_device
 	 * the whole block of INFO_SIZE
 	 */
 	memcpy(fs_info->super_copy, disk_super, sizeof(*fs_info->super_copy));
-	btrfs_release_disk_super(disk_super);
+	kfree(disk_super);
 
 	disk_super = fs_info->super_copy;
 
fs/btrfs/super.c +2 -2
index e4ce2754cfde..b6feddcf4510 100644
@@ -2309,7 +2309,7 @@ static int check_dev_super(struct btrfs_device *dev)
 		return 0;
 
 	/* Only need to check the primary super block. */
-	sb = btrfs_read_disk_super(dev->bdev, 0, true);
+	sb = btrfs_read_disk_super(dev->bdev, 0);
 	if (IS_ERR(sb))
 		return PTR_ERR(sb);
 
@@ -2341,7 +2341,7 @@ static int check_dev_super(struct btrfs_device *dev)
 		goto out;
 	}
 out:
-	btrfs_release_disk_super(sb);
+	kfree(sb);
 	return ret;
 }
 
fs/btrfs/volumes.c +27 -43

133 lines not on this page · raw message

fs/btrfs/volumes.h +1 -3
index 7395cb5e1238..bf2e9a5a63ea 100644
@@ -798,9 +798,7 @@ struct btrfs_chunk_map *btrfs_get_chunk_map(struct btrfs_fs_info *fs_info,
 					    u64 logical, u64 length);
 void btrfs_remove_chunk_map(struct btrfs_fs_info *fs_info, struct btrfs_chunk_map *map);
 struct btrfs_super_block *btrfs_read_disk_super(struct block_device *bdev,
-						int copy_num, bool drop_cache);
-void btrfs_release_disk_super(struct btrfs_super_block *super);
-
+						int copy_num);
 static inline void btrfs_dev_stat_inc(struct btrfs_device *dev,
 				      int index)
 {
fs/btrfs/zoned.c +16 -12
index 245e813ecd78..ce67f68075d7 100644
@@ -117,23 +117,27 @@ static int sb_write_pointer(struct block_device *bdev, struct blk_zone *zones,
 		return -ENOENT;
 	} else if (full[0] && full[1]) {
 		/* Compare two super blocks */
-		struct address_space *mapping = bdev->bd_mapping;
-		struct page *page[BTRFS_NR_SB_LOG_ZONES];
-		struct btrfs_super_block *super[BTRFS_NR_SB_LOG_ZONES];
+		struct btrfs_super_block *super[BTRFS_NR_SB_LOG_ZONES] = { 0 };
 
 		for (int i = 0; i < BTRFS_NR_SB_LOG_ZONES; i++) {
 			u64 zone_end = (zones[i].start + zones[i].capacity) << SECTOR_SHIFT;
 			u64 bytenr = ALIGN_DOWN(zone_end, BTRFS_SUPER_INFO_SIZE) -
 						BTRFS_SUPER_INFO_SIZE;
+			int ret;
 
-			page[i] = read_cache_page_gfp(mapping,
-					bytenr >> PAGE_SHIFT, GFP_NOFS);
-			if (IS_ERR(page[i])) {
-				if (i == 1)
-					btrfs_release_disk_super(super[0]);
-				return PTR_ERR(page[i]);
+			super[i] = kmalloc(BTRFS_SUPER_INFO_SIZE, GFP_NOFS);
+			if (!super[i]) {
+				kfree(super[0]);
+				kfree(super[1]);
+				return -ENOMEM;
+			}
+			ret = bdev_rw_virt(bdev, bytenr >> SECTOR_SHIFT, super[i],
+					   BTRFS_SUPER_INFO_SIZE, REQ_OP_READ);
+			if (ret < 0) {
+				kfree(super[0]);
+				kfree(super[1]);
+				return ret;
 			}
-			super[i] = page_address(page[i]);
 		}
 
 		if (btrfs_super_generation(super[0]) >
@@ -142,8 +146,8 @@ static int sb_write_pointer(struct block_device *bdev, struct blk_zone *zones,
 		else
 			sector = zones[0].start;
 
-		for (int i = 0; i < BTRFS_NR_SB_LOG_ZONES; i++)
-			btrfs_release_disk_super(super[i]);
+		kfree(super[0]);
+		kfree(super[1]);
 	} else if (!full[0] && (empty[1] || full[1])) {
 		sector = zones[0].wp;
 	} else if (full[0]) {
Signature · 1 line
2.50.0
#2 lore raw

Re: [PATCH 1/2] btrfs: use bdev_rw_virt() to read and scratch the disk super block

fs/btrfs/zoned.c static int sb_write_pointer(struct block_device *bdev, struct blk_zone *zones, · line 150

Quoted 4 lines · Qu Wenruo
fs/btrfs/zoned.c +2 -2
-		for (int i = 0; i < BTRFS_NR_SB_LOG_ZONES; i++)
-			btrfs_release_disk_super(super[i]);
+		kfree(super[0]);
+		kfree(super[1]);

Nit: I'd personally prefer to keep

for (int i = 0; i < BTRFS_NR_SB_LOG_ZONES; i++)

	kfree(super[i]);
author
#3 lore raw

PATCH 2/2 btrfs: do not poke into bdev's page cache for super block write

In reply to Qu Wenruo

[EXISTING BEHAVIOR]
Currently btrfs is utilizing block device's page cache to write super blocks.

This has a long history, dating back to early days when we relies on the page's flags to determine if the IO is done or failed.

But later commit bc00965dbff7 ("btrfs: count super block write errors in device instead of tracking folio error state") uses extra atomic to track how many errors are hit, and we no longer rely on page flags to determine if the IO is done or failed.

[PROBLEMS]
But such direct usage of block devices' page cache is putting btrfs responsible to the implementation details of the block device.

In fact this has already caused problem when the block device's page cache has large folio support enabled, fixed by commit 65f2a3b2323e ("btrfs: remove folio order ASSERT()s in super block writeback path").

This should give us a warning that poking into other layer's implementation is not a good idea.

[ENHANCEMENT]
Instead of directly using block device's page cache, use the regular bio interfaces, this involves:

- Introduce extra buffer for all super blocks of a device This is needed because we want to submit bios for all super blocks in one go, and wait for them all.
This is to increase concurrency, thus we can not reuse a single super block copy, and that's part of the reason we want to use page cache.

Unfortunately this means we will have extra 12K memory usage for each btrfs device.

- Introduce ways to wait for super block writeback Previously we rely on the page cache to wait for the IO to finish. Now we have an atomic, @sb_write_running, to record how many running super block writes are pending.

And also a wait queue head for waiting.

This greatly simplify wait_dev_supers(), now we only need to wait for the pending ios to finish.

- Simplify btrfs_end_super_write() function
Now we don't need to bother releasing the folio, we can get rid of the bio iteration code.

---
 fs/btrfs/disk-io.c | 76 ++++++++++++++--------------------------------
 fs/btrfs/volumes.c | 13 ++++++++
 fs/btrfs/volumes.h |  6 ++++
 3 files changed, 42 insertions(+), 53 deletions(-)
fs/btrfs/disk-io.c +23 -53
index c4b020187249..c93d7b908f66 100644
@@ -3692,27 +3692,23 @@ ALLOW_ERROR_INJECTION(open_ctree, ERRNO);
 static void btrfs_end_super_write(struct bio *bio)
 {
 	struct btrfs_device *device = bio->bi_private;
-	struct folio_iter fi;
 
-	bio_for_each_folio_all(fi, bio) {
-		if (bio->bi_status) {
-			btrfs_warn_rl(device->fs_info,
-				"lost super block write due to IO error on %s (%d)",
-				btrfs_dev_name(device),
-				blk_status_to_errno(bio->bi_status));
-			btrfs_dev_stat_inc_and_print(device,
-						     BTRFS_DEV_STAT_WRITE_ERRS);
-			/* Ensure failure if the primary sb fails. */
-			if (bio->bi_opf & REQ_FUA)
-				atomic_add(BTRFS_SUPER_PRIMARY_WRITE_ERROR,
-					   &device->sb_write_errors);
-			else
-				atomic_inc(&device->sb_write_errors);
-		}
-		folio_unlock(fi.folio);
-		folio_put(fi.folio);
+	if (bio->bi_status) {
+		btrfs_warn_rl(device->fs_info,
+			"lost super block write due to IO error on %s (%d)",
+			btrfs_dev_name(device),
+			blk_status_to_errno(bio->bi_status));
+		btrfs_dev_stat_inc_and_print(device,
+					     BTRFS_DEV_STAT_WRITE_ERRS);
+		/* Ensure failure if the primary sb fails. */
+		if (bio->bi_opf & REQ_FUA)
+			atomic_add(BTRFS_SUPER_PRIMARY_WRITE_ERROR,
+				   &device->sb_write_errors);
+		else
+			atomic_inc(&device->sb_write_errors);
 	}
-
+	if (atomic_dec_and_test(&device->sb_write_running))
+		wake_up(&device->sb_write_wait);
 	bio_put(bio);
 }
 
@@ -3730,24 +3726,21 @@ static int write_dev_supers(struct btrfs_device *device,
 			    struct btrfs_super_block *sb, int max_mirrors)
 {
 	struct btrfs_fs_info *fs_info = device->fs_info;
-	struct address_space *mapping = device->bdev->bd_mapping;
 	SHASH_DESC_ON_STACK(shash, fs_info->csum_shash);
 	int i;
 	int ret;
 	u64 bytenr, bytenr_orig;
 
 	atomic_set(&device->sb_write_errors, 0);
+	ASSERT(atomic_read(&device->sb_write_running) == 0);
 
 	if (max_mirrors == 0)
 		max_mirrors = BTRFS_SUPER_MIRROR_MAX;
-
+	ASSERT(max_mirrors <= BTRFS_SUPER_MIRROR_MAX);
 	shash->tfm = fs_info->csum_shash;
 
 	for (i = 0; i < max_mirrors; i++) {
-		struct folio *folio;
 		struct bio *bio;
-		struct btrfs_super_block *disk_super;
-		size_t offset;
 
 		bytenr_orig = btrfs_sb_offset(i);
 		ret = btrfs_sb_log_location(device, i, WRITE, &bytenr);
@@ -3769,21 +3762,7 @@ static int write_dev_supers(struct btrfs_device *device,
 		crypto_shash_digest(shash, (const char *)sb + BTRFS_CSUM_SIZE,
 				    BTRFS_SUPER_INFO_SIZE - BTRFS_CSUM_SIZE,
 				    sb->csum);
-
-		folio = __filemap_get_folio(mapping, bytenr >> PAGE_SHIFT,
-					    FGP_LOCK | FGP_ACCESSED | FGP_CREAT,
-					    GFP_NOFS);
-		if (IS_ERR(folio)) {
-			btrfs_err(device->fs_info,
-			  "couldn't get super block page for bytenr %llu error %ld",
-			  bytenr, PTR_ERR(folio));
-			atomic_inc(&device->sb_write_errors);
-			continue;
-		}
-
-		offset = offset_in_folio(folio, bytenr);
-		disk_super = folio_address(folio) + offset;
-		memcpy(disk_super, sb, BTRFS_SUPER_INFO_SIZE);
+		memcpy(device->sb_write_buf[i], sb, BTRFS_SUPER_INFO_SIZE);
 
 		/*
 		 * Directly use bios here instead of relying on the page cache
@@ -3796,7 +3775,7 @@ static int write_dev_supers(struct btrfs_device *device,
 		bio->bi_iter.bi_sector = bytenr >> SECTOR_SHIFT;
 		bio->bi_private = device;
 		bio->bi_end_io = btrfs_end_super_write;
-		bio_add_folio_nofail(bio, folio, BTRFS_SUPER_INFO_SIZE, offset);
+		bio_add_virt_nofail(bio, device->sb_write_buf[i], BTRFS_SUPER_INFO_SIZE);
 
 		/*
 		 * We FUA only the first super block.  The others we allow to
@@ -3805,6 +3784,7 @@ static int write_dev_supers(struct btrfs_device *device,
 		 */
 		if (i == 0 && !btrfs_test_opt(device->fs_info, NOBARRIER))
 			bio->bi_opf |= REQ_FUA;
+		atomic_inc(&device->sb_write_running);
 		submit_bio(bio);
 
 		if (btrfs_advance_sb_log(device, i))
@@ -3830,10 +3810,10 @@ static int wait_dev_supers(struct btrfs_device *device, int max_mirrors)
 
 	if (max_mirrors == 0)
 		max_mirrors = BTRFS_SUPER_MIRROR_MAX;
+	ASSERT(max_mirrors <= BTRFS_SUPER_MIRROR_MAX);
 
+	/* Calculate how many super blocks we really have. */
 	for (i = 0; i < max_mirrors; i++) {
-		struct folio *folio;
-
 		ret = btrfs_sb_log_location(device, i, READ, &bytenr);
 		if (ret == -ENOENT) {
 			break;
@@ -3846,17 +3826,8 @@ static int wait_dev_supers(struct btrfs_device *device, int max_mirrors)
 		if (bytenr + BTRFS_SUPER_INFO_SIZE >=
 		    device->commit_total_bytes)
 			break;
-
-		folio = filemap_get_folio(device->bdev->bd_mapping,
-					  bytenr >> PAGE_SHIFT);
-		/* If the folio has been removed, then we know it completed. */
-		if (IS_ERR(folio))
-			continue;
-
-		/* Folio will be unlocked once the write completes. */
-		folio_wait_locked(folio);
-		folio_put(folio);
 	}
+	wait_event(device->sb_write_wait, atomic_read(&device->sb_write_running) == 0);
 
 	errors += atomic_read(&device->sb_write_errors);
 	if (errors >= BTRFS_SUPER_PRIMARY_WRITE_ERROR)
@@ -3866,7 +3837,6 @@ static int wait_dev_supers(struct btrfs_device *device, int max_mirrors)
 			  device->devid);
 		return -1;
 	}
-
 	return errors < i ? 0 : -1;
 }
 
fs/btrfs/volumes.c +13 -0
index 03643c71addf..be638774b9eb 100644
@@ -400,6 +400,7 @@ static struct btrfs_fs_devices *alloc_fs_devices(const u8 *fsid)
 static void btrfs_free_device(struct btrfs_device *device)
 {
 	WARN_ON(!list_empty(&device->post_commit_list));
+	WARN_ON(atomic_read(&device->sb_write_running) != 0);
 	/*
 	 * No need to call kfree_rcu() nor do RCU lock/unlock, nothing is
 	 * reading the device name.
@@ -407,6 +408,8 @@ static void btrfs_free_device(struct btrfs_device *device)
 	kfree(rcu_dereference_raw(device->name));
 	btrfs_extent_io_tree_release(&device->alloc_state);
 	btrfs_destroy_dev_zone_info(device);
+	for (int i = 0; i < BTRFS_SUPER_MIRROR_MAX; i++)
+		kfree(device->sb_write_buf[i]);
 	kfree(device);
 }
 
@@ -6893,6 +6896,8 @@ struct btrfs_device *btrfs_alloc_device(struct btrfs_fs_info *fs_info,
 	INIT_LIST_HEAD(&dev->post_commit_list);
 
 	atomic_set(&dev->dev_stats_ccnt, 0);
+	atomic_set(&dev->sb_write_running, 0);
+	init_waitqueue_head(&dev->sb_write_wait);
 	btrfs_device_data_ordered_init(dev);
 	btrfs_extent_io_tree_init(fs_info, &dev->alloc_state, IO_TREE_DEVICE_ALLOC_STATE);
 
@@ -6925,6 +6930,14 @@ struct btrfs_device *btrfs_alloc_device(struct btrfs_fs_info *fs_info,
 		rcu_assign_pointer(dev->name, name);
 	}
 
+	for (int i = 0; i < BTRFS_SUPER_MIRROR_MAX; i++) {
+		dev->sb_write_buf[i] = kmalloc(BTRFS_SUPER_INFO_SIZE, GFP_KERNEL);
+		if (!dev->sb_write_buf[i]) {
+			btrfs_free_device(dev);
+			return ERR_PTR(-ENOMEM);
+		}
+	}
+
 	return dev;
 }
 
fs/btrfs/volumes.h +6 -0
index bf2e9a5a63ea..830a8383b73b 100644
@@ -20,6 +20,7 @@
 #include <linux/rbtree.h>
 #include <uapi/linux/btrfs.h>
 #include <uapi/linux/btrfs_tree.h>
+#include "disk-io.h"
 #include "messages.h"
 #include "extent-io-tree.h"
 
@@ -182,6 +183,11 @@ struct btrfs_device {
 	struct bio flush_bio;
 	struct completion flush_wait;
 
+	/* Buffer for each super block. */
+	struct btrfs_super_block *sb_write_buf[BTRFS_SUPER_MIRROR_MAX];
+	atomic_t sb_write_running;
+	wait_queue_head_t sb_write_wait;
+
 	/* per-device scrub information */
 	struct scrub_ctx *scrub_ctx;
 
Signature · 1 line
2.50.0
#5 lore raw
Quoted 5 lines · Johannes Thumshirn

Minus the nit in 1/2

I'm also running it throught fstests on my CI setup (nearly done and looking good so far).

If your CI run has finished, mind to check if the generic/492 failed randomly?

During my local runs, generic/492 will hit random failure, due to blkid unable to find any useful btrfs super block.

And that is caused by the 2nd patch, which makes sense as that patch changed how we write the superblocks.

So there seems to be something missing related to the writeback behavior.

Thanks,
Qu

Quoted 2 lines
#6 lore raw
Quoted 12 lines · Qu Wenruo
Quoted 5 lines · Johannes Thumshirn

Minus the nit in 1/2

I'm also running it throught fstests on my CI setup (nearly done and looking good so far).

If your CI run has finished, mind to check if the generic/492 failed randomly?

Quoted 8 lines

During my local runs, generic/492 will hit random failure, due to blkid unable to find any useful btrfs super block.

And that is caused by the 2nd patch, which makes sense as that patch changed how we write the superblocks.

So there seems to be something missing related to the writeback behavior.

In the CI it finished successfully. I've manually ran it 50 times on a tcmu emulated SMR drive and there it failed 7 out of the 50 times with the following signature:

generic/492 1s ... [ 119.110313] BTRFS error (device sdb): unable to set label with more than 255 bytes
- output mismatch (see /home/johannes/src/fstests/results//generic/492.out.bad)

     --- tests/generic/492.out	2025-05-15 21:26:16.848414286 +0200
     +++ /home/johannes/src/fstests/results//generic/492.out.bad	2025-07-09 10:41:47.280866272 +0200
     @@ -5,8 +5,6 @@
      label = ""
      label = "label.492"
      label = "label.492"
     -SCRATCH_DEV: LABEL="label.492"
     -SCRATCH_DEV: LABEL="label.492"
      label = "label.492"
      label: Invalid argument
     ...
     (Run 'diff -u /home/johannes/src/fstests/tests/generic/492.out /home/johannes/src/fstests/results//generic/492.out.bad'  to see the entire diff)

Ran: generic/492
Failures: generic/492
Failed 1 of 1 tests

#7 lore raw
Quoted 41 lines · Johannes Thumshirn
Quoted 12 lines · Qu Wenruo
Quoted 5 lines · Johannes Thumshirn

Minus the nit in 1/2

I'm also running it throught fstests on my CI setup (nearly done and looking good so far).

If your CI run has finished, mind to check if the generic/492 failed randomly?

Quoted 8 lines

During my local runs, generic/492 will hit random failure, due to blkid unable to find any useful btrfs super block.

And that is caused by the 2nd patch, which makes sense as that patch changed how we write the superblocks.

So there seems to be something missing related to the writeback behavior.

In the CI it finished successfully. I've manually ran it 50 times on a tcmu emulated SMR drive and there it failed 7 out of the 50 times with the following signature:

generic/492 1s ... [ 119.110313] BTRFS error (device sdb): unable to set label with more than 255 bytes
- output mismatch (see /home/johannes/src/fstests/results//generic/492.out.bad)

      --- tests/generic/492.out	2025-05-15 21:26:16.848414286 +0200
      +++ /home/johannes/src/fstests/results//generic/492.out.bad	2025-07-09 10:41:47.280866272 +0200
      @@ -5,8 +5,6 @@
       label = ""
       label = "label.492"
       label = "label.492"
      -SCRATCH_DEV: LABEL="label.492"
      -SCRATCH_DEV: LABEL="label.492"
       label = "label.492"
       label: Invalid argument
      ...
      (Run 'diff -u /home/johannes/src/fstests/tests/generic/492.out /home/johannes/src/fstests/results//generic/492.out.bad'  to see the entire diff)
Quoted 3 lines

Ran: generic/492
Failures: generic/492
Failed 1 of 1 tests

Thanks for confirming, it's exactly the same I'm hitting.

And it's pretty weird other fses, including f2fs and ext4 are also utilizing direct block device's page cache to do super block IO.

So this is something weird here.

Thanks,
Qu