Skip to contentSkip to conversation

Various trees,shell files missing the shebang line

PATCH In review Bhaskar Chowdhury 3 participants 14 messages Jul 22, 2025

Subsystems (9)
lore
Share & tools
lore
#0 lore raw

cover Various trees,shell files missing the shebang line

This is a human being with flesh and blood.

Shell script files were missing the "shebang" line aka shell interpreter.

Note to Randy,

This is for your spare time Eagle Eye stuff, if you could...please.

Oh, I might have inadvertantly added some harmless blank lines too.

Bhaskar Chowdhury (11):
Shebang line was missing,fixed
Shebang line was missing,fixed
Shebang line was missing,fixed
Shebang line was missing,fixed
There was a space between bang and shell path,fixed Shebang line was missing,fixed
Shebang line was missing,fixed
Shebang line was missing,fixed
Shebang line was missing,fixed
Shebang line was missing,fixed
Shebang line was missing,fixed

 Documentation/admin-guide/aoe/status.sh                     | 2 +-
 Documentation/admin-guide/aoe/udev-install.sh               | 6 ++++--
 Documentation/features/list-arch.sh                         | 2 ++
 Documentation/features/scripts/features-refresh.sh          | 2 +-
 arch/powerpc/tools/head_check.sh                            | 1 +
 samples/pktgen/functions.sh                                 | 2 +-
 samples/pktgen/parameters.sh                                | 2 +-
 tools/bootconfig/scripts/ftrace.sh                          | 1 +
 tools/perf/tests/shell/common/init.sh                       | 1 +
 tools/perf/tests/shell/common/patterns.sh                   | 1 +
 .../drivers/net/mlxsw/spectrum-2/mirror_gre_scale.sh        | 1 +
 11 files changed, 15 insertions(+), 6 deletions(-)

--
2.49.1

#1 lore raw

PATCH 1/11 Shebang line was missing,fixed

Added the shebang lines at the top of the file.

---
 Documentation/admin-guide/aoe/udev-install.sh | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
Documentation/admin-guide/aoe/udev-install.sh +4 -2
index 15e86f58c036..1a34692cda23 100644
@@ -1,6 +1,8 @@
-# install the aoe-specific udev rules from udev.txt into
+#!/bin/sh
+
+# install the aoe-specific udev rules from udev.txt into
 # the system's udev configuration
-#
+#
 
 me="`basename $0`"
 

--
2.49.1

#2 lore raw

PATCH 2/11 Shebang line was missing,fixed

In reply to Bhaskar Chowdhury

Added the shebang line at the top of file.

---
 Documentation/features/list-arch.sh | 2 ++
 1 file changed, 2 insertions(+)
Documentation/features/list-arch.sh +2 -0
index ac8ff7f6f859..e7124a4c3e8f 100755
@@ -1,3 +1,5 @@
+#!/bin/sh
+
 # SPDX-License-Identifier: GPL-2.0
 #
 # Small script that visualizes the kernel feature support status

--
2.49.1

#3 lore raw

PATCH 3/11 Shebang line was missing,fixed

In reply to Bhaskar Chowdhury

Added the shebang line at the top of file.

---
 Documentation/features/scripts/features-refresh.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/features/scripts/features-refresh.sh +1 -1
index c2288124e94a..a908704fd149 100755
@@ -1,4 +1,4 @@
-#
+#!/bin/sh
 # Small script that refreshes the kernel feature support status in place.
 #
 

--
2.49.1

#4 lore raw

PATCH 4/11 Shebang line was missing,fixed

In reply to Bhaskar Chowdhury

Added the shebang line at the top of file.

---
 arch/powerpc/tools/head_check.sh | 1 +
 1 file changed, 1 insertion(+)
arch/powerpc/tools/head_check.sh +1 -0
index 689907cda996..a9cd06958921 100644
@@ -1,3 +1,4 @@
+#!/bin/sh
 # Copyright © 2016 IBM Corporation
 
 # This program is free software; you can redistribute it and/or

--
2.49.1

#5 lore raw

PATCH 5/11 There was a space between bang and shell path,fixed

In reply to Bhaskar Chowdhury

Added the shebang line at the top of file.

---
 Documentation/admin-guide/aoe/status.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/admin-guide/aoe/status.sh +1 -1
index eeec7baae57a..83bb8eb229e7 100644
@@ -1,4 +1,4 @@
-#! /bin/sh
+#!/bin/sh
 # collate and present sysfs information about AoE storage
 #
 # A more complete version of this script is aoe-stat, in the

--
2.49.1

#6 lore raw

PATCH 6/11 Shebang line was missing,fixed

In reply to Bhaskar Chowdhury

Added the shebang line at the top of file.

---
 samples/pktgen/functions.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
samples/pktgen/functions.sh +1 -1
index c08cefb8eb1f..2578e97e46ff 100644
@@ -1,4 +1,4 @@
-#
+#!/bin/sh
 # Common functions used by pktgen scripts
 #  - Depending on bash 3 (or higher) syntax
 #

--
2.49.1

#7 lore raw

PATCH 7/11 Shebang line was missing,fixed

In reply to Bhaskar Chowdhury

Added the shebang line at the top of file.

---
 samples/pktgen/parameters.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
samples/pktgen/parameters.sh +1 -1
index 81906f199454..419001ddf387 100644
@@ -1,4 +1,4 @@
-#
+#!/bin/sh
 # SPDX-License-Identifier: GPL-2.0
 # Common parameter parsing for pktgen scripts
 #

--
2.49.1

#8 lore raw

PATCH 8/11 Shebang line was missing,fixed

In reply to Bhaskar Chowdhury

Added the shebang line at the top of file.

---
 tools/bootconfig/scripts/ftrace.sh | 1 +
 1 file changed, 1 insertion(+)
tools/bootconfig/scripts/ftrace.sh +1 -0
index 186eed923041..cc5250c64699 100644
@@ -1,3 +1,4 @@
+#!/bin/sh
 # SPDX-License-Identifier: GPL-2.0-only
 
 clear_trace() { # reset trace output

--
2.49.1

#9 lore raw

PATCH 9/11 Shebang line was missing,fixed

In reply to Bhaskar Chowdhury

Added the shebang line at the top of file.

---
 tools/perf/tests/shell/common/init.sh | 1 +
 1 file changed, 1 insertion(+)
tools/perf/tests/shell/common/init.sh +1 -0
index 26c7525651e0..9e9d4247ada3 100644
@@ -1,3 +1,4 @@
+#!/bin/sh
 # SPDX-License-Identifier: GPL-2.0
 #
 #	init.sh

--
2.49.1

#10 lore raw

PATCH 10/11 Shebang line was missing,fixed

In reply to Bhaskar Chowdhury

Added the shebang line at the top of file.

---
 tools/perf/tests/shell/common/patterns.sh | 1 +
 1 file changed, 1 insertion(+)
tools/perf/tests/shell/common/patterns.sh +1 -0
index 21dab25c7b7f..807c1bc7bb52 100644
@@ -1,3 +1,4 @@
+#!/bin/sh
 # SPDX-License-Identifier: GPL-2.0
 
 export RE_NUMBER="[0-9\.]+"

--
2.49.1

#11 lore raw

PATCH 11/11 Shebang line was missing,fixed

In reply to Bhaskar Chowdhury

Added the shebang line at the top of file.

---
 .../selftests/drivers/net/mlxsw/spectrum-2/mirror_gre_scale.sh   | 1 +
 1 file changed, 1 insertion(+)
tools/testing/selftests/drivers/net/mlxsw/spectrum-2/mirror_gre_scale.sh +1 -0
index f7c168decd1e..abe3835ded4d 100644
@@ -1,3 +1,4 @@
+#!/bin/sh
 # SPDX-License-Identifier: GPL-2.0
 source ../mirror_gre_scale.sh
 

--
2.49.1

#12 lore raw
In reply to Bhaskar Chowdhury
Quoted 4 lines · Bhaskar Chowdhury

This is a human being with flesh and blood.

Shell script files were missing the "shebang" line aka shell interpreter.

Quoted 8 lines

Note to Randy,

This is for your spare time Eagle Eye stuff, if you could...please.

Oh, I might have inadvertantly added some harmless blank lines too.

Bhaskar Chowdhury (11):
Shebang line was missing,fixed

There's also a missing space before ",fixed" in all of the commit descriptions. Perhaps you could fix this when you send a v2?

- Ted

maintainer
#13 lore raw
In reply to Bhaskar Chowdhury
Quoted 10 lines · Bhaskar Chowdhury

This is a human being with flesh and blood.

Shell script files were missing the "shebang" line aka shell interpreter.

Note to Randy,

This is for your spare time Eagle Eye stuff, if you could...please.

Oh, I might have inadvertantly added some harmless blank lines too.

Quoted 12 lines

Bhaskar Chowdhury (11):
Shebang line was missing,fixed
Shebang line was missing,fixed
Shebang line was missing,fixed
Shebang line was missing,fixed
There was a space between bang and shell path,fixed Shebang line was missing,fixed
Shebang line was missing,fixed
Shebang line was missing,fixed
Shebang line was missing,fixed
Shebang line was missing,fixed
Shebang line was missing,fixed

A bunch of patches with the same subject line and changelog isn't going to help anybody looking at these changes later on. Please, for each one, come up with a proper, subsystem-specific subject line and describe the actual work (which file you changed) in the changelog.

Thanks,

jon