Add MAX14001/MAX14002 support

Add device-tree documentation for MAX14001/MAX14002 ADCs. The MAX14001/MAX14002 are isolated, single-channel analog-to-digital converters with programmable voltage comparators and inrush current control optimized for configurable binary input applications.

Co-developed-by Marilene Andrade Garcia <[email protected]>

Signed-off-by Marilene Andrade Garcia <[email protected]>

Signed-off-by Kim Seer Paller <[email protected]>

---
 .../bindings/iio/adc/adi,max14001.yaml        | 79 +++++++++++++++++++
 MAINTAINERS                                   |  8 ++
 2 files changed, 87 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,max14001.yaml

Documentation/devicetree/bindings/iio/adc/adi,max14001.yaml new file +33 -0

new file mode 100644
index 000000000000..ff9a41f04300
@@ -0,0 +1,79 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+# Copyright 2023-2025 Analog Devices Inc.
+# Copyright 2023 Kim Seer Paller
+# Copyright 2025 Marilene Andrade Garcia
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/adc/adi,max14001.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Analog Devices MAX14001-MAX14002 ADC
+
+maintainers:
+  - Kim Seer Paller <[email protected]>
+  - Marilene Andrade Garcia <[email protected]>
+
+description: |
+    Single channel 10 bit ADC with SPI interface.
+    Datasheet can be found here
+      https://www.analog.com/media/en/technical-documentation/data-sheets/MAX14001-MAX14002.pdf
+
+$ref: /schemas/spi/spi-peripheral-props.yaml#
+
+properties:
+  compatible:
+    enum:
+      - adi,max14001
+      - adi,max14002
+
+  reg:
+    maxItems: 1
+
+  spi-max-frequency:
+    maximum: 5000000

Documentation/devicetree/bindings/iio/adc/adi,max14001.yaml new file +6 -0

+required:
+  - compatible
+  - reg
+  - vdd-supply
+  - vddl-supply
+

Quoted 4 lines · Marilene Andrade Garcia

Add device-tree documentation for MAX14001/MAX14002 ADCs. The MAX14001/MAX14002 are isolated, single-channel analog-to-digital converters with programmable voltage comparators and inrush current control optimized for configurable binary input applications.

When there are multiple devices, DT maintainers like to know what is the difference between the devices.

Quoted 4 lines

Co-developed-by Marilene Andrade Garcia <[email protected]>

Signed-off-by Marilene Andrade Garcia <[email protected]>

Signed-off-by Kim Seer Paller <[email protected]>

Sine the patch is From: M.A.G., according to [1], this should be:

Co-developed-by K.S.P.

Signed-off-by K.S.P.

Signed-off-by M.A.G.

(hopefully obvious, but don't use the abbreviations - I just did that for brevity)

[1]: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by

Quoted 31 lines

---
 .../bindings/iio/adc/adi,max14001.yaml        | 79 +++++++++++++++++++
 MAINTAINERS                                   |  8 ++
 2 files changed, 87 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,max14001.yaml

Documentation/devicetree/bindings/iio/adc/adi,max14001.yaml new file +19 -0

new file mode 100644
index 000000000000..ff9a41f04300
@@ -0,0 +1,79 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+# Copyright 2023-2025 Analog Devices Inc.
+# Copyright 2023 Kim Seer Paller
+# Copyright 2025 Marilene Andrade Garcia
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/adc/adi,max14001.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Analog Devices MAX14001-MAX14002 ADC
+
+maintainers:
+  - Kim Seer Paller <[email protected]>
+  - Marilene Andrade Garcia <[email protected]>
+
+description: |
+    Single channel 10 bit ADC with SPI interface.
+    Datasheet can be found here
+      https://www.analog.com/media/en/technical-documentation/data-sheets/MAX14001-MAX14002.pdf

Documentation/devicetree/bindings/iio/adc/adi,max14001.yaml line 27

Quoted 8 lines

Documentation/devicetree/bindings/iio/adc/adi,max14001.yaml new file +8 -0

+
+$ref: /schemas/spi/spi-peripheral-props.yaml#
+
+properties:
+  compatible:
+    enum:
+      - adi,max14001
+      - adi,max14002

Documentation/devicetree/bindings/iio/adc/adi,max14001.yaml line 33

Quoted 6 lines

Documentation/devicetree/bindings/iio/adc/adi,max14001.yaml new file +6 -0

+
+  reg:
+    maxItems: 1
+
+  spi-max-frequency:
+    maximum: 5000000

Quoted 4 lines · Marilene Andrade Garcia

Add device-tree documentation for MAX14001/MAX14002 ADCs. The MAX14001/MAX14002 are isolated, single-channel analog-to-digital converters with programmable voltage comparators and inrush current control optimized for configurable binary input applications.

When there are multiple devices, DT maintainers like to know what is the difference between the devices.

Quoted 5 lines

Co-developed-by Marilene Andrade Garcia <[email protected]>

Signed-off-by Marilene Andrade Garcia <[email protected]>

Signed-off-by Kim Seer Paller <[email protected]>

Sine the patch is From: M.A.G., according to [1], this should be:

Co-developed-by K.S.P.

Signed-off-by K.S.P.

Signed-off-by M.A.G.

(hopefully obvious, but don't use the abbreviations - I just did that for brevity)

[1]: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by

Quoted 45 lines

---
 .../bindings/iio/adc/adi,max14001.yaml        | 79 +++++++++++++++++++
 MAINTAINERS                                   |  8 ++
 2 files changed, 87 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,max14001.yaml

Documentation/devicetree/bindings/iio/adc/adi,max14001.yaml new file +33 -0

new file mode 100644
index 000000000000..ff9a41f04300
@@ -0,0 +1,79 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+# Copyright 2023-2025 Analog Devices Inc.
+# Copyright 2023 Kim Seer Paller
+# Copyright 2025 Marilene Andrade Garcia
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/adc/adi,max14001.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Analog Devices MAX14001-MAX14002 ADC
+
+maintainers:
+  - Kim Seer Paller <[email protected]>
+  - Marilene Andrade Garcia <[email protected]>
+
+description: |
+    Single channel 10 bit ADC with SPI interface.
+    Datasheet can be found here
+      https://www.analog.com/media/en/technical-documentation/data-sheets/MAX14001-MAX14002.pdf
+
+$ref: /schemas/spi/spi-peripheral-props.yaml#
+
+properties:
+  compatible:
+    enum:
+      - adi,max14001
+      - adi,max14002
+
+  reg:
+    maxItems: 1
+
+  spi-max-frequency:
+    maximum: 5000000

Documentation/devicetree/bindings/iio/adc/adi,max14001.yaml line 43

Quoted 10 lines

Documentation/devicetree/bindings/iio/adc/adi,max14001.yaml new file +10 -0

+
+  vdd-supply:
+    description:
+      Isolated DC-DC power supply input voltage.
+
+  vddl-supply:
+    description:
+      Logic power supply.
+
+  vrefin-supply:

The actual pin name is REFIN, so refin-supply would make more sense.

Documentation/devicetree/bindings/iio/adc/adi,max14001.yaml line 47

Quoted 4 lines

Documentation/devicetree/bindings/iio/adc/adi,max14001.yaml new file +4 -0

+    description:
+      ADC voltage reference supply.
+
+  interrupts:

Likely needs minItems: 1 in case only one interrupt is wired.

Documentation/devicetree/bindings/iio/adc/adi,max14001.yaml line 52

Quoted 5 lines

Documentation/devicetree/bindings/iio/adc/adi,max14001.yaml new file +5 -0

+    items:
+      - description: |
+          Interrupt for signaling when conversion results exceed the configured
+          upper threshold for ADC readings or fall below the lower threshold for
+          them. Interrupt source must be attached to COUT pin.

We could shorten these descriptions. The important part is which pin it is connected to.

Documentation/devicetree/bindings/iio/adc/adi,max14001.yaml line 56

Quoted 4 lines

Documentation/devicetree/bindings/iio/adc/adi,max14001.yaml new file +4 -0

+      - description: |
+          Alert output that asserts low during a number of different error
+          conditions. The interrupt source must be attached to FAULT pin.
+

And also interrupt-names: makes sense so we know which one is is wired if only one is given.

Quoted 7 lines

Documentation/devicetree/bindings/iio/adc/adi,max14001.yaml new file +6 -0

+required:
+  - compatible
+  - reg
+  - vdd-supply
+  - vddl-supply
+

The MAX14001/MAX14002 is configurable, isolated 10-bit ADCs for multi-range binary inputs. In addition to ADC readings, the MAX14001/MAX14002 offers more features, like a binary comparator, a filtered reading that can provide the average of the last 2, 4, or 8 ADC readings, and an inrush comparator that triggers the inrush current. There is also a fault feature that can diagnose seven possible fault conditions. And an option to select an external or internal ADC voltage reference.

MAX14001/MAX14002 features implemented so far:
- Raw ADC reading.
- Filtered ADC average reading with the default configuration.
- MV fault disable.
- Selection of external or internal ADC voltage reference, depending on whether it is declared in the device tree.

+#include <linux/kernel.h>

+#define MAX14001_WRITE_WEN 0x294

drivers/iio/adc/max14001.c new file +10 -0

+	/*
+	 * The following buffers will be bit-reversed during device
+	 * communication, because the device transmits and receives data
+	 * LSB-first.
+	 * DMA (thus cache coherency maintenance) requires the transfer
+	 * buffers to live in their own cache lines.
+	 */
+	__be16 spi_tx_buffer __aligned(IIO_DMA_MINALIGN);
+	__be16 spi_rx_buffer;
+};

drivers/iio/adc/max14001.c new file +11 -0

+static int max14001_read(struct max14001_state *st, u16 reg_addr, u16 *reg_data)
+{
+	struct spi_transfer xfers[] = {
+		{
+			.tx_buf = &st->spi_tx_buffer,
+			.len = sizeof(st->spi_tx_buffer),
+			.cs_change = 1,
+		}, {
+			.rx_buf = &st->spi_rx_buffer,
+			.len = sizeof(st->spi_rx_buffer),
+		},

drivers/iio/adc/max14001.c new file +13 -0

+	ret = spi_sync_transfer(st->spi, xfers, ARRAY_SIZE(xfers));
+	if (ret)
+		return ret;
+
+	/*
+	 * Convert received 16-bit value from big-endian to cpu-endian format
+	 * and reverses bit order.
+	 */
+	st->spi_rx_buffer = bitrev16(be16_to_cpu(st->spi_rx_buffer));
+	*reg_data = FIELD_GET(MAX14001_MASK_DATA, st->spi_rx_buffer);
+
+	return 0;
+}

(quoted diff) +2 -0

+	return spi_write(st->spi, &st->spi_tx_buffer, sizeof(st->spi_tx_buffer));
+}

drivers/iio/adc/max14001.c new file +11 -0

+static int max14001_write_single_reg(struct max14001_state *st, u16 reg_addr,
+				     u16 reg_data)
+{
+	int ret;
+
+	/* Enable register write */
+	ret = max14001_write(st, MAX14001_REG_WEN, MAX14001_WRITE_WEN);
+	if (ret)
+		return ret;
+
+	/* Write data into register */

+}

drivers/iio/adc/max14001.c new file +15 -0

+		if (ret)
+			return ret;
+
+		*val = reg_data;
+
+		return IIO_VAL_INT;
+	case IIO_CHAN_INFO_SCALE:
+		*val = st->vref_mv;
+		*val2 = 10;
+
+		return IIO_VAL_FRACTIONAL_LOG2;
+	default:
+		return -EINVAL;
+	}
+}

+};

drivers/iio/adc/max14001.c new file +20 -0

+	int ret;
+
+	/* Enable SPI Registers Write */
+	ret = max14001_write(st, MAX14001_REG_WEN, MAX14001_WRITE_WEN);
+	if (ret)
+		return ret;
+
+	/*
+	 * Reads all registers and writes the values back to their appropriate
+	 * verification registers to clear the Memory Validation fault.
+	 */
+	for (reg_addr = MAX14001_REG_FLTEN; reg_addr <= MAX14001_REG_ENBL; reg_addr++) {
+		ret = max14001_write_verification_reg(st, reg_addr);
+		if (ret)
+			return ret;
+	}
+
+	/* Disable SPI Registers Write */
+	return max14001_write(st, MAX14001_REG_WEN, 0);
+}

drivers/iio/adc/max14001.c new file +19 -0

+	indio_dev = devm_iio_device_alloc(dev, sizeof(*st));
+	if (!indio_dev)
+		return -ENOMEM;
+
+	st = iio_priv(indio_dev);
+	st->spi = spi;
+	st->chip_info = spi_get_device_match_data(spi);
+	if (!st->chip_info)
+		return dev_err_probe(dev, -ENODEV, "Failed to get match data\n");
+
+	indio_dev->name = st->chip_info->name;
+	indio_dev->info = &max14001_info;
+	indio_dev->channels = max14001_channel;
+	indio_dev->num_channels = ARRAY_SIZE(max14001_channel);
+	indio_dev->modes = INDIO_DIRECT_MODE;
+
+	ret = devm_regulator_get_enable(dev, "vdd");
+	if (ret)
+		return dev_err_probe(dev, ret,

drivers/iio/adc/max14001.c new file +2 -0

+	return devm_iio_device_register(dev, indio_dev);
+}

+};

drivers/iio/adc/max14001.c line 291

Quoted 3 lines

drivers/iio/adc/max14001.c new file +3 -0

+	ret = devm_regulator_get_enable_read_voltage(dev, "vrefin");
+	if (ret < 0) {
+		st->vref_mv = 1250000 / 1000;

(MICRO / MILLI)

drivers/iio/adc/max14001.c line 293

Quoted 2 lines

drivers/iio/adc/max14001.c new file +2 -0

+	} else {
+		st->vref_mv = ret / 1000;

Ditto.

Review

Quoted 2 lines

(quoted diff) +2 -0

+		ext_vrefin = 1;
+	}

And with deduplication refactored code:

	ret = devm_regulator_get_enable_read_voltage(dev, "vrefin");

	if (ret < 0)
		ret = 1250000;
	else
		ext_vrefin = 1;
	st->vref_mv = ret / (MICRO / MILLI);

Quoted 4 lines

drivers/iio/adc/max14001.c new file +4 -0

+	ret = devm_mutex_init(dev, &st->lock);
+	if (ret)
+		return dev_err_probe(dev, ret,
+			"Failed to init the mutex\n");

On 9/2/25 8:45 AM, Andy Shevchenko wrote:

Quoted 16 lines

drivers/iio/adc/max14001.c line 291

Quoted 3 lines

drivers/iio/adc/max14001.c new file +3 -0

+	ret = devm_regulator_get_enable_read_voltage(dev, "vrefin");
+	if (ret < 0) {
+		st->vref_mv = 1250000 / 1000;

(MICRO / MILLI)

drivers/iio/adc/max14001.c line 293

Quoted 2 lines

drivers/iio/adc/max14001.c new file +2 -0

+	} else {
+		st->vref_mv = ret / 1000;

Ditto.

Review

Quoted 2 lines

(quoted diff) +2 -0

+		ext_vrefin = 1;
+	}

And with deduplication refactored code:

Quoted 1 line

	ret = devm_regulator_get_enable_read_voltage(dev, "vrefin");

	if (ret < 0 && ret != -ENODEV)
		return dev_err_probe(dev, ret, "Failed to get REFIN voltage\n");

Most errors should be propagated, so we should also add this. Only -ENODEV means that the supply was omitted from the devicetree and we should use the internal reference voltage.

Quoted 5 lines

	if (ret < 0)
		ret = 1250000;
	else
		ext_vrefin = 1;
	st->vref_mv = ret / (MICRO / MILLI);

The MAX14001/MAX14002 is configurable, isolated 10-bit ADCs for multi-range binary inputs. In addition to ADC readings, the MAX14001/MAX14002 offers more features, like a binary comparator, a filtered reading that can provide the average of the last 2, 4, or 8 ADC readings, and an inrush comparator that triggers the inrush current. There is also a fault feature that can diagnose seven possible fault conditions. And an option to select an external or internal ADC voltage reference.

MAX14001/MAX14002 features implemented so far:
- Raw ADC reading.
- Filtered ADC average reading with the default configuration.
- MV fault disable.
- Selection of external or internal ADC voltage reference, depending on whether it is declared in the device tree.

Co-developed-by Marilene Andrade Garcia <[email protected]>

Signed-off-by Marilene Andrade Garcia <[email protected]>

Signed-off-by Kim Seer Paller <[email protected]>

---
 MAINTAINERS                |   1 +
 drivers/iio/adc/Kconfig    |  10 ++
 drivers/iio/adc/Makefile   |   1 +
 drivers/iio/adc/max14001.c | 355 +++++++++++++++++++++++++++++++++++++
 4 files changed, 367 insertions(+)
 create mode 100644 drivers/iio/adc/max14001.c

MAINTAINERS +1 -0

index f145f0204407..b6457063da6c 100644
@@ -14976,6 +14976,7 @@ L:	[email protected]
 S:	Maintained
 W:	https://ez.analog.com/linux-software-drivers
 F:	Documentation/devicetree/bindings/iio/adc/adi,max14001.yaml
+F:	drivers/iio/adc/max14001.c
 
 MAXBOTIX ULTRASONIC RANGER IIO DRIVER
 M:	Andreas Klinger <[email protected]>

drivers/iio/adc/Kconfig +10 -0

index e3d3826c3357..11e911ceab4c 100644
@@ -958,6 +958,16 @@ config MAX11410
 	  To compile this driver as a module, choose M here: the module will be
 	  called max11410.
 
+config MAX14001
+	tristate "Analog Devices MAX14001/MAX14002 ADC driver"
+	depends on SPI
+	help
+	  Say yes here to build support for Analog Devices MAX14001/MAX14002
+	  Configurable, Isolated 10-bit ADCs for Multi-Range Binary Inputs.
+
+	  To compile this driver as a module, choose M here: the module will be
+	  called max14001.
+
 config MAX1241
 	tristate "Maxim max1241 ADC driver"
 	depends on SPI_MASTER

drivers/iio/adc/Makefile +1 -0

index 89d72bf9ce70..569f2f5613d4 100644
@@ -85,6 +85,7 @@ obj-$(CONFIG_MAX11100) += max11100.o
 obj-$(CONFIG_MAX1118) += max1118.o
 obj-$(CONFIG_MAX11205) += max11205.o
 obj-$(CONFIG_MAX11410) += max11410.o
+obj-$(CONFIG_MAX14001) += max14001.o
 obj-$(CONFIG_MAX1241) += max1241.o
 obj-$(CONFIG_MAX1363) += max1363.o
 obj-$(CONFIG_MAX34408) += max34408.o

drivers/iio/adc/max14001.c new file +63 -0

new file mode 100644
index 000000000000..6755df152976
@@ -0,0 +1,355 @@
+// SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause)
+/*
+ * Analog Devices MAX14001/MAX14002 ADC driver
+ *
+ * Copyright (C) 2023-2025 Analog Devices Inc.
+ * Copyright (C) 2023 Kim Seer Paller <[email protected]>
+ * Copyright (c) 2025 Marilene Andrade Garcia <[email protected]>
+ *
+ * Datasheet: https://www.analog.com/media/en/technical-documentation/data-sheets/MAX14001-MAX14002.pdf
+ */
+
+#include <linux/array_size.h>
+#include <linux/bitfield.h>
+#include <linux/bitrev.h>
+#include <linux/bits.h>
+#include <linux/byteorder/generic.h>
+#include <linux/device.h>
+#include <linux/iio/iio.h>
+#include <linux/iio/types.h>
+#include <linux/kernel.h>
+#include <linux/mod_devicetable.h>
+#include <linux/module.h>
+#include <linux/regulator/consumer.h>
+#include <linux/spi/spi.h>
+#include <linux/types.h>
+
+/* MAX14001 Registers Address */
+#define MAX14001_REG_ADC		0x00
+#define MAX14001_REG_FADC		0x01
+#define MAX14001_REG_FLAGS		0x02
+#define MAX14001_REG_FLTEN		0x03
+#define MAX14001_REG_THL		0x04
+#define MAX14001_REG_THU		0x05
+#define MAX14001_REG_INRR		0x06
+#define MAX14001_REG_INRT		0x07
+#define MAX14001_REG_INRP		0x08
+#define MAX14001_REG_CFG		0x09
+#define MAX14001_REG_ENBL		0x0A
+#define MAX14001_REG_ACT		0x0B
+#define MAX14001_REG_WEN		0x0C
+
+#define MAX14001_REG_VERIFICATION(x)	((x) + 0x10)
+
+#define MAX14001_REG_CFG_EXRF		BIT(5)
+
+#define MAX14001_MASK_ADDR		GENMASK(15, 11)
+#define MAX14001_MASK_DATA		GENMASK(9, 0)
+
+#define MAX14001_SET_WRITE_BIT		BIT(10)
+#define MAX14001_WRITE_WEN		0x294
+
+enum max14001_chip_model {
+	max14001,
+	max14002,
+};
+
+struct max14001_chip_info {
+	const char *name;
+};
+
+struct max14001_state {
+	const struct max14001_chip_info *chip_info;
+	struct spi_device *spi;

drivers/iio/adc/max14001.c new file +9 -0

+	 * DMA (thus cache coherency maintenance) requires the transfer
+	 * buffers to live in their own cache lines.
+	 */
+	__be16 spi_tx_buffer __aligned(IIO_DMA_MINALIGN);
+	__be16 spi_rx_buffer;
+};
+
 
 
 
+static int max14001_probe(struct spi_device *spi)
+{

Hello everyone,

Thank you for your input on how to handle the situation with the driver code. Kim, I also apologize for the unexpected situation involving your previous code.

Based on the suggestions, I applied my v1 code changes to v9 of Kim’s code, resulting in this v10 version that combines both.
Compared to v9, the updates are:

- Added support for max14002.
- Added a function to write a single register, since the write enable register must be updated before writing to any others and updated again afterward.
- Renamed the init function to better reflect its purpose, which is to disable the memory verification fault. I also replaced the one-by-one handling of registers verification values with a loop, since they are in sequential ascending order.
- Replaced the old regulator APIs with the new ones.
- Updated the device tree documentation to align with the datasheet nomenclature for voltage suppliers.
- Used IIO_CHAN_INFO_AVERAGE_RAW to return the filtered average of ADC readings.

One of the reviews I received about my v1 version suggested using a custom regmap. I attempted to implement that, but I feel that most of the default regmap functions (e.g., regmap_update_bits) would need to be overridden

because of the unique way this device handles communication, such as inverting bits before sending a message, updating the write enable register before writing any other register, and updating it again afterward. However, as I am still new to the IIO kernel code, I may be missing something. If you could provide further explanation or an example, I would be grateful.

Regarding locking, Kim’s original code implemented it, and it remains in the driver.

I still have a question about using _mean_raw (IIO_CHAN_INFO_AVERAGE_RAW) to read the register containing the latest filtered average ADC readings. Should I create a v11 version with a patch to include in_voltageY_mean_raw in the file /linux/Documentation/ABI/testing/sysfs-bus-iio?

The idea is to use in_voltageY_mean_raw to return the filtered average and also to set how many ADC readings (0, 2, 4, or 8) are included in the mean calculation. Any feedback on using IIO_CHAN_INFO_AVERAGE_RAW this way would be appreciated.

The v10 changes were tested on a Raspberry Pi 5 using a modified kernel (rpi-6.12). The MAX14001PMB evaluation board, which contains two MAX14001 devices, was used for testing. One device measures current, and the other measures voltage. The evaluation board introduces an offset to allow measuring negative values. These board-specific characteristics were not included in the driver code (neither the offset nor the current channel capability), but they were considered in the calculation of the values read by the devices. Should the code that applies these board configuration parameters be added as an additional driver file inside the IIO subsystem, or should it remain only in a user application?

I plan to continue sending patches to cover all the features of the device. This includes adding interrupt handling for faults and for when the signal exceeds the upper or lower threshold, implementing the inrush current feature, and completing the filtered average reading functionality by adding the ability to set the number of readings used in the mean calculation.

And I would like to thank again my GSoC mentors Marcelo Schmitt, Ceclan Dumitru, Jonathan Santos and Dragos Bogdan for their help with the code.

Thank you for your time,
Best regards,
Marilene Andrade Garcia.

Marilene Andrade Garcia (2):
dt-bindings: iio: adc: add max14001
iio: adc: max14001: New driver

 .../bindings/iio/adc/adi,max14001.yaml        |  79 ++++
 MAINTAINERS                                   |   9 +
 drivers/iio/adc/Kconfig                       |  10 +
 drivers/iio/adc/Makefile                      |   1 +
 drivers/iio/adc/max14001.c                    | 355 ++++++++++++++++++
 5 files changed, 454 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,max14001.yaml
 create mode 100644 drivers/iio/adc/max14001.c

base-commit: d1487b0b78720b86ec2a2ac7acc683ec90627e5b

Quoted 11 lines

because of the unique way this device handles communication, such as inverting bits before sending a message, updating the write enable register before writing any other register, and updating it again afterward. However, as I am still new to the IIO kernel code, I may be missing something. If you could provide further explanation or an example, I would be grateful.

Regarding locking, Kim’s original code implemented it, and it remains in the driver.

Quoted 4 lines

I still have a question about using _mean_raw (IIO_CHAN_INFO_AVERAGE_RAW) to read the register containing the latest filtered average ADC readings. Should I create a v11 version with a patch to include in_voltageY_mean_raw in the file /linux/Documentation/ABI/testing/sysfs-bus-iio?

There is already "/sys/bus/iio/devices/iio:deviceX/in_Y_mean_raw" which I think is intended to cover that.

Quoted 2 lines

The idea is to use in_voltageY_mean_raw to return the filtered average and also to set how many ADC readings (0, 2, 4, or 8) are included in the mean

Quoted 2 lines

calculation. Any feedback on using IIO_CHAN_INFO_AVERAGE_RAW this way would be appreciated.

Quoted 1 line