Support ROHM BD72720 PMIC

From: Matti Vaittinen <[email protected]>

The BD71828 power-supply driver assumes register addresses to be 8-bit. The new BD72720 will use stacked register maps to hide paging which is done using secondary I2C slave address. This requires use of 9-bit register addresses in the power-supply driver (added offset 0x100 to the 8-bit hardware register addresses).

The cost is slightly used memory consumption as the members in the struct pwr_regs will be changed from u8 to unsigned int, which means 3 byte increase / member / instance.
This is currently 14 members (expected to possibly be increased when adding new variants / new functionality which may introduce new registers, but not expected to grow much) and 2 instances (will be 3 instances when BD72720 gets added).

So, even if the number of registers grew to 50 it'd be 150 bytes / instance. Assuming we eventually supported 5 variants, it'd be 5 * 150 bytes, which stays very reasonable considering systems we are dealing with.

As a side note, we can reduce the "wasted space / member / instance" from 3 bytes to 1 byte, by using u16 instead of the unsigned int if needed. I rather use unsigned int to be initially prepared for devices with 32 bit registers if there is no need to count bytes.

Signed-off-by Matti Vaittinen <[email protected]>

---

Revision history:
v2 => :
- No changes

RFCv1 => v2:
- New patch

---
 drivers/power/supply/bd71828-power.c | 26 +++++++++++++-------------
 1 file changed, 13 insertions(+), 13 deletions(-)

drivers/power/supply/bd71828-power.c +13 -13

index f667baedeb77..ce73c0f48397 100644
@@ -44,19 +44,19 @@
 #define VBAT_LOW_TH			0x00D4
 
 struct pwr_regs {
-	u8 vbat_avg;
-	u8 ibat;
-	u8 ibat_avg;
-	u8 btemp_vth;
-	u8 chg_state;
-	u8 bat_temp;
-	u8 dcin_stat;
-	u8 dcin_collapse_limit;
-	u8 chg_set1;
-	u8 chg_en;
-	u8 vbat_alm_limit_u;
-	u8 conf;
-	u8 vdcin;
+	unsigned int vbat_avg;
+	unsigned int ibat;
+	unsigned int ibat_avg;
+	unsigned int btemp_vth;
+	unsigned int chg_state;
+	unsigned int bat_temp;
+	unsigned int dcin_stat;
+	unsigned int dcin_collapse_limit;
+	unsigned int chg_set1;
+	unsigned int chg_en;
+	unsigned int vbat_alm_limit_u;
+	unsigned int conf;
+	unsigned int vdcin;
 };
 
 static const struct pwr_regs pwr_regs_bd71828 = {

Signature · 1 line

2.52.0

From: Matti Vaittinen <[email protected]>

The ROHM BD72720 is a power management IC with a charger and coulomb counter block which is closely related to the charger / coulomb counter found from the BD71815, BD71828, BD71879 which are all supported by the bd71828-power driver. Due to the similarities it makes sense to support also the BD72720 with the same driver.

Add basic support for the charger logic on ROHM BD72720.

Signed-off-by Matti Vaittinen <[email protected]>

---
Revision history:
v2 => :
- No changes

RFCv1 => v2:
- Support using 9-bit register addresses (offset of 0x100) with the BD72720
- Simplify probe and IC data as we don't need two regmaps
- Drop two BD72720 specific functions as we no longer need different regmap for it.

Note: This patch depends on the series: "power: supply: add charger for BD71828" by Andreas:
https://lore.kernel.org/all/[email protected]/

NOTE: Fuel-gauging is not supported. You can find an unmaintained downstream reference-driver with a fuel-gauge example from:
https://github.com/RohmSemiconductor/Linux-Kernel-PMIC-Drivers/releases/tag/bd72720-reference-driver-v1

---
 drivers/power/supply/bd71828-power.c | 134 +++++++++++++++++++++++----
 1 file changed, 116 insertions(+), 18 deletions(-)

drivers/power/supply/bd71828-power.c +98 -18

index ce73c0f48397..438e220a9cb7 100644
@@ -5,6 +5,7 @@
 #include <linux/kernel.h>
 #include <linux/mfd/rohm-bd71815.h>
 #include <linux/mfd/rohm-bd71828.h>
+#include <linux/mfd/rohm-bd72720.h>
 #include <linux/module.h>
 #include <linux/mod_devicetable.h>
 #include <linux/platform_device.h>

@@ -51,12 +52,14 @@ struct pwr_regs {
 	unsigned int chg_state;
 	unsigned int bat_temp;
 	unsigned int dcin_stat;
+	unsigned int dcin_online_mask;
 	unsigned int dcin_collapse_limit;
 	unsigned int chg_set1;
 	unsigned int chg_en;
 	unsigned int vbat_alm_limit_u;
 	unsigned int conf;
 	unsigned int vdcin;
+	unsigned int vdcin_himask;
 };
 
 static const struct pwr_regs pwr_regs_bd71828 = {

@@ -67,12 +70,14 @@ static const struct pwr_regs pwr_regs_bd71828 = {
 	.chg_state = BD71828_REG_CHG_STATE,
 	.bat_temp = BD71828_REG_BAT_TEMP,
 	.dcin_stat = BD71828_REG_DCIN_STAT,
+	.dcin_online_mask = BD7182x_MASK_DCIN_DET,
 	.dcin_collapse_limit = BD71828_REG_DCIN_CLPS,
 	.chg_set1 = BD71828_REG_CHG_SET1,
 	.chg_en   = BD71828_REG_CHG_EN,
 	.vbat_alm_limit_u = BD71828_REG_ALM_VBAT_LIMIT_U,
 	.conf = BD71828_REG_CONF,
 	.vdcin = BD71828_REG_VDCIN_U,
+	.vdcin_himask = BD7182x_MASK_VDCIN_U,
 };
 
 static const struct pwr_regs pwr_regs_bd71815 = {

@@ -85,6 +90,7 @@ static const struct pwr_regs pwr_regs_bd71815 = {
 	.chg_state = BD71815_REG_CHG_STATE,
 	.bat_temp = BD71815_REG_BAT_TEMP,
 	.dcin_stat = BD71815_REG_DCIN_STAT,
+	.dcin_online_mask = BD7182x_MASK_DCIN_DET,
 	.dcin_collapse_limit = BD71815_REG_DCIN_CLPS,
 	.chg_set1 = BD71815_REG_CHG_SET1,
 	.chg_en   = BD71815_REG_CHG_SET1,

@@ -92,6 +98,31 @@ static const struct pwr_regs pwr_regs_bd71815 = {
 	.conf = BD71815_REG_CONF,
 
 	.vdcin = BD71815_REG_VM_DCIN_U,
+	.vdcin_himask = BD7182x_MASK_VDCIN_U,
+};
+
+static struct pwr_regs pwr_regs_bd72720 = {
+	.vbat_avg = BD72720_REG_VM_SA_VBAT_U,
+	.ibat = BD72720_REG_CC_CURCD_U,
+	.ibat_avg = BD72720_REG_CC_SA_CURCD_U,
+	.btemp_vth = BD72720_REG_VM_BTMP_U,
+	/*
+	 * Note, state 0x40 IMP_CHK. not documented
+	 * on other variants but was still handled in
+	 * existing code. No memory traces as to why.
+	 */
+	.chg_state = BD72720_REG_CHG_STATE,
+	.bat_temp = BD72720_REG_CHG_BAT_TEMP_STAT,
+	.dcin_stat = BD72720_REG_INT_VBUS_SRC,
+	.dcin_online_mask = BD72720_MASK_DCIN_DET,
+	.dcin_collapse_limit = -1, /* Automatic. Setting not supported */
+	.chg_set1 = BD72720_REG_CHG_SET_1,
+	.chg_en = BD72720_REG_CHG_EN,
+	/* 15mV note in data-sheet */
+	.vbat_alm_limit_u = BD72720_REG_ALM_VBAT_TH_U,
+	.conf = BD72720_REG_CONF, /* o XSTB, only PON. Seprate slave addr */
+	.vdcin = BD72720_REG_VM_VBUS_U, /* 10 bits not 11 as with other ICs */
+	.vdcin_himask = BD72720_MASK_VDCIN_U,
 };
 
 struct bd71828_power {

@@ -298,7 +329,7 @@ static int get_chg_online(struct bd71828_power *pwr, int *chg_online)
 		dev_err(pwr->dev, "Failed to read DCIN status\n");
 		return ret;
 	}
-	*chg_online = ((r & BD7182x_MASK_DCIN_DET) != 0);
+	*chg_online = ((r & pwr->regs->dcin_online_mask) != 0);
 
 	return 0;
 }

@@ -329,8 +360,8 @@ static int bd71828_bat_inserted(struct bd71828_power *pwr)
 	ret = val & BD7182x_MASK_CONF_PON;
 
 	if (ret)
-		regmap_update_bits(pwr->regmap, pwr->regs->conf,
-				   BD7182x_MASK_CONF_PON, 0);
+		if (regmap_update_bits(pwr->regmap, pwr->regs->conf, BD7182x_MASK_CONF_PON, 0))
+			dev_err(pwr->dev, "Failed to write CONF register\n");
 
 	return ret;
 }

@@ -358,11 +389,13 @@ static int bd71828_init_hardware(struct bd71828_power *pwr)
 	int ret;
 
 	/* TODO: Collapse limit should come from device-tree ? */
-	ret = regmap_write(pwr->regmap, pwr->regs->dcin_collapse_limit,
-			   BD7182x_DCIN_COLLAPSE_DEFAULT);
-	if (ret) {
-		dev_err(pwr->dev, "Failed to write DCIN collapse limit\n");
-		return ret;
+	if (pwr->regs->dcin_collapse_limit != (unsigned int)-1) {
+		ret = regmap_write(pwr->regmap, pwr->regs->dcin_collapse_limit,
+				   BD7182x_DCIN_COLLAPSE_DEFAULT);
+		if (ret) {
+			dev_err(pwr->dev, "Failed to write DCIN collapse limit\n");
+			return ret;
+		}
 	}
 
 	ret = pwr->bat_inserted(pwr);

@@ -419,7 +452,7 @@ static int bd71828_charger_get_property(struct power_supply *psy,
 		break;
 	case POWER_SUPPLY_PROP_VOLTAGE_NOW:
 		ret = bd7182x_read16_himask(pwr, pwr->regs->vdcin,
-					    BD7182x_MASK_VDCIN_U, &tmp);
+					    pwr->regs->vdcin_himask, &tmp);
 		if (ret)
 			return ret;
 

@@ -630,6 +663,9 @@ BD_ISR_AC(dcin_ovp_det, "DCIN OVER VOLTAGE", true)
 BD_ISR_DUMMY(dcin_mon_det, "DCIN voltage below threshold")
 BD_ISR_DUMMY(dcin_mon_res, "DCIN voltage above threshold")
 
+BD_ISR_DUMMY(vbus_curr_limit, "VBUS current limited")
+BD_ISR_DUMMY(vsys_ov_res, "VSYS over-voltage cleared")
+BD_ISR_DUMMY(vsys_ov_det, "VSYS over-voltage")
 BD_ISR_DUMMY(vsys_uv_res, "VSYS under-voltage cleared")
 BD_ISR_DUMMY(vsys_uv_det, "VSYS under-voltage")
 BD_ISR_DUMMY(vsys_low_res, "'VSYS low' cleared")

@@ -878,6 +914,51 @@ static int bd7182x_get_irqs(struct platform_device *pdev,
 		BDIRQ("bd71828-temp-125-over", bd71828_temp_vf125_det),
 		BDIRQ("bd71828-temp-125-under", bd71828_temp_vf125_res),
 	};
+	static const struct bd7182x_irq_res bd72720_irqs[] = {
+		BDIRQ("bd72720_int_vbus_rmv", BD_ISR_NAME(dcin_removed)),
+		BDIRQ("bd72720_int_vbus_det", bd7182x_dcin_detected),
+		BDIRQ("bd72720_int_vbus_mon_res", BD_ISR_NAME(dcin_mon_res)),
+		BDIRQ("bd72720_int_vbus_mon_det", BD_ISR_NAME(dcin_mon_det)),
+		BDIRQ("bd72720_int_vsys_mon_res", BD_ISR_NAME(vsys_mon_res)),
+		BDIRQ("bd72720_int_vsys_mon_det", BD_ISR_NAME(vsys_mon_det)),
+		BDIRQ("bd72720_int_vsys_uv_res", BD_ISR_NAME(vsys_uv_res)),
+		BDIRQ("bd72720_int_vsys_uv_det", BD_ISR_NAME(vsys_uv_det)),
+		BDIRQ("bd72720_int_vsys_lo_res", BD_ISR_NAME(vsys_low_res)),
+		BDIRQ("bd72720_int_vsys_lo_det", BD_ISR_NAME(vsys_low_det)),
+		BDIRQ("bd72720_int_vsys_ov_res", BD_ISR_NAME(vsys_ov_res)),
+		BDIRQ("bd72720_int_vsys_ov_det", BD_ISR_NAME(vsys_ov_det)),
+		BDIRQ("bd72720_int_bat_ilim", BD_ISR_NAME(vbus_curr_limit)),
+		BDIRQ("bd72720_int_chg_done", bd718x7_chg_done),
+		BDIRQ("bd72720_int_extemp_tout", BD_ISR_NAME(chg_wdg_temp)),
+		BDIRQ("bd72720_int_chg_wdt_exp", BD_ISR_NAME(chg_wdg)),
+		BDIRQ("bd72720_int_bat_mnt_out", BD_ISR_NAME(rechg_res)),
+		BDIRQ("bd72720_int_bat_mnt_in", BD_ISR_NAME(rechg_det)),
+		BDIRQ("bd72720_int_chg_trns", BD_ISR_NAME(chg_state_changed)),
+
+		BDIRQ("bd72720_int_vbat_mon_res", BD_ISR_NAME(bat_mon_res)),
+		BDIRQ("bd72720_int_vbat_mon_det", BD_ISR_NAME(bat_mon)),
+		BDIRQ("bd72720_int_vbat_sht_res", BD_ISR_NAME(bat_short_res)),
+		BDIRQ("bd72720_int_vbat_sht_det", BD_ISR_NAME(bat_short)),
+		BDIRQ("bd72720_int_vbat_lo_res", BD_ISR_NAME(bat_low_res)),
+		BDIRQ("bd72720_int_vbat_lo_det", BD_ISR_NAME(bat_low)),
+		BDIRQ("bd72720_int_vbat_ov_res", BD_ISR_NAME(bat_ov_res)),
+		BDIRQ("bd72720_int_vbat_ov_det", BD_ISR_NAME(bat_ov)),
+		BDIRQ("bd72720_int_bat_rmv", BD_ISR_NAME(bat_removed)),
+		BDIRQ("bd72720_int_bat_det", BD_ISR_NAME(bat_det)),
+		BDIRQ("bd72720_int_dbat_det", BD_ISR_NAME(bat_dead)),
+		BDIRQ("bd72720_int_bat_temp_trns", BD_ISR_NAME(temp_transit)),
+		BDIRQ("bd72720_int_lobtmp_res", BD_ISR_NAME(temp_bat_low_res)),
+		BDIRQ("bd72720_int_lobtmp_det", BD_ISR_NAME(temp_bat_low)),
+		BDIRQ("bd72720_int_ovbtmp_res", BD_ISR_NAME(temp_bat_hi_res)),
+		BDIRQ("bd72720_int_ovbtmp_det", BD_ISR_NAME(temp_bat_hi)),
+		BDIRQ("bd72720_int_ocur1_res", BD_ISR_NAME(bat_oc1_res)),
+		BDIRQ("bd72720_int_ocur1_det", BD_ISR_NAME(bat_oc1)),
+		BDIRQ("bd72720_int_ocur2_res", BD_ISR_NAME(bat_oc2_res)),
+		BDIRQ("bd72720_int_ocur2_det", BD_ISR_NAME(bat_oc2)),
+		BDIRQ("bd72720_int_ocur3_res", BD_ISR_NAME(bat_oc3_res)),
+		BDIRQ("bd72720_int_ocur3_det", BD_ISR_NAME(bat_oc3)),
+		BDIRQ("bd72720_int_cc_mon2_det", BD_ISR_NAME(bat_cc_mon)),
+	};
 	int num_irqs;
 	const struct bd7182x_irq_res *irqs;
 

@@ -890,6 +971,10 @@ static int bd7182x_get_irqs(struct platform_device *pdev,
 		irqs = &bd71815_irqs[0];
 		num_irqs = ARRAY_SIZE(bd71815_irqs);
 		break;
+	case ROHM_CHIP_TYPE_BD72720:
+		irqs = &bd72720_irqs[0];
+		num_irqs = ARRAY_SIZE(bd72720_irqs);
+		break;
 	default:
 		return -EINVAL;
 	}

@@ -958,21 +1043,27 @@ static int bd71828_power_probe(struct platform_device *pdev)
 	struct power_supply_config ac_cfg = {};
 	struct power_supply_config bat_cfg = {};
 	int ret;
-	struct regmap *regmap;
-
-	regmap = dev_get_regmap(pdev->dev.parent, NULL);
-	if (!regmap) {
-		dev_err(&pdev->dev, "No parent regmap\n");
-		return -EINVAL;
-	}
 
 	pwr = devm_kzalloc(&pdev->dev, sizeof(*pwr), GFP_KERNEL);
 	if (!pwr)
 		return -ENOMEM;
 
-	pwr->regmap = regmap;
-	pwr->dev = &pdev->dev;
+	/*
+	 * The BD72720 MFD device registers two regmaps. Power-supply driver
+	 * uses the "wrap-map", which provides access to both of the I2C slave
+	 * addresses used by the BD72720

drivers/power/supply/bd71828-power.c +9 -0

+
+	pwr->dev = &pdev->dev;
 
 	switch (pwr->chip_type) {
 	case ROHM_CHIP_TYPE_BD71828:

@@ -985,6 +1076,12 @@ static int bd71828_power_probe(struct platform_device *pdev)
 		pwr->get_temp = bd71815_get_temp;
 		pwr->regs = &pwr_regs_bd71815;
 		break;
+	case ROHM_CHIP_TYPE_BD72720:
+		pwr->bat_inserted = bd71828_bat_inserted;
+		pwr->regs = &pwr_regs_bd72720;
+		pwr->get_temp = bd71828_get_temp;
+		dev_dbg(pwr->dev, "Found ROHM BD72720\n");
+		break;
 	default:
 		dev_err(pwr->dev, "Unknown PMIC\n");
 		return -EINVAL;

@@ -1030,6 +1127,7 @@ static int bd71828_power_probe(struct platform_device *pdev)
 static const struct platform_device_id bd71828_charger_id[] = {
 	{ "bd71815-power", ROHM_CHIP_TYPE_BD71815 },
 	{ "bd71828-power", ROHM_CHIP_TYPE_BD71828 },
+	{ "bd72720-power", ROHM_CHIP_TYPE_BD72720 },
 	{ },
 };
 MODULE_DEVICE_TABLE(platform, bd71828_charger_id);

Signature · 1 line

2.52.0

Hi,

Quoted 24 lines · Matti Vaittinen

From: Matti Vaittinen <[email protected]>

The ROHM BD72720 is a power management IC with a charger and coulomb counter block which is closely related to the charger / coulomb counter found from the BD71815, BD71828, BD71879 which are all supported by the bd71828-power driver. Due to the similarities it makes sense to support also the BD72720 with the same driver.

Add basic support for the charger logic on ROHM BD72720.

Signed-off-by Matti Vaittinen <[email protected]>

---
Revision history:
v2 => :
- No changes

RFCv1 => v2:
- Support using 9-bit register addresses (offset of 0x100) with the BD72720
- Simplify probe and IC data as we don't need two regmaps
- Drop two BD72720 specific functions as we no longer need different regmap for it.

Quoted 3 lines

Note: This patch depends on the series: "power: supply: add charger for BD71828" by Andreas:
https://lore.kernel.org/all/[email protected]/

That should be in v6.19?

Hi,

Quoted 24 lines · Matti Vaittinen

From: Matti Vaittinen <[email protected]>

The ROHM BD72720 is a power management IC with a charger and coulomb counter block which is closely related to the charger / coulomb counter found from the BD71815, BD71828, BD71879 which are all supported by the bd71828-power driver. Due to the similarities it makes sense to support also the BD72720 with the same driver.

Add basic support for the charger logic on ROHM BD72720.

Signed-off-by Matti Vaittinen <[email protected]>

---
Revision history:
v2 => :
- No changes

RFCv1 => v2:
- Support using 9-bit register addresses (offset of 0x100) with the

    BD72720

- Simplify probe and IC data as we don't need two regmaps
- Drop two BD72720 specific functions as we no longer need different regmap for it.

Quoted 3 lines

Note: This patch depends on the series: "power: supply: add charger for BD71828" by Andreas:
https://lore.kernel.org/all/[email protected]/

That should be in v6.19?

Quoted 22 lines

drivers/power/supply/bd71828-power.c +4 -9

@@ -958,21 +1043,27 @@ static int bd71828_power_probe(struct platform_device *pdev)
  	struct power_supply_config ac_cfg = {};
  	struct power_supply_config bat_cfg = {};
  	int ret;
-	struct regmap *regmap;
-
-	regmap = dev_get_regmap(pdev->dev.parent, NULL);
-	if (!regmap) {
-		dev_err(&pdev->dev, "No parent regmap\n");
-		return -EINVAL;
-	}
 
  	pwr = devm_kzalloc(&pdev->dev, sizeof(*pwr), GFP_KERNEL);
  	if (!pwr)
  		return -ENOMEM;
 
-	pwr->regmap = regmap;
-	pwr->dev = &pdev->dev;
+	/*
+	 * The BD72720 MFD device registers two regmaps. Power-supply driver
+	 * uses the "wrap-map", which provides access to both of the I2C slave
+	 * addresses used by the BD72720

drivers/power/supply/bd71828-power.c static int bd71828_power_probe(struct platform_device *pdev) · line 1064

Quoted 10 lines

drivers/power/supply/bd71828-power.c +9 -0

+	 */
  	pwr->chip_type = platform_get_device_id(pdev)->driver_data;
+	if (pwr->chip_type != ROHM_CHIP_TYPE_BD72720)
+		pwr->regmap = dev_get_regmap(pdev->dev.parent, NULL);
+	else
+		pwr->regmap = dev_get_regmap(pdev->dev.parent, "wrap-map");
+	if (!pwr->regmap) {
+		dev_err(&pdev->dev, "No parent regmap\n");
+		return -EINVAL;
+	}

return dev_err_probe(&pdev->dev, -EINVAL, "No parent regmap\n");

Otherwise LGTM.

Quoted 7 lines

drivers/power/supply/bd71828-power.c +1 -0

  	switch (pwr->chip_type) {
  	case ROHM_CHIP_TYPE_BD71828:

@@ -985,6 +1076,12 @@ static int bd71828_power_probe(struct platform_device *pdev)
  		pwr->get_temp = bd71815_get_temp;
  		pwr->regs = &pwr_regs_bd71815;
  		break;
+	case ROHM_CHIP_TYPE_BD72720:

drivers/power/supply/bd71828-power.c static int bd71828_power_probe(struct platform_device *pdev) · line 1087

Quoted 8 lines

drivers/power/supply/bd71828-power.c +5 -0

+		pwr->bat_inserted = bd71828_bat_inserted;
+		pwr->regs = &pwr_regs_bd72720;
+		pwr->get_temp = bd71828_get_temp;
+		dev_dbg(pwr->dev, "Found ROHM BD72720\n");
+		break;
  	default:
  		dev_err(pwr->dev, "Unknown PMIC\n");
  		return -EINVAL;

Quoted 10 lines

drivers/power/supply/bd71828-power.c +1 -0

@@ -1030,6 +1127,7 @@ static int bd71828_power_probe(struct platform_device *pdev)
  static const struct platform_device_id bd71828_charger_id[] = {
  	{ "bd71815-power", ROHM_CHIP_TYPE_BD71815 },
  	{ "bd71828-power", ROHM_CHIP_TYPE_BD71828 },
+	{ "bd72720-power", ROHM_CHIP_TYPE_BD72720 },
  	{ },
  };
  MODULE_DEVICE_TABLE(platform, bd71828_charger_id);

Signature · 1 line

2.52.0

Resending the v6

This series depends on
5bff79dad20a ("power: supply: Add bd718(15/28/78) charger driver") which is in power-supply tree, for-next. Thus, the series is based on it.

Resending the v6

Series is same as v6 _except_ being rebased on v6.19-rc1 - and adding rb tags which were replied to v6.

The ROHM BD72720 is a new power management IC for portable, battery powered devices. It integrates 10 BUCKs and 11 LDOs, RTC, charger, LEDs, GPIOs and a clock gate. To me the BD72720 seems like a successor to the BD71828 and BD71815 PMICs.

This series depends on
5bff79dad20a ("power: supply: Add bd718(15/28/78) charger driver") which is in power-supply tree, for-next. Thus, the series is based on it.

The testing since v4 has suffered some hardware-issues after I accidentally enabled charging while the PMIC's battery pin was connected to the I/O domain. Some heat was generated, not terribly lot smoke though...

After the incident I've had occasional I2C failures. I, however, suspect the root cause is HW damage in I/O lines.

Revision history:
v6 resend:
- Rebased on v6.19-rc1 and collected rb-tags from v6.

v5 => v6:
- MFD fixes as suggested by Lee
- Styling mostly
- New patch to Fix comment style for MFD driver
More accurate changelog in individual patches

v4 => v5:
- dt-binding fixes as discussed in v4 reviews.
- Drop rohm,vdr-battery.yaml and add vdr properties to battery.yaml
- Drop 'rohm,' -vendor-prefix from vdr properties
- Link to v4:

    https://lore.kernel.org/all/[email protected]/

More accurate changelog in individual patches

v3 => v4:
- dt-binding fixes to the BD72720 MFD example and regulator bindings More accurate changelog in individual patches

v2 => v3:
- rebased to power-supply/for-next as dependencies are merged to there
- plenty of dt-binding changes as suggested by reviewers
- add new patch to better document existing 'trickle-charging' property More accurate changelog in individual patches

RFCv1 => v2:
- Drop RFC status
- Use stacked regmaps to hide secondary map from the sub-drivers
- Quite a few styling fixes and improvements as suggested by reviewers. More accurate changelog in individual patches.
- Link to v1:

    https://lore.kernel.org/all/[email protected]/

---

Matti Vaittinen (17):
dt-bindings: regulator: ROHM BD72720
dt-bindings: battery: Clarify trickle-charge
dt-bindings: battery: Add trickle-charge upper limit
dt-bindings: battery: Voltage drop properties
dt-bindings: mfd: ROHM BD72720
dt-bindings: leds: bd72720: Add BD72720
mfd: rohm-bd71828: Use regmap_reg_range()
mfd: rohm-bd71828: Use standard file header format
mfd: rohm-bd71828: Support ROHM BD72720
regulator: bd71828: rename IC specific entities
regulator: bd71828: Support ROHM BD72720
gpio: Support ROHM BD72720 gpios
clk: clk-bd718x7: Support BD72720 clk gate
rtc: bd70528: Support BD72720 rtc
power: supply: bd71828: Support wider register addresses
power: supply: bd71828-power: Support ROHM BD72720
MAINTAINERS: Add ROHM BD72720 PMIC

 .../bindings/leds/rohm,bd71828-leds.yaml      |    7 +-
 .../bindings/mfd/rohm,bd72720-pmic.yaml       |  339 ++++++
 .../bindings/power/supply/battery.yaml        |   33 +-
 .../regulator/rohm,bd72720-regulator.yaml     |  148 +++
 MAINTAINERS                                   |    2 +
 drivers/clk/Kconfig                           |    4 +-
 drivers/clk/clk-bd718x7.c                     |   10 +-
 drivers/gpio/Kconfig                          |    9 +
 drivers/gpio/Makefile                         |    1 +
 drivers/gpio/gpio-bd72720.c                   |  281 +++++
 drivers/mfd/Kconfig                           |   18 +-
 drivers/mfd/rohm-bd71828.c                    |  555 ++++++++-
 drivers/power/supply/bd71828-power.c          |  160 ++-
 drivers/regulator/Kconfig                     |    8 +-
 drivers/regulator/bd71828-regulator.c         | 1025 ++++++++++++++++-
 drivers/rtc/Kconfig                           |    3 +-

 drivers/rtc/rtc-bd70528.c                     |   21 +-
 include/linux/mfd/rohm-bd72720.h              |  634 ++++++++++
 include/linux/mfd/rohm-generic.h              |    1 +
 19 files changed, 3127 insertions(+), 132 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/mfd/rohm,bd72720-pmic.yaml
 create mode 100644 Documentation/devicetree/bindings/regulator/rohm,bd72720-regulator.yaml
 create mode 100644 drivers/gpio/gpio-bd72720.c
 create mode 100644 include/linux/mfd/rohm-bd72720.h

Signature · 1 line

2.52.0

Quoted 100 lines · Matti Vaittinen

Resending the v6

Series is same as v6 _except_ being rebased on v6.19-rc1 - and adding rb tags which were replied to v6.

The ROHM BD72720 is a new power management IC for portable, battery powered devices. It integrates 10 BUCKs and 11 LDOs, RTC, charger, LEDs, GPIOs and a clock gate. To me the BD72720 seems like a successor to the BD71828 and BD71815 PMICs.

This series depends on
5bff79dad20a ("power: supply: Add bd718(15/28/78) charger driver") which is in power-supply tree, for-next. Thus, the series is based on it.

The testing since v4 has suffered some hardware-issues after I accidentally enabled charging while the PMIC's battery pin was connected to the I/O domain. Some heat was generated, not terribly lot smoke though...

After the incident I've had occasional I2C failures. I, however, suspect the root cause is HW damage in I/O lines.

Revision history:
v6 resend:
- Rebased on v6.19-rc1 and collected rb-tags from v6.

v5 => v6:
- MFD fixes as suggested by Lee
- Styling mostly
- New patch to Fix comment style for MFD driver
More accurate changelog in individual patches

v4 => v5:
- dt-binding fixes as discussed in v4 reviews.
- Drop rohm,vdr-battery.yaml and add vdr properties to battery.yaml
- Drop 'rohm,' -vendor-prefix from vdr properties
- Link to v4:

     https://lore.kernel.org/all/[email protected]/

More accurate changelog in individual patches

v3 => v4:
- dt-binding fixes to the BD72720 MFD example and regulator bindings More accurate changelog in individual patches

v2 => v3:
- rebased to power-supply/for-next as dependencies are merged to there
- plenty of dt-binding changes as suggested by reviewers
- add new patch to better document existing 'trickle-charging' property More accurate changelog in individual patches

RFCv1 => v2:
- Drop RFC status
- Use stacked regmaps to hide secondary map from the sub-drivers
- Quite a few styling fixes and improvements as suggested by reviewers. More accurate changelog in individual patches.
- Link to v1:

     https://lore.kernel.org/all/[email protected]/

---

Matti Vaittinen (17):
dt-bindings: regulator: ROHM BD72720
dt-bindings: battery: Clarify trickle-charge
dt-bindings: battery: Add trickle-charge upper limit
dt-bindings: battery: Voltage drop properties
dt-bindings: mfd: ROHM BD72720
dt-bindings: leds: bd72720: Add BD72720
mfd: rohm-bd71828: Use regmap_reg_range()
mfd: rohm-bd71828: Use standard file header format
mfd: rohm-bd71828: Support ROHM BD72720
regulator: bd71828: rename IC specific entities
regulator: bd71828: Support ROHM BD72720
gpio: Support ROHM BD72720 gpios
clk: clk-bd718x7: Support BD72720 clk gate
rtc: bd70528: Support BD72720 rtc
power: supply: bd71828: Support wider register addresses
power: supply: bd71828-power: Support ROHM BD72720
MAINTAINERS: Add ROHM BD72720 PMIC

  .../bindings/leds/rohm,bd71828-leds.yaml      |    7 +-
  .../bindings/mfd/rohm,bd72720-pmic.yaml       |  339 ++++++
  .../bindings/power/supply/battery.yaml        |   33 +-
  .../regulator/rohm,bd72720-regulator.yaml     |  148 +++
  MAINTAINERS                                   |    2 +
  drivers/clk/Kconfig                           |    4 +-
  drivers/clk/clk-bd718x7.c                     |   10 +-
  drivers/gpio/Kconfig                          |    9 +
  drivers/gpio/Makefile                         |    1 +
  drivers/gpio/gpio-bd72720.c                   |  281 +++++
  drivers/mfd/Kconfig                           |   18 +-
  drivers/mfd/rohm-bd71828.c                    |  555 ++++++++-
  drivers/power/supply/bd71828-power.c          |  160 ++-
  drivers/regulator/Kconfig                     |    8 +-
  drivers/regulator/bd71828-regulator.c         | 1025 ++++++++++++++++-
  drivers/rtc/Kconfig                           |    3 +-
  drivers/rtc/rtc-bd70528.c                     |   21 +-
  include/linux/mfd/rohm-bd72720.h              |  634 ++++++++++
  include/linux/mfd/rohm-generic.h              |    1 +
  19 files changed, 3127 insertions(+), 132 deletions(-)

Quoted 4 lines

create mode 100644 Documentation/devicetree/bindings/mfd/rohm,bd72720-pmic.yaml create mode 100644 Documentation/devicetree/bindings/regulator/rohm,bd72720-regulator.yaml create mode 100644 drivers/gpio/gpio-bd72720.c
create mode 100644 include/linux/mfd/rohm-bd72720.h

The MFD parts LGTM.

What Acks are you waiting on? What's the merge strategy?

Quoted 107 lines · Lee Jones

Quoted 100 lines · Matti Vaittinen

Resending the v6

Series is same as v6 _except_ being rebased on v6.19-rc1 - and adding rb tags which were replied to v6.

The ROHM BD72720 is a new power management IC for portable, battery powered devices. It integrates 10 BUCKs and 11 LDOs, RTC, charger, LEDs, GPIOs and a clock gate. To me the BD72720 seems like a successor to the BD71828 and BD71815 PMICs.

This series depends on
5bff79dad20a ("power: supply: Add bd718(15/28/78) charger driver") which is in power-supply tree, for-next. Thus, the series is based on it.

The testing since v4 has suffered some hardware-issues after I accidentally enabled charging while the PMIC's battery pin was connected to the I/O domain. Some heat was generated, not terribly lot smoke though...

After the incident I've had occasional I2C failures. I, however, suspect the root cause is HW damage in I/O lines.

Revision history:
v6 resend:
- Rebased on v6.19-rc1 and collected rb-tags from v6.

v5 => v6:
- MFD fixes as suggested by Lee
- Styling mostly
- New patch to Fix comment style for MFD driver
More accurate changelog in individual patches

v4 => v5:
- dt-binding fixes as discussed in v4 reviews.
- Drop rohm,vdr-battery.yaml and add vdr properties to battery.yaml
- Drop 'rohm,' -vendor-prefix from vdr properties
- Link to v4:

     https://lore.kernel.org/all/[email protected]/

More accurate changelog in individual patches

v3 => v4:
- dt-binding fixes to the BD72720 MFD example and regulator bindings More accurate changelog in individual patches

v2 => v3:
- rebased to power-supply/for-next as dependencies are merged to there
- plenty of dt-binding changes as suggested by reviewers
- add new patch to better document existing 'trickle-charging' property More accurate changelog in individual patches

RFCv1 => v2:
- Drop RFC status
- Use stacked regmaps to hide secondary map from the sub-drivers
- Quite a few styling fixes and improvements as suggested by reviewers. More accurate changelog in individual patches.
- Link to v1:

     https://lore.kernel.org/all/[email protected]/

---

Matti Vaittinen (17):
dt-bindings: regulator: ROHM BD72720
dt-bindings: battery: Clarify trickle-charge
dt-bindings: battery: Add trickle-charge upper limit
dt-bindings: battery: Voltage drop properties
dt-bindings: mfd: ROHM BD72720
dt-bindings: leds: bd72720: Add BD72720
mfd: rohm-bd71828: Use regmap_reg_range()
mfd: rohm-bd71828: Use standard file header format
mfd: rohm-bd71828: Support ROHM BD72720
regulator: bd71828: rename IC specific entities
regulator: bd71828: Support ROHM BD72720
gpio: Support ROHM BD72720 gpios
clk: clk-bd718x7: Support BD72720 clk gate
rtc: bd70528: Support BD72720 rtc
power: supply: bd71828: Support wider register addresses
power: supply: bd71828-power: Support ROHM BD72720
MAINTAINERS: Add ROHM BD72720 PMIC

  .../bindings/leds/rohm,bd71828-leds.yaml      |    7 +-
  .../bindings/mfd/rohm,bd72720-pmic.yaml       |  339 ++++++
  .../bindings/power/supply/battery.yaml        |   33 +-
  .../regulator/rohm,bd72720-regulator.yaml     |  148 +++
  MAINTAINERS                                   |    2 +
  drivers/clk/Kconfig                           |    4 +-
  drivers/clk/clk-bd718x7.c                     |   10 +-
  drivers/gpio/Kconfig                          |    9 +
  drivers/gpio/Makefile                         |    1 +
  drivers/gpio/gpio-bd72720.c                   |  281 +++++
  drivers/mfd/Kconfig                           |   18 +-
  drivers/mfd/rohm-bd71828.c                    |  555 ++++++++-
  drivers/power/supply/bd71828-power.c          |  160 ++-
  drivers/regulator/Kconfig                     |    8 +-
  drivers/regulator/bd71828-regulator.c         | 1025 ++++++++++++++++-
  drivers/rtc/Kconfig                           |    3 +-
  drivers/rtc/rtc-bd70528.c                     |   21 +-
  include/linux/mfd/rohm-bd72720.h              |  634 ++++++++++
  include/linux/mfd/rohm-generic.h              |    1 +
  19 files changed, 3127 insertions(+), 132 deletions(-)

Quoted 4 lines

create mode 100644 Documentation/devicetree/bindings/mfd/rohm,bd72720-pmic.yaml create mode 100644 Documentation/devicetree/bindings/regulator/rohm,bd72720-regulator.yaml create mode 100644 drivers/gpio/gpio-bd72720.c
create mode 100644 include/linux/mfd/rohm-bd72720.h

Quoted 1 line

The MFD parts LGTM.

Thanks Lee!

Quoted 1 line

What Acks are you waiting on? What's the merge strategy?

I think everything else has been acked by maintainers, except the power-supply parts. I think those have only been looked at by Andreas and Linus W. Haven't heard anything from Sebastian :(

I would love to see the patches 1 - 14 and 17 to be merged (via MFD?). I could then re-spin the 15 and 16 to limited audience as I hope Sebastian had time to take a look at them. However, I don't think any of the other patches in the series depend on the last .

Yours,
-- Matti.

---
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~

[...]

Quoted 9 lines

Quoted 1 line

The MFD parts LGTM.

Thanks Lee!

Quoted 1 line

What Acks are you waiting on? What's the merge strategy?

I think everything else has been acked by maintainers, except the power-supply parts. I think those have only been looked at by Andreas and Linus W. Haven't heard anything from Sebastian :(

Quoted 4 lines

I would love to see the patches 1 - 14 and 17 to be merged (via MFD?). I could then re-spin the 15 and 16 to limited audience as I hope Sebastian had time to take a look at them. However, I don't think any of the other patches in the series depend on the last .

Hi,

Quoted 10 lines · Lee Jones

[...]

Quoted 9 lines

Quoted 1 line

The MFD parts LGTM.

Thanks Lee!

Quoted 1 line

What Acks are you waiting on? What's the merge strategy?

I think everything else has been acked by maintainers, except the power-supply parts. I think those have only been looked at by Andreas and Linus W. Haven't heard anything from Sebastian :(

Yes, I'm lacking behind quite a bit, sorry for that.

Quoted 4 lines

Quoted 4 lines

I would love to see the patches 1 - 14 and 17 to be merged (via MFD?). I could then re-spin the 15 and 16 to limited audience as I hope Sebastian had time to take a look at them. However, I don't think any of the other patches in the series depend on the last .

Sounds good to me.

Quoted 12 lines · Sebastian Reichel

Quoted 10 lines · Lee Jones

[...]

Quoted 9 lines

Quoted 1 line

The MFD parts LGTM.

Thanks Lee!

Quoted 1 line

What Acks are you waiting on? What's the merge strategy?

I think everything else has been acked by maintainers, except the power-supply parts. I think those have only been looked at by Andreas and Linus W. Haven't heard anything from Sebastian :(

Quoted 8 lines

Yes, I'm lacking behind quite a bit, sorry for that.

Quoted 4 lines

Quoted 4 lines

I would love to see the patches 1 - 14 and 17 to be merged (via MFD?). I could then re-spin the 15 and 16 to limited audience as I hope Sebastian had time to take a look at them. However, I don't think any of the other patches in the series depend on the last .

Sounds good to me.

Ah. Since the 15/17:
"[PATCH RESEND v6 15/17] power: supply: bd71828: Support wider register addresses" was now acked by Sebastian, then it can also go via MFD?

Also, if it is Ok to address all the "dev_err() + return ERRNO" => "return dev_err_probe(,ERRNO,)" conversions in a follow-up, then I guess the whole series, including 16/17 is good to go? If this is the case, please just let me know and I'll send the follow-up. Otherwise, I will re-spin the 16/17 and add a new patch for the remaining "dev_err() + return ERRNO" => "return dev_err_probe(,ERRNO,)" case(s)