implement psock_update_sk_prot
Subsystems (5)
Geliang Tang
reviewerv2 cover implement psock_update_sk_prot
From: Geliang Tang <[email protected]>
v2:
- Include mptcp_bpf_update_proto within CONFIG_BPF_SYSCALL to fix the
compilation errors reported by the kernel test robot.
- Add checks for IS_ENABLED(CONFIG_MPTCP_IPV6).
Implement psock_update_sk_prot, for basic MPTCP BPF SOCKMAP support.
Geliang Tang (3):
mptcp: implement psock_update_sk_prot
mptcp: allow overridden write_space to be invoked selftests/bpf: Update sockmap tests for MPTCP
net/mptcp/protocol.c | 105 ++++++++++++++++++ net/mptcp/protocol.h | 2 +- .../testing/selftests/bpf/prog_tests/mptcp.c | 4 +- 3 files changed, 108 insertions(+), 3 deletions(-)
Signature · 1 line
2.51.0
Geliang Tang
reviewerPATCH v2 1/3 mptcp: implement psock_update_sk_prot
From: Geliang Tang <[email protected]>
Add MPTCP support for BPF sockmap by implementing psock_update_sk_prot callback. This allows MPTCP sockets to dynamically switch protocol handlers when attached to or detached from sockmap programs. Separate protocol structures are maintained for IPv4/IPv6 and TX/RX configurations.
tcp_bpf_update_proto() in net/ipv4/tcp_bpf.c is a frame of reference for this patch.
--- net/mptcp/protocol.c | 105 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 105 insertions(+)
net/mptcp/protocol.c +105 -0
@@ -11,6 +11,7 @@#include <linux/netdevice.h> #include <linux/sched/signal.h> #include <linux/atomic.h> +#include <linux/skmsg.h> #include <net/aligned_data.h> #include <net/rps.h> #include <net/sock.h>
@@ -4017,6 +4018,98 @@ static int mptcp_connect(struct sock *sk, struct sockaddr_unsized *uaddr,return 0 ; } +#ifdef CONFIG_BPF_SYSCALL +enum { +MPTCP_BPF_IPV4 , +MPTCP_BPF_IPV6 , +MPTCP_BPF_NUM_PROTS , +}; + +enum { +MPTCP_BPF_BASE , +MPTCP_BPF_TX , +MPTCP_BPF_RX , +MPTCP_BPF_TXRX , +MPTCP_BPF_NUM_CFGS , +}; + +static struct proto mptcp_bpf_prots[MPTCP_BPF_NUM_PROTS ][MPTCP_BPF_NUM_CFGS ]; + +static void mptcp_bpf_rebuild_protos (struct proto prot[MPTCP_BPF_NUM_CFGS ], +struct proto *base) +{ + prot[MPTCP_BPF_BASE ] = *base; + prot[MPTCP_BPF_BASE ].destroy = sock_map_destroy; + prot[MPTCP_BPF_BASE ].close = sock_map_close; + prot[MPTCP_BPF_BASE ].sock_is_readable = sk_msg_is_readable; + + prot[MPTCP_BPF_TX ] = prot[MPTCP_BPF_BASE ]; + prot[MPTCP_BPF_RX ] = prot[MPTCP_BPF_BASE ]; + prot[MPTCP_BPF_TXRX ] = prot[MPTCP_BPF_TX ]; +} + +#if IS_ENABLED (CONFIG_MPTCP_IPV6 ) +static struct proto *mptcpv6_prot_saved__read_mostly ; +static DEFINE_SPINLOCK (mptcpv6_prot_lock); + +static void mptcp_bpf_check_v6_needs_rebuild (struct proto *ops) +{ +/* +* Load with acquire semantics to ensure we see the latest protocol +* structure before checking for rebuild. +*/ +if (unlikely (ops !=smp_load_acquire (&mptcpv6_prot_saved))) { +spin_lock_bh (&mptcpv6_prot_lock); +if (likely (ops != mptcpv6_prot_saved)) { +mptcp_bpf_rebuild_protos (mptcp_bpf_prots[MPTCP_BPF_IPV6 ], ops); +/* Ensure mptcpv6_prot_saved update is visible before releasing lock */ +smp_store_release (&mptcpv6_prot_saved, ops); + } +spin_unlock_bh (&mptcpv6_prot_lock); + } +} + +static int mptcp_bpf_assert_proto_ops (struct proto *ops) +{ +/* In order to avoid retpoline, we make assumptions when we call +* into ops if e.g. a psock is not present. Make sure they are +* indeed valid assumptions. +*/ +return ops->recvmsg == mptcp_recvmsg && + ops->sendmsg == mptcp_sendmsg ?0 : -EOPNOTSUPP ; +} +#endif + +static int mptcp_bpf_update_proto (struct sock *sk,struct sk_psock *psock,bool restore) +{ +int family = sk->sk_family ==AF_INET6 ?MPTCP_BPF_IPV6 :MPTCP_BPF_IPV4 ; +int config = psock->progs.msg_parser ?MPTCP_BPF_TX :MPTCP_BPF_BASE ; + +if (psock->progs.stream_verdict || psock->progs.skb_verdict) + config = (config ==MPTCP_BPF_TX ) ?MPTCP_BPF_TXRX :MPTCP_BPF_RX ; + +if (restore) { + sk->sk_write_space = psock->saved_write_space; +/* Pairs with lockless read in sk_clone_lock() */ +sock_replace_proto (sk, psock->sk_proto); +return 0 ; + } + +#if IS_ENABLED (CONFIG_MPTCP_IPV6 ) +if (sk->sk_family ==AF_INET6 ) { +if (mptcp_bpf_assert_proto_ops (psock->sk_proto)) +return -EINVAL ; + +mptcp_bpf_check_v6_needs_rebuild (psock->sk_proto); + } +#endif + +/* Pairs with lockless read in sk_clone_lock() */ +sock_replace_proto (sk, &mptcp_bpf_prots[family][config]); +return 0 ; +} +#endif +static struct proto mptcp_prot = { .name ="MPTCP" , .owner =THIS_MODULE ,
@@ -4048,8 +4141,20 @@ static struct proto mptcp_prot = { .obj_size = sizeof(struct mptcp_sock), .slab_flags = SLAB_TYPESAFE_BY_RCU, .no_autobind = true, +#ifdef CONFIG_BPF_SYSCALL + .psock_update_sk_prot = mptcp_bpf_update_proto, +#endif }; +#ifdef CONFIG_BPF_SYSCALL +static int __init mptcp_bpf_v4_build_proto (void ) +{ +mptcp_bpf_rebuild_protos (mptcp_bpf_prots[MPTCP_BPF_IPV4 ], &mptcp_prot); +return 0 ; +} +late_initcall (mptcp_bpf_v4_build_proto); +#endif +static int mptcp_bind (struct socket *sock,struct sockaddr_unsized *uaddr,int addr_len) {struct mptcp_sock *msk =mptcp_sk (sock->sk);
Signature · 1 line
2.51.0
Geliang Tang
reviewerPATCH v2 2/3 mptcp: allow overridden write_space to be invoked
In reply to Geliang TangFrom: Geliang Tang <[email protected]>
psock may override its own sk_write_space functions. This patch ensures that the overridden sk_write_space can be invoked by MPTCP.
Note: This patch was initially included in the NVME MPTCP set.
--- net/mptcp/protocol.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/mptcp/protocol.h +1 -1
@@ -1014,7 +1014,7 @@ static inline void mptcp_write_space(struct sock *sk)/* pairs with memory barrier in mptcp_poll */ smp_mb ();if (mptcp_stream_memory_free (sk,1 )) -sk_stream_write_space (sk); +INDIRECT_CALL_1 (sk->sk_write_space, sk_stream_write_space, sk); }static inline void __mptcp_sync_sndbuf (struct sock *sk)
Signature · 1 line
2.51.0
Geliang Tang
reviewerRe: [PATCH mptcp-next v2 2/3] mptcp: allow overridden write_space to be invoked
Hi Matt, Mat, Paolo,
Quoted 7 lines · Geliang Tang
From: Geliang Tang <[email protected]>
psock may override its own
sk_write_spacefunctions. This patch ensures
that the overriddensk_write_spacecan be invoked by MPTCP.Note: This patch was initially included in the NVME MPTCP set.
This patch was initially developed to resolve the "timeout" errors observed in the NVMe MPTCP tests described in [1], because NVMe TCP overrides its own sk_write_space. During subsequent development, I discovered that not only NVMe TCP overrides its own sk_write_space, but KTLS and psock also override it.
Therefore, this patch is needed in all three series. To reduce dependencies between these three series, I propose to merge this patch into the mainline first.
Thanks,
-Geliang
Quoted 24 lines
Suggested-by Paolo Abeni <[email protected]>Co-developed-by Gang Yan <[email protected]>Signed-off-by Gang Yan <[email protected]>Signed-off-by Geliang Tang <[email protected]>---
net/mptcp/protocol.h | 2 +-1 file changed, 1 insertion(+), 1 deletion(-)net/mptcp/protocol.h +1
-1@@ -1014,7 +1014,7 @@ static inline void mptcp_write_space(struct sock *sk) /* pairs with memory barrier in mptcp_poll */ smp_mb(); if (mptcp_stream_memory_free(sk, 1)) -sk_stream_write_space (sk); +INDIRECT_CALL_1 (sk->sk_write_space, sk_stream_write_space, sk); }
static inline void__mptcp_sync_sndbuf(struct sock *sk)
Matthieu Baerts
maintainerRe: [PATCH mptcp-next v2 2/3] mptcp: allow overridden write_space to be invoked
Hi Geliang,
Quoted 17 lines · Geliang Tang
Hi Matt, Mat, Paolo,
Quoted 7 lines · Geliang Tang
From: Geliang Tang <[email protected]>
psock may override its own
sk_write_spacefunctions. This patch ensures
that the overriddensk_write_spacecan be invoked by MPTCP.Note: This patch was initially included in the NVME MPTCP set.
This patch was initially developed to resolve the "timeout" errors observed in the NVMe MPTCP tests described in [1], because NVMe TCP overrides its own
sk_write_space. During subsequent development, I discovered that not only NVMe TCP overrides its ownsk_write_space, but KTLS and psock also override it.
Quoted 3 lines
Therefore, this patch is needed in all three series. To reduce dependencies between these three series, I propose to merge this patch into the mainline first.
Just to be sure, when you say "mainline", do you mean our MPTCP tree with the export branch?
Because we are at the end of a cycle here, my priority is to flush patches that are ready or fix issues. If I'm not mistaken, this patch is needed for new features that are not in our tree, not in net or net-next trees, right?
Cheers,
Matt
Signature · 1 line
Sponsored by the NGI0 Core fund.
Geliang Tang
reviewerRe: [PATCH mptcp-next v2 2/3] mptcp: allow overridden write_space to be invoked
Hi Matt,
Thanks for your reply.
Quoted 29 lines · Matthieu Baerts
Hi Geliang,
Quoted 18 lines · Geliang Tang
Hi Matt, Mat, Paolo,
Quoted 7 lines · Geliang Tang
From: Geliang Tang <[email protected]>
psock may override its own
sk_write_spacefunctions. This patch ensures
that the overriddensk_write_spacecan be invoked by MPTCP.Note: This patch was initially included in the NVME MPTCP set.
This patch was initially developed to resolve the "timeout" errors observed in the NVMe MPTCP tests described in [1], because NVMe TCP overrides its own
sk_write_space. During subsequent development, I discovered that not only NVMe TCP overrides its ownsk_write_space, but
KTLS and psock also override it.Quoted 4 lines
Therefore, this patch is needed in all three series. To reduce dependencies between these three series, I propose to merge this patch
into the mainline first.Just to be sure, when you say "mainline", do you mean our MPTCP tree with the export branch?
Quoted 6 lines
Because we are at the end of a cycle here, my priority is to flush patches that are ready or fix issues. If I'm not mistaken, this patch is
needed for new features that are not in our tree, not in net or net- next
trees, right?
Yes, it is needed for new features. In this case, merging it into the export branch first is also an option. It can be sent to net-next in the next cycle. I plan to submit the KTLS series and the NVMe series to the KTLS and NVMe communities for feedback respectively. If this write_space patch enters net-next early, it would be more convenient.
Thanks,
-Geliang
Quoted 3 lines
Cheers,
Matt
Matthieu Baerts
maintainerRe: [PATCH mptcp-next v2 2/3] mptcp: allow overridden write_space to be invoked
Quoted 41 lines · Geliang Tang
Hi Matt,
Thanks for your reply.
Quoted 29 lines · Matthieu Baerts
Hi Geliang,
Quoted 18 lines · Geliang Tang
Hi Matt, Mat, Paolo,
Quoted 7 lines · Geliang Tang
From: Geliang Tang <[email protected]>
psock may override its own
sk_write_spacefunctions. This patch ensures
that the overriddensk_write_spacecan be invoked by MPTCP.Note: This patch was initially included in the NVME MPTCP set.
This patch was initially developed to resolve the "timeout" errors observed in the NVMe MPTCP tests described in [1], because NVMe TCP overrides its own
sk_write_space. During subsequent development, I discovered that not only NVMe TCP overrides its ownsk_write_space, but
KTLS and psock also override it.Quoted 4 lines
Therefore, this patch is needed in all three series. To reduce dependencies between these three series, I propose to merge this patch
into the mainline first.Just to be sure, when you say "mainline", do you mean our MPTCP tree with the export branch?
Quoted 6 lines
Because we are at the end of a cycle here, my priority is to flush patches that are ready or fix issues. If I'm not mistaken, this patch is
needed for new features that are not in our tree, not in net or net- next
trees, right?
Quoted 5 lines
Yes, it is needed for new features. In this case, merging it into the export branch first is also an option. It can be sent to net-next in the next cycle. I plan to submit the KTLS series and the NVMe series to the KTLS and NVMe communities for feedback respectively. If this
write_spacepatch enters net-next early, it would be more convenient.
I see.
Is only this patch 2/3 from this series needed? Or the whole series?
Cheers,
Matt
Signature · 1 line
Sponsored by the NGI0 Core fund.
Re: [PATCH mptcp-next v2 2/3] mptcp: allow overridden write_space to be invoked
Hi Geliang,
Quoted 48 lines · Matthieu Baerts
Quoted 41 lines · Geliang Tang
Hi Matt,
Thanks for your reply.
Quoted 29 lines · Matthieu Baerts
Hi Geliang,
Quoted 18 lines · Geliang Tang
Hi Matt, Mat, Paolo,
Quoted 7 lines · Geliang Tang
From: Geliang Tang <[email protected]>
psock may override its own
sk_write_spacefunctions. This patch ensures
that the overriddensk_write_spacecan be invoked by MPTCP.Note: This patch was initially included in the NVME MPTCP set.
This patch was initially developed to resolve the "timeout" errors observed in the NVMe MPTCP tests described in [1], because NVMe TCP overrides its own
sk_write_space. During subsequent development, I discovered that not only NVMe TCP overrides its ownsk_write_space, but
KTLS and psock also override it.Quoted 4 lines
Therefore, this patch is needed in all three series. To reduce dependencies between these three series, I propose to merge this patch
into the mainline first.Just to be sure, when you say "mainline", do you mean our MPTCP tree with the export branch?
Quoted 6 lines
Because we are at the end of a cycle here, my priority is to flush patches that are ready or fix issues. If I'm not mistaken, this patch is
needed for new features that are not in our tree, not in net or net- next
trees, right?Quoted 5 lines
Yes, it is needed for new features. In this case, merging it into the export branch first is also an option. It can be sent to net-next in the next cycle. I plan to submit the KTLS series and the NVMe series to the KTLS and NVMe communities for feedback respectively. If this
write_spacepatch enters net-next early, it would be more convenient.
Quoted 3 lines
I see.
Is only this patch 2/3 from this series needed? Or the whole series?
I just applied this patch (only this one) and I will try to send it this cycle.
Cheers,
Matt
Signature · 1 line
Sponsored by the NGI0 Core fund.
Matthieu Baerts
maintainerRe: [PATCH mptcp-next v2 2/3] mptcp: allow overridden write_space to be invoked
Quoted 51 lines · Matthieu Baerts
Hi Geliang,
Quoted 48 lines · Matthieu Baerts
Quoted 46 lines · Geliang Tang
Hi Matt,
Thanks for your reply.
Quoted 29 lines · Matthieu Baerts
Hi Geliang,
Quoted 18 lines · Geliang Tang
Hi Matt, Mat, Paolo,
Quoted 7 lines · Geliang Tang
From: Geliang Tang <[email protected]>
psock may override its own
sk_write_spacefunctions. This patch ensures
that the overriddensk_write_spacecan be invoked by MPTCP.Note: This patch was initially included in the NVME MPTCP set.
This patch was initially developed to resolve the "timeout" errors observed in the NVMe MPTCP tests described in [1], because NVMe TCP overrides its own
sk_write_space. During subsequent development, I discovered that not only NVMe TCP overrides its ownsk_write_space, but
KTLS and psock also override it.Quoted 4 lines
Therefore, this patch is needed in all three series. To reduce dependencies between these three series, I propose to merge this patch
into the mainline first.Just to be sure, when you say "mainline", do you mean our MPTCP tree with the export branch?
Quoted 6 lines
Because we are at the end of a cycle here, my priority is to flush patches that are ready or fix issues. If I'm not mistaken, this patch is
needed for new features that are not in our tree, not in net or net- next
trees, right?Yes, it is needed for new features. In this case, merging it into the export branch first is also an option. It can be sent to net-next in the next cycle. I plan to submit the KTLS series and the NVMe series to the KTLS and NVMe communities for feedback respectively. If this
write_spacepatch enters net-next early, it would be more convenient.
Quoted 6 lines
Quoted 3 lines
I see.
Is only this patch 2/3 from this series needed? Or the whole series?
I just applied this patch (only this one) and I will try to send it this cycle.
New patches for t/upstream:
- d8af4a2b24b5: mptcp: allow overridden write_space to be invoked
- Results: 9577d6866c4a..a5bb737958a3 (export)
Tests are now in progress:
Cheers,
Matt
Signature · 1 line
Sponsored by the NGI0 Core fund.
Matthieu Baerts
maintainerRe: [PATCH mptcp-next v2 2/3] mptcp: allow overridden write_space to be invoked
In reply to Geliang TangHi Geliang, Paolo,
Quoted 20 lines · Geliang Tang
From: Geliang Tang <[email protected]>
psock may override its own
sk_write_spacefunctions. This patch ensures that the overriddensk_write_spacecan be invoked by MPTCP.Note: This patch was initially included in the NVME MPTCP set.
Suggested-by Paolo Abeni <[email protected]>Co-developed-by Gang Yan <[email protected]>Signed-off-by Gang Yan <[email protected]>Signed-off-by Geliang Tang <[email protected]>--- net/mptcp/protocol.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)net/mptcp/protocol.h +0
-0
net/mptcp/protocol.h static inline void mptcp_write_space(struct sock *sk) · line 1017
Quoted 5 lines
net/mptcp/protocol.h +1
-1@@ -1014,7 +1014,7 @@ static inline void mptcp_write_space(struct sock *sk)/* pairs with memory barrier in mptcp_poll */ smp_mb ();if (mptcp_stream_memory_free (sk,1 )) -sk_stream_write_space (sk); +INDIRECT_CALL_1 (sk->sk_write_space, sk_stream_write_space, sk);
As I mentioned on the netdev ML when sending this patch upstream, there is something fishy here: sk->sk_write_space is never set to sk_stream_write_space here with the MPTCP sockets, but to sock_def_write_space. (Subflow sockets use sk_stream_write_space.)
In other words, this patch changes the behaviour, which was not supposed to be the case, now calling sock_def_write_space() instead of sk_stream_write_space().
So either sk->sk_write_space should be set to sk_stream_write_space for the MPTCP sockets (I guess, I don't think sk->sk_write_space() is ever called with an MPTCP socket for the moment), or sock_def_write_space() should have been called before (then a fix is needed).
Cheers,
Matt
Signature · 1 line
Sponsored by the NGI0 Core fund.
Geliang Tang
reviewerRe: [PATCH mptcp-next v2 2/3] mptcp: allow overridden write_space to be invoked
Hi Matt,
Quoted 19 lines · Matthieu Baerts
Hi Geliang, Paolo,
Quoted 16 lines · Geliang Tang
From: Geliang Tang <[email protected]>
psock may override its own
sk_write_spacefunctions. This patch ensures
that the overriddensk_write_spacecan be invoked by MPTCP.Note: This patch was initially included in the NVME MPTCP set.
Suggested-by Paolo Abeni <[email protected]>Co-developed-by Gang Yan <[email protected]>Signed-off-by Gang Yan <[email protected]>Signed-off-by Geliang Tang <[email protected]>---
net/mptcp/protocol.h | 2 +-1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 14 lines
net/mptcp/protocol.h static inline void mptcp_write_space(struct · line 1019
Quoted 12 lines
net/mptcp/protocol.h +1
-1@@ -1014,7 +1014,7 @@ static inline void mptcp_write_space(struct sock *sk) /* pairs with memory barrier in mptcp_poll */ smp_mb(); if (mptcp_stream_memory_free(sk, 1)) -sk_stream_write_space (sk); +INDIRECT_CALL_1 (sk->sk_write_space, sk_stream_write_space, sk);As I mentioned on the netdev ML when sending this patch upstream,
Sorry for the trouble.
Quoted 10 lines
there
is something fishy here:sk->sk_write_spaceis never set tosk_stream_write_spacehere with the MPTCP sockets, but tosock_def_write_space. (Subflow sockets usesk_stream_write_space.)In other words, this patch changes the behaviour, which was not supposed
to be the case, now callingsock_def_write_space()instead ofsk_stream_write_space().
Quoted 4 lines
So either
sk->sk_write_spaceshould be set tosk_stream_write_spacefor
the MPTCP sockets (I guess, I don't thinksk->sk_write_space()is ever
I just sent a squash-to patch to set it to sk_stream_write_space for the MPTCP sockets.
Thanks,
-Geliang
Quoted 6 lines
called with an MPTCP socket for the moment), or
sock_def_write_space()
should have been called before (then a fix is needed).Cheers,
Matt
Geliang Tang
reviewerPATCH v2 3/3 selftests/bpf: Update sockmap tests for MPTCP
In reply to Geliang TangFrom: Geliang Tang <[email protected]>
Update sockmap tests to reflect new MPTCP support. MPTCP sockets are now allowed in sockmap, so test expectations are adjusted accordingly.
--- tools/testing/selftests/bpf/prog_tests/mptcp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
tools/testing/selftests/bpf/prog_tests/mptcp.c +2 -2
@@ -570,13 +570,13 @@ static void test_sockmap_reject_mptcp(struct mptcp_sockmap *skel) server_fd =accept (listen_fd,NULL ,0 ); err =bpf_map_update_elem (bpf_map__fd (skel->maps.sock_map), &zero, &server_fd,BPF_NOEXIST ); -if (!ASSERT_EQ (err, -EOPNOTSUPP ,"server should be disallowed" )) +if (!ASSERT_EQ (err,0 ,"server should be allowed" )) goto end;/* MPTCP client should also be disallowed */ err =bpf_map_update_elem (bpf_map__fd (skel->maps.sock_map), &zero, &client_fd1,BPF_NOEXIST ); -if (!ASSERT_EQ (err, -EOPNOTSUPP ,"client should be disallowed" )) +if (!ASSERT_EQ (err, -EEXIST ,"client should be allowed" )) goto end; end:if (client_fd1 >=0 )
Signature · 1 line
2.51.0
Hi Geliang,
Thank you for your modifications, that's great!
Our CI did some validations and here is its report:
- KVM Validation: normal (except selftest_mptcp_join): Success! ✅
- KVM Validation: normal (only selftest_mptcp_join): Success! ✅
- KVM Validation: debug (except selftest_mptcp_join): Success! ✅
- KVM Validation: debug (only selftest_mptcp_join): Success! ✅
- KVM Validation: btf-normal (only bpftest_all): Success! ✅
- KVM Validation: btf-debug (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/20688424112
Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/6ca2d68f2a7c
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=1038151
If there are some issues, you can reproduce them using the same environment as the one used by the CI thanks to a docker image, e.g.:
$ cd [kernel source code]
$ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
--pull always mptcp/mptcp-upstream-virtme-docker:latest \
auto-normalFor more details:
https://github.com/multipath-tcp/mptcp-upstream-virtme-docker
Please note that despite all the efforts that have been already done to have a stable tests suite when executed on a public CI like here, it is possible some reported issues are not due to your modifications. Still, do not hesitate to help us improve that ;-)
Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)