mm: Coccinelle-driven cleanups across memory
Subsystems (4)
v5 cover mm: Coccinelle-driven cleanups across memory
This patch series contains minor changes identified by Coccinelle scripts under scripts/coccinelle/misc/:
* Use the %pe printk format specifier for PTR_ERR() reporting in vmscan.c and zswap.c
Found using:
make coccicheck MODE=report M=mm/
change since v4:
- Remove use of ALIGN() macro as it caused infinite loop in case page was already aligned.
change since v3:
- Update the commit message to highlight change in computation of boundary using ALIGN().
changes since v1 and v2:
- Patch 1/3: update return value as per review comments.
- patch 2/3 and 3/3: Add Acked-by and Reviewed-by tags.
link to v1: https://lore.kernel.org/all/[email protected]/
link to v2: https://lore.kernel.org/all/[email protected]/
link to v3: https://lore.kernel.org/all/[email protected]/
link to v4: https://lore.kernel.org/all/[email protected]/
Sahil Chandna (2):
mm/vmscan: use %pe to print error pointers
mm/zswap: use %pe to print error pointers
mm/vmscan.c | 4 ++-- mm/zswap.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)
Signature · 1 line
2.50.1
PATCH v5 1/2 mm/vmscan: use %pe to print error pointers
Use the %pe printk format specifier to report error pointers directly instead of printing PTR_ERR() as a long value. This improves clarity, produces more readable error messages.
This instance was flagged by the Coccinelle script (misc/ptr_err_to_pe.cocci) as an opportunity to adopt %pe.
Found by: make coccicheck MODE=report M=mm/
No functional change intended
---
changes since v2:
- Add Acked-by tag
link to v2: https://lore.kernel.org/all/64e15c6b2ce86d7824f54e9e001b6f5b44af48b8.1763796152.git.chandna.sahil@gmail.com/
link to v3: https://lore.kernel.org/all/db049e564cafcb0913bee930d6a577ea43044f5b.1764177933.git.chandna.sahil@gmail.com/
link to v4: https://lore.kernel.org/all/2c842a64fddeb0fe0cac087783aaedd97edc3191.1764312627.git.chandna.sahil@gmail.com/
--- mm/vmscan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
mm/vmscan.c +2 -2
@@ -7479,8 +7479,8 @@ void __meminit kswapd_run(int nid) pgdat->kswapd =kthread_create_on_node (kswapd, pgdat, nid,"kswapd%d" , nid);if (IS_ERR (pgdat->kswapd)) {/* failure at boot is fatal */ -pr_err ("Failed to start kswapd on node %d,ret=%ld\n" , - nid,PTR_ERR (pgdat->kswapd)); +pr_err ("Failed to start kswapd on node %d, ret=%pe\n" , + nid, pgdat->kswapd);BUG_ON (system_state <SYSTEM_RUNNING ); pgdat->kswapd =NULL ; }else {
Signature · 1 line
2.50.1
PATCH v5 2/2 mm/zswap: use %pe to print error pointers
In reply to Sahil ChandnaUse the %pe printk format specifier to report error pointers directly instead of printing PTR_ERR() as a long value. This improves clarity, produces more readable error messages.
This instance was flagged by the Coccinelle script (misc/ptr_err_to_pe.cocci) as an opportunity to adopt %pe.
Found by: make coccicheck MODE=report M=mm/
No functional change intended.
---
Changes since v2:
- Add Acked-by tag.
link to v2: https://lore.kernel.org/all/0c00ceedce6e0d9aed35cee5faf15fd9126a1f70.1763796152.git.chandna.sahil@gmail.com/
link to v3: https://lore.kernel.org/all/57b7205813aa87c8f5c8bf765e5a8d88daeba68f.1764177933.git.chandna.sahil@gmail.com/
link to v4: https://lore.kernel.org/all/6d729a60eb71baade3670e5bb609a068683af3eb.1764312627.git.chandna.sahil@gmail.com/
--- mm/zswap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
mm/zswap.c +2 -2
@@ -749,8 +749,8 @@ static int zswap_cpu_comp_prepare(unsigned int cpu, struct hlist_node *node) acomp =crypto_alloc_acomp_node (pool->tfm_name,0 ,0 ,cpu_to_node (cpu));if (IS_ERR (acomp)) { -pr_err ("could not alloc crypto acomp %s : %ld\n" , - pool->tfm_name,PTR_ERR (acomp)); +pr_err ("could not alloc crypto acomp %s : %pe\n" , + pool->tfm_name, acomp); ret =PTR_ERR (acomp); goto fail; }
Signature · 1 line
2.50.1