Skip to contentSkip to conversation

Pull request

PATCH In review Yoann Congal 2 participants 4 messages Apr 10 – Apr 11

lore
Share & tools
lore
#0 lore raw

cover Pull request

This is a last minute fix about the git:// protocol migration. It passed oe-selftest:
https://autobuilder.yoctoproject.org/valkyrie/#/builders/69/builds/209

The following changes since commit f2bc121f821f684a541b1f4e317078c50d29c389:

scripts/install-buildtools: Update to 4.0.34 (2026-04-10 00:51:17 +0200)

are available in the Git repository at:

https://git.openembedded.org/openembedded-core-contrib stable/kirkstone-next
https://git.openembedded.org/openembedded-core-contrib/log/?h=stable/kirkstone-next

for you to fetch changes up to b507de6d469890f14d153c0eb48361d97d24a71e:

oeqa/selftest/git-submodule-test: Default to https git protocol for YP/OE repos (2026-04-10 13:26:01 +0200)

----------------------------------------------------------------

Yoann Congal (1):
oeqa/selftest/git-submodule-test: Default to https git protocol for
YP/OE repos

 .../recipes-test/git-submodule-test/git-submodule-test.bb     | 4 ++--
 meta/lib/oeqa/selftest/cases/archiver.py                      | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
#1 lore raw

PATCH 1/1 oeqa/selftest/git-submodule-test: Default to https git protocol for YP/OE repos

From: Yoann Congal <[email protected]>

Following up on commit 139102a73d41 ("recipes: Default to https git protocol where possible"),

Quoted 3 lines

The recommendation from server maintainers is that the https protocol is both faster and more reliable than the dedicated git protocol at this point. Switch to it where possible.

Use ";protocol=https" for the parent git submodule and, also, update the SRCREV to point to a commit where submodules are reference through a
https:// URL instead of a git:// one.

Update the expected output of the archiver test.

---
 .../recipes-test/git-submodule-test/git-submodule-test.bb     | 4 ++--
 meta/lib/oeqa/selftest/cases/archiver.py                      | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
meta-selftest/recipes-test/git-submodule-test/git-submodule-test.bb +2 -2
index fa3041b7d8f..3f66cf6919d 100644
@@ -5,8 +5,8 @@ LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/MIT;md5=0835ade698e0bcf8506ecda
 
 INHIBIT_DEFAULT_DEPS = "1"
 
-SRC_URI = "gitsm://git.yoctoproject.org/git-submodule-test;branch=master"
-SRCREV = "a2885dd7d25380d23627e7544b7bbb55014b16ee"
+SRC_URI = "gitsm://git.yoctoproject.org/git-submodule-test;branch=master;protocol=https"
+SRCREV = "f280847494763cdcf71197557a81ba7d8a6bce42"
 
 S = "${WORKDIR}/git"
 
meta/lib/oeqa/selftest/cases/archiver.py +2 -2
index 75195241b79..ad2dd2dda65 100644
@@ -301,8 +301,8 @@ class Archiver(OESelftestTestCase):
 
         bb_vars = get_bb_vars(['DEPLOY_DIR_SRC'])
         for target_file_name in [
-            'gitsmshallow_git.yoctoproject.org.git-submodule-test_a2885dd-1_master.tar.gz',
-            'gitsmshallow_git.yoctoproject.org.bitbake-gitsm-test1_bare_120f4c7-1.tar.gz',
+            'gitsmshallow_git.yoctoproject.org.git-submodule-test_f280847-1_master.tar.gz',
+            'gitsmshallow_git.yoctoproject.org.bitbake-gitsm-test1_bare_79a0efa-1.tar.gz',
             'gitsmshallow_git.yoctoproject.org.bitbake-gitsm-test2_bare_f66699e-1.tar.gz',
             'gitsmshallow_git.openembedded.org.bitbake_bare_52a144a-1.tar.gz',
             'gitsmshallow_git.openembedded.org.bitbake_bare_c39b997-1.tar.gz'
#2 lore raw

Re: [OE-core][kirkstone 1/1] oeqa/selftest/git-submodule-test: Default to https git protocol for YP/OE repos

Quoted 41 lines · Yoann Congal via lists.openembedded.org

From: Yoann Congal <[email protected]>

Following up on commit 139102a73d41 ("recipes: Default to https git protocol where possible"),

Quoted 3 lines

The recommendation from server maintainers is that the https protocol is both faster and more reliable than the dedicated git protocol at this point. Switch to it where possible.

Use ";protocol=https" for the parent git submodule and, also, update the SRCREV to point to a commit where submodules are reference through a
https:// URL instead of a git:// one.

Update the expected output of the archiver test.

---
 .../recipes-test/git-submodule-test/git-submodule-test.bb     | 4 ++-- meta/lib/oeqa/selftest/cases/archiver.py                      | 4 ++--

 2 files changed, 4 insertions(+), 4 deletions(-)
meta-selftest/recipes-test/git-submodule-test/git-submodule-test.bb +0 -0
index fa3041b7d8f..3f66cf6919d 100644
@@ -5,8 +5,8 @@ LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/MIT;md5=0835ade698e0bcf8506ecda


 INHIBIT_DEFAULT_DEPS = "1"

meta-selftest/recipes-test/git-submodule-test/git-submodule-test.bb +2 -2
-SRC_URI = "gitsm://git.yoctoproject.org/git-submodule-test;branch=master"
-SRCREV = "a2885dd7d25380d23627e7544b7bbb55014b16ee"
+SRC_URI = "gitsm://git.yoctoproject.org/git-submodule-test;branch=master;protocol=https"
+SRCREV = "f280847494763cdcf71197557a81ba7d8a6bce42"


 S = "${WORKDIR}/git"

meta/lib/oeqa/selftest/cases/archiver.py +0 -0
index 75195241b79..ad2dd2dda65 100644
@@ -301,8 +301,8 @@ class Archiver(OESelftestTestCase):


         bb_vars = get_bb_vars(['DEPLOY_DIR_SRC'])

Quoted 8 lines

         for target_file_name in [
-            'gitsmshallow_git.yoctoproject.org.git-submodule-test_a2885dd-1_master.tar.gz', -            'gitsmshallow_git.yoctoproject.org.bitbake-gitsm-test1_bare_120f4c7-1.tar.gz', +            'gitsmshallow_git.yoctoproject.org.git-submodule-test_f280847-1_master.tar.gz', +            'gitsmshallow_git.yoctoproject.org.bitbake-gitsm-test1_bare_79a0efa-1.tar.gz', 'gitsmshallow_git.yoctoproject.org.bitbake-gitsm-test2_bare_f66699e-1.tar.gz', 'gitsmshallow_git.openembedded.org.bitbake_bare_52a144a-1.tar.gz', 'gitsmshallow_git.openembedded.org.bitbake_bare_c39b997-1.tar.gz'

Does master need that? At a quick look it probably should...

I'm wondering if this should be using an isolated downloads directory for the test and it is seeing files from previous builds?

Cheers,

Richard

#3 lore raw

Re: [OE-core][kirkstone 1/1] oeqa/selftest/git-submodule-test: Default to https git protocol for YP/OE repos

Quoted 63 lines · Richard Purdie
Quoted 3 lines · Yoann Congal via lists.openembedded.org

From: Yoann Congal <[email protected]>

Following up on commit 139102a73d41 ("recipes: Default to https git

protocol where possible"),

Quoted 2 lines
Quoted 2 lines

The recommendation from server maintainers is that the https protocol is both faster and more reliable than the dedicated git protocol at

this point.

Quoted 8 lines
Quoted 1 line

Switch to it where possible.

Use ";protocol=https" for the parent git submodule and, also, update the SRCREV to point to a commit where submodules are reference through a
https:// URL instead of a git:// one.

Update the expected output of the archiver test.

Review

Quoted 7 lines
---
 .../recipes-test/git-submodule-test/git-submodule-test.bb     | 4 ++--
 meta/lib/oeqa/selftest/cases/archiver.py                      | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
(quoted diff) +0 -0

git-submodule-test.bb b/meta-selftest/recipes-test/git-submodule-test/ git-submodule-test.bb

Quoted 2 lines

index fa3041b7d8f..3f66cf6919d 100644
--- a/meta-selftest/recipes-test/git-submodule-test/

git-submodule-test.bb

Quoted 1 line

+++ b/meta-selftest/recipes-test/git-submodule-test/

git-submodule-test.bb

Review LIC_FILES_CHKSUM =

Quoted 1 line
(quoted diff) +0 -0
@@ -5,8 +5,8 @@ LIC_FILES_CHKSUM =

"file://${COMMON_LICENSE_DIR}/MIT;md5=0835ade698e0bcf8506ecda

meta-selftest/recipes-test/git-submodule-test/git-submodule-test.bb LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/MIT;md5=0835ade698e0bcf8506ecda

Quoted 4 lines
meta-selftest/recipes-test/git-submodule-test/git-submodule-test.bb +0 -1
 INHIBIT_DEFAULT_DEPS = "1"
 
-SRC_URI = "gitsm://

git.yoctoproject.org/git-submodule-test;branch=master"

Review LIC_FILES_CHKSUM = · line 7

Quoted 2 lines
(quoted diff) +1 -1
-SRCREV = "a2885dd7d25380d23627e7544b7bbb55014b16ee"
+SRC_URI = "gitsm://

git.yoctoproject.org/git-submodule-test;branch=master;protocol=https"

Review

Quoted 5 lines
meta-selftest/recipes-test/git-submodule-test/git-submodule-test.bb +1 -0
+SRCREV = "f280847494763cdcf71197557a81ba7d8a6bce42"
 
 S = "${WORKDIR}/git"
 
(quoted diff) +0 -0

b/meta/lib/oeqa/selftest/cases/archiver.py

meta/lib/oeqa/selftest/cases/archiver.py class Archiver(OESelftestTestCase): · line 304

Quoted 8 lines

index 75195241b79..ad2dd2dda65 100644

meta/lib/oeqa/selftest/cases/archiver.py +0 -1
@@ -301,8 +301,8 @@ class Archiver(OESelftestTestCase):
 
         bb_vars = get_bb_vars(['DEPLOY_DIR_SRC'])
         for target_file_name in [
-

'gitsmshallow_git.yoctoproject.org.git-submodule-test_a2885dd-1_master.tar.gz',

meta/lib/oeqa/selftest/cases/archiver.py class Archiver(OESelftestTestCase): · line 305

Quoted 1 line
meta/lib/oeqa/selftest/cases/archiver.py +0 -1
-

'gitsmshallow_git.yoctoproject.org.bitbake-gitsm-test1_bare_120f4c7-1.tar.gz',

meta/lib/oeqa/selftest/cases/archiver.py class Archiver(OESelftestTestCase): · line 304

Quoted 1 line
meta/lib/oeqa/selftest/cases/archiver.py +1 -0
+

'gitsmshallow_git.yoctoproject.org.git-submodule-test_f280847-1_master.tar.gz',

meta/lib/oeqa/selftest/cases/archiver.py class Archiver(OESelftestTestCase): · line 305

Quoted 1 line
meta/lib/oeqa/selftest/cases/archiver.py +1 -0
+

'gitsmshallow_git.yoctoproject.org.bitbake-gitsm-test1_bare_79a0efa-1.tar.gz',

Quoted 1 line
Quoted 8 lines

'gitsmshallow_git.yoctoproject.org.bitbake-gitsm-test2_bare_f66699e-1.tar.gz',

Quoted 1 line

'gitsmshallow_git.openembedded.org.bitbake_bare_52a144a-1.tar.gz',

Quoted 1 line

'gitsmshallow_git.openembedded.org.bitbake_bare_c39b997-1.tar.gz'

Does master need that? At a quick look it probably should...

Yes it does need it. And this is not the only reference patched on kirkstone that is not patch on master, I will send the series to master as soon as possible.

Quoted 4 lines

I'm wondering if this should be using an isolated downloads directory for the test and it is seeing files from previous builds?

Yes, surely.

But more generally, a universe fetch, on a empty dl_dir and a blocked
git:// protocol (can be done locally with a firewall rule, don't know about doing that on AB) should be interesting...

Regards,

Quoted 5 lines

Cheers,

Richard