Skip to contentSkip to conversation

arm64: dts: imx8mm-var-som-symphony: minor board updates

PATCH Applied Stefano Radaelli 3 participants 5 messages Jun 3 – Jun 29

Subsystems (2)
Device tree bindings Arm i.MX and Layerscape
lore
Share & tools
lore

Stefano Radaelli

author
#0 lore raw

cover arm64: dts: imx8mm-var-som-symphony: minor board updates

This series contains minor updates for the Variscite Symphony carrier board based on the current hardware configuration.

It updates the RGB_SEL handling and marks the relevant input devices as wakeup sources.

Stefano Radaelli (2):
arm64: dts: imx8mm-var-som-symphony: add wakeup sources
arm64: dts: imx8mm-var-som-symphony: keep RGB_SEL low

 .../boot/dts/freescale/imx8mm-var-som-symphony.dts   | 12 ++++++++++++
 1 file changed, 12 insertions(+)

base-commit: be580423d3f84b84a2f549df91e66bc4f54eda02

Signature · 1 line
2.47.3
author
#1 lore raw

PATCH 1/2 arm64: dts: imx8mm-var-som-symphony: add wakeup sources

From: Stefano Radaelli <[email protected]>

Mark the Symphony carrier board GPIO keys and capacitive touchscreen as wakeup sources.

Signed-off-by Stefano Radaelli <[email protected]>
---
 arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dts | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dts +4 -0
index 857325ef4461..090752014ee2 100644
@@ -55,18 +55,21 @@ key-back {
 			label = "Back";
 			gpios = <&pca9534 1 GPIO_ACTIVE_LOW>;
 			linux,code = <KEY_BACK>;
+			wakeup-source;
 		};
 
 		key-home {
 			label = "Home";
 			gpios = <&pca9534 2 GPIO_ACTIVE_LOW>;
 			linux,code = <KEY_HOME>;
+			wakeup-source;
 		};
 
 		key-menu {
 			label = "Menu";
 			gpios = <&pca9534 3 GPIO_ACTIVE_LOW>;
 			linux,code = <KEY_MENU>;
+			wakeup-source;
 		};
 	};
 

@@ -187,6 +190,7 @@ ft5x06_ts: touchscreen@38 {
 		touchscreen-size-y = <480>;
 		touchscreen-inverted-x;
 		touchscreen-inverted-y;
+		wakeup-source;
 	};
 
 	rtc@68 {
Signature · 1 line
2.47.3
author
#2 lore raw

PATCH 2/2 arm64: dts: imx8mm-var-som-symphony: keep RGB_SEL low

In reply to Stefano Radaelli

From: Stefano Radaelli <[email protected]>

Keep the RGB_SEL line driven low on the Symphony carrier board.

This avoids leaving the line floating and ensures the board remains in the expected display configuration.

Signed-off-by Stefano Radaelli <[email protected]>
---
 arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dts | 8 ++++++++
 1 file changed, 8 insertions(+)
arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dts +8 -0
index 090752014ee2..fd0a1862ce90 100644
@@ -168,6 +168,14 @@ pca6408: gpio@21 {
 		reg = <0x21>;
 		gpio-controller;
 		#gpio-cells = <2>;
+
+		/* RGB_SEL */
+		lvds-brg-enable-hog {
+			gpio-hog;
+			gpios = <7 GPIO_ACTIVE_HIGH>;
+			output-low;
+			line-name = "rgb_sel";
+		};
 	};
 
 	st33ktpm2xi2c: tpm@2e {
Signature · 1 line
2.47.3
AI review
#3 lore raw

Re: [PATCH v1 2/2] arm64: dts: imx8mm-var-som-symphony: keep RGB_SEL low

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The newly added gpio-hog node is named `lvds-brg-enable-hog`, but it is documented to control the…

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly added gpio-hog node is named lvds-brg-enable-hog, but it is documented to control the RGB_SEL line and its line-name property is set to rgb_sel. This is likely a copy-paste error. --

commit 9c97f65e1888df2bd494aacf3412a0fd8cf0a5db
Author: Stefano Radaelli <[email protected]>

arm64: dts: imx8mm-var-som-symphony: keep RGB_SEL low

This commit drives the RGB_SEL line low on the Symphony carrier board. It does this by adding a gpio-hog subnode to the pca6408 GPIO controller to ensure the board remains in the expected display configuration.

arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dts pca6408: gpio@21 { · line 173

Quoted 10 lines
arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dts +3 -0
@@ -168,6 +168,14 @@ pca6408: gpio@21 {
 		reg = <0x21>;
 		gpio-controller;
 		#gpio-cells = <2>;
+
+		/* RGB_SEL */
+		lvds-brg-enable-hog {

[Severity: Low]
This isn't a bug, but is this node name a copy-paste error? It is documented to control RGB_SEL and sets the line-name to "rgb_sel", so a name like rgb-sel-hog might be more appropriate to avoid confusion.

Quoted 6 lines
arch/arm64/boot/dts/freescale/imx8mm-var-som-symphony.dts +5 -0
+			gpio-hog;
+			gpios = <7 GPIO_ACTIVE_HIGH>;
+			output-low;
+			line-name = "rgb_sel";
+		};
 	};
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=2
Applied
#4 lore raw
In reply to Stefano Radaelli

From: Frank Li <[email protected]>

Quoted 11 lines · Stefano Radaelli

This series contains minor updates for the Variscite Symphony carrier board based on the current hardware configuration.

It updates the RGB_SEL handling and marks the relevant input devices as wakeup sources.

Stefano Radaelli (2):
arm64: dts: imx8mm-var-som-symphony: add wakeup sources
arm64: dts: imx8mm-var-som-symphony: keep RGB_SEL low

[...]

Applied, thanks!

[1/2] arm64: dts: imx8mm-var-som-symphony: add wakeup sources

      commit: b376fc7db933785a5a89446ed0748ebb7709c1c6
[2/2] arm64: dts: imx8mm-var-som-symphony: keep RGB_SEL low
      commit: 7294b6214493075806a032227691781a2df94fc9

Best regards,

Signature · 1 line
Frank Li <[email protected]>