Skip to contentSkip to conversation

sc59x: Disable CONFIG_EFI_LOADER

PATCH Superseded Caleb Ethridge 2 participants 5 messages Aug 5 – Aug 10

lore
Share & tools
lore
#0 lore raw

cover sc59x: Disable CONFIG_EFI_LOADER

From: Caleb Ethridge <[email protected]>

The sc5xx boards do not use UEFI support, so CONFIG_EFI_LOADER brings in unused code in the build. This is already disabled for every board except for the sc598 and sc594 variants, this series extends this exclusion to those boards.

Caleb Ethridge (2):
configs: adi: sc598: disable CONFIG_EFI_LOADER
configs: adi: sc594: disable CONFIG_EFI_LOADER

 configs/sc594-som-ezkit-spl_defconfig  | 1 +
 configs/sc594-som-ezlite-spl_defconfig | 2 +-
 configs/sc598-som-ezkit-spl_defconfig  | 2 +-
 configs/sc598-som-ezlite-spl_defconfig | 2 +-
 4 files changed, 4 insertions(+), 3 deletions(-)
Signature · 1 line
2.43.0
#1 lore raw

PATCH 1/2 configs: adi: sc598: disable CONFIG_EFI_LOADER

From: Caleb Ethridge <[email protected]>

The SC598 boards do not use UEFI support, so CONFIG_EFI_LOADER brings in unused code. Disable CONFIG_EFI_LOADER for the sc598-som-ezkit and sc598-som-ezlite defconfigs.

---
 configs/sc598-som-ezkit-spl_defconfig  | 2 +-
 configs/sc598-som-ezlite-spl_defconfig | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
configs/sc598-som-ezkit-spl_defconfig +1 -1
index bf001459831..1c6e4ea613a 100644
@@ -32,6 +32,7 @@ CONFIG_CDU0_CLKO10=5
 CONFIG_CDU0_CLKO12=1
 CONFIG_CDU0_CLKO13=3
 CONFIG_CDU0_CLKO14=3
+# CONFIG_EFI_LOADER is not set
 CONFIG_FIT=y
 CONFIG_FIT_SIGNATURE=y
 CONFIG_LEGACY_IMAGE_FORMAT=y
@@ -110,4 +111,3 @@ CONFIG_USB=y
 CONFIG_USB_DWC2=y
 CONFIG_USB_STORAGE=y
 # CONFIG_SPL_CRC8 is not set
-# CONFIG_TOOLS_MKEFICAPSULE is not set
configs/sc598-som-ezlite-spl_defconfig +1 -1
index 09fda4f4ecc..b3c347c6804 100644
@@ -32,6 +32,7 @@ CONFIG_CDU0_CLKO10=5
 CONFIG_CDU0_CLKO12=1
 CONFIG_CDU0_CLKO13=3
 CONFIG_CDU0_CLKO14=3
+# CONFIG_EFI_LOADER is not set
 CONFIG_FIT=y
 CONFIG_FIT_SIGNATURE=y
 CONFIG_LEGACY_IMAGE_FORMAT=y
@@ -108,4 +109,3 @@ CONFIG_USB=y
 CONFIG_USB_DWC2=y
 CONFIG_USB_STORAGE=y
 # CONFIG_SPL_CRC8 is not set
-# CONFIG_TOOLS_MKEFICAPSULE is not set
Signature · 1 line
2.43.0
#2 lore raw

PATCH 2/2 configs: adi: sc594: disable CONFIG_EFI_LOADER

In reply to Caleb Ethridge

From: Caleb Ethridge <[email protected]>

The SC594 boards do not use UEFI support, CONFIG_EFI_LOADER brings in unused code. Disable CONFIG_EFI_LOADER for the sc594-som-ezkit and sc594-som-ezlite defconfigs.

---
 configs/sc594-som-ezkit-spl_defconfig  | 1 +
 configs/sc594-som-ezlite-spl_defconfig | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
configs/sc594-som-ezkit-spl_defconfig +1 -0
index c62097a2ac9..b157849060e 100644
@@ -14,6 +14,7 @@ CONFIG_SPL_SERIAL=y
 CONFIG_SC59X=y
 CONFIG_TARGET_SC594_SOM_EZKIT=y
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
+# CONFIG_EFI_LOADER is not set
 CONFIG_FIT=y
 CONFIG_FIT_SIGNATURE=y
 CONFIG_LEGACY_IMAGE_FORMAT=y
configs/sc594-som-ezlite-spl_defconfig +1 -1
index 39481351102..dadff29f827 100644
@@ -17,6 +17,7 @@ CONFIG_CDU0_CLKO10=5
 CONFIG_SF_DEFAULT_BUS=0
 CONFIG_SF_DEFAULT_CS=0
 # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set
+# CONFIG_EFI_LOADER is not set
 CONFIG_FIT=y
 CONFIG_FIT_SIGNATURE=y
 CONFIG_LEGACY_IMAGE_FORMAT=y
@@ -86,4 +87,3 @@ CONFIG_USB=y
 CONFIG_USB_DWC2=y
 CONFIG_USB_STORAGE=y
 # CONFIG_SPL_CRC8 is not set
-# CONFIG_TOOLS_MKEFICAPSULE is not set
Signature · 1 line
2.43.0
#3 lore raw
In reply to Caleb Ethridge

Hi Caleb,

Quoted 12 lines · Caleb Ethridge

From: Caleb Ethridge <[email protected]>

The sc5xx boards do not use UEFI support, so CONFIG_EFI_LOADER brings in unused code in the build. This is already disabled for every board except for the sc598 and sc594 variants, this series extends this exclusion to those boards.

Caleb Ethridge (2):
configs: adi: sc598: disable CONFIG_EFI_LOADER
configs: adi: sc594: disable CONFIG_EFI_LOADER

Quoted 9 lines
 configs/sc594-som-ezkit-spl_defconfig  | 1 +
 configs/sc594-som-ezlite-spl_defconfig | 2 +-
 configs/sc598-som-ezkit-spl_defconfig  | 2 +-
 configs/sc598-som-ezlite-spl_defconfig | 2 +-
 4 files changed, 4 insertions(+), 3 deletions(-)

--
2.43.0

This series fails to apply to uboot/main for me.

I only see

# CONFIG_TOOLS_MKEFICAPSULE is not set

in sc594-som-ezlite-spl_defconfig. and the other diffs are missing changes introduced in c6796425da45f ("arm: sc5xx: Remove SC5XX_LOADADDR"), so I think you need to rebase on top of main to pick them up.

Thanks,
Greg

#4 lore raw

Hey Greg,

It looks like the old patch series was based against master instead of main. I have rebased everything on the top of main and resubmitted.

Thanks,

Caleb