KVM: selftests: add powerpc support
Subsystems (3)
v6 cover KVM: selftests: add powerpc support
Patch v5 -> v6:
================
(Suggestions from Sean):
1. Dropped kvm_create_max_vcpu, hardware_disable_test and their respective plumbing.
2. Bundled the enablement and the fixes for few of the tests together to avoid the ordering issues.
Patch v4 -> v5:
==============
- Fixed the issues reported by Anushree while running on kvm on powervm (nested).
- Fixed memslot_perf_test on powerpc.
PATCH v3 -> PATCH v4:
==================
- Rebased on top of Sean's new page allocator patch series v2 [1] This allowed to drop and patch-2 since it will now come from Sean's v2.
- Addressed review comments from Sean - squashed patches 6-10 in patch-1 of this.
- Dropped patch-5 to print vcpu_id when KVM_CREATE_VCPU ioctl fails.
- Added additional patch-3 to this series to allow dirty_log_test to run on all big-endian machines.
[1]: https://lore.kernel.org/kvm/[email protected]/
[v3]: https://lore.kernel.org/linuxppc-dev/2d2c46be7f051c7f1c645afaec67f57067d37a81.1781093720.git.ritesh.list@gmail.com/
Testing updates:
================
I have done some fair amount of testing of the selftests both on real HW and using various combinations on qemu (powernv+LE (default), pseries+cap-nested-hv, pseries+cap-nested-papr, powernv+BE). There were few powerpc kvm kernel fixes which were identified as part of this work. I will send those patches separately as those anyway needs to go in separately.
<pasted snippet of cover letter from previous versions>
=======================================================
Hi All,
This series primarly adds KVM selftests support for powerpc (64-bit, BookS, radix MMU).
This patch series is originally Nick's work. I have mainly only rebased it on the latest upstream tree. Since the rebase required few changes to all the four patches (Patch 1-4), I have dropped the earlier Acked-by from Michael Ellerman.
Since the last series was posted three years ago [1], I am resetting the version to RFC. This rebase was done as part of a larger effort to improve the selftests infrastructure for Linux on PowerPC tree. Thanks to Harsh and Maddy for their help on this.
Nicholas Piggin (1):
KVM: PPC: selftests: add support for powerpc
Ritesh Harjani (IBM) (4):
KVM: selftests: Move memslot_perf_test off the 256M ELF load address
KVM: PPC: selftests: Add helper for checking if running nested
KVM: PPC: selftests: Skip idle-page check when running nested on pseries LPAR
KVM: selftests: Don't limit LE dirty-bitmap bitops to s390x
MAINTAINERS | 2 + tools/testing/selftests/kvm/Makefile | 2 +- tools/testing/selftests/kvm/Makefile.kvm | 15 + .../selftests/kvm/access_tracking_perf_test.c | 11 + tools/testing/selftests/kvm/dirty_log_test.c | 12 +- .../testing/selftests/kvm/include/kvm_util.h | 9 + .../selftests/kvm/include/powerpc/hcall.h | 17 + .../kvm/include/powerpc/kvm_util_arch.h | 22 + .../selftests/kvm/include/powerpc/ppc_asm.h | 32 ++ .../selftests/kvm/include/powerpc/processor.h | 46 ++ .../selftests/kvm/include/powerpc/ucall.h | 21 + tools/testing/selftests/kvm/lib/guest_modes.c | 20 +- tools/testing/selftests/kvm/lib/kvm_util.c | 8 + .../selftests/kvm/lib/powerpc/handlers.S | 93 ++++ .../testing/selftests/kvm/lib/powerpc/hcall.c | 45 ++ .../selftests/kvm/lib/powerpc/processor.c | 512 ++++++++++++++++++ .../testing/selftests/kvm/lib/powerpc/ucall.c | 22 + .../testing/selftests/kvm/memslot_perf_test.c | 2 +- 18 files changed, 879 insertions(+), 12 deletions(-) create mode 100644 tools/testing/selftests/kvm/include/powerpc/hcall.h create mode 100644 tools/testing/selftests/kvm/include/powerpc/kvm_util_arch.h create mode 100644 tools/testing/selftests/kvm/include/powerpc/ppc_asm.h create mode 100644 tools/testing/selftests/kvm/include/powerpc/processor.h create mode 100644 tools/testing/selftests/kvm/include/powerpc/ucall.h create mode 100644 tools/testing/selftests/kvm/lib/powerpc/handlers.S create mode 100644 tools/testing/selftests/kvm/lib/powerpc/hcall.c create mode 100644 tools/testing/selftests/kvm/lib/powerpc/processor.c create mode 100644 tools/testing/selftests/kvm/lib/powerpc/ucall.c
--
2.39.5
PATCH v6 1/5 KVM: PPC: selftests: add support for powerpc
From: Nicholas Piggin <[email protected]>
Implement KVM selftests support for powerpc (Book3S-64).
ucalls are implemented with an unsupported PAPR hcall number which will always cause KVM to exit to userspace.
Virtual memory is implemented for the radix MMU, and only a base page size is supported (both 4K and 64K).
Guest interrupts are taken in real-mode, so require a page allocated at gRA 0x0. Interrupt entry is complicated because gVA:gRA is not 1:1 mapped (like the kernel is), so the MMU can not just be switched on and off.
This patch series also changes the following types as done in other selftests. These changes are squashed in this main patch as discussed here [1]:
- Use u64 instead of uint64_t
- Use s64 instead of int64_t
- Use u32 instead of uint32_t
- Use u8 instead of uint8_t
- Replace u64 gpa, u64 gva|vaddr with gpa_t and gva_t
- Adopt to the new page table allocator APIs
- Start the guest at the entry point and not the descriptor in case of elfv1
[1]: https://lore.kernel.org/linuxppc-dev/[email protected]/
[Rebased to latest mainline tree, "cc" to clobber list, fix the
size calculation in kvm_arch_vm_post_create()]
--- MAINTAINERS | 2 + tools/testing/selftests/kvm/Makefile | 2 +- tools/testing/selftests/kvm/Makefile.kvm | 12 + .../testing/selftests/kvm/include/kvm_util.h | 9 + .../selftests/kvm/include/powerpc/hcall.h | 17 + .../kvm/include/powerpc/kvm_util_arch.h | 22 + .../selftests/kvm/include/powerpc/ppc_asm.h | 32 ++ .../selftests/kvm/include/powerpc/processor.h | 39 ++ .../selftests/kvm/include/powerpc/ucall.h | 21 + tools/testing/selftests/kvm/lib/guest_modes.c | 20 +- tools/testing/selftests/kvm/lib/kvm_util.c | 8 + .../selftests/kvm/lib/powerpc/handlers.S | 93 ++++ .../testing/selftests/kvm/lib/powerpc/hcall.c | 45 ++ .../selftests/kvm/lib/powerpc/processor.c | 512 ++++++++++++++++++ .../testing/selftests/kvm/lib/powerpc/ucall.c | 22 + 15 files changed, 853 insertions(+), 3 deletions(-) create mode 100644 tools/testing/selftests/kvm/include/powerpc/hcall.h create mode 100644 tools/testing/selftests/kvm/include/powerpc/kvm_util_arch.h create mode 100644 tools/testing/selftests/kvm/include/powerpc/ppc_asm.h create mode 100644 tools/testing/selftests/kvm/include/powerpc/processor.h create mode 100644 tools/testing/selftests/kvm/include/powerpc/ucall.h create mode 100644 tools/testing/selftests/kvm/lib/powerpc/handlers.S create mode 100644 tools/testing/selftests/kvm/lib/powerpc/hcall.c create mode 100644 tools/testing/selftests/kvm/lib/powerpc/processor.c create mode 100644 tools/testing/selftests/kvm/lib/powerpc/ucall.c
MAINTAINERS +2 -0
@@ -14349,6 +14349,8 @@ F: arch/powerpc/include/asm/kvm* F: arch/powerpc/include/uapi/asm/kvm* F: arch/powerpc/kernel/kvm* F: arch/powerpc/kvm/ +F: tools/testing/selftests/kvm/*/powerpc/ +F: tools/testing/selftests/kvm/powerpc/ KERNEL VIRTUAL MACHINE FOR RISC-V (KVM/riscv) M: Anup Patel <[email protected]>
tools/testing/selftests/kvm/Makefile +1 -1
@@ -3,7 +3,7 @@ top_srcdir = ../../../.. include $(top_srcdir)/scripts/subarch.include ARCH ?= $(SUBARCH) -ifeq ($(ARCH),$(filter $(ARCH),arm64 s390 riscv x86 x86_64 loongarch)) +ifeq ($(ARCH),$(filter $(ARCH),arm64 s390 riscv x86 x86_64 loongarch powerpc)) # Top-level selftests allows ARCH=x86_64 :-( ifeq ($(ARCH),x86_64) override ARCH := x86
tools/testing/selftests/kvm/Makefile.kvm +12 -0
@@ -53,6 +53,11 @@ LIBKVM_loongarch += lib/loongarch/processor.c LIBKVM_loongarch += lib/loongarch/ucall.c LIBKVM_loongarch += lib/loongarch/exception.S +LIBKVM_powerpc += lib/powerpc/handlers.S +LIBKVM_powerpc += lib/powerpc/processor.c +LIBKVM_powerpc += lib/powerpc/ucall.c +LIBKVM_powerpc += lib/powerpc/hcall.c + # Non-compiled test targets TEST_PROGS_x86 += x86/nx_huge_pages_test.sh
@@ -251,6 +256,13 @@ TEST_GEN_PROGS_loongarch += memslot_perf_test TEST_GEN_PROGS_loongarch += set_memory_region_test TEST_GEN_PROGS_loongarch += steal_time +TEST_GEN_PROGS_powerpc = demand_paging_test +TEST_GEN_PROGS_powerpc += guest_print_test +TEST_GEN_PROGS_powerpc += kvm_binary_stats_test +TEST_GEN_PROGS_powerpc += kvm_page_table_test +TEST_GEN_PROGS_powerpc += set_memory_region_test +TEST_GEN_PROGS_powerpc += memslot_modification_stress_test + SPLIT_TESTS += arch_timer SPLIT_TESTS += get-reg-list
tools/testing/selftests/kvm/include/kvm_util.h +9 -0
@@ -241,6 +241,9 @@ enum vm_guest_mode {VM_MODE_P41V48_4K ,VM_MODE_P41V39_4K , +VM_MODE_P52V52_4K ,/* For powerpc64 */ +VM_MODE_P52V52_64K , + NUM_VM_MODES, };
@@ -300,6 +303,12 @@ extern enum vm_guest_mode vm_mode_default;#define MIN_PAGE_SHIFT 12U#define ptes_per_page (page_size) ((page_size) / 8) +#elif defined(__powerpc64__) + +#define VM_MODE_DEFAULT vm_mode_default +#define MIN_PAGE_SHIFT 12U +#define ptes_per_page (page_size) ((page_size) / 8) +#endif #define VM_SHAPE_DEFAULT VM_SHAPE(VM_MODE_DEFAULT)
tools/testing/selftests/kvm/include/powerpc/hcall.h new file +17 -0
@@ -0,0 +1,17 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* +* powerpc hcall defines +*/ +#ifndef SELFTEST_KVM_HCALL_H +#define SELFTEST_KVM_HCALL_H + +#include <linux/compiler.h> + +/* Ucalls use unimplemented PAPR hcall 0 which exits KVM */ +#define H_UCALL 0 + +s64 hcall0 (u64 token); +s64 hcall1 (u64 token,u64 arg1); +s64 hcall2 (u64 token,u64 arg1,u64 arg2); + +#endif
tools/testing/selftests/kvm/include/powerpc/kvm_util_arch.h new file +22 -0
@@ -0,0 +1,22 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef SELFTEST_KVM_UTIL_ARCH_H +#define SELFTEST_KVM_UTIL_ARCH_H + +#include <stdint.h> + +#include "kvm_util_types.h" + +struct kvm_mmu_arch {}; + +/* Page table fragment cache for guest page tables < page size */ +struct vm_pt_frag_cache { +gpa_t page; +size_t page_nr_used; +}; + +struct kvm_vm_arch { +gpa_t prtb;/* process table */ +struct vm_pt_frag_cache pt_frag_cache[2 ];/* 256B and 4KB PT caches */ +}; + +#endif /* SELFTEST_KVM_UTIL_ARCH_H */
tools/testing/selftests/kvm/include/powerpc/ppc_asm.h new file +32 -0
@@ -0,0 +1,32 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* +* powerpc asm specific defines +*/ +#ifndef SELFTEST_KVM_PPC_ASM_H +#define SELFTEST_KVM_PPC_ASM_H + +#define STACK_FRAME_MIN_SIZE 112/* Could be 32 on ELFv2 */ +#define STACK_REDZONE_SIZE 512 + +#define INT_FRAME_SIZE (STACK_FRAME_MIN_SIZE + STACK_REDZONE_SIZE) + +#define SPR_SRR0 0x01a +#define SPR_SRR1 0x01b +#define SPR_CFAR 0x01c + +#define MSR_SF 0x8000000000000000ULL +#define MSR_HV 0x1000000000000000ULL +#define MSR_VEC 0x0000000002000000ULL +#define MSR_VSX 0x0000000000800000ULL +#define MSR_EE 0x0000000000008000ULL +#define MSR_PR 0x0000000000004000ULL +#define MSR_FP 0x0000000000002000ULL +#define MSR_ME 0x0000000000001000ULL +#define MSR_IR 0x0000000000000020ULL +#define MSR_DR 0x0000000000000010ULL +#define MSR_RI 0x0000000000000002ULL +#define MSR_LE 0x0000000000000001ULL + +#define LPCR_ILE 0x0000000002000000ULL + +#endif
tools/testing/selftests/kvm/include/powerpc/processor.h new file +39 -0
@@ -0,0 +1,39 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* +* powerpc processor specific defines +*/ +#ifndef SELFTEST_KVM_PROCESSOR_H +#define SELFTEST_KVM_PROCESSOR_H + +#include <linux/compiler.h> +#include "ppc_asm.h" +#include "kvm_util_types.h" + +extern unsigned char __interrupts_start[]; +extern unsigned char __interrupts_end[]; + +struct kvm_vm ; +struct kvm_vcpu ; + +struct ex_regs { +u64 gprs[32 ]; +u64 nia; +u64 msr; +u64 cfar; +u64 lr; +u64 ctr; +u64 xer; +u32 cr; +u32 trap; +gva_t gva;/* gva of this struct */ +}; + +void vm_install_exception_handler (struct kvm_vm *vm,int vector, +void (*handler)(struct ex_regs *)); + +static inline void cpu_relax (void ) +{ + asmvolatile ("" :::"memory" ); +} + +#endif
tools/testing/selftests/kvm/include/powerpc/ucall.h new file +21 -0
@@ -0,0 +1,21 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef SELFTEST_KVM_UCALL_H +#define SELFTEST_KVM_UCALL_H + +#include "hcall.h" + +#define UCALL_EXIT_REASON KVM_EXIT_PAPR_HCALL + +#define UCALL_R4_UCALL 0x5715/* regular ucall, r5 contains ucall pointer */ +#define UCALL_R4_SIMPLE 0x0000/* simple exit usable by asm with no ucall data */ + +static inline void ucall_arch_init (struct kvm_vm *vm,gpa_t mmio_gpa) +{ +} + +static inline void ucall_arch_do_ucall (gva_t uc) +{ +hcall2 (H_UCALL ,UCALL_R4_UCALL , (uintptr_t )(uc)); +} + +#endif
tools/testing/selftests/kvm/lib/guest_modes.c +18 -2
@@ -4,16 +4,20 @@*/ #include "guest_modes.h" -#if defined(__aarch64__) || defined(__riscv) +#if defined(__aarch64__) || defined(__riscv) || defined(__powerpc64__)#include "processor.h" enum vm_guest_mode vm_mode_default;#endif +#if defined(__powerpc64__) +#include <unistd.h> +#endif +struct guest_mode guest_modes[NUM_VM_MODES ];void guest_modes_append_default (void ) { -#if !defined(__aarch64__) && !defined(__riscv) +#if !defined(__aarch64__) && !defined(__riscv) && !defined(__powerpc64__)guest_mode_append (VM_MODE_DEFAULT , true);#endif
@@ -108,6 +112,18 @@ void guest_modes_append_default(void) TEST_ASSERT(vm_mode_default != NUM_VM_MODES, "No supported mode!"); }#endif +#ifdef __powerpc64__ + { +TEST_REQUIRE (kvm_has_cap (KVM_CAP_PPC_MMU_RADIX)); +/* Radix guest EA and RA are 52-bit on POWER9 and POWER10 */ +if (sysconf (_SC_PAGESIZE) ==4096 ) + vm_mode_default =VM_MODE_P52V52_4K ; +else + vm_mode_default =VM_MODE_P52V52_64K ; +guest_mode_append (VM_MODE_P52V52_4K , true); +guest_mode_append (VM_MODE_P52V52_64K , true); + } +#endif }void for_each_guest_mode (void (*func)(enum vm_guest_mode ,void *),void *arg)
tools/testing/selftests/kvm/lib/kvm_util.c +8 -0
@@ -227,6 +227,8 @@ const char *vm_guest_mode_string(u32 i) [VM_MODE_P41V57_4K] = "PA-bits:41, VA-bits:57, 4K pages", [VM_MODE_P41V48_4K] = "PA-bits:41, VA-bits:48, 4K pages", [VM_MODE_P41V39_4K] = "PA-bits:41, VA-bits:39, 4K pages", + [VM_MODE_P52V52_4K] = "PA-bits:52, VA-bits:52, 4K pages", + [VM_MODE_P52V52_64K ] ="PA-bits:52, VA-bits:52, 64K pages" , };_Static_assert (sizeof (strings)/sizeof (char *) ==NUM_VM_MODES ,"Missing new mode strings?" );
@@ -263,6 +265,8 @@ const struct vm_guest_mode_params vm_guest_mode_params[] = { [VM_MODE_P41V57_4K] = { 41, 57, 0x1000, 12 }, [VM_MODE_P41V48_4K] = { 41, 48, 0x1000, 12 }, [VM_MODE_P41V39_4K] = { 41, 39, 0x1000, 12 }, + [VM_MODE_P52V52_4K] = { 52, 52, 0x1000, 12 }, + [VM_MODE_P52V52_64K] = { 52, 52, 0x10000, 16 }, };_Static_assert (sizeof (vm_guest_mode_params)/sizeof (struct vm_guest_mode_params ) ==NUM_VM_MODES ,"Missing new mode params?" );
@@ -383,6 +387,10 @@ struct kvm_vm *____vm_create(struct vm_shape shape)case VM_MODE_P41V39_4K : vm->mmu.pgtable_levels =3 ;break ; +case VM_MODE_P52V52_4K : +case VM_MODE_P52V52_64K : + vm->mmu.pgtable_levels =4 ; +break ;default :TEST_FAIL ("Unknown guest mode: 0x%x" , vm->mode); }
tools/testing/selftests/kvm/lib/powerpc/handlers.S new file +93 -0
93 lines not on this page · raw message
tools/testing/selftests/kvm/lib/powerpc/hcall.c new file +45 -0
45 lines not on this page · raw message
tools/testing/selftests/kvm/lib/powerpc/processor.c new file +512 -0
512 lines not on this page · raw message
tools/testing/selftests/kvm/lib/powerpc/ucall.c new file +22 -0
@@ -0,0 +1,22 @@ +// SPDX-License-Identifier: GPL-2.0 +/* +* ucall support. A ucall is a "hypercall to host userspace". +*/ +#include "kvm_util.h" +#include "ucall_common.h" +#include "hcall.h" + +void *ucall_arch_get_ucall (struct kvm_vcpu *vcpu) +{ +struct kvm_run *run = vcpu->run; + +if (run->exit_reason ==UCALL_EXIT_REASON && + run->papr_hcall.nr ==H_UCALL ) { +struct kvm_regs regs; + +vcpu_regs_get (vcpu, ®s); +if (regs.gpr[4 ] ==UCALL_R4_UCALL ) +return (void *)regs.gpr[5 ]; + } +return NULL ; +}
Signature · 1 line
2.39.5
[email protected]
AI reviewRe: [PATCH v6 1/5] KVM: PPC: selftests: add support for powerpc
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] selftests: build failure due to undeclared memory allocation functions --
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] selftests: build failure due to undeclared memory allocation functions --
commit 504c1ed58b27eced07a127f9dbb77eee82c18970
Author: Nicholas Piggin <[email protected]>
Subject: KVM: PPC: selftests: add support for powerpc
This commit implements KVM selftests support for powerpc (Book3S-64). However, it introduces build failures because of calls to undeclared memory allocation functions.
Quoted 6 lines
tools/testing/selftests/kvm/lib/powerpc/processor.c new file +0
-0
tools/testing/selftests/kvm/lib/powerpc/processor.c line 59
Quoted 8 lines
tools/testing/selftests/kvm/lib/powerpc/processor.c new file +6
-0@@ -0,0 +1,512 @@ +void virt_arch_pgd_alloc (struct kvm_vm *vm) +{ + pgd_pages = (1UL << (RADIX_PGD_INDEX_SIZE +3 )) >> vm->page_shift; +if (!pgd_pages) + pgd_pages =1 ; + pgtb =vm_alloc_page_table_pages (vm, pgd_pages);
[Severity: Low]
Is the definition of vm_alloc_page_table_pages missing? This causes the module to fail compiling and linking because the function is undefined.
tools/testing/selftests/kvm/lib/powerpc/processor.c line 172
Quoted 10 lines
tools/testing/selftests/kvm/lib/powerpc/processor.c new file +9
-0+ vm->mmu.pgd = pgtb; +static gpa_t __vm_alloc_pt (struct kvm_vm *vm,u64 pt_shift) +{ +gpa_t pt; + +if (pt_shift >= vm->page_shift) { +size_t pt_pages =1ULL << (pt_shift - vm->page_shift); + + pt =vm_alloc_page_table_pages (vm, pt_pages);
[Severity: Low]
Does this code also rely on the undefined vm_alloc_page_table_pages function?
Quoted 8 lines
tools/testing/selftests/kvm/lib/powerpc/processor.c new file +7
-0+ }else { +void kvm_arch_vm_post_create (struct kvm_vm *vm,unsigned int nr_vcpus) +{ +size_t excp_size = __interrupts_end - __interrupts_start; +size_t excp_pages = (excp_size + vm->page_size -1 ) / vm->page_size; +gpa_t excp_paddr; +void *mem;
tools/testing/selftests/kvm/lib/powerpc/processor.c line 434
Quoted 10 lines
tools/testing/selftests/kvm/lib/powerpc/processor.c new file +10
-0+ +/* +* Guest interrupts are taken in real-mode, i.e. the vectors must live +* at gPA 0. Use the innermost allocator to override the minimum GPA +* that MEM_REGION_DATA would otherwise impose. +*/ + excp_paddr =____vm_phy_pages_alloc (vm, excp_pages,0 , + vm->memslots[MEM_REGION_DATA ], +vm_arch_has_protected_memory (vm), + false);
[Severity: Low]
Could this call to an undeclared function ____vm_phy_pages_alloc be a mistake? This call passes 6 arguments, which differs from the standard 5 arguments.
Quoted 2 lines
tools/testing/selftests/kvm/lib/powerpc/processor.c new file +2
-0+ + TEST_ASSERT(excp_paddr == 0,
Signature · 1 line
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
PATCH v6 2/5 KVM: selftests: Move memslot_perf_test off the 256M ELF load address
In reply to Ritesh Harjani (IBM)KVM selftests are built with -fno-PIE/-no-pie so the binary uses fixed load addresses.
On powerpc64, GNU ld default links at 0x10000000 (256M) which is also the MEM_GPA, so the identity map trips with the error:
PTE already present at level: 4 gva: 0x10000000 pte:0xc00000000002018f
Put the test slots at 512M instead which is past the ELF. e.g. failure w/o this fix:
./memslot_perf_test -s 514
Random seed: 0x423558ef
Testing map performance with 1 runs, 5 seconds each
==== Test Assertion Failure ====
lib/powerpc/processor.c:235: !pte
pid=371 tid=371 errno=2 - No such file or directory
1 0x0000000010018293: virt_arch_pg_map at processor.c:235
2 0x0000000010008b3f: virt_pg_map at kvm_util.h:1325
3 (inlined by) virt_map at kvm_util.c:1571
4 0x0000000010001cab: prepare_vm at memslot_perf_test.c:353
5 (inlined by) test_execute at memslot_perf_test.c:816
6 (inlined by) test_loop at memslot_perf_test.c:1062
7 (inlined by) main at memslot_perf_test.c:1136
8 0x000000001001d713: __libc_start_call_main at libc-start.o:?
9 0x000000001001db47: __libc_start_main_impl at ??:? PTE already present at level: 4 gva: 0x10000000 pte:0xc00000000002018f
--- tools/testing/selftests/kvm/Makefile.kvm | 1 + tools/testing/selftests/kvm/memslot_perf_test.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-)
tools/testing/selftests/kvm/Makefile.kvm +1 -0
@@ -262,6 +262,7 @@ TEST_GEN_PROGS_powerpc += kvm_binary_stats_test TEST_GEN_PROGS_powerpc += kvm_page_table_test TEST_GEN_PROGS_powerpc += set_memory_region_test TEST_GEN_PROGS_powerpc += memslot_modification_stress_test +TEST_GEN_PROGS_powerpc += memslot_perf_test SPLIT_TESTS += arch_timer SPLIT_TESTS += get-reg-list
tools/testing/selftests/kvm/memslot_perf_test.c +1 -1
@@ -30,7 +30,7 @@#define MEM_EXTRA_SIZE SZ_64K#define MEM_SIZE (SZ_512M + MEM_EXTRA_SIZE) -#define MEM_GPA SZ_256M +#define MEM_GPA SZ_512M#define MEM_AUX_GPA MEM_GPA#define MEM_SYNC_GPA MEM_AUX_GPA#define MEM_TEST_GPA (MEM_AUX_GPA + MEM_EXTRA_SIZE)
Signature · 1 line
2.39.5
PATCH v6 3/5 KVM: PPC: selftests: Add helper for checking if running nested
In reply to Ritesh Harjani (IBM)access_tracking_perf_test needs detection if we are running nested guests. This adds the needed helper.
--- tools/testing/selftests/kvm/include/powerpc/processor.h | 7 +++++++ 1 file changed, 7 insertions(+)
tools/testing/selftests/kvm/include/powerpc/processor.h +7 -0
@@ -6,6 +6,8 @@#define SELFTEST_KVM_PROCESSOR_H #include <linux/compiler.h> +#include <unistd.h> +#include "ppc_asm.h" #include "kvm_util_types.h"
@@ -36,4 +38,9 @@ static inline void cpu_relax(void) asm volatile("" ::: "memory"); } +static inline bool is_pseries_lpar (void ) +{ +return !access ("/proc/device-tree/rtas/ibm,hypertas-functions" ,F_OK ); +} +#endif
Signature · 1 line
2.39.5
PATCH v6 4/5 KVM: PPC: selftests: Skip idle-page check when running nested on pseries LPAR
In reply to Ritesh Harjani (IBM)Same nested TLB/access bit issue like x86. Use the is_pseries_lpar() check to detect when running nested kvm on pseries LPAR to only warn on idle-page check.
--- tools/testing/selftests/kvm/Makefile.kvm | 1 + .../testing/selftests/kvm/access_tracking_perf_test.c | 11 +++++++++++ 2 files changed, 12 insertions(+)
tools/testing/selftests/kvm/Makefile.kvm +1 -0
@@ -263,6 +263,7 @@ TEST_GEN_PROGS_powerpc += kvm_page_table_test TEST_GEN_PROGS_powerpc += set_memory_region_test TEST_GEN_PROGS_powerpc += memslot_modification_stress_test TEST_GEN_PROGS_powerpc += memslot_perf_test +TEST_GEN_PROGS_powerpc += access_tracking_perf_test SPLIT_TESTS += arch_timer SPLIT_TESTS += get-reg-list
tools/testing/selftests/kvm/access_tracking_perf_test.c +11 -0
@@ -470,6 +470,17 @@ static int access_tracking_unreliable(void)puts ("Skipping idle page count sanity check, because the test is run nested" ); return 1; } +#endif +#ifdef __powerpc64__ +/* +* Nested KVM (pSeries LPAR) can hide accessed/idle, since KVM doesn't +* explicitely flush the TLB for access bit update. L0 keeps +* translations cached so the guest won't see the idle bit cleared. +*/ +if (is_pseries_lpar ()) { +puts ("Skipping idle page count sanity check, because the test is run nested" ); +return 1 ; + }#endif /* * When NUMA balancing is enabled, guest memory will be unmapped to get
Signature · 1 line
2.39.5
PATCH v6 5/5 KVM: selftests: Don't limit LE dirty-bitmap bitops to s390x
In reply to Ritesh Harjani (IBM)dirty_log_test already has BITOP_LE_SWIZZLE helpers, but they were compiled in only for s390x, so every other big-endian host used native test_bit().
The test fails on big-endian powerpc because it treated dirty host pages as clean (because of the endianness issue)
w/o the fix the test fails with:
Clear page 1 value (1) >= iteration (1)
--- tools/testing/selftests/kvm/Makefile.kvm | 1 + tools/testing/selftests/kvm/dirty_log_test.c | 12 ++++-------- 2 files changed, 5 insertions(+), 8 deletions(-)
tools/testing/selftests/kvm/Makefile.kvm +1 -0
@@ -264,6 +264,7 @@ TEST_GEN_PROGS_powerpc += set_memory_region_test TEST_GEN_PROGS_powerpc += memslot_modification_stress_test TEST_GEN_PROGS_powerpc += memslot_perf_test TEST_GEN_PROGS_powerpc += access_tracking_perf_test +TEST_GEN_PROGS_powerpc += dirty_log_test SPLIT_TESTS += arch_timer SPLIT_TESTS += get-reg-list
tools/testing/selftests/kvm/dirty_log_test.c +4 -8
@@ -44,8 +44,11 @@#define TEST_MIN_WRITES_PER_ITERATION 0x100/* Dirty bitmaps are always little endian, so we need to swap on big endian */ -#if defined(__s390x__) +#if __BYTE_ORDER__ == __ORDER_BIG_ENDIAN__# define BITOP_LE_SWIZZLE ((BITS_PER_LONG-1) & ~0x7) +#else +# define BITOP_LE_SWIZZLE 0 +#endif # define test_bit_le (nr, addr) \ test_bit((nr) ^ BITOP_LE_SWIZZLE, addr)# define __set_bit_le (nr, addr) \
@@ -56,13 +59,6 @@ __test_and_set_bit((nr) ^ BITOP_LE_SWIZZLE, addr)# define __test_and_clear_bit_le (nr, addr) \ __test_and_clear_bit((nr) ^ BITOP_LE_SWIZZLE, addr) -#else -# define test_bit_le test_bit -# define __set_bit_le __set_bit -# define __clear_bit_le __clear_bit -# define __test_and_set_bit_le __test_and_set_bit -# define __test_and_clear_bit_le __test_and_clear_bit -#endif #define TEST_DIRTY_RING_COUNT 65536
--
2.39.5