Skip to contentSkip to conversation

media: atomisp: remove unused functions

PATCH New Avishek Chaulagain 1 participant 4 messages Nov 16

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

v2 cover media: atomisp: remove unused functions

These three functions have no callers anywhere in the tree. Remove each unused function along with its declaration and the now-stale leading comment that described it.

Found via a tree-wide search for functions whose name appears only in their definition and prototype, and compile-tested under allmodconfig.

Changes since v1:
- Also remove the now-stale leading comments that described each removed function; v1 deleted the functions but left those comments dangling above unrelated code. (Dan Carpenter, Andy Shevchenko)

v1: https://lore.kernel.org/all/[email protected]/

Avishek Chaulagain (3):
media: atomisp: Remove unused any_virq_signal()
media: atomisp: Remove unused get_sp_code_addr()
media: atomisp: Remove unused hmm_flush()

 drivers/staging/media/atomisp/include/hmm/hmm.h           | 1 -
 .../media/atomisp/pci/hive_isp_css_common/host/irq.c      | 8 --------
 .../atomisp/pci/hive_isp_css_include/host/irq_public.h    | 6 ------
 drivers/staging/media/atomisp/pci/hmm/hmm.c               | 6 ------
 .../atomisp/pci/runtime/spctrl/interface/ia_css_spctrl.h  | 3 ---
 .../staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c | 5 -----
 6 files changed, 29 deletions(-)
Signature · 1 line
2.43.0
#1 lore raw

PATCH v2 1/3 media: atomisp: Remove unused any_virq_signal()

any_virq_signal() has no callers anywhere in the tree. Remove the unused function and its declaration.

---
 .../media/atomisp/pci/hive_isp_css_common/host/irq.c      | 8 --------
 .../atomisp/pci/hive_isp_css_include/host/irq_public.h    | 6 ------
 2 files changed, 14 deletions(-)
drivers/staging/media/atomisp/pci/hive_isp_css_common/host/irq.c +0 -8
index 61dea3863..f1b01f5f9 100644
@@ -215,14 +215,6 @@ void irq_raise(
 	return;
 }
 
-bool any_virq_signal(void)
-{
-	unsigned int irq_status = irq_reg_load(IRQ0_ID,
-					       _HRT_IRQ_CONTROLLER_STATUS_REG_IDX);
-
-	return (irq_status != 0);
-}
-
 void cnd_virq_enable_channel(
     const enum virq_id				irq_ID,
     const bool					en)
drivers/staging/media/atomisp/pci/hive_isp_css_include/host/irq_public.h +0 -6
index 901e10f87..b487b7f31 100644
@@ -103,12 +103,6 @@ void irq_raise(
     const irq_ID_t				ID,
     const irq_sw_channel_id_t	irq_id);
 
-/*! Test if any IRQ channel of the virtual super IRQ has raised a signal
-
- \return any(VIRQ.channel[irq_ID] != 0)
- */
-bool any_virq_signal(void);
-
 /*! Enable an IRQ channel of the virtual super IRQ
 
  \param	irq[in]				IRQ (channel) identifier
Signature · 1 line
2.43.0
#2 lore raw

PATCH v2 2/3 media: atomisp: Remove unused get_sp_code_addr()

In reply to Avishek Chaulagain

get_sp_code_addr() has no callers anywhere in the tree. Remove the unused function and its declaration.

---
 .../atomisp/pci/runtime/spctrl/interface/ia_css_spctrl.h     | 3 ---
 .../staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c    | 5 -----
 2 files changed, 8 deletions(-)
drivers/staging/media/atomisp/pci/runtime/spctrl/interface/ia_css_spctrl.h +0 -3
index 3cd69284f..f8be93e03 100644
@@ -25,9 +25,6 @@ typedef struct {
 	char      *program_name;    /** not used on hardware, only for simulation */
 } ia_css_spctrl_cfg;
 
-/* Get the code addr in DDR of SP */
-ia_css_ptr get_sp_code_addr(sp_ID_t  sp_id);
-
 /* ! Load firmware on to specfied SP
 */
 int ia_css_spctrl_load_fw(sp_ID_t sp_id,
drivers/staging/media/atomisp/pci/runtime/spctrl/src/spctrl.c +0 -5
index 78f00f07b..49b986351 100644
@@ -104,11 +104,6 @@ void sh_css_spctrl_reload_fw(sp_ID_t sp_id)
 	spctrl_loaded[sp_id] = true;
 }
 
-ia_css_ptr get_sp_code_addr(sp_ID_t  sp_id)
-{
-	return spctrl_cofig_info[sp_id].code_addr;
-}
-
 int ia_css_spctrl_unload_fw(sp_ID_t sp_id)
 {
 	if ((sp_id >= N_SP_ID) || ((sp_id < N_SP_ID) && (!spctrl_loaded[sp_id])))
Signature · 1 line
2.43.0
#3 lore raw

PATCH v2 3/3 media: atomisp: Remove unused hmm_flush()

In reply to Avishek Chaulagain

hmm_flush() has no callers anywhere in the tree. Remove the unused function and its declaration.

---
 drivers/staging/media/atomisp/include/hmm/hmm.h | 1 -
 drivers/staging/media/atomisp/pci/hmm/hmm.c     | 6 ------
 2 files changed, 7 deletions(-)
drivers/staging/media/atomisp/include/hmm/hmm.h +0 -1
index a7aef27f5..545bb52c5 100644
@@ -32,7 +32,6 @@ void hmm_free(ia_css_ptr ptr);
 int hmm_load(ia_css_ptr virt, void *data, unsigned int bytes);
 int hmm_store(ia_css_ptr virt, const void *data, unsigned int bytes);
 int hmm_set(ia_css_ptr virt, int c, unsigned int bytes);
-int hmm_flush(ia_css_ptr virt, unsigned int bytes);
 
 /*
  * get kernel memory physical address from ISP virtual address.
drivers/staging/media/atomisp/pci/hmm/hmm.c +0 -6
index f998b57f9..5dff2edb5 100644
@@ -262,12 +262,6 @@ int hmm_load(ia_css_ptr virt, void *data, unsigned int bytes)
 	return load_and_flush(virt, data, bytes);
 }
 
-/* Flush hmm data from the data cache */
-int hmm_flush(ia_css_ptr virt, unsigned int bytes)
-{
-	return load_and_flush(virt, NULL, bytes);
-}
-
 /* Write function in ISP memory management */
 int hmm_store(ia_css_ptr virt, const void *data, unsigned int bytes)
 {
Signature · 1 line
2.43.0