Skip to contentSkip to conversation

io_uring/rsrc: remove unused constants

PATCH Applied Caleb Sander Mateos 3 participants 3 messages Feb 19, 2025 io_uring

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 io_uring/rsrc: remove unused constants

IO_NODE_ALLOC_CACHE_MAX has been unused since commit fbbb8e991d86 ("io_uring/rsrc: get rid of io_rsrc_node allocation cache") removed the rsrc_node_cache.

IO_RSRC_TAG_TABLE_SHIFT and IO_RSRC_TAG_TABLE_MASK have been unused since commit 7029acd8a950 ("io_uring/rsrc: get rid of per-ring io_rsrc_node list") removed the separate tag table for registered nodes.

---
 io_uring/rsrc.h | 6 ------
 1 file changed, 6 deletions(-)
io_uring/rsrc.h +0 -6
index a6d883c62b22..0297daf02ac7 100644
@@ -2,16 +2,10 @@
 #ifndef IOU_RSRC_H
 #define IOU_RSRC_H
 
 #include <linux/lockdep.h>
 
-#define IO_NODE_ALLOC_CACHE_MAX 32
-
-#define IO_RSRC_TAG_TABLE_SHIFT	(PAGE_SHIFT - 3)
-#define IO_RSRC_TAG_TABLE_MAX	(1U << IO_RSRC_TAG_TABLE_SHIFT)
-#define IO_RSRC_TAG_TABLE_MASK	(IO_RSRC_TAG_TABLE_MAX - 1)
-
 enum {
 	IORING_RSRC_FILE		= 0,
 	IORING_RSRC_BUFFER		= 1,
 };
 
Signature · 1 line
2.45.2
Reviewed-by on v1 1/1
#1 lore raw

Hi,

Quoted 43 lines

-----Original Message-----
From: Caleb Sander Mateos <[email protected]>
Sent: Wednesday, February 19, 2025 11:35 AM
To: Jens Axboe <[email protected]>; Pavel Begunkov <[email protected]>
Cc: Caleb Sander Mateos <[email protected]>; io- [email protected]; [email protected]
Subject: [PATCH] io_uring/rsrc: remove unused constants

IO_NODE_ALLOC_CACHE_MAX has been unused since commit fbbb8e991d86 ("io_uring/rsrc: get rid of io_rsrc_node allocation cache") removed the rsrc_node_cache.

IO_RSRC_TAG_TABLE_SHIFT and IO_RSRC_TAG_TABLE_MASK have been unused since commit 7029acd8a950 ("io_uring/rsrc: get rid of per-ring io_rsrc_node list") removed the separate tag table for registered nodes.

---
 io_uring/rsrc.h | 6 ------
 1 file changed, 6 deletions(-)
io_uring/rsrc.h index renamed from io_uring/rsrc.h +0 -0

a6d883c62b22..0297daf02ac7 100644

io_uring/rsrc.h +0 -7
@@ -2,16 +2,10 @@
 #ifndef IOU_RSRC_H
 #define IOU_RSRC_H
 
 #include <linux/lockdep.h>
 
-#define IO_NODE_ALLOC_CACHE_MAX 32
-
-#define IO_RSRC_TAG_TABLE_SHIFT	(PAGE_SHIFT - 3)
-#define IO_RSRC_TAG_TABLE_MAX	(1U << IO_RSRC_TAG_TABLE_SHIFT)
-#define IO_RSRC_TAG_TABLE_MASK	(IO_RSRC_TAG_TABLE_MAX - 1)
-
 enum {
 	IORING_RSRC_FILE		= 0,
 	IORING_RSRC_BUFFER		= 1,
 };
 
--
Quoted 2 lines

2.45.2

---
Li Zetao

maintainer Applied
#2 lore raw
In reply to Caleb Sander Mateos
Quoted 9 lines · Caleb Sander Mateos

IO_NODE_ALLOC_CACHE_MAX has been unused since commit fbbb8e991d86 ("io_uring/rsrc: get rid of io_rsrc_node allocation cache") removed the rsrc_node_cache.

IO_RSRC_TAG_TABLE_SHIFT and IO_RSRC_TAG_TABLE_MASK have been unused since commit 7029acd8a950 ("io_uring/rsrc: get rid of per-ring io_rsrc_node list") removed the separate tag table for registered nodes.

[...]

Applied, thanks!

[1/1] io_uring/rsrc: remove unused constants

      commit: fb3331f53e3cb1f1505f918f4f33bb0a3a231e4f

Best regards,

Signature · 1 line
Jens Axboe