Skip to contentSkip to conversation

platform/x86: hp-wmi: Add fan control support for OMEN 8C4D

PATCH In review Lauri Sarap 2 participants 2 messages Jun 16 – Jul 1 x86 platform drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 platform/x86: hp-wmi: Add fan control support for OMEN 8C4D

The HP OMEN Transcend 16-u1xxx with board ID 8C4D uses the Victus S fan control path with OMEN v1 thermal profile parameters.

Manual fan control has been tested through the hwmon pwm interface. The legacy OMEN profile path exposes controls but does not change fan speed on this board; the Victus S table with omen_v1_thermal_params provides working fan RPM changes.

Assisted-by Codex:GPT-5
---
 drivers/platform/x86/hp/hp-wmi.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/platform/x86/hp/hp-wmi.c +4 -0
index d1cc6e7d1..ffe229ec0 100644
@@ -221,6 +221,10 @@ static const struct dmi_system_id victus_s_thermal_profile_boards[] __initconst
 		.matches = { DMI_MATCH(DMI_BOARD_NAME, "8BD5") },
 		.driver_data = (void *)&victus_s_thermal_params,
 	},
+	{
+		.matches = { DMI_MATCH(DMI_BOARD_NAME, "8C4D") },
+		.driver_data = (void *)&omen_v1_thermal_params,
+	},
 	{
 		.matches = { DMI_MATCH(DMI_BOARD_NAME, "8C76") },
 		.driver_data = (void *)&omen_v1_thermal_params,

base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731

Signature · 1 line
2.54.0
maintainer
#1 lore raw
Quoted 19 lines · Lauri Sarap

The HP OMEN Transcend 16-u1xxx with board ID 8C4D uses the Victus S fan control path with OMEN v1 thermal profile parameters.

Manual fan control has been tested through the hwmon pwm interface. The legacy OMEN profile path exposes controls but does not change fan speed on this board; the Victus S table with omen_v1_thermal_params provides working fan RPM changes.

Assisted-by Codex:GPT-5
---
 drivers/platform/x86/hp/hp-wmi.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/platform/x86/hp/hp-wmi.c +0 -0
index d1cc6e7d1..ffe229ec0 100644

drivers/platform/x86/hp/hp-wmi.c static const struct dmi_system_id victus_s_thermal_profile_boards[] __initconst · line 230

Quoted 10 lines
drivers/platform/x86/hp/hp-wmi.c +4 -0
@@ -221,6 +221,10 @@ static const struct dmi_system_id victus_s_thermal_profile_boards[] __initconst
 		.matches = { DMI_MATCH(DMI_BOARD_NAME, "8BD5") },
 		.driver_data = (void *)&victus_s_thermal_params,
 	},
+	{
+		.matches = { DMI_MATCH(DMI_BOARD_NAME, "8C4D") },
+		.driver_data = (void *)&omen_v1_thermal_params,
+	},
 	{
 		.matches = { DMI_MATCH(DMI_BOARD_NAME, "8C76") },
 		.driver_data = (void *)&omen_v1_thermal_params,

Thanks for the patch.

hp-wmi driver's .driver_data scope has been expanded. Please check the very changes recently added into the review-ilpo-next branch in the platform drivers repo and adapt this patch accordingly. Then post v2, thank you.

Signature · 1 line
 i.