r8169: improve error message if no dedicated PHY driver is found
Heiner Kallweit
maintainerPATCH RESEND 1/1 r8169: improve error message if no dedicated PHY driver is found
There's a number of consumer mainboards where the BIOS leaves the PHY in a state that it's reporting an invalid PHY ID. To detect such cases add the PHY ID to the error message if no dedicated PHY driver is found.
Signed-off-by Heiner Kallweit <[email protected]>
---
- accidently sent previous version from wrong mail account
--- drivers/net/ethernet/realtek/r8169_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/ethernet/realtek/r8169_main.c +2 -1
@@ -5197,7 +5197,8 @@ static int r8169_mdio_register(struct rtl8169_private *tp)/* Most chip versions fail with the genphy driver. * Therefore ensure that the dedicated PHY driver is loaded. */ -dev_err (&pdev->dev,"realtek.ko not loaded, maybe it needs to be added to initramfs?\n" ); +dev_err (&pdev->dev,"no dedicated PHY driver found for PHY ID 0x%08x, maybe realtek.ko needs to be added to initramfs?\n" , + tp->phydev->phy_id);return -EUNATCH ; }
Signature · 1 line
2.26.2
From: Heiner Kallweit <[email protected]>
Date: Mon, 27 Apr 2020 21:07:00 +0200
Quoted 7 lines
There's a number of consumer mainboards where the BIOS leaves the PHY in a state that it's reporting an invalid PHY ID. To detect such cases add the PHY ID to the error message if no dedicated PHY driver is found.
Signed-off-by Heiner Kallweit <[email protected]>---
- accidently sent previous version from wrong mail account
Applied, thanks.