Skip to contentSkip to conversation

r8169: improve error message if no dedicated PHY driver is found

PATCH RESEND Applied Heiner Kallweit 2 participants 2 messages Apr 27, 2020

Subsystems (3)
lore
Share & tools
lore

Heiner Kallweit

author maintainer
#0 lore raw

PATCH RESEND 1/1 r8169: improve error message if no dedicated PHY driver is found

There's a number of consumer mainboards where the BIOS leaves the PHY in a state that it's reporting an invalid PHY ID. To detect such cases add the PHY ID to the error message if no dedicated PHY driver is found.

---
- accidently sent previous version from wrong mail account

---
 drivers/net/ethernet/realtek/r8169_main.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/ethernet/realtek/r8169_main.c +2 -1
index f70e36c20..7471fae53 100644
@@ -5197,7 +5197,8 @@ static int r8169_mdio_register(struct rtl8169_private *tp)
 		/* Most chip versions fail with the genphy driver.
 		 * Therefore ensure that the dedicated PHY driver is loaded.
 		 */
-		dev_err(&pdev->dev, "realtek.ko not loaded, maybe it needs to be added to initramfs?\n");
+		dev_err(&pdev->dev, "no dedicated PHY driver found for PHY ID 0x%08x, maybe realtek.ko needs to be added to initramfs?\n",
+			tp->phydev->phy_id);
 		return -EUNATCH;
 	}
 
Signature · 1 line
2.26.2
maintainer Applied
#1 lore raw

From: Heiner Kallweit <[email protected]>
Date: Mon, 27 Apr 2020 21:07:00 +0200

Quoted 7 lines

There's a number of consumer mainboards where the BIOS leaves the PHY in a state that it's reporting an invalid PHY ID. To detect such cases add the PHY ID to the error message if no dedicated PHY driver is found.

---
- accidently sent previous version from wrong mail account

Applied, thanks.