Skip to contentSkip to conversation

ACPI: video: Add backlight=native quirk for Dell OptiPlex 7770 AIO

PATCH Applied Jan Schär 3 participants 3 messages Apr 11 – Apr 15

Subsystems (2)
lore
Share & tools
lore

Jan Schär

author
#0 lore raw

PATCH 1/1 ACPI: video: Add backlight=native quirk for Dell OptiPlex 7770 AIO

The Dell OptiPlex 7770 AIO needs the same quirk as the 7760 AIO. The backlight can be controlled with the native controller, intel_backlight, but not with dell_uart_backlight.

I dumped the DSDT using acpidump, acpixtract and iasl, and confirmed that it contains the DELL0501 device. When loading the dell_uart_backlight driver with rmmod dell_uart_backlight, modprobe dell_uart_backlight dyndbg, it reports "Firmware version: GL_Re_V18".

Fixes cd8e468efb4f ("ACPI: video: Add Dell UART backlight controller detection")
---
 drivers/acpi/video_detect.c | 8 ++++++++
 1 file changed, 8 insertions(+)
drivers/acpi/video_detect.c +8 -0
index 4cf74f173c78..4a2132ae28b4 100644
@@ -878,6 +878,14 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
 		DMI_MATCH(DMI_PRODUCT_NAME, "OptiPlex 7760 AIO"),
 		},
 	},
+	{
+	 .callback = video_detect_force_native,
+	 /* Dell OptiPlex 7770 AIO */
+	 .matches = {
+		DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+		DMI_MATCH(DMI_PRODUCT_NAME, "OptiPlex 7770 AIO"),
+		},
+	},
 
 	/*
 	 * Models which have nvidia-ec-wmi support, but should not use it.

base-commit: 591cd656a1bf5ea94a222af5ef2ee76df029c1d2

Signature · 1 line
2.51.0
Reviewed-by on v1 1/1
#1 lore raw

Hi,

Quoted 4 lines · Jan Schär

The Dell OptiPlex 7770 AIO needs the same quirk as the 7760 AIO. The backlight can be controlled with the native controller, intel_backlight, but not with dell_uart_backlight.

Quoted 8 lines

I dumped the DSDT using acpidump, acpixtract and iasl, and confirmed that it contains the DELL0501 device. When loading the dell_uart_backlight driver with rmmod dell_uart_backlight, modprobe dell_uart_backlight dyndbg, it reports "Firmware version: GL_Re_V18".

Fixes cd8e468efb4f ("ACPI: video: Add Dell UART backlight controller detection")

Thanks, patch looks good to me:

Regards,

Hans

Quoted 25 lines
---
 drivers/acpi/video_detect.c | 8 ++++++++
 1 file changed, 8 insertions(+)
drivers/acpi/video_detect.c +8 -0
index 4cf74f173c78..4a2132ae28b4 100644
@@ -878,6 +878,14 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
 		DMI_MATCH(DMI_PRODUCT_NAME, "OptiPlex 7760 AIO"),
 		},
 	},
+	{
+	 .callback = video_detect_force_native,
+	 /* Dell OptiPlex 7770 AIO */
+	 .matches = {
+		DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+		DMI_MATCH(DMI_PRODUCT_NAME, "OptiPlex 7770 AIO"),
+		},
+	},
 
 	/*
 	 * Models which have nvidia-ec-wmi support, but should not use it.

base-commit: 591cd656a1bf5ea94a222af5ef2ee76df029c1d2

maintainer Applied
#2 lore raw
Quoted 13 lines · Hans de Goede

Hi,

Quoted 9 lines · Jan Schär

The Dell OptiPlex 7770 AIO needs the same quirk as the 7760 AIO. The backlight can be controlled with the native controller, intel_backlight, but not with dell_uart_backlight.

I dumped the DSDT using acpidump, acpixtract and iasl, and confirmed that it contains the DELL0501 device. When loading the dell_uart_backlight driver with rmmod dell_uart_backlight, modprobe dell_uart_backlight dyndbg, it reports "Firmware version: GL_Re_V18".

Quoted 7 lines
Quoted 3 lines
Fixes cd8e468efb4f ("ACPI: video: Add Dell UART backlight controller detection")

Thanks, patch looks good to me:

Applied as 7.1-rc material, thanks!

Quoted 26 lines
Quoted 25 lines
---
 drivers/acpi/video_detect.c | 8 ++++++++
 1 file changed, 8 insertions(+)
drivers/acpi/video_detect.c +8 -0
index 4cf74f173c78..4a2132ae28b4 100644
@@ -878,6 +878,14 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
              DMI_MATCH(DMI_PRODUCT_NAME, "OptiPlex 7760 AIO"),
              },
      },
+     {
+      .callback = video_detect_force_native,
+      /* Dell OptiPlex 7770 AIO */
+      .matches = {
+             DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+             DMI_MATCH(DMI_PRODUCT_NAME, "OptiPlex 7770 AIO"),
+             },
+     },
 
      /*
       * Models which have nvidia-ec-wmi support, but should not use it.

base-commit: 591cd656a1bf5ea94a222af5ef2ee76df029c1d2