Skip to contentSkip to conversation

lib: simplify sbi_fifo_inplace_update()

PATCH New Heinrich Schuchardt 4 participants 4 messages Jun 21, 2021 – Jun 22, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lib: simplify sbi_fifo_inplace_update()

Don't assign an unused value to variable index.

Use operator '-=' where applicable.

---
 lib/sbi/sbi_fifo.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
lib/sbi/sbi_fifo.c +2 -2
index 2a5c012..b2395f3 100644
@@ -118,7 +118,7 @@ bool sbi_fifo_reset(struct sbi_fifo *fifo)
 int sbi_fifo_inplace_update(struct sbi_fifo *fifo, void *in,
 			    int (*fptr)(void *in, void *data))
 {
-	int i, index = 0;
+	int i, index;
 	int ret = SBI_FIFO_UNCHANGED;
 	void *entry;
 
@@ -135,7 +135,7 @@ int sbi_fifo_inplace_update(struct sbi_fifo *fifo, void *in,
 	for (i = 0; i < fifo->avail; i++) {
 		index = fifo->tail + i;
 		if (index >= fifo->num_entries)
-			index = index - fifo->num_entries;
+			index -= fifo->num_entries;
 		entry = (void *)fifo->queue + (u32)index * fifo->entry_size;
 		ret = fptr(in, entry);
 

--
2.30.2

#1 lore raw

PATCH 1/1 lib: simplify sbi_fifo_inplace_update()

Quoted 36 lines · Heinrich Schuchardt

Don't assign an unused value to variable index.

Use operator '-=' where applicable.

---
 lib/sbi/sbi_fifo.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
lib/sbi/sbi_fifo.c +2 -3
index 2a5c012..b2395f3 100644
@@ -118,7 +118,7 @@ bool sbi_fifo_reset(struct sbi_fifo *fifo)
 int sbi_fifo_inplace_update(struct sbi_fifo *fifo, void *in,
                            int (*fptr)(void *in, void *data))
 {
-       int i, index = 0;
+       int i, index;
        int ret = SBI_FIFO_UNCHANGED;
        void *entry;
 
@@ -135,7 +135,7 @@ int sbi_fifo_inplace_update(struct sbi_fifo *fifo, void *in,
        for (i = 0; i < fifo->avail; i++) {
                index = fifo->tail + i;
                if (index >= fifo->num_entries)
-                       index = index - fifo->num_entries;
+                       index -= fifo->num_entries;
                entry = (void *)fifo->queue + (u32)index * fifo->entry_size;
                ret = fptr(in, entry);
 
--

2.30.2

Quoted 4 lines

--
opensbi mailing list
opensbi at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/opensbi

Signature · 2 lines
Regards,
Atish
#2 lore raw

PATCH 1/1 lib: simplify sbi_fifo_inplace_update()

In reply to Heinrich Schuchardt

? 2021-06-21???? 21:03 +0200?Heinrich Schuchardt???

Quoted 5 lines

Don't assign an unused value to variable index.

Use operator '-=' where applicable.

Regards,
Xiang W

Quoted 32 lines

---
?lib/sbi/sbi_fifo.c | 4 ++--
?1 file changed, 2 insertions(+), 2 deletions(-)

lib/sbi/sbi_fifo.c +2 -2
index 2a5c012..b2395f3 100644
@@ -118,7 +118,7 @@ bool sbi_fifo_reset(struct sbi_fifo *fifo)
 ?int sbi_fifo_inplace_update(struct sbi_fifo *fifo, void *in,
 ??????????????????????????? int (*fptr)(void *in, void *data))
 ?{
-???????int i, index = 0;
+???????int i, index;
 ????????int ret = SBI_FIFO_UNCHANGED;
 ????????void *entry;
 
@@ -135,7 +135,7 @@ int sbi_fifo_inplace_update(struct sbi_fifo
 *fifo, void *in,
 ????????for (i = 0; i < fifo->avail; i++) {
 ????????????????index = fifo->tail + i;
 ????????????????if (index >= fifo->num_entries)
-???????????????????????index = index - fifo->num_entries;
+???????????????????????index -= fifo->num_entries;

????????????????entry = (void *)fifo->queue + (u32)index * fifo-

Quoted 1 line

entry_size;

????????????????ret = fptr(in, entry);

--
2.30.2

Applied
#3 lore raw

PATCH 1/1 lib: simplify sbi_fifo_inplace_update()

?On 22/06/21, 12:14 PM, "opensbi on behalf of Xiang W" <opensbi-bounces at lists.infradead.org on behalf of [email protected]> wrote:

? 2021-06-21???? 21:03 +0200?Heinrich Schuchardt??? > Don't assign an unused value to variable index. >
> Use operator '-=' where applicable.
>
> Signed-off-by: Heinrich Schuchardt <[email protected]>

Applied this patch to the riscv/opensbi repo.

Regards,
Anup

Quoted 28 lines
---
 lib/sbi/sbi_fifo.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
lib/sbi/sbi_fifo.c +2 -2
index 2a5c012..b2395f3 100644
@@ -118,7 +118,7 @@ bool sbi_fifo_reset(struct sbi_fifo *fifo)
 int sbi_fifo_inplace_update(struct sbi_fifo *fifo, void *in,
                            int (*fptr)(void *in, void *data))
 {
-       int i, index = 0;
+       int i, index;
        int ret = SBI_FIFO_UNCHANGED;
        void *entry;
 
@@ -135,7 +135,7 @@ int sbi_fifo_inplace_update(struct sbi_fifo
 *fifo, void *in,
        for (i = 0; i < fifo->avail; i++) {
                index = fifo->tail + i;
                if (index >= fifo->num_entries)
-                       index = index - fifo->num_entries;
+                       index -= fifo->num_entries;
                entry = (void *)fifo->queue + (u32)index * fifo-
 >entry_size;
                ret = fptr(in, entry);
Quoted 4 lines

--
2.30.2

--
opensbi mailing list
opensbi at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/opensbi