Skip to contentSkip to conversation

Amiga joystick typo (was: Re: Input: fix open/close races in joystick drivers - add a semaphore)

PATCH In review Geert Uytterhoeven 2 participants 3 messages Jul 13, 2005 1 message not in the archive Input drivers

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 Amiga joystick typo (was: Re: Input: fix open/close races in joystick drivers - add a semaphore)

Quoted 11 lines · Linux Kernel Mailing List

tree 11d80109ddc2f61de6a75a37941346100a67a0d1
parent af246041277674854383cf91b8f0b01217b521e8
author Dmitry Torokhov <[email protected]> Sun, 29 May 2005 12:29:52 -0500 committer Dmitry Torokhov <[email protected]> Sun, 29 May 2005 12:29:52 -0500

Input: fix open/close races in joystick drivers - add a semaphore
to the ones that register more than one input device.

 drivers/input/joystick/amijoy.c     |   29 ++++++++++++++++-------------

This patch broke compilation of amijoy. Trivial fix below.

Amiga joystick: Fix typo introduced by fixing the open/close races in 2.6.13-rc1

drivers/input/joystick/amijoy.c +1 -1
@@ -105,7 +105,7 @@ out:
 
 static void amijoy_close(struct input_dev *dev)
 {
-	down(&amijoysem);
+	down(&amijoy_sem);
 	if (!--amijoy_used)
 		free_irq(IRQ_AMIGA_VERTB, amijoy_interrupt);
 	up(&amijoy_sem);

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

maintainer
#2 lore raw
Quoted 6 lines · Geert Uytterhoeven
Quoted 5 lines · Linux Kernel Mailing List

tree 11d80109ddc2f61de6a75a37941346100a67a0d1
parent af246041277674854383cf91b8f0b01217b521e8
author Dmitry Torokhov <[email protected]> Sun, 29 May 2005 12:29:52 -0500 committer Dmitry Torokhov <[email protected]> Sun, 29 May 2005 12:29:52 -0500

Quoted 9 lines
Quoted 6 lines

Input: fix open/close races in joystick drivers - add a semaphore
to the ones that register more than one input device.

 drivers/input/joystick/amijoy.c     |   29 ++++++++++++++++-------------

This patch broke compilation of amijoy. Trivial fix below.

Sorry about that. Question - if I were to build a cross-compiler for amiga what arch is that? Right now I am "compiling" for i386 and hope that I will catch some real errors in between complaints about missing include files and definitions...

Signature · 1 line
Dmitry
#3 lore raw
Quoted 14 lines · Dmitry Torokhov
Quoted 13 lines · Geert Uytterhoeven
Quoted 11 lines · Linux Kernel Mailing List

tree 11d80109ddc2f61de6a75a37941346100a67a0d1
parent af246041277674854383cf91b8f0b01217b521e8
author Dmitry Torokhov <[email protected]> Sun, 29 May 2005 12:29:52 -0500 committer Dmitry Torokhov <[email protected]> Sun, 29 May 2005 12:29:52 -0500

Input: fix open/close races in joystick drivers - add a semaphore
to the ones that register more than one input device.

 drivers/input/joystick/amijoy.c     |   29 ++++++++++++++++-------------
Quoted 7 lines
Quoted 2 lines

This patch broke compilation of amijoy. Trivial fix below.

Sorry about that. Question - if I were to build a cross-compiler for amiga what arch is that? Right now I am "compiling" for i386 and hope that I will catch some real errors in between complaints about missing include files and definitions...

That's either m68k for original Amigas, or ppc for Amigas equipped with an APUS (Amiga Power Up System) CPU upgrade card.

Unfortunately both of them are broken in the main tree. For m68k, our tree is at http://linux-m68k-cvs.ubb.ca/.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds