Skip to contentSkip to conversation

Exporting array data in sysfs

DISCUSSION Rolf Eike Beer 3 participants 9 messages Sep 18, 2006

lore
Share & tools
lore
#0 lore raw

Hi,

I would like to put the contents of an array in sysfs files. I found no simple way to do this, so here are my thoughts in hope someone can hand me a light.

-simple array (array of simple type like int, char* and so on)

needs:
.name, .read, .write, .num, .writenum

When exported a directory "name" is created, containing num()+1 entries. There is one entry for each array entry plus the special entry "n". "cat n" gives you the result of num, writing to num calls writenum to change the number of array members. If writenum is NULL the array has fixed size.

read is read(struct whatever *, int, char *). The second argument gives the array number, the last one the buffer to print to (as usual). write looks similar, just as in existing sysfs interface (e.g. device_create_file()).

-complex array (array of struct)

This is even more tricky. You can't do this now if you don't know the number of entries. If you do you can create a struct device_attribute (or similar) for every entry and have different access functions that "know" their index. This is horribly inefficient and ugly.

Sort of access struct could be:

.name is fmt-string containing %i (or %lli or something like this) .members is an array of structs looking similar to what I described above for the simple array. Now the index gives the index of the struct. .num, .writenum as above

Nesting them is probably not worth it at all as it would look horrible. :)

Thoughts?

#1 lore raw
Quoted 4 lines · Rolf Eike Beer

Hi,

I would like to put the contents of an array in sysfs files. I found no simple way to do this, so here are my thoughts in hope someone can hand me a light.

What is wrong with using an attribute group for this kind of information?

And do you have an example of a place in the kernel where this would be necessary?

thanks,

greg k-h

#2 lore raw
Quoted 9 lines · Greg KH
Quoted 5 lines · Rolf Eike Beer

Hi,

I would like to put the contents of an array in sysfs files. I found no simple way to do this, so here are my thoughts in hope someone can hand me a light.

What is wrong with using an attribute group for this kind of information?

Missing documentation. Yes, this looks like I could use this at least for the simple interfaces (which would be enough).

Eike

#3 lore raw
Quoted 8 lines · Rolf Eike Beer
Quoted 7 lines · Greg KH
Quoted 5 lines · Rolf Eike Beer

Hi,

I would like to put the contents of an array in sysfs files. I found no simple way to do this, so here are my thoughts in hope someone can hand me a light.

Quoted 6 lines
Quoted 2 lines

What is wrong with using an attribute group for this kind of information?

Missing documentation. Yes, this looks like I could use this at least for the simple interfaces (which would be enough).

I imoplemented sysfs arrays and array groups once:

http://www.ussg.iu.edu/hypermail/linux/kernel/0503.2/1155.html

Not sure if it still appliers. Maybe Greg will consider taking it in if there is a user of this code.

Signature · 1 line
Dmitry
#4 lore raw
Quoted 15 lines · Dmitry Torokhov
Quoted 8 lines · Rolf Eike Beer
Quoted 7 lines · Greg KH
Quoted 5 lines · Rolf Eike Beer

Hi,

I would like to put the contents of an array in sysfs files. I found no simple way to do this, so here are my thoughts in hope someone can hand me a light.

Quoted 5 lines
Quoted 2 lines

What is wrong with using an attribute group for this kind of information?

Missing documentation. Yes, this looks like I could use this at least for the simple interfaces (which would be enough).

Quoted 6 lines

I imoplemented sysfs arrays and array groups once:

http://www.ussg.iu.edu/hypermail/linux/kernel/0503.2/1155.html

Not sure if it still appliers. Maybe Greg will consider taking it in if there is a user of this code.

I guess we can add some once it is in :)

It looks good, but I would change some minor things. If there is no read function given I would return -EIO instead of 0, this is how other places do it. The limitation to 999 entries should go. But otherwise it looks very similar to what I had in mind.

Thanks.

Eike

#5 lore raw
Quoted 20 lines · Rolf Eike Beer
Quoted 19 lines · Dmitry Torokhov
Quoted 8 lines · Rolf Eike Beer
Quoted 7 lines · Greg KH
Quoted 5 lines · Rolf Eike Beer

Hi,

I would like to put the contents of an array in sysfs files. I found no simple way to do this, so here are my thoughts in hope someone can hand me a light.

Quoted 5 lines
Quoted 2 lines

What is wrong with using an attribute group for this kind of information?

Missing documentation. Yes, this looks like I could use this at least for the simple interfaces (which would be enough).

I imoplemented sysfs arrays and array groups once:

http://www.ussg.iu.edu/hypermail/linux/kernel/0503.2/1155.html

Quoted 8 lines
Quoted 2 lines

Not sure if it still appliers. Maybe Greg will consider taking it in if there is a user of this code.

I guess we can add some once it is in :)

It looks good, but I would change some minor things. If there is no read function given I would return -EIO instead of 0, this is how other places do it.

Yes, the patch was done when everyone returned 0 instead of -EIO. Also there is kmalloc->kzalloc conversion, etc.

Quoted 1 line

The limitation to 999 entries should go.

It is not really a limitation but rather a safeguard. Do you really expect to have arrays with that many attributes?

Quoted 9 lines

But otherwise it looks very
similar to what I had in mind.

Thanks.

Eike

Signature · 1 line
Dmitry
#6 lore raw
Quoted 9 lines · Dmitry Torokhov
Quoted 5 lines · Rolf Eike Beer
Quoted 1 line · Dmitry Torokhov

http://www.ussg.iu.edu/hypermail/linux/kernel/0503.2/1155.html

The limitation to 999 entries should go.

It is not really a limitation but rather a safeguard. Do you really expect to have arrays with that many attributes?

At least I don't know how much they will be. If the user wants to do crazy things... :) I'm currently hacking on a store_n implementation, perhaps I'll be able to show some code tomorrow.

Eike

#7 lore raw
Quoted 6 lines · Rolf Eike Beer
Quoted 4 lines · Dmitry Torokhov
Quoted 3 lines · Rolf Eike Beer
Quoted 1 line · Dmitry Torokhov

http://www.ussg.iu.edu/hypermail/linux/kernel/0503.2/1155.html

Quoted 9 lines
Quoted 4 lines
Quoted 1 line

The limitation to 999 entries should go.

It is not really a limitation but rather a safeguard. Do you really expect to have arrays with that many attributes?

At least I don't know how much they will be. If the user wants to do crazy things... :) I'm currently hacking on a store_n implementation, perhaps I'll be able to show some code tomorrow.

I do not think you shoudl allow user do crazy things. The memory is kmalloced so there naturally a limit on number of attrinutes that can be created. And I am not sure abot usefulness of resizing form usespace.
Could you give me an example of a user who needs dynamic attribute arrays?

Signature · 1 line
Dmitry
#8 lore raw

Am Montag, 18. September 2006 17:41 schrieb Dmitry Torokhov:

Quoted 15 lines · Rolf Eike Beer
Quoted 5 lines
Quoted 4 lines · Dmitry Torokhov
Quoted 3 lines · Rolf Eike Beer
Quoted 1 line · Dmitry Torokhov

http://www.ussg.iu.edu/hypermail/linux/kernel/0503.2/1155.html

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

The limitation to 999 entries should go.

It is not really a limitation but rather a safeguard. Do you really expect to have arrays with that many attributes?

At least I don't know how much they will be. If the user wants to do crazy things... :) I'm currently hacking on a store_n implementation, perhaps I'll be able to show some code tomorrow.

Quoted 5 lines

I do not think you shoudl allow user do crazy things. The memory is kmalloced so there naturally a limit on number of attrinutes that can be created. And I am not sure abot usefulness of resizing form usespace.
Could you give me an example of a user who needs dynamic attribute arrays?

FPGA device, number of buffers for DMA transfers. 1000 buffers should be enough, but you'll never know what $user will do with his bigmem machine. They will be able to resize anyway. If I don't get it done with 'n' it will be an ioctl. For the moment it fails anyway since sysfs_get_dentry() got removed.

This resizing stuff is purely optional. A 'n' giving me the number of entries would at least help coding since you can easily find out how much space you need for reading everything in the directory. Giving a dynamic n this is racy, but that's another story.

Eike