Skip to contentSkip to conversation

2.6.19 -mm merge plans (input patches)

DISCUSSION Dmitry Torokhov 6 participants 7 messages Sep 20, 2006 – Sep 21, 2006

lore
Share & tools
lore
#0 lore raw
Quoted 2 lines · Andrew Morton

remove-silly-messages-from-input-layer.patch

I firmly believe that we should keep reporting these conditions. This way we can explain why keyboard might be losing keypresses. I am open to changing the message text. Would "atkbd.c: keyboard reported error condition (FYI only)" be better? It is KERN_DEBUG after all.

Quoted 2 lines

stowaway-keyboard-support.patch
stowaway-keyboard-support-update.patch

stowaway driver is in my tree now.

Quoted 1 line

stowaway-vs-driver-tree.patch

This is required for Greg's changes which I am unconvinced are needed.

Quoted 2 lines

input-i8042-disable-keyboard-port-when-panicking-and-blinking.patch i8042-activate-panic-blink-only-in-x.patch

There was a concern that blinking is useful even when not running X. Do you have any input?

Quoted 1 line

wistron-fix-detection-of-special-buttons.patch

Will apply.

Signature · 1 line
Dmitry
#1 lore raw
Quoted 8 lines · On Wed, 20 Sep 2006 17:29:43 -0400 "Dmitry Torokhov"…
Quoted 2 lines · Andrew Morton

remove-silly-messages-from-input-layer.patch

I firmly believe that we should keep reporting these conditions. This way we can explain why keyboard might be losing keypresses. I am open to changing the message text. Would "atkbd.c: keyboard reported error condition (FYI only)" be better? It is KERN_DEBUG after all.

But it irritates some people.

Perhaps we could make the message disable itself after the first 5-10 instances?

Quoted 5 lines
Quoted 2 lines

input-i8042-disable-keyboard-port-when-panicking-and-blinking.patch i8042-activate-panic-blink-only-in-x.patch

There was a concern that blinking is useful even when not running X. Do you have any input?

No, sorry.

#2 lore raw
Quoted 10 lines · Andrew Morton
Quoted 5 lines · On Wed, 20 Sep 2006 17:29:43 -0400 "Dmitry Torokhov"…
Quoted 2 lines

input-i8042-disable-keyboard-port-when-panicking-and-blinking.patch i8042-activate-panic-blink-only-in-x.patch

There was a concern that blinking is useful even when not running X. Do you have any input?

No, sorry.

I found it useful for machines panicking after suspend-to-ram with the video still dark.
I have, however, not seen a machine panicking on resume for quite some time. They just hang :-)

Signature · 3 lines
Stefan Seyfried
QA / R&D Team Mobile Devices        |              "Any ideas, John?"
SUSE LINUX Products GmbH, Nürnberg  | "Well, surrounding them's out." 
#3 lore raw
In reply to Dmitry Torokhov
Quoted 8 lines · Dmitry Torokhov
Quoted 2 lines · Andrew Morton

remove-silly-messages-from-input-layer.patch

I firmly believe that we should keep reporting these conditions. This way we can explain why keyboard might be losing keypresses. I am open to changing the message text. Would "atkbd.c: keyboard reported error condition (FYI only)" be better?

Q: What do you expect users to do when they see the message?

Quoted 1 line

It is KERN_DEBUG after all.

users can, and do read dmesg.

Dave

#4 lore raw
Quoted 12 lines · Dave Jones
Quoted 8 lines · Dmitry Torokhov
Quoted 2 lines · Andrew Morton

remove-silly-messages-from-input-layer.patch

I firmly believe that we should keep reporting these conditions. This way we can explain why keyboard might be losing keypresses. I am open to changing the message text. Would "atkbd.c: keyboard reported error condition (FYI only)" be better?

Q: What do you expect users to do when they see the message?

A: Nothing. But when they tell me that sometimes they lose keystrokes I can ask them if they see it in dmesg. And if they see it there is nothing I can do. Again, if you could suggest a better wording that would not alarm unsuspecting users that would be great.

Signature · 1 line
Dmitry
#5 lore raw
Quoted 10 lines · Dmitry Torokhov
Quoted 9 lines · Dave Jones
Quoted 7 lines · Dmitry Torokhov
Quoted 1 line · Andrew Morton

remove-silly-messages-from-input-layer.patch

I firmly believe that we should keep reporting these conditions. This way we can explain why keyboard might be losing keypresses. I am open to changing the message text. Would "atkbd.c: keyboard reported error condition (FYI only)" be better?

Quoted 6 lines
Quoted 1 line

Q: What do you expect users to do when they see the message?

A: Nothing. But when they tell me that sometimes they lose keystrokes I can ask them if they see it in dmesg. And if they see it there is nothing I can do. Again, if you could suggest a better wording that would not alarm unsuspecting users that would be great.

If it is needed only to answer "does my keyboard work", maybe you could store an error count in the driver, or put it to the event layer. Coupled with a way to retrieve the value (ioctl+evtest,proc,sys,etc), the user can get the information they need, but only when they actually want it.

The networking subsystem seems to store a lot of its error conditions in proc-accessible counters rather than printing a warning. Thus there is precedent for avoiding dmesg spam in this way.

Just my $0.02

- Jim Bruce

#6 lore raw
Quoted 24 lines · James Bruce
Quoted 10 lines · Dmitry Torokhov
Quoted 9 lines · Dave Jones
Quoted 7 lines · Dmitry Torokhov
Quoted 1 line · Andrew Morton

remove-silly-messages-from-input-layer.patch

I firmly believe that we should keep reporting these conditions. This way we can explain why keyboard might be losing keypresses. I am open to changing the message text. Would "atkbd.c: keyboard reported error condition (FYI only)" be better?

Quoted 6 lines
Quoted 1 line

Q: What do you expect users to do when they see the message?

A: Nothing. But when they tell me that sometimes they lose keystrokes I can ask them if they see it in dmesg. And if they see it there is nothing I can do. Again, if you could suggest a better wording that would not alarm unsuspecting users that would be great.

If it is needed only to answer "does my keyboard work", maybe you could store an error count in the driver, or put it to the event layer. Coupled with a way to retrieve the value (ioctl+evtest,proc,sys,etc), the user can get the information they need, but only when they actually want it.

Quoted 4 lines

The networking subsystem seems to store a lot of its error conditions in proc-accessible counters rather than printing a warning. Thus there is precedent for avoiding dmesg spam in this way.

That is actually a pretty good idea. I'll add a sysfs counter attribute and remove that printk, unless there are objections.

Signature · 1 line
Dmitry