ublk_drv: initialize ret variable
Subsystems (2)
PATCH 1/1 ublk_drv: initialize ret variable
clang build fails withdrivers/block/ublk_drv.c:1304:6: error: variable 'ret' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
When the call to ublk_get_device_from_id() fails, ret is used without being initized. So initialize.
Fixes 71f28f3136af ("ublk_drv: add io_uring based userspace block driver")
Signed-off-by Tom Rix <[email protected]>
--- drivers/block/ublk_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/block/ublk_drv.c +1 -1
@@ -1298,7 +1298,7 @@ static int ublk_ctrl_get_queue_affinity(struct io_uring_cmd *cmd)struct ublk_device *ub;unsigned long queue;unsigned int retlen; -int ret; +int ret = -ENODEV ; ub =ublk_get_device_from_id (header->dev_id);if (!ub)
Signature · 1 line
2.27.0
Jens Axboe
maintainerQuoted 5 lines · Tom Rix
clang build fails with
drivers/block/ublk_drv.c:1304:6: error: variable 'ret' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]When the call to
ublk_get_device_from_id()fails, ret is used without being initized. So initialize.
Should already be fixed:
Signature · 1 line
Jens Axboe