ACPI / LPSS: Make PCI dependency explicit
Subsystems (12)
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH v4 1/11 ACPI / LPSS: Make PCI dependency explicit
This code depends on PCI. Compile only when PCI is present.
--- drivers/acpi/Makefile | 3 ++- drivers/acpi/internal.h | 4 ++++ 2 files changed, 6 insertions(+), 1 deletion(-)
drivers/acpi/Makefile +2 -1
@@ -41,7 +41,8 @@ acpi-y += ec.o acpi-$(CONFIG_ACPI_DOCK) += dock.o acpi-$(CONFIG_PCI) += pci_root.o pci_link.o pci_irq.o obj-$(CONFIG_ACPI_MCFG) += pci_mcfg.o -acpi-y += acpi_lpss.o acpi_apd.o +acpi-$(CONFIG_PCI) += acpi_lpss.o +acpi-y += acpi_apd.o acpi-y += acpi_platform.o acpi-y += acpi_pnp.o acpi-$(CONFIG_ARM_AMBA) += acpi_amba.o
drivers/acpi/internal.h +4 -0
@@ -81,7 +81,11 @@ void acpi_debugfs_init(void);#else static inline void acpi_debugfs_init (void ) {return ; }#endif +#ifdef CONFIG_PCI void acpi_lpss_init (void ); +#else +static inline void acpi_lpss_init (void ) {} +#endif void acpi_apd_init (void );
Signature · 1 line
2.19.0
PATCH v4 2/11 ata: pata_acpi: Make PCI dependency explicit
In reply to a message not in the archivePATA_ACPI is a PCI device driver but the PCI dependency has not been explicitly called out.
--- drivers/ata/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/ata/Kconfig +1 -1
@@ -1091,7 +1091,7 @@ comment "Generic fallback / legacy drivers" config PATA_ACPI tristate "ACPI firmware driver for PATA" - depends on ATA_ACPI && ATA_BMDMA + depends on ATA_ACPI && ATA_BMDMA && PCI help This option enables an ACPI method driver which drives motherboard PATA controller interfaces through the ACPI
Signature · 1 line
2.19.0
PATCH v4 3/11 vga-switcheroo: make PCI dependency explicit
In reply to a message not in the archiveThis driver depends on the PCI infrastructure but the dependency has not been explicitly called out.
--- drivers/gpu/vga/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/vga/Kconfig +1 -0
@@ -21,6 +21,7 @@ config VGA_SWITCHEROO bool "Laptop Hybrid Graphics - GPU switching support" depends on X86 depends on ACPI + depends on PCI select VGA_ARB help Many laptops released in 2008/9/10 have two GPUs with a multiplexer
Signature · 6 lines
2.19.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v4 03/11] vga-switcheroo: make PCI dependency explicit
Quoted 7 lines · Sinan Kaya
This driver depends on the PCI infrastructure but the dependency has not been explicitly called out.
Fixes 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")Signed-off-by Sinan Kaya <[email protected]>Reviewed-by Lukas Wunner <[email protected]>Acked-by Daniel Vetter <[email protected]>
I'm assuming this goes in through the acpi tree, correct? -Daniel
Quoted 19 lines
--- drivers/gpu/vga/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/gpu/vga/Kconfig +1
-0@@ -21,6 +21,7 @@ config VGA_SWITCHEROO bool "Laptop Hybrid Graphics - GPU switching support" depends on X86 depends on ACPI + depends on PCI select VGA_ARB help Many laptops released in 2008/9/10 have two GPUs with a multiplexerSignature · 1 line
2.19.0
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Rafael J. Wysocki
maintainerRe: [PATCH v4 03/11] vga-switcheroo: make PCI dependency explicit
Quoted 11 lines · Daniel Vetter
Quoted 7 lines · Sinan Kaya
This driver depends on the PCI infrastructure but the dependency has not been explicitly called out.
Fixes 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")Signed-off-by Sinan Kaya <[email protected]>Reviewed-by Lukas Wunner <[email protected]>Acked-by Daniel Vetter <[email protected]>I'm assuming this goes in through the acpi tree, correct?
I'm going to pick it up.
PATCH v4 4/11 platform/x86: intel_ips: make PCI dependency explicit
In reply to a message not in the archiveipss driver is a PCI device driver but this has not been mentioned anywhere in Kconfig.
--- drivers/platform/x86/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/Kconfig +1 -1
@@ -1009,7 +1009,7 @@ config INTEL_MFLD_THERMAL config INTEL_IPS tristate "Intel Intelligent Power Sharing" - depends on ACPI + depends on ACPI && PCI ---help--- Intel Calpella platforms support dynamic power sharing between the CPU and GPU, maximizing performance in a given TDP. This driver,
Signature · 1 line
2.19.0
PATCH v4 5/11 platform/x86: intel_pmc: Make PCI dependency explicit
In reply to a message not in the archiveCode relies on PCI for execution. Specify this in the Kconfig.
--- drivers/platform/x86/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/platform/x86/Kconfig +1 -1
@@ -1174,7 +1174,7 @@ config INTEL_SMARTCONNECT config INTEL_PMC_IPC tristate "Intel PMC IPC Driver" - depends on ACPI + depends on ACPI && PCI ---help--- This driver provides support for PMC control on some Intel platforms. The PMC is an ARC processor which defines IPC commands for communication
Signature · 1 line
2.19.0
PATCH v4 6/11 platform/x86: apple-gmux: Make PCI dependency explicit
In reply to a message not in the archiveThis driver depends on the PCI infrastructure but the dependency has not been explicitly called out.
--- drivers/platform/x86/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/platform/x86/Kconfig +1 -0
@@ -1136,6 +1136,7 @@ config SAMSUNG_Q10 config APPLE_GMUX tristate "Apple Gmux Driver" depends on ACPI + depends on PCI depends on PNP depends on BACKLIGHT_CLASS_DEVICE depends on BACKLIGHT_APPLE=n || BACKLIGHT_APPLE
Signature · 1 line
2.19.0
Re: [PATCH v4 06/11] platform/x86: apple-gmux: Make PCI dependency explicit
Quoted 5 lines · Sinan Kaya
This driver depends on the PCI infrastructure but the dependency has not been explicitly called out.
Fixes 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")Signed-off-by Sinan Kaya <[email protected]>
PATCH v4 7/11 drivers: thermal: int3406_thermal: Make PCI dependency explicit
In reply to a message not in the archiveNeed CONFIG_PCI to be set in order to be able to use this driver.
--- drivers/thermal/intel/int340x_thermal/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/thermal/intel/int340x_thermal/Kconfig +1 -1
@@ -31,7 +31,7 @@ if INT340X_THERMAL config INT3406_THERMAL tristate "ACPI INT3406 display thermal driver" - depends on ACPI_VIDEO + depends on ACPI_VIDEO && PCI help The display thermal device represents the LED/LCD display panel that may or may not include touch support. The main function of
Signature · 1 line
2.19.0
PATCH v4 8/11 ASoC: Intel: atom: Make PCI dependency explicit
In reply to a message not in the archiveCode does unconditional select for IOSF_MBI. IOSF_MBI driver depends on CONFIG_PCI set but this is not specified anywhere.
--- sound/soc/intel/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/intel/Kconfig +1 -1
@@ -91,7 +91,7 @@ config SND_SST_ATOM_HIFI2_PLATFORM_PCI config SND_SST_ATOM_HIFI2_PLATFORM_ACPI tristate "ACPI HiFi2 (Baytrail, Cherrytrail) Platforms" default ACPI - depends on X86 && ACPI + depends on X86 && ACPI && PCI select SND_SST_IPC_ACPI select SND_SST_ATOM_HIFI2_PLATFORM select SND_SOC_ACPI_INTEL_MATCH
Signature · 1 line
2.19.0
Mark Brown
maintainerRe: [PATCH v4 08/11] ASoC: Intel: atom: Make PCI dependency explicit
Quoted 2 lines · Sinan Kaya
Code does unconditional select for
IOSF_MBI.IOSF_MBIdriver depends onCONFIG_PCIset but this is not specified anywhere.
I don't have the cover letter or anything for this series, what's going on with dependencies?
Re: [PATCH v4 08/11] ASoC: Intel: atom: Make PCI dependency explicit
Quoted 7 lines · Mark Brown
Quoted 2 lines · Sinan Kaya
Code does unconditional select for
IOSF_MBI.IOSF_MBIdriver depends onCONFIG_PCIset but this is not specified anywhere.I don't have the cover letter or anything for this series, what's going on with dependencies?
Here is the executive summary:
I have a changeset that separates ACPI from PCI on 4.21. CONFIG_ACPI used to select PCI. This is no longer true.
You can build an ACPI system without any PCI devices.
Mark Brown
maintainerRe: [PATCH v4 08/11] ASoC: Intel: atom: Make PCI dependency explicit
Quoted 11 lines · Sinan Kaya
Quoted 2 lines · Mark Brown
I don't have the cover letter or anything for this series, what's going on with dependencies?
Here is the executive summary:
I have a changeset that separates ACPI from PCI on 4.21.
CONFIG_ACPIused to select PCI. This is no longer true.You can build an ACPI system without any PCI devices.
So there's no dependency and I can just apply this?
Re: [PATCH v4 08/11] ASoC: Intel: atom: Make PCI dependency explicit
Quoted 7 lines · Mark Brown
Quoted 4 lines · Sinan Kaya
Quoted 2 lines · Mark Brown
I don't have the cover letter or anything for this series, what's going on with dependencies?
Quoted 8 lines
Quoted 6 lines
Here is the executive summary:
I have a changeset that separates ACPI from PCI on 4.21.
CONFIG_ACPIused to select PCI. This is no longer true.You can build an ACPI system without any PCI devices.
So there's no dependency and I can just apply this?
The plan is to apply this patchset via ACPI tree. Need an Acked-by per patch.
Re: [PATCH v4 08/11] ASoC: Intel: atom: Make PCI dependency explicit
Quoted 11 lines · Sinan Kaya
Quoted 9 lines · Mark Brown
Quoted 7 lines · Sinan Kaya
Quoted 2 lines · Mark Brown
I don't have the cover letter or anything for this series, what's going on with dependencies?
Here is the executive summary:
I have a changeset that separates ACPI from PCI on 4.21.CONFIG_ACPIused to select PCI. This is no longer true.
You can build an ACPI system without any PCI devices.So there's no dependency and I can just apply this?
The plan is to apply this patchset via ACPI tree. Need an Acked-by per patch.
Anytime we change the Kconfig settings for audio, we get all kinds of problems with randconfig and 0day/kbuild due to depend/select issues. I'd like to give this a spin first, can you share a link to the entire series? Thanks!
Re: [PATCH v4 08/11] ASoC: Intel: atom: Make PCI dependency explicit
Quoted 12 lines · Pierre-Louis Bossart
Quoted 9 lines · Sinan Kaya
Quoted 8 lines · Mark Brown
Quoted 7 lines · Sinan Kaya
Quoted 2 lines · Mark Brown
I don't have the cover letter or anything for this series, what's going on with dependencies?
Here is the executive summary:
I have a changeset that separates ACPI from PCI on 4.21.CONFIG_ACPIused to select PCI. This is no longer true.
You can build an ACPI system without any PCI devices.
Quoted 6 lines
Quoted 2 lines
Quoted 1 line
So there's no dependency and I can just apply this?
The plan is to apply this patchset via ACPI tree. Need an Acked-by per patch.
Anytime we change the
Kconfigsettings for audio, we get all kinds of problems with randconfig and 0day/kbuild due to depend/select issues. I'd like to give this a spin first, can you share a link to the entire series? Thanks!
Sure,
You can find them here
https://lore.kernel.org/patchwork/patch/1028330/
Click related.
Re: [PATCH v4 08/11] ASoC: Intel: atom: Make PCI dependency explicit
Quoted 19 lines · Sinan Kaya
Quoted 11 lines · Pierre-Louis Bossart
Quoted 9 lines · Sinan Kaya
Quoted 8 lines · Mark Brown
Quoted 7 lines · Sinan Kaya
Quoted 2 lines · Mark Brown
I don't have the cover letter or anything for this series, what's going on with dependencies?
Here is the executive summary:
I have a changeset that separates ACPI from PCI on 4.21.CONFIG_ACPIused to select PCI. This is no longer true.
You can build an ACPI system without any PCI devices.Quoted 6 lines
Quoted 2 lines
Quoted 1 line
So there's no dependency and I can just apply this?
The plan is to apply this patchset via ACPI tree. Need an Acked-by per patch.
Anytime we change the
Kconfigsettings for audio, we get all kinds of problems with randconfig and 0day/kbuild due to depend/select issues. I'd like to give this a spin first, can you share a link to the entire series? Thanks!
Quoted 7 lines
Sure,
You can find them here
https://lore.kernel.org/patchwork/patch/1028330/
Click related.
Something must be missing, I get compilation errors when PCI is not defined? And I see tons of references to pci stuff in drivers/acpi.
drivers/acpi/reboot.c: In function ‘acpi_reboot’:drivers/acpi/reboot.c:37:10: error: implicit declaration of function ‘pci_find_bus’; did you mean ‘pci_find_next_bus’? [-Werror=implicit-function-declaration] bus0 = pci_find_bus(0, 0);
^~~~~~~~~~~~
pci_find_next_busdrivers/acpi/reboot.c:37:8: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
bus0 = pci_find_bus(0, 0);
^drivers/acpi/reboot.c:45:3: error: implicit declaration of function ‘pci_bus_write_config_byte’; did you mean ‘pci_write_config_byte’? [-Werror=implicit-function-declaration] pci_bus_write_config_byte(bus0, devfn,
^~~~~~~~~~~~~~~~~~~~~~~~~
pci_write_config_byte
Re: [PATCH v4 08/11] ASoC: Intel: atom: Make PCI dependency explicit
Quoted 37 lines · Pierre-Louis Bossart
Quoted 19 lines · Sinan Kaya
Quoted 11 lines · Pierre-Louis Bossart
Quoted 9 lines · Sinan Kaya
Quoted 8 lines · Mark Brown
Quoted 7 lines · Sinan Kaya
Quoted 2 lines · Mark Brown
I don't have the cover letter or anything for this series, what's going on with dependencies?
Here is the executive summary:
I have a changeset that separates ACPI from PCI on 4.21.CONFIG_ACPIused to select PCI. This is no longer true.
You can build an ACPI system without any PCI devices.Quoted 6 lines
Quoted 2 lines
Quoted 1 line
So there's no dependency and I can just apply this?
The plan is to apply this patchset via ACPI tree. Need an Acked-by per patch.
Anytime we change the
Kconfigsettings for audio, we get all kinds of problems with randconfig and 0day/kbuild due to depend/select issues. I'd like to give this a spin first, can you share a link to the entire series? Thanks!Quoted 7 lines
Sure,
You can find them here
https://lore.kernel.org/patchwork/patch/1028330/
Click related.
Something must be missing, I get compilation errors when PCI is not defined? And I see tons of references to pci stuff in
drivers/acpi.
drivers/acpi/reboot.c: In function ‘acpi_reboot’:drivers/acpi/reboot.c:37:10: error: implicit declaration of function ‘pci_find_bus’; did you mean ‘pci_find_next_bus’? [-Werror=implicit-function-declaration]
Quoted 15 lines
bus0 = pci_find_bus(0, 0);
^~~~~~~~~~~~
pci_find_next_bus
drivers/acpi/reboot.c:37:8: warning: assignment makes pointer from
integer without a cast [-Wint-conversion]
bus0 = pci_find_bus(0, 0);
^
drivers/acpi/reboot.c:45:3: error: implicit declaration of function
‘pci_bus_write_config_byte’; did you mean ‘pci_write_config_byte’?
[-Werror=implicit-function-declaration]
pci_bus_write_config_byte(bus0, devfn,
^~~~~~~~~~~~~~~~~~~~~~~~~
pci_write_config_bytePlease check out this tag next-20181224 and apply the patches afterwards.
Re: [alsa-devel] [PATCH v4 08/11] ASoC: Intel: atom: Make PCI dependency explicit
Quoted 2 lines
Please check out this tag next-20181224 and apply the patches afterwards.
Thanks, will do. I think this patchset will uncover additional inconsistencies, e.g. for legacy Haswell/Broadwell/Baytrail the machine drivers depend on X86_INTEL_LPSS, which depends in turn on PCI, but the platform drivers only depend on ACPI, so there is a risk of creating a config that makes no sense (or should only be used for COMPILE_TEST)
Rafael J. Wysocki
maintainerRe: [PATCH v4 08/11] ASoC: Intel: atom: Make PCI dependency explicit
In reply to Sinan KayaQuoted 3 lines · Sinan Kaya
Code does unconditional select for
IOSF_MBI.IOSF_MBIdriver depends onCONFIG_PCIset but this is not specified anywhere.
IMO it would be better to say
"After commit 5d32a66541c46 (PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set) dependencies on CONFIG_PCI that previously were satisfied implicitly through dependencies on CONFIG_ACPI have to be specified directly. For this reason, add a direct dependency on CONFIG_PCI to the IOSF_MBI driver."
If you did that, the reviewers would know upfront what this was about and that might save at least one back-and-forth e-mail exchange in each case.
Rafael J. Wysocki
maintainerRe: [PATCH v4 08/11] ASoC: Intel: atom: Make PCI dependency explicit
Quoted 14 lines · Rafael J. Wysocki
Quoted 3 lines · Sinan Kaya
Code does unconditional select for
IOSF_MBI.IOSF_MBIdriver depends onCONFIG_PCIset but this is not specified anywhere.IMO it would be better to say
"After commit
5d32a66541c46(PCI/ACPI: Allow ACPI to be built withoutCONFIG_PCIset) dependencies onCONFIG_PCIthat previously were satisfied implicitly through dependencies onCONFIG_ACPIhave to be specified directly. For this reason, add a direct dependency onCONFIG_PCIto theIOSF_MBIdriver."
Quoted 3 lines
If you did that, the reviewers would know upfront what this was about and that might save at least one back-and-forth e-mail exchange in each case.
But, of course, the changelog doesn't even match the patch contents in this particular case. Please fix that.
PATCH v4 9/11 mmc: sdhci-acpi: Make PCI dependency explicit
In reply to a message not in the archiveSelect IOSF_MBI only when PCI and X86 is set.
--- drivers/mmc/host/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/Kconfig +1 -1
@@ -117,7 +117,7 @@ config MMC_RICOH_MMC config MMC_SDHCI_ACPI tristate "SDHCI support for ACPI enumerated SDHCI controllers" depends on MMC_SDHCI && ACPI - select IOSF_MBI if X86 + select IOSF_MBI if (X86 && PCI) help This selects support for ACPI enumerated SDHCI controllers, identified by ACPI Compatibility ID PNP0D40 or specific
Signature · 1 line
2.19.0
PATCH v4 10/11 x86/intel/lpss: Make PCI dependency explicit
In reply to a message not in the archiveLPSS code relies on PCI infrastructure but this dependency has not been explicitly called out.
--- arch/x86/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/Kconfig +1 -1
@@ -617,7 +617,7 @@ config X86_INTEL_QUARK config X86_INTEL_LPSS bool "Intel Low Power Subsystem Support" - depends on X86 && ACPI + depends on X86 && ACPI && PCI select COMMON_CLK select PINCTRL select IOSF_MBI
Signature · 1 line
2.19.0
PATCH v4 11/11 drivers: thermal: int340x_thermal: Make PCI dependency explicit
In reply to a message not in the archiveIOSF_CORE depends on PCI. This was never mentioned.
--- drivers/thermal/intel/int340x_thermal/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/thermal/intel/int340x_thermal/Kconfig +1 -1
@@ -4,7 +4,7 @@ config INT340X_THERMAL tristate "ACPI INT340X thermal drivers" - depends on X86 && ACPI + depends on X86 && ACPI && PCI select THERMAL_GOV_USER_SPACE select ACPI_THERMAL_REL select ACPI_FAN
Signature · 1 line
2.19.0