Skip to contentSkip to conversation

ufs: core: fix err handler mcq abort defect

PATCH In review [email protected] 2 participants 6 messages Aug 26, 2024 – Aug 28, 2024

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

v2 cover ufs: core: fix err handler mcq abort defect

From: Peter Wang <[email protected]>

This series fixes ufshcd_err_handler abort defect in mcq mode.

V2:
- Change patch description typo.

Peter Wang (2):
ufs: core: complete scsi command after release
ufs: core: force reset after mcq abort all

 drivers/ufs/core/ufshcd.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
Signature · 1 line
2.45.2
#1 lore raw

PATCH v2 1/2 ufs: core: complete scsi command after release

From: Peter Wang <[email protected]>

When the error handler successfully aborts a MCQ request, it only releases the command and does not notify the SCSI layer. This may cause another abort after 30 seconds timeout. This patch notifies the SCSI layer to requeue the request.

Below is error log

[   14.183804][   T74] ufshcd-mtk 112b0000.ufshci: ufshcd_err_handler started; HBA state eh_non_fatal; powered 1; shutting down 0; saved_err = 4; saved_uic_err = 64; force_reset = 0
[   14.256164][   T74] ufshcd-mtk 112b0000.ufshci: ufshcd_try_to_abort_task: cmd pending in the device. tag = 19
[   14.257511][   T74] ufshcd-mtk 112b0000.ufshci: Aborting tag 19 / CDB 0x35 succeeded
[   34.287949][    T8] ufshcd-mtk 112b0000.ufshci: ufshcd_abort: Device abort task at tag 19
[   34.290514][    T8] ufshcd-mtk 112b0000.ufshci: ufshcd_mcq_abort: skip abort. cmd at tag 19 already completed.
Fixes 93e6c0e19d5b ("scsi: ufs: core: Clear cmd if abort succeeds in MCQ mode")
---
 drivers/ufs/core/ufshcd.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/ufs/core/ufshcd.c +5 -1
index 0b3d0c8e0dda..4bcd4e5b62bd 100644
@@ -6482,8 +6482,12 @@ static bool ufshcd_abort_one(struct request *rq, void *priv)
 		if (!hwq)
 			return 0;
 		spin_lock_irqsave(&hwq->cq_lock, flags);
-		if (ufshcd_cmd_inflight(lrbp->cmd))
+		if (ufshcd_cmd_inflight(lrbp->cmd)) {
+			struct scsi_cmnd *cmd = lrbp->cmd;
+			set_host_byte(cmd, DID_REQUEUE);
 			ufshcd_release_scsi_cmd(hba, lrbp);
+			scsi_done(cmd);
+		}
 		spin_unlock_irqrestore(&hwq->cq_lock, flags);
 	}
 
Signature · 1 line
2.45.2
reviewer Reviewed-by on v2 1/2
#2 lore raw

Re: [PATCH v2 1/2] ufs: core: complete scsi command after release

Quoted 4 lines · On 8/25/24 8:45 PM, [email protected] wrote:

When the error handler successfully aborts a MCQ request, it only releases the command and does not notify the SCSI layer. This may cause another abort after 30 seconds timeout. This patch notifies the SCSI layer to requeue the request.

#3 lore raw

PATCH v2 2/2 ufs: core: force reset after mcq abort all

In reply to [email protected]

From: Peter Wang <[email protected]>

In mcq mode gerneal case, cq (head/tail) pointer is same as sq pointer (head/tail) if the hwq is empty.

But if command send to device and abort it, no response return and cq point will less than sq. In this case will have unpredictable error. This patch force reset for this case.

Below is error log

[   34.976612][    C3] ufshcd-mtk 112b0000.ufshci: OCS error from controller = 3 for tag 19
---
 drivers/ufs/core/ufshcd.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/ufs/core/ufshcd.c +2 -0
index 4bcd4e5b62bd..d9ef8f0279da 100644
@@ -6519,6 +6519,8 @@ static bool ufshcd_abort_all(struct ufs_hba *hba)
 	/* Complete the requests that are cleared by s/w */
 	ufshcd_complete_requests(hba, false);
 
+	if (is_mcq_enabled(hba))
+		return true;
 	return ret != 0;
 }
 
Signature · 1 line
2.45.2
#4 lore raw

Re: [PATCH v2 2/2] ufs: core: force reset after mcq abort all

Quoted 3 lines · On 8/25/24 8:45 PM, [email protected] wrote:

From: Peter Wang <[email protected]>

In mcq mode gerneal case, cq (head/tail) pointer is same as

Please capitalize "MCQ" and please fix the spelling of "general".

drivers/ufs/core/ufshcd.c static bool ufshcd_abort_all(struct ufs_hba *hba) · line 6525

Quoted 12 lines
drivers/ufs/core/ufshcd.c +2 -0
index 4bcd4e5b62bd..d9ef8f0279da 100644
@@ -6519,6 +6519,8 @@ static bool ufshcd_abort_all(struct ufs_hba *hba)
  	/* Complete the requests that are cleared by s/w */
  	ufshcd_complete_requests(hba, false);
 
+	if (is_mcq_enabled(hba))
+		return true;
  	return ret != 0;
  }

Please add a comment above the new if-test that explains why that code is present otherwise it will be hard to understand why that statement has been introduced.

Thanks,

Bart.

#5 lore raw

Re: [PATCH v2 2/2] ufs: core: force reset after mcq abort all

Quoted 29 lines · Bart Van Assche

External email : Please do not click links or open attachments until you have verified the sender or the content.

Quoted 3 lines · On 8/25/24 8:45 PM, [email protected] wrote:

From: Peter Wang <[email protected]>

In mcq mode gerneal case, cq (head/tail) pointer is same as

Please capitalize "MCQ" and please fix the spelling of "general".

drivers/ufs/core/ufshcd.c static bool ufshcd_abort_all(struct ufs_hba

Quoted 5 lines
drivers/ufs/core/ufshcd.c +0 -0
index 4bcd4e5b62bd..d9ef8f0279da 100644
@@ -6519,6 +6519,8 @@ static bool ufshcd_abort_all(struct ufs_hba

*hba)

drivers/ufs/core/ufshcd.c static bool ufshcd_abort_all(struct ufs_hba *hba) · line 6525

Quoted 7 lines
drivers/ufs/core/ufshcd.c +2 -0
  /* Complete the requests that are cleared by s/w */
  ufshcd_complete_requests(hba, false);
 
+if (is_mcq_enabled(hba))
+return true;
  return ret != 0;
  }

Please add a comment above the new if-test that explains why that code
is present otherwise it will be hard to understand why that statement has been introduced.

Quoted 3 lines

Thanks,

Bart.

Hi Bart,

Sorry, I need to abandon this patch series because I've discovered the reason why the aborted command hasn't returned.
And this patch 93e6c0e19d5b ("scsi: ufs: core: Clear cmd if abort succeeds in MCQ mode")
should reverted.

I will submit another patch to fix this issue.

Thanks.
Peter

Quoted 1 line