Skip to contentSkip to conversation

drm/amdgpu/powerplay: declare firmware for CI cards

PATCH In review Alex Deucher via amd-gfx 2 participants 3 messages Feb 13, 2019 – Feb 14, 2019 2 messages not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amdgpu/powerplay: declare firmware for CI cards

Missing firmware declaration caused firmware requirement to not be noted by the module and may cause firmware to not be available in initrd.

Fixes bc4b539e385088 "drm/amdgpu: remove old CI DPM implementation"
---
 drivers/gpu/drm/amd/powerplay/smumgr/smumgr.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/gpu/drm/amd/powerplay/smumgr/smumgr.c +4 -0
index a6edd5df33b0..4240aeec9000 100644
@@ -29,6 +29,10 @@
 #include <drm/amdgpu_drm.h>
 #include "smumgr.h"
 
+MODULE_FIRMWARE("amdgpu/bonaire_smc.bin");
+MODULE_FIRMWARE("amdgpu/bonaire_k_smc.bin");
+MODULE_FIRMWARE("amdgpu/hawaii_smc.bin");
+MODULE_FIRMWARE("amdgpu/hawaii_k_smc.bin");
 MODULE_FIRMWARE("amdgpu/topaz_smc.bin");
 MODULE_FIRMWARE("amdgpu/topaz_k_smc.bin");
 MODULE_FIRMWARE("amdgpu/tonga_smc.bin");
Signature · 6 lines
2.20.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 20190213201000.7235-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org

Reviewed-by Tested-by
#2 lore raw

This patch is

Quoted 15 lines · Alex Deucher via amd-gfx

Missing firmware declaration caused firmware requirement to not be noted by the module and may cause firmware to not be available in initrd.

Fixes bc4b539e385088 "drm/amdgpu: remove old CI DPM implementation"
---
  drivers/gpu/drm/amd/powerplay/smumgr/smumgr.c | 4 ++++
  1 file changed, 4 insertions(+)
drivers/gpu/drm/amd/powerplay/smumgr/smumgr.c +0 -0
index a6edd5df33b0..4240aeec9000 100644

drivers/gpu/drm/amd/powerplay/smumgr/smumgr.c line 38

Quoted 10 lines
drivers/gpu/drm/amd/powerplay/smumgr/smumgr.c +4 -0
@@ -29,6 +29,10 @@
  #include <drm/amdgpu_drm.h>
  #include "smumgr.h"
 
+MODULE_FIRMWARE("amdgpu/bonaire_smc.bin");
+MODULE_FIRMWARE("amdgpu/bonaire_k_smc.bin");
+MODULE_FIRMWARE("amdgpu/hawaii_smc.bin");
+MODULE_FIRMWARE("amdgpu/hawaii_k_smc.bin");
  MODULE_FIRMWARE("amdgpu/topaz_smc.bin");
  MODULE_FIRMWARE("amdgpu/topaz_k_smc.bin");
  MODULE_FIRMWARE("amdgpu/tonga_smc.bin");

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): d2cd2844-046f-526e-9606-a9ea365d8b09-5C7GfCeVMHo@public.gmane.org

author Reviewed-by Christian König
#4 lore raw

Am 13.02.19 um 21:17 schrieb James Zhu:

Quoted 24 lines

This patch is

Quoted 18 lines · Alex Deucher via amd-gfx

Missing firmware declaration caused firmware requirement to not be noted by the module and may cause firmware to not be available in initrd.

Fixes bc4b539e385088 "drm/amdgpu: remove old CI DPM implementation"
---
   drivers/gpu/drm/amd/powerplay/smumgr/smumgr.c | 4 ++++
   1 file changed, 4 insertions(+)
drivers/gpu/drm/amd/powerplay/smumgr/smumgr.c +0 -0
index a6edd5df33b0..4240aeec9000 100644
@@ -29,6 +29,10 @@
   #include <drm/amdgpu_drm.h>
   #include "smumgr.h"
 
Quoted 11 lines

drivers/gpu/drm/amd/powerplay/smumgr/smumgr.c line 38

Quoted 7 lines
drivers/gpu/drm/amd/powerplay/smumgr/smumgr.c +4 -0
+MODULE_FIRMWARE("amdgpu/bonaire_smc.bin");
+MODULE_FIRMWARE("amdgpu/bonaire_k_smc.bin");
+MODULE_FIRMWARE("amdgpu/hawaii_smc.bin");
+MODULE_FIRMWARE("amdgpu/hawaii_k_smc.bin");
   MODULE_FIRMWARE("amdgpu/topaz_smc.bin");
   MODULE_FIRMWARE("amdgpu/topaz_k_smc.bin");
   MODULE_FIRMWARE("amdgpu/tonga_smc.bin");

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx