Skip to contentSkip to conversation

gpio: Add support for DM GPIO for Kirkwood

PATCH New Harm Berntsen 2 participants 6 messages Nov 27, 2020 – Nov 30, 2020 GPIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gpio: Add support for DM GPIO for Kirkwood

The Armada driver also works on Nedap's ax8008 Kirkwood board with a Marvell 88F6180 CPU. The original commit of that driver, 704d9a645e1790e568abf43c5eff2de0d7b135ed also mentions that this driver would be suitable for Kirkwood.

This driver does not completely replace the Kirkwood specific driver as there are still dependencies on that driver(i.e. soft_i2c.c. in our case).

---

 drivers/gpio/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpio/Kconfig +1 -1
index 202fcc6f47..1f41bd3d55 100644
@@ -374,7 +374,7 @@ config SIFIVE_GPIO
 
 config MVEBU_GPIO
 	bool "Marvell MVEBU GPIO driver"
-	depends on DM_GPIO && ARCH_MVEBU
+	depends on DM_GPIO && (ARCH_MVEBU || ARCH_KIRKWOOD)
 	default y
 	help
 	  Say yes here to support Marvell MVEBU (Armada XP/38x) GPIOs.
Signature · 1 line
2.29.2
#1 lore raw

PATCH 1/1 gpio: Add support for DM GPIO for Kirkwood

Hi Harm,

Quoted 4 lines · Harm Berntsen

The Armada driver also works on Nedap's ax8008 Kirkwood board with a Marvell 88F6180 CPU. The original commit of that driver, 704d9a645e1790e568abf43c5eff2de0d7b135ed also mentions that this driver would be suitable for Kirkwood.

Well, this was really a long time ago. ;)

Quoted 3 lines

This driver does not completely replace the Kirkwood specific driver as there are still dependencies on that driver(i.e. soft_i2c.c. in our case).

So what work needs to be doney to completely replace the old legacy kw_gpio driver and remove it completely? Could you perhaps tackle it as well?

Other than that:

Thanks,
Stefan

Quoted 13 lines

---

  drivers/gpio/Kconfig | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpio/Kconfig +0 -0
index 202fcc6f47..1f41bd3d55 100644

drivers/gpio/Kconfig config SIFIVE_GPIO · line 380

Quoted 8 lines
drivers/gpio/Kconfig +1 -1
@@ -374,7 +374,7 @@ config SIFIVE_GPIO
 
  config MVEBU_GPIO
  	bool "Marvell MVEBU GPIO driver"
-	depends on DM_GPIO && ARCH_MVEBU
+	depends on DM_GPIO && (ARCH_MVEBU || ARCH_KIRKWOOD)
  	default y
  	help
  	  Say yes here to support Marvell MVEBU (Armada XP/38x) GPIOs.

Viele Gr??e,
Stefan

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de
#2 lore raw

PATCH 1/1 gpio: Add support for DM GPIO for Kirkwood

Hi Stefan,

Thanks for your review.

I've looked into the usage of the kw_gpio driver. The soft_i2c part I mentioned in the commit appeared to be specific to my board configuration. I've replaced the usage of that driver with the DM based i2c-gpio driver there.

All the usage of the kw_gpio functions is in board-specific code. I think the kw_gpio driver can be deprecated and board maintainers could update their code.

Kind regards,
Harm

-----Original Message-----
From: Stefan Roese <[email protected]>
To: Harm Berntsen <[email protected]>, u-boot at lists.denx.de <[email protected]>
Subject: Re: [PATCH] gpio: Add support for DM GPIO for Kirkwood
Date: Sat, 28 Nov 2020 11:08:43 +0100

Hi Harm,

Quoted 5 lines · Harm Berntsen

The Armada driver also works on Nedap's ax8008 Kirkwood board with a Marvell 88F6180 CPU. The original commit of that driver, 704d9a645e1790e568abf43c5eff2de0d7b135ed also mentions that this driver
would be suitable for Kirkwood.

Well, this was really a long time ago. ;)

Quoted 4 lines

This driver does not completely replace the Kirkwood specific driver as
there are still dependencies on that driver(i.e. soft_i2c.c. in our case).

So what work needs to be doney to completely replace the old legacy kw_gpio driver and remove it completely? Could you perhaps tackle it as well?

Other than that:

Thanks,
Stefan

Quoted 13 lines

---

? drivers/gpio/Kconfig | 2 +-
? 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/gpio/Kconfig +0 -0
index 202fcc6f47..1f41bd3d55 100644
@@ -374,7 +374,7 @@ config SIFIVE_GPIO

?

Quoted 9 lines

? config MVEBU_GPIO
????????bool "Marvell MVEBU GPIO driver" -???????depends on DM_GPIO && ARCH_MVEBU +???????depends on DM_GPIO && (ARCH_MVEBU || ARCH_KIRKWOOD) ????????default y
????????help
????????? Say yes here to support Marvell MVEBU (Armada XP/38x) GPIOs.

Viele Gr??e,
Stefan

#3 lore raw

PATCH 1/1 gpio: Add support for DM GPIO for Kirkwood

Hi Harm,

Quoted 8 lines · Harm Berntsen

Hi Stefan,

Thanks for your review.

I've looked into the usage of the kw_gpio driver. The soft_i2c part I mentioned in the commit appeared to be specific to my board configuration. I've replaced the usage of that driver with the DM based i2c-gpio driver there.

Good.

Quoted 3 lines

All the usage of the kw_gpio functions is in board-specific code. I think the kw_gpio driver can be deprecated and board maintainers could update their code.

Yes, that would be great. We probably need some way to deprecate this driver, so that current users will be notified top switch to the common MVEBU DM GPIO driver when compiling for these boards.

Thanks,
Stefan

Quoted 50 lines

Kind regards,
Harm

-----Original Message-----
From: Stefan Roese <[email protected]>
To: Harm Berntsen <[email protected]>, u-boot at lists.denx.de <[email protected]>
Subject: Re: [PATCH] gpio: Add support for DM GPIO for Kirkwood
Date: Sat, 28 Nov 2020 11:08:43 +0100

Hi Harm,

Quoted 5 lines · Harm Berntsen

The Armada driver also works on Nedap's ax8008 Kirkwood board with a Marvell 88F6180 CPU. The original commit of that driver, 704d9a645e1790e568abf43c5eff2de0d7b135ed also mentions that this driver
would be suitable for Kirkwood.

Well, this was really a long time ago. ;)

Quoted 4 lines

This driver does not completely replace the Kirkwood specific driver as
there are still dependencies on that driver(i.e. soft_i2c.c. in our case).

So what work needs to be doney to completely replace the old legacy kw_gpio driver and remove it completely? Could you perhaps tackle it as well?

Other than that:

Thanks,
Stefan

Quoted 13 lines

---

 ? drivers/gpio/Kconfig | 2 +-

? 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/gpio/Kconfig +0 -0
index 202fcc6f47..1f41bd3d55 100644
@@ -374,7 +374,7 @@ config SIFIVE_GPIO
 
Quoted 15 lines
Quoted 9 lines
drivers/gpio/Kconfig +1 -1
 ? config MVEBU_GPIO
 ????????bool "Marvell MVEBU GPIO driver"
-???????depends on DM_GPIO && ARCH_MVEBU
+???????depends on DM_GPIO && (ARCH_MVEBU || ARCH_KIRKWOOD)
 ????????default y
 ????????help
 ????????? Say yes here to support Marvell MVEBU (Armada XP/38x)

GPIOs.

Viele Gr??e,
Stefan

Viele Gr??e,
Stefan

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de
#4 lore raw

PATCH v2 1/1 gpio: Add support for DM GPIO for Kirkwood

In reply to Harm Berntsen

The Armada driver also works on Nedap's custom Kirkwood board with a Marvell 88F6180 CPU. The original commit of that driver, commit 704d9a645e17 ("gpio: Add DM GPIO driver for Marvell MVEBU"), also mentions that this driver would be suitable for Kirkwood. This does not completely replace the Kirkwood specific driver as there are still boards depending on that driver.

---
Canges for v2:
- Made commit message more clear

 drivers/gpio/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpio/Kconfig +1 -1
index 202fcc6f47..1f41bd3d55 100644
@@ -374,7 +374,7 @@ config SIFIVE_GPIO
 
 config MVEBU_GPIO
 	bool "Marvell MVEBU GPIO driver"
-	depends on DM_GPIO && ARCH_MVEBU
+	depends on DM_GPIO && (ARCH_MVEBU || ARCH_KIRKWOOD)
 	default y
 	help
 	  Say yes here to support Marvell MVEBU (Armada XP/38x) GPIOs.
Signature · 1 line
2.29.2
#5 lore raw

PATCH v2 1/1 gpio: Add support for DM GPIO for Kirkwood

Quoted 9 lines · Harm Berntsen

The Armada driver also works on Nedap's custom Kirkwood board with a Marvell 88F6180 CPU. The original commit of that driver, commit 704d9a645e17 ("gpio: Add DM GPIO driver for Marvell MVEBU"), also mentions that this driver would be suitable for Kirkwood. This does not completely replace the Kirkwood specific driver as there are still boards depending on that driver.

Thanks,
Stefan

Quoted 13 lines

---
Canges for v2:
- Made commit message more clear

  drivers/gpio/Kconfig | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpio/Kconfig +0 -0
index 202fcc6f47..1f41bd3d55 100644

drivers/gpio/Kconfig config SIFIVE_GPIO · line 380

Quoted 8 lines
drivers/gpio/Kconfig +1 -1
@@ -374,7 +374,7 @@ config SIFIVE_GPIO
 
  config MVEBU_GPIO
  	bool "Marvell MVEBU GPIO driver"
-	depends on DM_GPIO && ARCH_MVEBU
+	depends on DM_GPIO && (ARCH_MVEBU || ARCH_KIRKWOOD)
  	default y
  	help
  	  Say yes here to support Marvell MVEBU (Armada XP/38x) GPIOs.

Viele Gr??e,
Stefan

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de