Skip to contentSkip to conversation

staging: fbtft: ili9341: use macro FBTFT_REGISTER_SPI_DRIVER

PATCH RESEND Superseded Raphael Gallais-Pou 2 participants 3 messages Jul 18, 2023

Subsystems (3)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH RESEND v2 1/1 staging: fbtft: ili9341: use macro FBTFT_REGISTER_SPI_DRIVER

Using FBTFT_REGISTER_DRIVER resolves to a NULL struct spi_device_id. This ultimately causes a warning when the module probes. Fixes it.

Changes in v2:
- dropped MODULE_ALIAS changes
- changed commit log for more accurate description

---
 drivers/staging/fbtft/fb_ili9341.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/fbtft/fb_ili9341.c +1 -1
index 9ccd0823c3ab..47e72b87d76d 100644
@@ -145,7 +145,7 @@ static struct fbtft_display display = {
 	},
 };
 
-FBTFT_REGISTER_DRIVER(DRVNAME, "ilitek,ili9341", &display);
+FBTFT_REGISTER_SPI_DRIVER(DRVNAME, "ilitek", "ili9341", &display);
 
 MODULE_ALIAS("spi:" DRVNAME);
 MODULE_ALIAS("platform:" DRVNAME);
Signature · 1 line
2.41.0
#1 lore raw
Quoted 11 lines · Raphael Gallais-Pou

Using FBTFT_REGISTER_DRIVER resolves to a NULL struct spi_device_id. This ultimately causes a warning when the module probes. Fixes it.

Changes in v2:
- dropped MODULE_ALIAS changes
- changed commit log for more accurate description

---
 drivers/staging/fbtft/fb_ili9341.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Why is this a resend?

And the changes need to go below the --- line as per the documentation.

thanks,

greg k-h

#2 lore raw

Hi,

Le 18/07/2023 à 15:33, Greg Kroah-Hartman a écrit :

Quoted 8 lines · Raphael Gallais-Pou
Quoted 7 lines

Using FBTFT_REGISTER_DRIVER resolves to a NULL struct spi_device_id. This ultimately causes a warning when the module probes. Fixes it.

Changes in v2:
- dropped MODULE_ALIAS changes
- changed commit log for more accurate description

Quoted 7 lines
Quoted 4 lines
---
  drivers/staging/fbtft/fb_ili9341.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Why is this a resend? >
And the changes need to go below the --- line as per the documentation.

I messed up the first send and forgot the changelog.
Thanks for your insights, I understand now that I shouldn't have sent a 'RESEND', but rather a v3 with a third entry in the changelog.

Regards,
Raphaël

Quoted 4 lines

thanks,

greg k-h