drm/amdgpu: apply dm_pp_notify_wm_clock_changes() for Polaris only
Subsystems (3)
PATCH 1/1 drm/amdgpu: apply dm_pp_notify_wm_clock_changes() for Polaris only
Will expand it to other ASICs after verified.
--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c +6 -1
@@ -462,7 +462,12 @@ bool dm_pp_notify_wm_clock_changes(void *pp_handle = adev->powerplay.pp_handle;const struct amd_pm_funcs *pp_funcs = adev->powerplay.pp_funcs; -if (pp_funcs && pp_funcs->set_watermarks_for_clocks_ranges) { +/* +* Limit this watermark setting for Polaris for now +* TODO: expand this to other ASICs +*/ +if ((adev->asic_type >=CHIP_POLARIS10 ) && (adev->asic_type <=CHIP_VEGAM ) + && pp_funcs && pp_funcs->set_watermarks_for_clocks_ranges) {if (!pp_funcs->set_watermarks_for_clocks_ranges (pp_handle, (void *)wm_with_clock_ranges))return true;
Signature · 6 lines
2.29.0 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Am 30.10.20 um 12:04 schrieb Evan Quan:
Quoted 4 lines
Will expand it to other ASICs after verified.
Change-Id I03e074ea0e921a984eb819b222e434e88888e375Signed-off-by Evan Quan <[email protected]>
I assume this fixes my issue on Vega20?
Thanks,
Christian.
Quoted 12 lines
--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c +0
-0@@ -462,7 +462,12 @@ bool dm_pp_notify_wm_clock_changes(void *pp_handle = adev->powerplay.pp_handle;const struct amd_pm_funcs *pp_funcs = adev->powerplay.pp_funcs;
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c bool dm_pp_notify_wm_clock_changes( · line 473
Quoted 10 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c +6
-1-if (pp_funcs && pp_funcs->set_watermarks_for_clocks_ranges) { +/* +* Limit this watermark setting for Polaris for now +* TODO: expand this to other ASICs +*/ +if ((adev->asic_type >=CHIP_POLARIS10 ) && (adev->asic_type <=CHIP_VEGAM ) + && pp_funcs && pp_funcs->set_watermarks_for_clocks_ranges) {if (!pp_funcs->set_watermarks_for_clocks_ranges (pp_handle, (void *)wm_with_clock_ranges))return true;
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Quan, Evan
Acked-by Christian König[AMD Official Use Only - Internal Distribution Only]
Yes, it is intended for that.
BR
Evan
-----Original Message-----
From: Koenig, Christian <[email protected]>
Sent: Friday, October 30, 2020 7:06 PM
To: Quan, Evan <[email protected]>; [email protected]
Cc: Deucher, Alexander <[email protected]>
Subject: Re: [PATCH] drm/amdgpu: apply dm_pp_notify_wm_clock_changes() for Polaris only
Am 30.10.20 um 12:04 schrieb Evan Quan:
Quoted 4 lines
Will expand it to other ASICs after verified.
Change-Id I03e074ea0e921a984eb819b222e434e88888e375Signed-off-by Evan Quan <[email protected]>
I assume this fixes my issue on Vega20?
Thanks,
Christian.
Quoted 12 lines
--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c +0
-0@@ -462,7 +462,12 @@ bool dm_pp_notify_wm_clock_changes(void *pp_handle = adev->powerplay.pp_handle;const struct amd_pm_funcs *pp_funcs = adev->powerplay.pp_funcs;
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c bool dm_pp_notify_wm_clock_changes( · line 473
Quoted 10 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c +6
-1-if (pp_funcs && pp_funcs->set_watermarks_for_clocks_ranges) { +/* +* Limit this watermark setting for Polaris for now +* TODO: expand this to other ASICs +*/ +if ((adev->asic_type >=CHIP_POLARIS10 ) && (adev->asic_type <=CHIP_VEGAM ) + && pp_funcs && pp_funcs->set_watermarks_for_clocks_ranges) {if (!pp_funcs->set_watermarks_for_clocks_ranges (pp_handle, (void *)wm_with_clock_ranges))return true;
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Christian König
maintainerThanks, going to test it later today.
Christian.
Am 30.10.20 um 12:07 schrieb Quan, Evan:
Quoted 37 lines
[AMD Official Use Only - Internal Distribution Only]
Yes, it is intended for that.
BR
Evan
-----Original Message-----
From: Koenig, Christian <[email protected]>
Sent: Friday, October 30, 2020 7:06 PM
To: Quan, Evan <[email protected]>; [email protected]
Cc: Deucher, Alexander <[email protected]>
Subject: Re: [PATCH] drm/amdgpu: applydm_pp_notify_wm_clock_changes()for Polaris onlyAm 30.10.20 um 12:04 schrieb Evan Quan:
Quoted 4 lines
Will expand it to other ASICs after verified.
Change-Id I03e074ea0e921a984eb819b222e434e88888e375Signed-off-by Evan Quan <[email protected]>Acked-by Christian König <[email protected]>I assume this fixes my issue on Vega20?
Thanks,
Christian.Quoted 12 lines
--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c +0
-0@@ -462,7 +462,12 @@ bool dm_pp_notify_wm_clock_changes(void *pp_handle = adev->powerplay.pp_handle;const struct amd_pm_funcs *pp_funcs = adev->powerplay.pp_funcs;
Quoted 10 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c bool dm_pp_notify_wm_clock_changes( · line 473
Quoted 10 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c +6
-1-if (pp_funcs && pp_funcs->set_watermarks_for_clocks_ranges) { +/* +* Limit this watermark setting for Polaris for now +* TODO: expand this to other ASICs +*/ +if ((adev->asic_type >=CHIP_POLARIS10 ) && (adev->asic_type <=CHIP_VEGAM ) + && pp_funcs && pp_funcs->set_watermarks_for_clocks_ranges) {if (!pp_funcs->set_watermarks_for_clocks_ranges (pp_handle, (void *)wm_with_clock_ranges))return true;
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
That indeed fixes the issue.
Thanks,
Christian.
Am 30.10.20 um 12:11 schrieb Christian König:
Quoted 42 lines
Thanks, going to test it later today.
Christian.
Am 30.10.20 um 12:07 schrieb Quan, Evan:
Quoted 37 lines
[AMD Official Use Only - Internal Distribution Only]
Yes, it is intended for that.
BR
Evan
-----Original Message-----
From: Koenig, Christian <[email protected]>
Sent: Friday, October 30, 2020 7:06 PM
To: Quan, Evan <[email protected]>; [email protected]
Cc: Deucher, Alexander <[email protected]>
Subject: Re: [PATCH] drm/amdgpu: applydm_pp_notify_wm_clock_changes()for Polaris onlyAm 30.10.20 um 12:04 schrieb Evan Quan:
Quoted 4 lines
Will expand it to other ASICs after verified.
Change-Id I03e074ea0e921a984eb819b222e434e88888e375Signed-off-by Evan Quan <[email protected]>Acked-by Christian König <[email protected]>I assume this fixes my issue on Vega20?
Thanks,
Christian.Quoted 12 lines
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c| 7 ++++++-1 file changed, 6 insertions(+), 1 deletion(-)drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c +0
-0@@ -462,7 +462,12 @@ bool dm_pp_notify_wm_clock_changes( void *pp_handle = adev->powerplay.pp_handle; const struct amd_pm_funcs *pp_funcs = adev->powerplay.pp_funcs;
Quoted 16 lines
Quoted 11 lines
Quoted 11 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c +6
-1-if (pp_funcs && pp_funcs->set_watermarks_for_clocks_ranges) { +/* +* Limit this watermark setting for Polaris for now +* TODO: expand this to other ASICs +*/ +if ((adev->asic_type >=CHIP_POLARIS10 ) && (adev->asic_type <=CHIP_VEGAM ) + && pp_funcs && pp_funcs->set_watermarks_for_clocks_ranges) { if (!pp_funcs->set_watermarks_for_clocks_ranges(pp_handle, (void *)wm_with_clock_ranges))return true;
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx