vl: disable default cdrom when using explicitely scsi-hd
PATCH v2 1/1 vl: disable default cdrom when using explicitely scsi-hd
In commit af6bf1328ef90fae617857c02697e0174b84d596 (May 2011), ide-hd, ide-cd and scsi-cd have been added to disable default cdrom, "or else you can't put one on secondary master without -nodefaults".
Make it the same for scsi-hd, so you can put one on scsi-id 2 without using -nodefaults.
scsi-hd has probably been forgotten, as it has been added in the preceding commit (b443ae67130d32ad06b06fc9aa6d04d05ccd93ce).
Affected users are the ones using a machine with SCSI devices and start QEMU with -device scsi-hd but without -device scsi-cd or -cdrom
In that case, the default cdrom device will disappear instead of being empty.
--- vl.c | 1 + 1 file changed, 1 insertion(+)
vl.c +1 -0
@@ -226,6 +226,7 @@ static struct { { .driver = "ide-hd", .flag = &default_cdrom }, { .driver = "ide-drive", .flag = &default_cdrom }, { .driver = "scsi-cd", .flag = &default_cdrom }, + { .driver = "scsi-hd", .flag = &default_cdrom }, { .driver = "virtio-serial-pci", .flag = &default_virtcon }, { .driver = "virtio-serial", .flag = &default_virtcon }, { .driver = "VGA", .flag = &default_vga },
Signature · 1 line
2.1.4
Ping?
Quoted 31 lines · Hervé Poussineau
In commit
af6bf1328ef90fae617857c02697e0174b84d596(May 2011), ide-hd, ide-cd and scsi-cd have been added to disable default cdrom, "or else you can't put one on secondary master without -nodefaults".Make it the same for scsi-hd, so you can put one on scsi-id 2 without using -nodefaults.
scsi-hd has probably been forgotten, as it has been added in the preceding commit (b443ae67130d32ad06b06fc9aa6d04d05ccd93ce).Affected users are the ones using a machine with SCSI devices and start QEMU with -device scsi-hd but without -device scsi-cd or -cdrom
In that case, the default cdrom device will disappear instead of being empty.Signed-off-by Hervé Poussineau <[email protected]>--- vl.c | 1 + 1 file changed, 1 insertion(+)vl.c +1
-0@@ -226,6 +226,7 @@ static struct { { .driver = "ide-hd", .flag = &default_cdrom }, { .driver = "ide-drive", .flag = &default_cdrom }, { .driver = "scsi-cd", .flag = &default_cdrom }, + { .driver = "scsi-hd", .flag = &default_cdrom }, { .driver = "virtio-serial-pci", .flag = &default_virtcon }, { .driver = "virtio-serial", .flag = &default_virtcon }, { .driver = "VGA", .flag = &default_vga },
Quoted 23 lines · Hervé Poussineau
Ping?
Quoted 20 lines · Hervé Poussineau
In commit
af6bf1328ef90fae617857c02697e0174b84d596(May 2011), ide-hd, ide-cd and scsi-cd have been added to disable default cdrom, "or else you can't put one on secondary master without -nodefaults".Make it the same for scsi-hd, so you can put one on scsi-id 2 without using -nodefaults.
scsi-hd has probably been forgotten, as it has been added in the preceding commit (b443ae67130d32ad06b06fc9aa6d04d05ccd93ce).Affected users are the ones using a machine with SCSI devices and start QEMU
with -device scsi-hd but without -device scsi-cd or -cdrom In that case, the default cdrom device will disappear instead of being empty.Signed-off-by Hervé Poussineau <[email protected]>--- vl.c | 1 + 1 file changed, 1 insertion(+)
Quoted 15 lines
vl.c static struct { · line 232
Quoted 13 lines
vl.c +1
-0@@ -226,6 +226,7 @@ static struct { { .driver = "ide-hd", .flag = &default_cdrom }, { .driver = "ide-drive", .flag = &default_cdrom }, { .driver = "scsi-cd", .flag = &default_cdrom }, + { .driver = "scsi-hd", .flag = &default_cdrom }, { .driver = "virtio-serial-pci", .flag = &default_virtcon }, { .driver = "virtio-serial", .flag = &default_virtcon }, { .driver = "VGA", .flag = &default_vga },
ACK
Paolo, for you?
--js
Quoted 42 lines · John Snow
Quoted 23 lines · Hervé Poussineau
Ping?
Quoted 20 lines · Hervé Poussineau
In commit
af6bf1328ef90fae617857c02697e0174b84d596(May 2011), ide-hd, ide-cd and scsi-cd have been added to disable default cdrom, "or else you can't put one on secondary master without -nodefaults".Make it the same for scsi-hd, so you can put one on scsi-id 2 without using -nodefaults.
scsi-hd has probably been forgotten, as it has been added in the preceding commit (b443ae67130d32ad06b06fc9aa6d04d05ccd93ce).Affected users are the ones using a machine with SCSI devices and start QEMU
with -device scsi-hd but without -device scsi-cd or -cdrom In that case, the default cdrom device will disappear instead of being empty.Signed-off-by Hervé Poussineau <[email protected]>--- vl.c | 1 + 1 file changed, 1 insertion(+)Quoted 15 lines
vl.c static struct { · line 232
Quoted 13 lines
vl.c +1
-0@@ -226,6 +226,7 @@ static struct { { .driver = "ide-hd", .flag = &default_cdrom }, { .driver = "ide-drive", .flag = &default_cdrom }, { .driver = "scsi-cd", .flag = &default_cdrom }, + { .driver = "scsi-hd", .flag = &default_cdrom }, { .driver = "virtio-serial-pci", .flag = &default_virtcon }, { .driver = "virtio-serial", .flag = &default_virtcon }, { .driver = "VGA", .flag = &default_vga },
Quoted 3 lines
ACK
Paolo, for you?
Or for Eduardo or Markus... I'll pick it.
Paolo