Skip to contentSkip to conversation

drm/amdgpu: remove redundant memset

PATCH In review Philip Yang 2 participants 2 messages Aug 29, 2018 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amdgpu: remove redundant memset

Change-Id If94a59d3cbf2690dd2a1e2add71bc393df6a9686
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c +0 -1
index 153c9be..33d9ce2 100644
@@ -540,7 +540,6 @@ static int amdgpu_vm_alloc_levels(struct amdgpu_device *adev,
 						   GFP_KERNEL | __GFP_ZERO);
 		if (!parent->entries)
 			return -ENOMEM;
-		memset(parent->entries, 0 , sizeof(struct amdgpu_vm_pt));
 	}
 
 	from = saddr >> shift;
Signature · 6 lines
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1535554880-1503-1-git-send-email-Philip.Yang-5C7GfCeVMHo@public.gmane.org

#2 lore raw

Am 29.08.2018 um 17:01 schrieb Philip Yang:

Quoted 2 lines
Change-Id If94a59d3cbf2690dd2a1e2add71bc393df6a9686

You need to add a commit message, explaining why that can be removed.

With that done the patch is Reviewed-by: Christian König <[email protected]>.

Regards,
Christian.

Quoted 9 lines
---
  drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 1 -
  1 file changed, 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c +0 -0
index 153c9be..33d9ce2 100644

drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c static int amdgpu_vm_alloc_levels(struct amdgpu_device *adev, · line 545

Quoted 7 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c +0 -1
@@ -540,7 +540,6 @@ static int amdgpu_vm_alloc_levels(struct amdgpu_device *adev,
  						   GFP_KERNEL | __GFP_ZERO);
  		if (!parent->entries)
  			return -ENOMEM;
-		memset(parent->entries, 0 , sizeof(struct amdgpu_vm_pt));
  	}
 
  	from = saddr >> shift;

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx