Fixes: 1ca81883c557 ("ARM: dts: at91: sama5d2: add nodes for I2S controllers")
PATCH v2 1/1 Fixes: 1ca81883c557 ("ARM: dts: at91: sama5d2: add nodes for I2S controllers")
From: Ryan Wanner <[email protected]>
Fixed typo in i2s1 node
---
Changes since v1:
1. Corrected commit
--- arch/arm/boot/dts/sama5d2.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/sama5d2.dtsi +1 -1
@@ -1124,7 +1124,7 @@ AT91_XDMAC_DT_PERID(33))>, clocks = <&pmc PMC_TYPE_PERIPHERAL 55>, <&pmc PMC_TYPE_GCK 55>; clock-names = "pclk", "gclk"; assigned-clocks = <&pmc PMC_TYPE_CORE PMC_I2S1_MUX>; - assigned-parrents = <&pmc PMC_TYPE_GCK 55>; + assigned-clock-parents = <&pmc PMC_TYPE_GCK 55>; status = "disabled"; };
Signature · 1 line
2.34.1
Hi Ryan,
Quoted 5 lines · On 06/07/2022 at 18:21, [email protected] wrote:
From: Ryan Wanner <[email protected]>
Fixed typo in i2s1 node
Signed-off-by Ryan Wanner <[email protected]>
The "Fixes" tag should go there in this section of the email, and not replace the subject.
One example of the subject could be:
"[PATCH v2] ARM: dts: at91: sama5d2: fix typo in i2s1 node"
Quoted 3 lines
---
Changes since v1:
1. Corrected commit
You can place this content about changes...
Quoted 1 line
---
Just here, below the "---", so that you don't need to add another "---".
Regards,
Nicolas
Quoted 16 lines
arch/arm/boot/dts/sama5d2.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/boot/dts/sama5d2.dtsi +1
-1@@ -1124,7 +1124,7 @@ AT91_XDMAC_DT_PERID(33))>, clocks = <&pmc PMC_TYPE_PERIPHERAL 55>, <&pmc PMC_TYPE_GCK 55>; clock-names = "pclk", "gclk"; assigned-clocks = <&pmc PMC_TYPE_CORE PMC_I2S1_MUX>; - assigned-parrents = <&pmc PMC_TYPE_GCK 55>; + assigned-clock-parents = <&pmc PMC_TYPE_GCK 55>; status = "disabled"; };
Signature · 1 line
Nicolas Ferre
Quoted 3 lines · On 2022-07-06 6:21 PM, [email protected] wrote:
From: Ryan Wanner <[email protected]>
Fixed typo in i2s1 node
Perhaps this email got twisted by my client but what I'm seeing is fixes-tag instead of a proper commit title.
If that's really the case, please reword your title - Fixes-tag belongs to the tag area and should be placed before your final signed-off tag.
Also, as commit message is _not_ a title and is made of sentences, it is expected to have each end with '.'.
Another suggestion - nothing is "Fixed" when patch lands on the mailing list. It's just a proposal until it actually gets integrated by the maintainer. As change targets _current_ code, s/Fixed/Fix/ is the recommended phrasing.
Czarek
Quoted 1 line
Signed-off-by Ryan Wanner <[email protected]>