xen: Remove some deadcode (x)
PATCH 1/1 xen: Remove some deadcode (x)
From: "Dr. David Alan Gilbert" <[email protected]>
Remove three uncalled functions:
xenbus_mkdir() was added in 2007 by
commit 4bac07c993d0 ("xen: add the Xenbus sysfs and virtual device hotplug driver")
but has remained unused.
xen_get_runstate_snapshot() last use was removed in 2016 by
commit 6ba286ad8457 ("xen: support runqueue steal time on xen") which replaces the use by the _cpu version.
xen_resume_notifier_unregister() last use was removed in 2017 by
commit 1914f0cd203c ("xen/acpi: upload PM state from init-domain to Xen")
Remove them.
--- drivers/xen/manage.c | 6 ------ drivers/xen/time.c | 8 -------- drivers/xen/xenbus/xenbus_xs.c | 17 ----------------- include/xen/xen-ops.h | 2 -- include/xen/xenbus.h | 2 -- 5 files changed, 35 deletions(-)
drivers/xen/manage.c +0 -6
@@ -52,12 +52,6 @@ void xen_resume_notifier_register(struct notifier_block *nb) }EXPORT_SYMBOL_GPL (xen_resume_notifier_register); -void xen_resume_notifier_unregister (struct notifier_block *nb) -{ -raw_notifier_chain_unregister (&xen_resume_notifier, nb); -} -EXPORT_SYMBOL_GPL (xen_resume_notifier_unregister); -#ifdef CONFIG_HIBERNATE_CALLBACKS static int xen_suspend (void *data) {
drivers/xen/time.c +0 -8
@@ -136,14 +136,6 @@ void xen_manage_runstate_time(int action) } } -/* -* Runstate accounting -*/ -void xen_get_runstate_snapshot (struct vcpu_runstate_info *res) -{ -xen_get_runstate_snapshot_cpu (res,smp_processor_id ()); -} -/* return true when a vcpu could run but has no real cpu to run on */ bool xen_vcpu_stolen (int vcpu) {
drivers/xen/xenbus/xenbus_xs.c +0 -17
@@ -512,23 +512,6 @@ int xenbus_write(struct xenbus_transaction t, }EXPORT_SYMBOL_GPL (xenbus_write); -/* Create a new directory. */ -int xenbus_mkdir (struct xenbus_transaction t, -const char *dir,const char *node) -{ -char *path; -int ret; - - path =join (dir, node); -if (IS_ERR (path)) -return PTR_ERR (path); - - ret =xs_error (xs_single (t,XS_MKDIR , path,NULL )); -kfree (path); -return ret; -} -EXPORT_SYMBOL_GPL (xenbus_mkdir); -/* Destroy a file or directory (directories must be empty). */ int xenbus_rm (struct xenbus_transaction t,const char *dir,const char *node) {
include/xen/xen-ops.h +0 -2
@@ -30,13 +30,11 @@ void xen_arch_suspend(void);void xen_reboot (int reason);void xen_resume_notifier_register (struct notifier_block *nb); -void xen_resume_notifier_unregister (struct notifier_block *nb);bool xen_vcpu_stolen (int vcpu);void xen_setup_runstate_info (int cpu);void xen_time_setup_guest (void );void xen_manage_runstate_time (int action); -void xen_get_runstate_snapshot (struct vcpu_runstate_info *res);u64 xen_steal_clock (int cpu);int xen_setup_shutdown_event (void );
include/xen/xenbus.h +0 -2
@@ -154,8 +154,6 @@ void *xenbus_read(struct xenbus_transaction t, const char *dir, const char *node, unsigned int *len);int xenbus_write (struct xenbus_transaction t,const char *dir,const char *node,const char *string); -int xenbus_mkdir (struct xenbus_transaction t, -const char *dir,const char *node);int xenbus_exists (struct xenbus_transaction t,const char *dir,const char *node);int xenbus_rm (struct xenbus_transaction t,const char *dir,const char *node);
Signature · 1 line
2.50.1
Quoted 13 lines · On 13.07.25 15:26, [email protected] wrote:
From: "Dr. David Alan Gilbert" <[email protected]>
Remove three uncalled functions:
xenbus_mkdir()was added in 2007 by
commit4bac07c993d0("xen: add the Xenbus sysfs and virtual device hotplug driver")
but has remained unused.
xen_get_runstate_snapshot()last use was removed in 2016 by
commit6ba286ad8457("xen: support runqueue steal time on xen") which replaces the use by the_cpuversion.
Quoted 6 lines
xen_resume_notifier_unregister()last use was removed in 2017 by
commit1914f0cd203c("xen/acpi: upload PM state from init-domain to Xen")Remove them.
Signed-off-by Dr. David Alan Gilbert <[email protected]>
Juergen