Skip to contentSkip to conversation

tools/image-host.c build error

DISCUSSION Mark Kettenis 2 participants 2 messages Apr 19, 2022

lore
Share & tools
lore
#0 lore raw

Hello Philippe,

commit 6e052d1cbafbedbfba73070da483111f2ae68e5a broke building u-boot on OpenBSD:

tools/image-host.c:1208:10: error: use of undeclared identifier 'ENODATA'

The problem here is that ENODATA isn't in POSIX proper (it is part of the obsolete XSI STREAMS option so typically absent on systems with BSD heritage). So ENODATA should not be used in the host tools that are part of U-Boot. I would simply replace it with EINVAL, but maybe you have a different opinion.

I can send a proper patch if so desired.

Thanks,

Mark

#1 lore raw
Quoted 7 lines · Mark Kettenis

Hello Philippe,

commit 6e052d1cbafbedbfba73070da483111f2ae68e5a broke building u-boot on OpenBSD:

tools/image-host.c:1208:10: error: use of undeclared identifier 'ENODATA'

Quoted 7 lines

The problem here is that ENODATA isn't in POSIX proper (it is part of the obsolete XSI STREAMS option so typically absent on systems with BSD heritage). So ENODATA should not be used in the host tools that are part of U-Boot. I would simply replace it with EINVAL, but maybe you have a different opinion.

I can send a proper patch if so desired.

Please do. Sadly, I don't see BSD host options in Azure, which is where we have our Windows/macOS build tests done.

Signature · 1 line
Tom