s390x: epsw: fix report_pop_prefix() when running under non-QEMU
PATCH 1/3 s390x: epsw: fix report_pop_prefix() when running under non-QEMU
When we don't run in QEMU, we didn't push a prefix, hence pop won't work. Fix this by pushing the prefix before the QEMU check.
--- s390x/epsw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
s390x/epsw.c +2 -2
@@ -97,13 +97,13 @@ static void test_epsw(void)int main (int argc,char **argv) { +report_prefix_push ("epsw" ); +if (!host_is_kvm () && !host_is_tcg ()) {report_skip ("Not running under QEMU" ); goto done; } -report_prefix_push ("epsw" ); -test_epsw (); done:
Signature · 1 line
2.31.1
PATCH 2/3 s390x: tprot: use system include for mmu.h
mmu.h should come from the system includes
--- s390x/tprot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
s390x/tprot.c +1 -1
@@ -12,7 +12,7 @@#include <bitops.h> #include <asm/pgtable.h> #include <asm/interrupt.h> -#include "mmu.h" +#include <mmu.h> #include <vmalloc.h> #include <sclp.h>
Signature · 1 line
2.31.1
Re: [kvm-unit-tests PATCH v1 2/3] s390x: tprot: use system include for mmu.h
Quoted 1 line · Nico Boehr
mmu.hshould come from the system includes
Maybe: s/system/lib/
Quoted 11 lines
Signed-off-by Nico Boehr <[email protected]>--- s390x/tprot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)s390x/tprot.c +0
-0
s390x/tprot.c line 18
Quoted 8 lines
s390x/tprot.c +1
-1@@ -12,7 +12,7 @@#include <bitops.h> #include <asm/pgtable.h> #include <asm/interrupt.h> -#include "mmu.h" +#include <mmu.h> #include <vmalloc.h> #include <sclp.h>
PATCH v2 2/3 s390x: tprot: use lib include for mmu.h
mmu.h should come from the library includes
--- s390x/tprot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
s390x/tprot.c +1 -1
@@ -12,7 +12,7 @@#include <bitops.h> #include <asm/pgtable.h> #include <asm/interrupt.h> -#include "mmu.h" +#include <mmu.h> #include <vmalloc.h> #include <sclp.h>
Signature · 1 line
2.31.1
Re: [kvm-unit-tests PATCH v2 2/3] s390x: tprot: use lib include for mmu.h
Quoted 4 lines · Nico Boehr
mmu.hshould come from the library includesSigned-off-by Nico Boehr <[email protected]>Reviewed-by Thomas Huth <[email protected]>
Quoted 17 lines
--- s390x/tprot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)s390x/tprot.c +1
-1@@ -12,7 +12,7 @@#include <bitops.h> #include <asm/pgtable.h> #include <asm/interrupt.h> -#include "mmu.h" +#include <mmu.h> #include <vmalloc.h> #include <sclp.h>
Quoted 18 lines · Nico Boehr
When we don't run in QEMU, we didn't push a prefix, hence pop won't work. Fix this by pushing the prefix before the QEMU check.
Signed-off-by Nico Boehr <[email protected]>--- s390x/epsw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)s390x/epsw.c +2
-0@@ -97,13 +97,13 @@ static void test_epsw(void)int main (int argc,char **argv) { +report_prefix_push ("epsw" ); +
s390x/epsw.c static void test_epsw(void) · line 109
Quoted 10 lines
s390x/epsw.c +0
-2if (!host_is_kvm () && !host_is_tcg ()) {report_skip ("Not running under QEMU" ); goto done; } -report_prefix_push ("epsw" ); -test_epsw (); done:
Quoted 4 lines · Nico Boehr
When we don't run in QEMU, we didn't push a prefix, hence pop won't work. Fix this by pushing the prefix before the QEMU check.
Signed-off-by Nico Boehr <[email protected]>
Quoted 24 lines
--- s390x/epsw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)s390x/epsw.c +2
-2@@ -97,13 +97,13 @@ static void test_epsw(void)int main (int argc,char **argv) { +report_prefix_push ("epsw" ); +if (!host_is_kvm () && !host_is_tcg ()) {report_skip ("Not running under QEMU" ); goto done; } -report_prefix_push ("epsw" ); -test_epsw (); done: