ocfs2: Remove repeated uptodate check for buffer
PATCH 1/1 ocfs2: Remove repeated uptodate check for buffer
In commit 60f91826ca62 ("buffer: Avoid setting buffer bits that are already set"), function set_buffer_##name was added a test_bit() to check buffer, which is the same as function buffer_##name. The !buffer_uptodate(bh) here is a repeated check. Remove it.
--- fs/ocfs2/aops.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
fs/ocfs2/aops.c +1 -2
@@ -634,8 +634,7 @@ int ocfs2_map_page_blocks(struct page *page, u64 *p_blkno, }if (PageUptodate (page)) { -if (!buffer_uptodate (bh)) -set_buffer_uptodate (bh); +set_buffer_uptodate (bh); } else if (!buffer_uptodate(bh) && !buffer_delay(bh) && !buffer_new(bh) && ocfs2_should_read_blk(inode, page, block_start) &&
Signature · 1 line
2.25.1
Quoted 6 lines · Wan Jiabing
In commit
60f91826ca62("buffer: Avoid setting buffer bits that are already set"), function set_buffer_##name was added atest_bit()to check buffer, which is the same as function buffer_##name. The !buffer_uptodate(bh) here is a repeated check. Remove it.Signed-off-by Wan Jiabing <[email protected]>
Looks good.
Quoted 10 lines
--- fs/ocfs2/aops.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)fs/ocfs2/aops.c +0
-0
fs/ocfs2/aops.c int ocfs2_map_page_blocks(struct page *page, u64 *p_blkno, · line 640
Quoted 9 lines
fs/ocfs2/aops.c +1
-2@@ -634,8 +634,7 @@ int ocfs2_map_page_blocks(struct page *page, u64 *p_blkno, }if (PageUptodate (page)) { -if (!buffer_uptodate (bh)) -set_buffer_uptodate (bh); +set_buffer_uptodate (bh); } else if (!buffer_uptodate(bh) && !buffer_delay(bh) && !buffer_new(bh) && ocfs2_should_read_blk(inode, page, block_start) &&
_______________________________________________
Ocfs2-devel mailing list
[email protected]
https://oss.oracle.com/mailman/listinfo/ocfs2-devel