new board ls1028ardb introduced
cover new board ls1028ardb introduced
The following nine patches is to enable LS1028ARDB board in Buildroot.
NXP LS1028A silicon is based on Arm A72 core and designed for industry, some key features are enabled:
TSN - Time Sensitive Network on Network interface TSN/Swith - naive TSN Swith, support six ports
DP - display port for different resolution up to 4K
The base for these patches is "next" branch, commitID: 5fd8db02ef
1. Upgrade the RCW version to latest version supported via LSDK-19.09
2. Use RCW binary for boot board
3. Intruduce u-boot-dtb.bin for NXP Layerscape serial platform
4. Introduce RCW to Arm-trusted-firmware
5. Create one freescale-qoriq direcotry for all firmware hardware related
6. LS1028ARDB DP firmware is stored in freescale-qoriq
7. New patches to eanble GPIO interrupt for eNETC and Micro-bus
8. One standard directory for all Layerscape platform
9. LS1028ARDB related scripts and default configurations
---
PATCH 1/9 package/rcw: upgrade the rcw version to LSDK-19.09
Change the RCW version to LSDK-19.09.
--- package/rcw/rcw.hash | 3 +-- package/rcw/rcw.mk | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-)
package/rcw/rcw.hash +1 -2
@@ -1,3 +1,2 @@ # Locally calculated -sha256 1421ada9fec10b12ff21cd9ad82f0a835b191cb2dde80f03547764574b1346c3 rcw-LSDK-18.12.tar.gz -sha256 a531b3146425e592db17a51ff39c4801cb01fb4055ffdaada0572decc0655bcd LICENSE +sha256 b69a6a8b187ba794e0af716a509ced2bbac83da0f6e94b5c7331a34619db21b1 rcw-LSDK-19.09.tar.gz
package/rcw/rcw.mk +1 -1
@@ -4,7 +4,7 @@ # ################################################################################ -RCW_VERSION = LSDK-18.12 +RCW_VERSION = LSDK-19.09 RCW_SITE = https://source.codeaurora.org/external/qoriq/qoriq-components/rcw RCW_SITE_METHOD = git RCW_LICENSE = BSD-3-Clause
Signature · 1 line
2.17.1
PATCH 1/9 package/rcw: upgrade the rcw version to LSDK-19.09
Hello Jerry,
First of all, thanks a lot for this patch series, it is very nice to see NXP directly contributing to Buildroot some support for the LS1028 platform. See below one question about this patch.
Quoted 13 lines · On Wed, 20 Nov 2019 12:07:17 +0800 Changming Huang <[email protected]> wrote:
Change the RCW version to LSDK-19.09.
Signed-off-by Changming Huang <[email protected]>--- package/rcw/rcw.hash | 3 +-- package/rcw/rcw.mk | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-)package/rcw/rcw.hash +0
-0
package/rcw/rcw.hash line 3
Quoted 3 lines
package/rcw/rcw.hash +0
-2@@ -1,3 +1,2 @@ # Locally calculated -sha256 1421ada9fec10b12ff21cd9ad82f0a835b191cb2dde80f03547764574b1346c3 rcw-LSDK-18.12.tar.gz -sha256 a531b3146425e592db17a51ff39c4801cb01fb4055ffdaada0572decc0655bcd LICENSE
Why are you removing the hash of the license file here ?
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
[Buildroot] [EXT] Re: [PATCH 1/9] package/rcw: upgrade the rcw version to LSDK-19.09
Thanks for your reply, Thomas.
I will add-back the hash of license file in next version.
Best Regards
Jerry Huang
-----Original Message-----
From: Thomas Petazzoni <[email protected]>
Sent: Wednesday, November 20, 2019 4:00 PM
To: Jerry Huang <[email protected]>
Cc: buildroot at busybox.net
Subject: [EXT] Re: [Buildroot] [PATCH 1/9] package/rcw: upgrade the rcw version to LSDK-19.09
Caution: EXT Email
Hello Jerry,
First of all, thanks a lot for this patch series, it is very nice to see NXP directly contributing to Buildroot some support for the LS1028 platform. See below one question about this patch.
Quoted 15 lines · On Wed, 20 Nov 2019 12:07:17 +0800 Changming Huang <[email protected]> wrote:
Change the RCW version to LSDK-19.09.
Signed-off-by Changming Huang <[email protected]>--- package/rcw/rcw.hash | 3 +-- package/rcw/rcw.mk | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-)package/rcw/rcw.hash index renamed from package/rcw/rcw.hash +0
-0
7de1ec659a..3fbb5d167f100644package/rcw/rcw.hash +0
-1@@ -1,3 +1,2 @@ # Locally calculated -sha256
Quoted 5 lines
1421ada9fec10b12ff21cd9ad82f0a835b191cb2dde80f03547764574b1346c3rcw-LSDK-18.12.tar.gz
-sha256a531b3146425e592db17a51ff39c4801cb01fb4055ffdaada0572decc0655bcdLICENSE
Why are you removing the hash of the license file here ?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbootlin.com&data=02%7C01%7Cjerry.huang%40nxp.com%7C386c6a3dbcc941510fa508d76d8f9be5%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637098335879692477&sdata=i4kLTZ4FkszCKJEZ7sBpbJ4h%2BcsrrFe5HbjJzB3jz1I%3D&reserved=0
PATCH 1/9 package/rcw: upgrade the rcw version to LSDK-19.09
In reply to Changming HuangAm 2019-11-20 05:07, schrieb Changming Huang:
package/rcw/rcw.hash
Quoted 12 lines
Change the RCW version to LSDK-19.09.
Signed-off-by Changming Huang <[email protected]>--- package/rcw/rcw.hash | 3 +-- package/rcw/rcw.mk | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-)package/rcw/rcw.hash +0
-0
sorry for missing the initial commit.. but IMHO the package name "rcw" is _really_ bad. because its too generic. what if another SoC also has a package rcw. So if it is still possible, could it be renamed to rcw-qoriq ?
-michael
PATCH 1/9 package/rcw: upgrade the rcw version to LSDK-19.09
Hello,
Quoted 9 lines · On Wed, 20 Nov 2019 10:21:12 +0100 Michael Walle <[email protected]> wrote:
package/rcw/rcw.hash
Quoted 4 lines
package/rcw/rcw.hash +0
-0sorry for missing the initial commit.. but IMHO the package name "rcw" is _really_ bad. because its too generic. what if another SoC also has a package rcw. So if it is still possible, could it be renamed to rcw-qoriq ?
True, rcw is very short and quite generic. Matt, what do you think?
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/9 package/rcw: upgrade the rcw version to LSDK-19.09
Thomas, Michael,
Quoted 16 lines · Thomas Petazzoni
Hello,
Quoted 9 lines · On Wed, 20 Nov 2019 10:21:12 +0100 Michael Walle <[email protected]> wrote:
package/rcw/rcw.hash
Quoted 4 lines
package/rcw/rcw.hash +0
-0sorry for missing the initial commit.. but IMHO the package name "rcw" is _really_ bad. because its too generic. what if another SoC also has a package rcw. So if it is still possible, could it be renamed to rcw-qoriq ?
Quoted 2 lines
True, rcw is very short and quite generic. Matt, what do you think?
Michael, good points, maybe we could append a prefix to make it freescale-qoriq-rcw?
Matt
PATCH 1/9 package/rcw: upgrade the rcw version to LSDK-19.09
Quoted 4 lines · On Wed, 20 Nov 2019 03:38:40 -0600 Matthew Weber <[email protected]>…
Quoted 1 line
True, rcw is very short and quite generic. Matt, what do you think?
Michael, good points, maybe we could append a prefix to make it freescale-qoriq-rcw?
Yes, freescale-qorqiq-rcw is good.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
[Buildroot] [External] Re: [PATCH 1/9] package/rcw: upgrade the rcw version to LSDK-19.09
Changming,
Quoted 11 lines · Thomas Petazzoni
Quoted 4 lines · On Wed, 20 Nov 2019 03:38:40 -0600 Matthew Weber <[email protected]>…
Quoted 1 line
True, rcw is very short and quite generic. Matt, what do you think?
Michael, good points, maybe we could append a prefix to make it freescale-qoriq-rcw?
Yes, freescale-qorqiq-rcw is good.
I can send a patch, however do you want to add this rename as a patch in your current layerscape devkit series as you touch lots of RCW variables? Let me know your plan, I can send it but I don't want to do it in the middle of your work :).
Matt
[Buildroot] [EXT] Re: [External] Re: [PATCH 1/9] package/rcw: upgrade the rcw version to LSDK-19.09
Hi, Matt,
Best Regards
Jerry Huang
Quoted 24 lines
-----Original Message-----
From: Matthew Weber <[email protected]>
Sent: Wednesday, November 20, 2019 5:52 PM
To: Thomas Petazzoni <[email protected]>
Cc: Michael Walle <[email protected]>; Jerry Huang <[email protected]>; buildroot mailing list <[email protected]>
Subject: [EXT] Re: [External] Re: [Buildroot] [PATCH 1/9] package/rcw: upgrade the rcw version to LSDK-19.09Caution: EXT Email
Changming,
Quoted 9 lines · Thomas Petazzoni
Quoted 4 lines · On Wed, 20 Nov 2019 03:38:40 -0600 Matthew Weber <[email protected]>…
Quoted 1 line
True, rcw is very short and quite generic. Matt, what do you think?
Michael, good points, maybe we could append a prefix to make it freescale-qoriq-rcw?
Quoted 7 lines
Quoted 2 lines
Yes, freescale-qorqiq-rcw is good.
I can send a patch, however do you want to add this rename as a patch in your current layerscape devkit series as you touch lots of RCW variables? Let me know your plan, I can send it but I don't want to do it in the middle of your work :).
I can add this rename as a patch
I created one sub-directory " freescale-qoriq" for all hardware related, So, can I move RCW after rename into this directory?
Quoted 1 line
Matt
[Buildroot] [External] Re: [PATCH 1/9] package/rcw: upgrade the rcw version to LSDK-19.09
In reply to Matthew WeberHi,
Am 2019-11-20 10:51, schrieb Matthew Weber:
Quoted 14 lines
Changming,
Quoted 10 lines · Thomas Petazzoni
Quoted 4 lines · On Wed, 20 Nov 2019 03:38:40 -0600 Matthew Weber <[email protected]>…
Quoted 1 line
True, rcw is very short and quite generic. Matt, what do you think?
Michael, good points, maybe we could append a prefix to make it freescale-qoriq-rcw?
Yes, freescale-qorqiq-rcw is good.
sounds good. but also see below.
Quoted 6 lines
Quoted 1 line
I can send a patch, however do you want to add this rename as a patch in your current layerscape devkit series as you touch lots of RCW variables? Let me know your plan, I can send it but I don't want to do it in the middle of your work :).
The RCW is really board dependent. I can imagine some OEMs are using the ones from freescale, but most likely they won't fit their boards. For example, we have our own RCW repository (although only binary for now) for our board. Therefore, wouldn't it be better to have different rcw config(s) in the board directories?
TBH I just had a quick look at the package makefile and saw that it copies the RCWs to /usr/share. Most likely, you (also?) need them in a flash/sdcard image, though.
-michael
[Buildroot] [External] Re: [PATCH 1/9] package/rcw: upgrade the rcw version to LSDK-19.09
Michael,
Quoted 12 lines · Michael Walle
Hi,
Am 2019-11-20 10:51, schrieb Matthew Weber:
Quoted 8 lines
Changming,
Quoted 4 lines · Thomas Petazzoni
On Wed, 20 Nov 2019 03:38:40 -0600
Matthew Weber <[email protected]> wrote:
Quoted 8 lines
Quoted 6 lines
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
True, rcw is very short and quite generic. Matt, what do you think?
Michael, good points, maybe we could append a prefix to make it freescale-qoriq-rcw?
Yes, freescale-qorqiq-rcw is good.
sounds good. but also see below.
I see Changming's email about nesting this in the folder as well. No issue with that as long as the maintainers support it (similar to freescale-imx)
Quoted 8 lines
Quoted 7 lines
Quoted 2 lines
I can send a patch, however do you want to add this rename as a patch in your current layerscape devkit series as you touch lots of RCW variables? Let me know your plan, I can send it but I don't want to do it in the middle of your work :).
Quoted 5 lines
The RCW is really board dependent. I can imagine some OEMs are using the ones from freescale, but most likely they won't fit their boards. For example, we have our own RCW repository (although only binary for now) for our board. Therefore, wouldn't it be better to have different rcw config(s) in the board directories?
On the next branch there is a patch applied that allows custom board rcws to meet that need.
Quoted 4 lines
TBH I just had a quick look at the package makefile and saw that it copies the RCWs to
/usr/share. Most likely, you (also?) need them in a flash/sdcard image, though.
Agree, the package was originally setup to stage all the pieces the user needs to use the tool outside of the build from a deployed SDK for creating images (mainly a board bringup/hardware developer use case). REcently a patch was applied to Next that allows customized boards and with Changming's patch you can stage pre-defined board rcw binaries for use.
Matt
[Buildroot] [EXT] Re: [PATCH 1/9] package/rcw: upgrade the rcw version to LSDK-19.09
In reply to Thomas PetazzoniBest Regards
Jerry Huang
Quoted 14 lines
-----Original Message-----
From: Thomas Petazzoni <[email protected]>
Sent: Wednesday, November 20, 2019 5:46 PM
To: Matthew Weber <[email protected]>
Cc: Michael Walle <[email protected]>; Jerry Huang <[email protected]>; buildroot mailing list <[email protected]>
Subject: [EXT] Re: [Buildroot] [PATCH 1/9] package/rcw: upgrade the rcw version to LSDK-19.09Caution: EXT Email
On Wed, 20 Nov 2019 03:38:40 -0600
Matthew Weber <[email protected]> wrote:
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
True, rcw is very short and quite generic. Matt, what do you think?
Michael, good points, maybe we could append a prefix to make it freescale-qoriq-rcw?
Yes, freescale-qorqiq-rcw is good.
I create sub-directory " freescale-qoriq" in patch 0005-package-freescale-qoriq-xxx, so the RCW package can be moved into that? Because RCW is related with hardware for QorIQ serial platforms.
Quoted 9 lines
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbootlin.c
om&data=02%7C01%7Cjerry.huang%40nxp.com%7Ca79baf082b6c4b3d45 3c08d76d9e67fa%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6370 98399419780949&sdata=egdHxRKFOKtMuW2CusUxAU%2BLiAMXdZQ85m bUBJGCRPw%3D&reserved=0
PATCH 2/9 package/rcw: add target rcw binary support
In reply to Changming HuangFor NXP QorIQ (PowerPC and Layerscape) platform, we need to specify the RCW file and build it to binary.
Introduce BR2_PACKAGE_HOST_RCW_BIN to specify the RCW binary file
Introduce BR2_PACKAGE_HOST_RCW_BOOT_MODE to define the boot mode. Because the RCW binary can be stored in different media, for example:
SD card - RCW locate in SD card, boot the board from SD card
eMMC - RCW locate in eMMC chip, boot the board from eMMC chip
flexSPI - RCW locate in flexSPI, boot the board from flexSPI Nor/Nand flash
QSPI - RCW locate in QSPI flash, boot the board from QSPI flash
--- package/rcw/Config.in.host | 6 ++++++ package/rcw/rcw.mk | 11 +++++++++++ 2 files changed, 17 insertions(+)
package/rcw/Config.in.host +6 -0
@@ -25,4 +25,10 @@ config BR2_PACKAGE_HOST_RCW_CUSTOM_PATH included for use in the SDK or with post scripts but no RCW binary will not be generated. +config BR2_PACKAGE_HOST_RCW_BIN + string "Custom RCW" + +config BR2_PACKAGE_HOST_RCW_BOOT_MODE + string "Boot mode" + endif
package/rcw/rcw.mk +11 -0
@@ -37,6 +37,17 @@ endef define HOST_RCW_INSTALL_DELIVERY_FILE $(INSTALL) -D -m 0644 $(@D)/PBL.bin $(BINARIES_DIR)/PBL.bin endef +else +RCW_BIN = $(call qstrip,$(BR2_PACKAGE_HOST_RCW_BIN)) +RCW_PLATFORM = $(firstword $(subst /, ,$(RCW_BIN))) + +define HOST_RCW_BUILD_CMDS + cd $(@D)/$(RCW_PLATFORM) && $(MAKE) +endef + +define HOST_RCW_INSTALL_DELIVERY_FILE + $(INSTALL) -D -m 0644 $(@D)/$(RCW_BIN) $(BINARIES_DIR)/ +endef endif # Copy source files and script into $(HOST_DIR)/share/rcw/ so a developer
Signature · 1 line
2.17.1
PATCH 2/9 package/rcw: add target rcw binary support
Changming ,
Quoted 24 lines · Changming Huang
For NXP QorIQ (PowerPC and Layerscape) platform, we need to specify the RCW file and build it to binary.
Introduce
BR2_PACKAGE_HOST_RCW_BINto specify the RCW binary fileIntroduce
BR2_PACKAGE_HOST_RCW_BOOT_MODEto define the boot mode. Because the RCW binary can be stored in different media, for example:
SD card - RCW locate in SD card, boot the board from SD card
eMMC - RCW locate in eMMC chip, boot the board from eMMC chip
flexSPI - RCW locate in flexSPI, boot the board from flexSPI Nor/Nand flash
QSPI - RCW locate in QSPI flash, boot the board from QSPI flashSigned-off-by Changming Huang <[email protected]>--- package/rcw/Config.in.host | 6 ++++++ package/rcw/rcw.mk | 11 +++++++++++ 2 files changed, 17 insertions(+)package/rcw/Config.in.host +0
-0
package/rcw/Config.in.host config BR2_PACKAGE_HOST_RCW_CUSTOM_PATH · line 29
Quoted 5 lines
package/rcw/Config.in.host +2
-0@@ -25,4 +25,10 @@ config BR2_PACKAGE_HOST_RCW_CUSTOM_PATH included for use in the SDK or with post scripts but no RCW binary will not be generated. +config BR2_PACKAGE_HOST_RCW_BIN + string "Custom RCW"
Maybe instead of the word "Custom" use "Vendor" as you're wanting to specify a built in RCW build target that NXP is providing by default?
package/rcw/Config.in.host config BR2_PACKAGE_HOST_RCW_CUSTOM_PATH · line 32
Quoted 3 lines
package/rcw/Config.in.host +3
-0+ +config BR2_PACKAGE_HOST_RCW_BOOT_MODE + string "Boot mode"
Since there is a definitive list of options, maybe provide them to the user to select? Also, where is this used, is it just in the ATF package?
Quoted 31 lines
package/rcw/Config.in.host +1
-0+ endifpackage/rcw/rcw.mk +11
-1@@ -37,6 +37,17 @@ endef define HOST_RCW_INSTALL_DELIVERY_FILE $(INSTALL) -D -m 0644 $(@D)/PBL.bin $(BINARIES_DIR)/PBL.bin endef +else +RCW_BIN = $(call qstrip,$(BR2_PACKAGE_HOST_RCW_BIN)) +RCW_PLATFORM = $(firstword $(subst /, ,$(RCW_BIN))) + +define HOST_RCW_BUILD_CMDS + cd $(@D)/$(RCW_PLATFORM) && $(MAKE) +endef + +define HOST_RCW_INSTALL_DELIVERY_FILE + $(INSTALL) -D -m 0644 $(@D)/$(RCW_BIN) $(BINARIES_DIR)/ +endef endif # Copy source files and script into $(HOST_DIR)/share/rcw/ so a developer --2.17.1
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 23 lines
Matthew Weber | Associate Director Software Engineer | Commercial Avionics COLLINS AEROSPACE 400 Collins Road NE, Cedar Rapids, Iowa 52498, USA Tel: +1 319 295 7349 | FAX: +1 319 263 6099 matthew.weber at collins.com | collinsaerospace.com CONFIDENTIALITY WARNING: This message may contain proprietary and/or privileged information of Collins Aerospace and its affiliated companies. If you are not the intended recipient, please 1) Do not disclose, copy, distribute or use this message or its contents. 2) Advise the sender by return email. 3) Delete all copies (including all attachments) from your computer. Your cooperation is greatly appreciated. Any export restricted material should be shared using my matthew.weber at corp.rockwellcollins.com address.
PATCH 3/9 boot/arm-trusted-firmware: Add u-boot-dtb.bin support
In reply to Changming HuangNXP Layerscape platforms use u-boot-dtb.bin to boot the board.
--- boot/arm-trusted-firmware/arm-trusted-firmware.mk | 4 ++++ 1 file changed, 4 insertions(+)
boot/arm-trusted-firmware/arm-trusted-firmware.mk +4 -0
@@ -70,7 +70,11 @@ endif endif # BR2_TARGET_ARM_TRUSTED_FIRMWARE_BL32_OPTEE ifeq ($(BR2_TARGET_ARM_TRUSTED_FIRMWARE_UBOOT_AS_BL33),y) +ifeq ($(BR2_TARGET_UBOOT_FORMAT_DTB_BIN),y) +ARM_TRUSTED_FIRMWARE_MAKE_OPTS += BL33=$(BINARIES_DIR)/u-boot-dtb.bin +else ARM_TRUSTED_FIRMWARE_MAKE_OPTS += BL33=$(BINARIES_DIR)/u-boot.bin +endif ARM_TRUSTED_FIRMWARE_DEPENDENCIES += uboot endif
Signature · 1 line
2.17.1
PATCH 3/9 boot/arm-trusted-firmware: Add u-boot-dtb.bin support
Quoted 12 lines
NXP Layerscape platforms use u-boot-dtb.bin to boot the board.
Signed-off-by Changming Huang <[email protected]>--- boot/arm-trusted-firmware/arm-trusted-firmware.mk | 4 ++++ 1 file changed, 4 insertions(+)boot/arm-trusted-firmware/arm-trusted-firmware.mk +0
-0
boot/arm-trusted-firmware/arm-trusted-firmware.mk endif · line 79
Quoted 10 lines
boot/arm-trusted-firmware/arm-trusted-firmware.mk +4
-0@@ -70,7 +70,11 @@ endif endif # BR2_TARGET_ARM_TRUSTED_FIRMWARE_BL32_OPTEE ifeq ($(BR2_TARGET_ARM_TRUSTED_FIRMWARE_UBOOT_AS_BL33),y) +ifeq ($(BR2_TARGET_UBOOT_FORMAT_DTB_BIN),y) +ARM_TRUSTED_FIRMWARE_MAKE_OPTS += BL33=$(BINARIES_DIR)/u-boot-dtb.bin +else ARM_TRUSTED_FIRMWARE_MAKE_OPTS += BL33=$(BINARIES_DIR)/u-boot.bin +endif ARM_TRUSTED_FIRMWARE_DEPENDENCIES += uboot endif
Hi Jerry, Thomas, and all
Looks good, but probably we could make it a little bit more future-proof. What do you think about using the same pattern-based approach here as implemented in commit e4d276c357fdf9f19f99f8 (buildroot next branch) for ATF firmware images.
In brief, to add option BR2_TARGET_ARM_TRUSTED_FIRMWARE_UBOOT_BL33_IMAGE in arm-trusted-firmware Config.in and set its default value to u-boot.bin. Then u-boot-dtb.bin value could be specified in the board defconfig.
Thoughts ? Comments ?
Regards,
Sergey
[Buildroot] [EXT] Re: [PATCH 3/9] boot/arm-trusted-firmware: Add u-boot-dtb.bin support
Best Regards
Jerry Huang
Quoted 42 lines
-----Original Message-----
From: Sergey Matyukevich <[email protected]>
Sent: Wednesday, November 20, 2019 3:38 PM
To: Jerry Huang <[email protected]>
Cc: buildroot at busybox.net
Subject: [EXT] Re: [Buildroot] [PATCH 3/9] boot/arm-trusted-firmware: Add u-boot-dtb.bin supportCaution: EXT Email
Quoted 13 lines
NXP Layerscape platforms use u-boot-dtb.bin to boot the board.
Signed-off-by Changming Huang <[email protected]>--- boot/arm-trusted-firmware/arm-trusted-firmware.mk | 4 ++++ 1 file changed, 4 insertions(+)boot/arm-trusted-firmware/arm-trusted-firmware.mk +0
-0boot/arm-trusted-firmware/arm-trusted-firmware.mk endif · line 74
Quoted 5 lines
boot/arm-trusted-firmware/arm-trusted-firmware.mk +2
-0@@ -70,7 +70,11 @@ endif endif # BR2_TARGET_ARM_TRUSTED_FIRMWARE_BL32_OPTEE ifeq ($(BR2_TARGET_ARM_TRUSTED_FIRMWARE_UBOOT_AS_BL33),y) +ifeq ($(BR2_TARGET_UBOOT_FORMAT_DTB_BIN),y) +ARM_TRUSTED_FIRMWARE_MAKE_OPTS +=BL33=$(BINARIES_DIR)/u-boot-dtb.bin
boot/arm-trusted-firmware/arm-trusted-firmware.mk endif · line 76
Quoted 2 lines
boot/arm-trusted-firmware/arm-trusted-firmware.mk +1
-0+else ARM_TRUSTED_FIRMWARE_MAKE_OPTS +=BL33=$(BINARIES_DIR)/u-boot.bin
boot/arm-trusted-firmware/arm-trusted-firmware.mk endif · line 78
Quoted 2 lines
boot/arm-trusted-firmware/arm-trusted-firmware.mk +1
-0+endif ARM_TRUSTED_FIRMWARE_DEPENDENCIES += uboot endifHi Jerry, Thomas, and all
Looks good, but probably we could make it a little bit more future-proof. What do you think about using the same pattern-based approach here as implemented in commit
e4d276c357fdf9f19f99f8(buildroot next branch) for ATF firmware images.
Quoted 7 lines
In brief, to add option
BR2_TARGET_ARM_TRUSTED_FIRMWARE_UBOOT_BL33_IMAGE
in arm-trusted-firmware Config.in and set its default value to u-boot.bin. Then u-boot-dtb.bin value could be specified in the board defconfig.Thoughts ? Comments ?
That sound good for me.
May I draft the first version for that?
Quoted 2 lines
Regards,
Sergey
PATCH 3/9 boot/arm-trusted-firmware: Add u-boot-dtb.bin support
In reply to Sergey MatyukevichHello Sergey, Hello Jerry,
Quoted 11 lines · On Wed, 20 Nov 2019 10:37:54 +0300 Sergey Matyukevich <[email protected]>…
boot/arm-trusted-firmware/arm-trusted-firmware.mk endif · line 79
Quoted 8 lines
ifeq ($(BR2_TARGET_ARM_TRUSTED_FIRMWARE_UBOOT_AS_BL33),y)
boot/arm-trusted-firmware/arm-trusted-firmware.mk +4
-0+ifeq ($(BR2_TARGET_UBOOT_FORMAT_DTB_BIN),y) +ARM_TRUSTED_FIRMWARE_MAKE_OPTS += BL33=$(BINARIES_DIR)/u-boot-dtb.bin +else ARM_TRUSTED_FIRMWARE_MAKE_OPTS += BL33=$(BINARIES_DIR)/u-boot.bin +endif ARM_TRUSTED_FIRMWARE_DEPENDENCIES += uboot endifHi Jerry, Thomas, and all
Quoted 8 lines
Looks good, but probably we could make it a little bit more future-proof. What do you think about using the same pattern-based approach here as implemented in commit
e4d276c357fdf9f19f99f8(buildroot next branch) for ATF firmware images.In brief, to add option
BR2_TARGET_ARM_TRUSTED_FIRMWARE_UBOOT_BL33_IMAGEin arm-trusted-firmware Config.in and set its default value to u-boot.bin. Then u-boot-dtb.bin value could be specified in the board defconfig.
I was going to say that Jerry's solution looks better, as it's more automatic for the user.
However, the selection of the U-Boot image format is not a Kconfig "choice" in boot/uboot/Config.in: one can select multiple images. In this case, how can ATF know which one to use ? Jerry's proposal is to assume that if BR2_TARGET_UBOOT_FORMAT_DTB_BIN=y, then you want to use u-boot-dtb.bin, but if there are multiple U-Boot images enabled, it's indeed difficult to know which one to chose for ATF.
So, I agree with Sergey: probably the easiest is simply some free-form string option, with a default to u-boot.bin to preserve backward compatibility.
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 4/9 boot/arm-trusted-firmware: Add RCW support
In reply to Changming HuangNXP Layerscape platforms use RCW (Reset Configure Word) to setup clocking and IO allocations and then launches the next stage of boot. RCW needs ATF as well as uboot.BR2_PACKAGE_HOST_RCW_BOOT_MODE is used to determine if ATF is used for RCW.
--- boot/arm-trusted-firmware/arm-trusted-firmware.mk | 9 +++++++++ 1 file changed, 9 insertions(+)
boot/arm-trusted-firmware/arm-trusted-firmware.mk +9 -0
@@ -95,6 +95,15 @@ endif ARM_TRUSTED_FIRMWARE_MAKE_TARGETS = all +RCW_BOOT_MODE = $(call qstrip,$(BR2_PACKAGE_HOST_RCW_BOOT_MODE)) +ifneq ($(RCW_BOOT_MODE),) +RCW_PATH = $(call qstrip,$(BR2_PACKAGE_HOST_RCW_BIN)) +RCW_FILE = $(lastword $(subst /, ,$(RCW_PATH))) +ARM_TRUSTED_FIRMWARE_MAKE_OPTS += BOOT_MODE=$(RCW_BOOT_MODE) RCW=$(BINARIES_DIR)/$(RCW_FILE) +ARM_TRUSTED_FIRMWARE_MAKE_TARGETS += pbl +ARM_TRUSTED_FIRMWARE_DEPENDENCIES += host-rcw +endif + ifeq ($(BR2_TARGET_ARM_TRUSTED_FIRMWARE_FIP),y) ARM_TRUSTED_FIRMWARE_MAKE_TARGETS += fip ARM_TRUSTED_FIRMWARE_DEPENDENCIES += host-openssl
Signature · 1 line
2.17.1
PATCH 4/9 boot/arm-trusted-firmware: Add RCW support
Quoted 10 lines
boot/arm-trusted-firmware/arm-trusted-firmware.mk +2
-0@@ -95,6 +95,15 @@ endif ARM_TRUSTED_FIRMWARE_MAKE_TARGETS = all +RCW_BOOT_MODE = $(call qstrip,$(BR2_PACKAGE_HOST_RCW_BOOT_MODE)) +ifneq ($(RCW_BOOT_MODE),)
boot/arm-trusted-firmware/arm-trusted-firmware.mk endif · line 109
Quoted 10 lines
boot/arm-trusted-firmware/arm-trusted-firmware.mk +7
-0+RCW_PATH = $(call qstrip,$(BR2_PACKAGE_HOST_RCW_BIN)) +RCW_FILE = $(lastword $(subst /, ,$(RCW_PATH))) +ARM_TRUSTED_FIRMWARE_MAKE_OPTS += BOOT_MODE=$(RCW_BOOT_MODE) RCW=$(BINARIES_DIR)/$(RCW_FILE) +ARM_TRUSTED_FIRMWARE_MAKE_TARGETS += pbl +ARM_TRUSTED_FIRMWARE_DEPENDENCIES += host-rcw +endif + ifeq ($(BR2_TARGET_ARM_TRUSTED_FIRMWARE_FIP),y) ARM_TRUSTED_FIRMWARE_MAKE_TARGETS += fip ARM_TRUSTED_FIRMWARE_DEPENDENCIES += host-openssl
Hi Jerry and all,
Here arm-trusted-firmware build is modified when some host package with specific configuration is enabled in board config.
Shouldn't it be the other way around ? To be more specific: another Config.in option for arm-trusted-firmware which pulls required build time dependencies, e.g. see Marvell DDR options or FIP options.
Regards,
Sergey
[Buildroot] [EXT] Re: [PATCH 4/9] boot/arm-trusted-firmware: Add RCW support
Thanks a lot for your reply.
My comment in lines.
Best Regards
Jerry Huang
Quoted 36 lines
-----Original Message-----
From: Sergey Matyukevich <[email protected]>
Sent: Wednesday, November 20, 2019 3:50 PM
To: Jerry Huang <[email protected]>
Cc: buildroot at busybox.net
Subject: [EXT] Re: [Buildroot] [PATCH 4/9] boot/arm-trusted-firmware: Add RCW supportCaution: EXT Email
boot/arm-trusted-firmware/arm-trusted-firmware.mk endif · line 98
Quoted 10 lines
boot/arm-trusted-firmware/arm-trusted-firmware.mk +1
-0@@ -95,6 +95,15 @@ endif ARM_TRUSTED_FIRMWARE_MAKE_TARGETS = all +RCW_BOOT_MODE = $(callqstrip,$(BR2_PACKAGE_HOST_RCW_BOOT_MODE))
boot/arm-trusted-firmware/arm-trusted-firmware.mk endif
Quoted 4 lines
boot/arm-trusted-firmware/arm-trusted-firmware.mk +4
-0+ifneq ($(RCW_BOOT_MODE),) +RCW_PATH = $(call qstrip,$(BR2_PACKAGE_HOST_RCW_BIN)) +RCW_FILE = $(lastword $(subst /, ,$(RCW_PATH))) +ARM_TRUSTED_FIRMWARE_MAKE_OPTS +=BOOT_MODE=$(RCW_BOOT_MODE)
boot/arm-trusted-firmware/arm-trusted-firmware.mk endif · line 103
Quoted 1 line
boot/arm-trusted-firmware/arm-trusted-firmware.mk +1
-0+RCW=$(BINARIES_DIR)/$(RCW_FILE)
ARM_TRUSTED_FIRMWARE_MAKE_TARGETS+=Quoted 5 lines
boot/arm-trusted-firmware/arm-trusted-firmware.mk +2
-0+pbl ARM_TRUSTED_FIRMWARE_DEPENDENCIES += host-rcw endif + ifeq ($(BR2_TARGET_ARM_TRUSTED_FIRMWARE_FIP),y) ARM_TRUSTED_FIRMWARE_MAKE_TARGETS += fip
ARM_TRUSTED_FIRMWARE_DEPENDENCIES+= host-opensslHi Jerry and all,
Quoted 6 lines
Here arm-trusted-firmware build is modified when some host package with specific configuration is enabled in board config.
Shouldn't it be the other way around ? To be more specific: another Config.in option for arm-trusted-firmware which pulls required build time dependencies, e.g. see Marvell DDR options or FIP options.
1. If use another Config.in option for arm-trusted-firmware like Marvell DDR , need to mv package/rcw to boot/ directory.
2. Refer to FIP, add option like this BR2_PACKAGE_HOST_RCW_ATF in package/rcw/Config.in.host.
How do you think about the second way?
Quoted 2 lines
Regards,
Sergey
[Buildroot] [EXT] Re: [PATCH 4/9] boot/arm-trusted-firmware: Add RCW support
Quoted 29 lines
Quoted 29 lines
boot/arm-trusted-firmware/arm-trusted-firmware.mk endif · line 98
Quoted 10 lines
boot/arm-trusted-firmware/arm-trusted-firmware.mk +1
-0@@ -95,6 +95,15 @@ endif ARM_TRUSTED_FIRMWARE_MAKE_TARGETS = all +RCW_BOOT_MODE = $(callqstrip,$(BR2_PACKAGE_HOST_RCW_BOOT_MODE))
boot/arm-trusted-firmware/arm-trusted-firmware.mk endif
Quoted 4 lines
boot/arm-trusted-firmware/arm-trusted-firmware.mk +4
-0+ifneq ($(RCW_BOOT_MODE),) +RCW_PATH = $(call qstrip,$(BR2_PACKAGE_HOST_RCW_BIN)) +RCW_FILE = $(lastword $(subst /, ,$(RCW_PATH))) +ARM_TRUSTED_FIRMWARE_MAKE_OPTS +=BOOT_MODE=$(RCW_BOOT_MODE)
boot/arm-trusted-firmware/arm-trusted-firmware.mk endif · line 103
Quoted 1 line
boot/arm-trusted-firmware/arm-trusted-firmware.mk +1
-0+RCW=$(BINARIES_DIR)/$(RCW_FILE)
ARM_TRUSTED_FIRMWARE_MAKE_TARGETS+=Quoted 5 lines
boot/arm-trusted-firmware/arm-trusted-firmware.mk +2
-0+pbl ARM_TRUSTED_FIRMWARE_DEPENDENCIES += host-rcw endif + ifeq ($(BR2_TARGET_ARM_TRUSTED_FIRMWARE_FIP),y) ARM_TRUSTED_FIRMWARE_MAKE_TARGETS += fip
ARM_TRUSTED_FIRMWARE_DEPENDENCIES+= host-opensslHi Jerry and all,
Here arm-trusted-firmware build is modified when some host package with specific configuration is enabled in board config.
Quoted 6 lines
Quoted 3 lines
Shouldn't it be the other way around ? To be more specific: another Config.in option for arm-trusted-firmware which pulls required build time dependencies, e.g. see Marvell DDR options or FIP options.
1. If use another Config.in option for arm-trusted-firmware like Marvell DDR , need to mv package/rcw to boot/ directory.
2. Refer to FIP, add option like thisBR2_PACKAGE_HOST_RCW_ATFin package/rcw/Config.in.host.
How do you think about the second way?
Hi Jerry, Thomas, and all
I think Marvell DDR was not a good example. In this case ATF does not need any sources from RCW package, only its binary. So what about the same approach as for BR2_TARGET_ARM_TRUSTED_FIRMWARE_UBOOT_AS_BL33 ? The idea is not to check whether RCW host package was selected, but to request RCW as a build dependency and then use its binary.
To be more specific, instead of checking BR2_PACKAGE_HOST_RCW_BOOT_MODE, just add BR2_TARGET_ARM_TRUSTED_FIRMWARE_FSL_QORIQ_RCW_BOOT_MODE and do the following in arm-trusted-firmware.mk:
ifeq ($(BR2_TARGET_ARM_TRUSTED_FIRMWARE_FSL_QORIQ_RCW_BOOT_MODE),y) ARM_TRUSTED_FIRMWARE_DEPENDENCIES += host-rcw ARM_TRUSTED_FIRMWARE_MAKE_TARGETS += pbl ARM_TRUSTED_FIRMWARE_MAKE_OPTS += BOOT_MODE=... CW=... endif
IIUC, you don't need to move host-rcw package to boot directory. Or you need more flexibility when selecting boot mode and CW params ?
Thoughts ? Comments ?
Regards,
Sergey
[Buildroot] [EXT] Re: [PATCH 4/9] boot/arm-trusted-firmware: Add RCW support
Hi, Sergey
Best Regards
Jerry Huang
Quoted 48 lines
-----Original Message-----
From: Sergey Matyukevich <[email protected]>
Sent: Thursday, November 21, 2019 4:03 PM
To: Jerry Huang <[email protected]>
Cc: buildroot at busybox.net
Subject: Re: [EXT] Re: [Buildroot] [PATCH 4/9] boot/arm-trusted-firmware: Add RCW supportCaution: EXT Email
Quoted 26 lines
Quoted 26 lines
boot/arm-trusted-firmware/arm-trusted-firmware.mk endif · line 98
Quoted 10 lines
boot/arm-trusted-firmware/arm-trusted-firmware.mk +1
-0@@ -95,6 +95,15 @@ endif ARM_TRUSTED_FIRMWARE_MAKE_TARGETS = all +RCW_BOOT_MODE = $(callqstrip,$(BR2_PACKAGE_HOST_RCW_BOOT_MODE))
boot/arm-trusted-firmware/arm-trusted-firmware.mk endif
Quoted 4 lines
boot/arm-trusted-firmware/arm-trusted-firmware.mk +4
-0+ifneq ($(RCW_BOOT_MODE),) +RCW_PATH = $(call qstrip,$(BR2_PACKAGE_HOST_RCW_BIN)) +RCW_FILE = $(lastword $(subst /, ,$(RCW_PATH))) +ARM_TRUSTED_FIRMWARE_MAKE_OPTS +=BOOT_MODE=$(RCW_BOOT_MODE)
boot/arm-trusted-firmware/arm-trusted-firmware.mk endif · line 103
Quoted 1 line
boot/arm-trusted-firmware/arm-trusted-firmware.mk +1
-0+RCW=$(BINARIES_DIR)/$(RCW_FILE)
ARM_TRUSTED_FIRMWARE_MAKE_TARGETS+=Quoted 5 lines
boot/arm-trusted-firmware/arm-trusted-firmware.mk +2
-0+pbl ARM_TRUSTED_FIRMWARE_DEPENDENCIES += host-rcw endif + ifeq ($(BR2_TARGET_ARM_TRUSTED_FIRMWARE_FIP),y) ARM_TRUSTED_FIRMWARE_MAKE_TARGETS += fip
ARM_TRUSTED_FIRMWARE_DEPENDENCIES+= host-opensslHi Jerry and all,
Quoted 7 lines
Quoted 6 lines
Here arm-trusted-firmware build is modified when some host package with specific configuration is enabled in board config.
Shouldn't it be the other way around ? To be more specific: another Config.in option for arm-trusted-firmware which pulls required build time dependencies, e.g. see Marvell DDR options or FIP options.
1. If use another Config.in option for arm-trusted-firmware like Marvell DDR ,
need to mv package/rcw to boot/ directory.
Quoted 1 line
2. Refer to FIP, add option like this
BR2_PACKAGE_HOST_RCW_ATFinpackage/rcw/Config.in.host.
Quoted 1 line
How do you think about the second way?
Quoted 7 lines
Hi Jerry, Thomas, and all
I think Marvell DDR was not a good example. In this case ATF does not need any sources from RCW package, only its binary. So what about the same approach as for
BR2_TARGET_ARM_TRUSTED_FIRMWARE_UBOOT_AS_BL33?
The idea is not to check whether RCW host package was selected, but to request RCW as a build dependency and then use its binary.
Agree with you, now I added option BR2_PACKAGE_HOST_RCW_ATF=y to select ATF for RCW.
Quoted 5 lines
To be more specific, instead of checking
BR2_PACKAGE_HOST_RCW_BOOT_MODE, just addBR2_TARGET_ARM_TRUSTED_FIRMWARE_FSL_QORIQ_RCW_BOOT_MODEand do the following in arm-trusted-firmware.mk:
Quoted 7 lines
ifeq ($(BR2_TARGET_ARM_TRUSTED_FIRMWARE_FSL_QORIQ_RCW_BOOT_MODE) ,y)
ARM_TRUSTED_FIRMWARE_DEPENDENCIES+= host-rcwARM_TRUSTED_FIRMWARE_MAKE_TARGETS+= pblARM_TRUSTED_FIRMWARE_MAKE_OPTS+= BOOT_MODE=... CW=... endif
Because there are different boot mode: sd, emmc, flexspi_nor, flexspi_nand, So I define the option BR2_PACKAGE_HOST_RCW_BOOT_MODE to indicate it. RCW=xxx is to indicate the location of RCW binary needed by ATF.
Quoted 2 lines
IIUC, you don't need to move host-rcw package to boot directory. Or you need more flexibility when selecting boot mode and CW params ?
I plan to move package/rcw into package/freescale-qoriq/
Quoted 4 lines
Thoughts ? Comments ?
Regards,
Sergey
[Buildroot] [EXT] Re: [PATCH 4/9] boot/arm-trusted-firmware: Add RCW support
Post the new codes:
ifeq ($(BR2_PACKAGE_HOST_RCW_ATF),y)RCW_BOOT_MODE = $(call qstrip,$(BR2_PACKAGE_HOST_RCW_BOOT_MODE))RCW_PATH = $(call qstrip,$(BR2_PACKAGE_HOST_RCW_BIN))RCW_FILE = $(lastword $(subst /, ,$(RCW_PATH))) ARM_TRUSTED_FIRMWARE_MAKE_OPTS += BOOT_MODE=$(RCW_BOOT_MODE) RCW=$(BINARIES_DIR)/$(RCW_FILE) ARM_TRUSTED_FIRMWARE_MAKE_TARGETS += pblARM_TRUSTED_FIRMWARE_DEPENDENCIES += host-fsl-qoriq-rcw
endif
Best Regards
Jerry Huang
Quoted 99 lines
-----Original Message-----
From: Jerry Huang
Sent: Thursday, November 21, 2019 4:38 PM
To: Sergey Matyukevich <[email protected]>
Cc: buildroot at busybox.net
Subject: RE: [EXT] Re: [Buildroot] [PATCH 4/9] boot/arm-trusted-firmware: Add RCW supportHi, Sergey
Best Regards
Jerry HuangQuoted 8 lines
-----Original Message-----
From: Sergey Matyukevich <[email protected]>
Sent: Thursday, November 21, 2019 4:03 PM
To: Jerry Huang <[email protected]>
Cc: buildroot at busybox.net
Subject: Re: [EXT] Re: [Buildroot] [PATCH 4/9]
boot/arm-trusted-firmware: Add RCW supportQuoted 34 lines
Caution: EXT Email
Quoted 32 lines
Quoted 32 lines
boot/arm-trusted-firmware/arm-trusted-firmware.mk endif · line 98
Quoted 10 lines
boot/arm-trusted-firmware/arm-trusted-firmware.mk +1
-0@@ -95,6 +95,15 @@ endif ARM_TRUSTED_FIRMWARE_MAKE_TARGETS = all +RCW_BOOT_MODE = $(callqstrip,$(BR2_PACKAGE_HOST_RCW_BOOT_MODE))
boot/arm-trusted-firmware/arm-trusted-firmware.mk endif
Quoted 4 lines
boot/arm-trusted-firmware/arm-trusted-firmware.mk +4
-0+ifneq ($(RCW_BOOT_MODE),) +RCW_PATH = $(call qstrip,$(BR2_PACKAGE_HOST_RCW_BIN)) +RCW_FILE = $(lastword $(subst /, ,$(RCW_PATH))) +ARM_TRUSTED_FIRMWARE_MAKE_OPTS +=BOOT_MODE=$(RCW_BOOT_MODE)
boot/arm-trusted-firmware/arm-trusted-firmware.mk endif · line 103
Quoted 1 line
boot/arm-trusted-firmware/arm-trusted-firmware.mk +1
-0+RCW=$(BINARIES_DIR)/$(RCW_FILE)
ARM_TRUSTED_FIRMWARE_MAKE_TARGETS+=Quoted 5 lines
boot/arm-trusted-firmware/arm-trusted-firmware.mk +2
-0+pbl ARM_TRUSTED_FIRMWARE_DEPENDENCIES += host-rcw endif + ifeq ($(BR2_TARGET_ARM_TRUSTED_FIRMWARE_FIP),y) ARM_TRUSTED_FIRMWARE_MAKE_TARGETS += fip
ARM_TRUSTED_FIRMWARE_DEPENDENCIES+= host-opensslHi Jerry and all,
Here arm-trusted-firmware build is modified when some host package with specific configuration is enabled in board config.
Shouldn't it be the other way around ? To be more specific:
another Config.in option for arm-trusted-firmware which pulls required build time dependencies, e.g. see Marvell DDR options or FIPoptions.
Quoted 4 lines
Quoted 2 lines
1. If use another Config.in option for arm-trusted-firmware like Marvell DDR ,
need to mv package/rcw to boot/ directory.
Quoted 1 line
2. Refer to FIP, add option like this
BR2_PACKAGE_HOST_RCW_ATFinQuoted 8 lines
package/rcw/Config.in.host.
Quoted 1 line
How do you think about the second way?
Hi Jerry, Thomas, and all
I think Marvell DDR was not a good example. In this case ATF does not need any sources from RCW package, only its binary. So what about the same approach as for
BR2_TARGET_ARM_TRUSTED_FIRMWARE_UBOOT_AS_BL33?Quoted 2 lines
The idea is not to check whether RCW host package was selected, but to request RCW as a build dependency and then use its binary.
Agree with you, now I added option BR2_PACKAGE_HOST_RCW_ATF=y to select ATF for RCW.
Quoted 7 lines
To be more specific, instead of checking
BR2_PACKAGE_HOST_RCW_BOOT_MODE, just addBR2_TARGET_ARM_TRUSTED_FIRMWARE_FSL_QORIQ_RCW_BOOT_MODEand do the following in arm-trusted-firmware.mk:ifeq
($(BR2_TARGET_ARM_TRUSTED_FIRMWARE_FSL_QORIQ_RCW_BOOT_MODE)
Quoted 5 lines
,y)
ARM_TRUSTED_FIRMWARE_DEPENDENCIES+= host-rcwARM_TRUSTED_FIRMWARE_MAKE_TARGETS+= pblARM_TRUSTED_FIRMWARE_MAKE_OPTS+= BOOT_MODE=... CW=... endifBecause there are different boot mode: sd, emmc,
flexspi_nor,flexspi_nand, So I define the optionBR2_PACKAGE_HOST_RCW_BOOT_MODEto indicate it. RCW=xxx is to indicate the location of RCW binary needed by ATF.Quoted 2 lines
IIUC, you don't need to move host-rcw package to boot directory. Or you need more flexibility when selecting boot mode and CW params ?
I plan to move package/rcw into package/freescale-qoriq/
Quoted 4 lines
Thoughts ? Comments ?
Regards,
Sergey
PATCH 5/9 package/freescale-qoriq: new package directory
In reply to Changming HuangThe freescale-qoriq directory is intended to contain all freescale QorIQ (including PowerPC and LayerScape serial) related packages, together with their download site and version info.
--- package/Config.in | 1 + package/freescale-qoriq/Config.in | 4 ++++ package/freescale-qoriq/freescale-qoriq.mk | 1 + 3 files changed, 6 insertions(+) create mode 100644 package/freescale-qoriq/Config.in create mode 100644 package/freescale-qoriq/freescale-qoriq.mk
package/Config.in +1 -0
@@ -447,6 +447,7 @@ endmenu source "package/flashrom/Config.in" source "package/fmtools/Config.in" source "package/freescale-imx/Config.in" + source "package/freescale-qoriq/Config.in" source "package/fxload/Config.in" source "package/gadgetfs-test/Config.in" source "package/gcnano-binaries/Config.in"
package/freescale-qoriq/Config.in new file +4 -0
@@ -0,0 +1,4 @@ +menu "Freescale QorIQ libraries" + depends on BR2_aarch64 || BR2_arm || BR2_powerpc64 || BR2_powerpc + +endmenu
package/freescale-qoriq/freescale-qoriq.mk new file +1 -0
@@ -0,0 +1 @@ +include $(sort $(wildcard package/freescale-qoriq/*/*.mk))
Signature · 1 line
2.17.1
PATCH 5/9 package/freescale-qoriq: new package directory
Hello Jerry,
Quoted 5 lines · On Wed, 20 Nov 2019 12:07:21 +0800 Changming Huang <[email protected]> wrote:
The freescale-qoriq directory is intended to contain all freescale QorIQ (including PowerPC and LayerScape serial) related packages, together with their download site and version info.
Signed-off-by Changming Huang <[email protected]>
Do you really expect to have multiple package in this sub-directory ? Your patch series is adding only one.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 6/9 package/freescale-qoriq/cadence: new package
In reply to Changming HuangThis package provides the firmware for LS1028ARDB DP (display port).
--- package/freescale-qoriq/Config.in | 2 ++ package/freescale-qoriq/cadence/Config.in | 9 +++++++++ package/freescale-qoriq/cadence/cadence.mk | 19 +++++++++++++++++++ 3 files changed, 30 insertions(+) create mode 100644 package/freescale-qoriq/cadence/Config.in create mode 100644 package/freescale-qoriq/cadence/cadence.mk
package/freescale-qoriq/Config.in +2 -0
@@ -1,4 +1,6 @@ menu "Freescale QorIQ libraries" depends on BR2_aarch64 || BR2_arm || BR2_powerpc64 || BR2_powerpc +source "package/freescale-qoriq/cadence/Config.in" + endmenu
package/freescale-qoriq/cadence/Config.in new file +9 -0
@@ -0,0 +1,9 @@ +config BR2_PACKAGE_CADENCE + bool "display port firmware" + help + Display Port, a resident EL3 firmware. + +if BR2_PACKAGE_CADENCE +config BR2_PACKAGE_CADENCE_DP_BIN + string "Custom DP Firmware BIN" +endif
package/freescale-qoriq/cadence/cadence.mk new file +19 -0
@@ -0,0 +1,19 @@ +################################################################################ +# +# DP firmware for NXP layerscape platforms +# +################################################################################ +CADENCE_INSTALL_IMAGES = YES + +DP_BIN = $(call qstrip,$(BR2_PACKAGE_CADENCE_DP_BIN)) + +define CADENCE_BUILD_CMDS + cd $(@D)/ && wget http://www.nxp.com/lgfiles/sdk/lsdk1909/firmware-cadence-lsdk1909.bin &&\ + chmod +x firmware-cadence-lsdk1909.bin && ./firmware-cadence-lsdk1909.bin --auto-accept; +endef + +define CADENCE_INSTALL_IMAGES_CMDS + cp $(@D)/firmware-cadence-lsdk1909/dp/$(DP_BIN) $(BINARIES_DIR)/; +endef + +$(eval $(generic-package))
Signature · 1 line
2.17.1
PATCH 6/9 package/freescale-qoriq/cadence: new package
Hello,
Quoted 7 lines · On Wed, 20 Nov 2019 12:07:22 +0800 Changming Huang <[email protected]> wrote:
This package provides the firmware for LS1028ARDB DP (display port).
Signed-off-by Changming Huang <[email protected]>--- package/freescale-qoriq/Config.in | 2 ++ package/freescale-qoriq/cadence/Config.in | 9 +++++++++ package/freescale-qoriq/cadence/cadence.mk | 19 +++++++++++++++++++
We need an entry in the DEVELOPERS file for this package.
Also, "cadence" is not descriptive enough as a package name. freescale-qoriq-cadence-dp-firmware perhaps? It's a bit long, but at least it's descriptive.
Quoted 3 lines
3 files changed, 30 insertions(+) create mode 100644 package/freescale-qoriq/cadence/Config.in create mode 100644 package/freescale-qoriq/cadence/cadence.mk
The .hash file is missing.
package/freescale-qoriq/cadence/Config.in line 2
Quoted 8 lines
package/freescale-qoriq/cadence/Config.in new file +2
-0@@ -0,0 +1,9 @@ +config BR2_PACKAGE_CADENCE + bool "display port firmware"
This should be just the package name.
package/freescale-qoriq/cadence/Config.in line 4
Quoted 2 lines
package/freescale-qoriq/cadence/Config.in new file +2
-0+ help + Display Port, a resident EL3 firmware.
Indentation is not correct, we also need a link to some upstream web site that gives details about this firmware.
Just curious: the DisplayPort really needs a firmware that runs on the main CPU, at EL3 ? This is pretty scary :-/ How does it get loaded ?
package/freescale-qoriq/cadence/Config.in line 8
Quoted 3 lines
package/freescale-qoriq/cadence/Config.in new file +3
-0+if BR2_PACKAGE_CADENCE +config BR2_PACKAGE_CADENCE_DP_BIN + string "Custom DP Firmware BIN"
This is not needed, there is a single firmware image in the archive, just hardcode it in the package.
package/freescale-qoriq/cadence/cadence.mk line 3
Quoted 10 lines
package/freescale-qoriq/cadence/Config.in new file +1
-0+endifpackage/freescale-qoriq/cadence/cadence.mk new file +3
-0@@ -0,0 +1,19 @@ +################################################################################ +# +# DP firmware for NXP layerscape platforms
Just the name of the package.
package/freescale-qoriq/cadence/cadence.mk line 6
Quoted 3 lines
package/freescale-qoriq/cadence/cadence.mk new file +3
-0+# +################################################################################ +CADENCE_INSTALL_IMAGES = YES
One empty line between the comment header and the first variable.
Also, please specify _INSTALL_TARGET = NO
package/freescale-qoriq/cadence/cadence.mk line 8
Quoted 1 line
package/freescale-qoriq/cadence/cadence.mk new file +1
-0+DP_BIN = $(call qstrip,$(BR2_PACKAGE_CADENCE_DP_BIN))
As per the comment above, this is not needed.
package/freescale-qoriq/cadence/cadence.mk line 11
Quoted 3 lines
package/freescale-qoriq/cadence/cadence.mk new file +3
-0+ +define CADENCE_BUILD_CMDS + cd $(@D)/ && wget http://www.nxp.com/lgfiles/sdk/lsdk1909/firmware-cadence-lsdk1909.bin &&\
Urgh, this is horrible: you are completely bypassing Buildroot's download infrastructure. Please use it:
<pkg>_VERSION = lsdk1909
<pkg>_SITE = http://www.nxp.com/lgfiles/sdk/lsdk1909/
<pkg>_SOURCE = firmware-cadence-$(<pkg>_VERSION).bin
define <pkg>_EXTRACT_CMDS
cd $(@D); \ sh $(<pkg>_DL_DIR)/$(<pkg>_SOURCE) --auto-accept
endef
package/freescale-qoriq/cadence/cadence.mk line 16
Quoted 2 lines
package/freescale-qoriq/cadence/cadence.mk new file +2
-0+define CADENCE_INSTALL_IMAGES_CMDS + cp $(@D)/firmware-cadence-lsdk1909/dp/$(DP_BIN) $(BINARIES_DIR)/;
Use:
$(INSTALL) -D -m 0644 $(@D)/firmware-cadence-lsdk1909/dp/ls1028a-dp-fw.bin $(BINARIES_DIR)/ls1028a-dp-fw.bin
Also, please add the appropriate licensing information, since there is a COPYING file in the archive.
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
[Buildroot] [EXT] Re: [PATCH 6/9] package/freescale-qoriq/cadence: new package
Thanks a lot for your detail comments.
Mine in lines.
Best Regards
Jerry Huang
Quoted 17 lines
-----Original Message-----
From: Thomas Petazzoni <[email protected]>
Sent: Wednesday, November 20, 2019 5:13 PM
To: Jerry Huang <[email protected]>
Cc: buildroot at busybox.net
Subject: [EXT] Re: [Buildroot] [PATCH 6/9] package/freescale-qoriq/cadence:
new packageCaution: EXT Email
Hello,
Quoted 2 lines · On Wed, 20 Nov 2019 12:07:22 +0800 Changming Huang <[email protected]> wrote:
This package provides the firmware for LS1028ARDB DP (display port).
Quoted 7 lines
Quoted 5 lines
Signed-off-by Changming Huang <[email protected]>--- package/freescale-qoriq/Config.in | 2 ++ package/freescale-qoriq/cadence/Config.in | 9 +++++++++
package/freescale-qoriq/cadence/cadence.mk| 19 +++++++++++++++++++We need an entry in the DEVELOPERS file for this package.
Ok, I will add the entry in DEVELOPERS
Quoted 3 lines
Also, "cadence" is not descriptive enough as a package name. freescale-qoriq-cadence-dp-firmware perhaps? It's a bit long, but at least it's descriptive.
I think "cadence-dp-firmware" can be used for its name. Because it is under sub-directory " freescale-qoriq", we can remove the prefix " freescale-qoriq" from package name.
Quoted 5 lines
Quoted 3 lines
3 files changed, 30 insertions(+) create mode 100644 package/freescale-qoriq/cadence/Config.in create mode 100644 package/freescale-qoriq/cadence/cadence.mkThe .hash file is missing.
I will add the hash file.
Quoted 11 lines
package/freescale-qoriq/cadence/Config.in line 2
Quoted 9 lines
package/freescale-qoriq/cadence/Config.in new file +2
-0@@ -0,0 +1,9 @@ +config BR2_PACKAGE_CADENCE + bool "display port firmware"This should be just the package name.
Ok
Quoted 5 lines
package/freescale-qoriq/cadence/Config.in line 4
Quoted 2 lines
package/freescale-qoriq/cadence/Config.in new file +2
-0+ help + Display Port, a resident EL3 firmware.Indentation is not correct, we also need a link to some upstream web site that gives details about this firmware.
Sure, I will adjust it.
Quoted 2 lines
Just curious: the DisplayPort really needs a firmware that runs on the main CPU, at EL3 ? This is pretty scary :-/ How does it get loaded ?
Yes, LS1028ARDB need this firmware for display port.
We used the command "hdp load" in uboot before starting Linux kernel.
Quoted 6 lines
package/freescale-qoriq/cadence/Config.in line 8
Quoted 3 lines
package/freescale-qoriq/cadence/Config.in new file +3
-0+if BR2_PACKAGE_CADENCE +config BR2_PACKAGE_CADENCE_DP_BIN + string "Custom DP Firmware BIN"This is not needed, there is a single firmware image in the archive, just hardcode it in the package.
ok
Quoted 70 lines
package/freescale-qoriq/cadence/cadence.mk
Quoted 9 lines
package/freescale-qoriq/cadence/Config.in new file +1
-0+endifpackage/freescale-qoriq/cadence/cadence.mk new file +0
-0@@ -0,0 +1,19 @@+###############################################################
######package/freescale-qoriq/cadence/cadence.mk line 3
Quoted 3 lines
package/freescale-qoriq/cadence/cadence.mk new file +3
-0+########### +# +# DP firmware for NXP layerscape platformsJust the name of the package.
package/freescale-qoriq/cadence/cadence.mk line 4
Quoted 2 lines
package/freescale-qoriq/cadence/cadence.mk new file +1
-0+#+###############################################################
######package/freescale-qoriq/cadence/cadence.mk line 6
Quoted 2 lines
package/freescale-qoriq/cadence/cadence.mk new file +2
-0+########### +CADENCE_INSTALL_IMAGES = YESOne empty line between the comment header and the first variable.
Also, please specify
_INSTALL_TARGET= NOpackage/freescale-qoriq/cadence/cadence.mk line 8
Quoted 1 line
package/freescale-qoriq/cadence/cadence.mk new file +1
-0+DP_BIN = $(call qstrip,$(BR2_PACKAGE_CADENCE_DP_BIN))As per the comment above, this is not needed.
package/freescale-qoriq/cadence/cadence.mk
Quoted 5 lines
package/freescale-qoriq/cadence/cadence.mk new file +4
-0+ +define CADENCE_BUILD_CMDS + cd $(@D)/ && wget +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.+nxp.com%2Flgfiles%2Fsdk%2Flsdk1909%2Ffirmware-cadence-lsdk1909.bin&a m
Quoted 1 line
+p;data=02%7C01%7Cjerry.huang%40nxp.com%7C9c92f3028db94a45041a08d 76d99
Quoted 1 line
+e558%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637098380050 336719&
Quoted 1 line
+amp;sdata=1f65%2B7j1t%2FuLicJMICfrV%2BrZpjme4a4YUtK88gDJF8g%3D&a mp;re
Quoted 1 line
+served=0 &&\
Urgh, this is horrible: you are completely bypassing Buildroot's download infrastructure. Please use it:
<pkg>_VERSION = lsdk1909
<pkg>_SITE =
https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.nxp.
com%2Flgfiles%2Fsdk%2Flsdk1909%2F&data=02%7C01%7Cjerry.huang%4 0nxp.com%7C9c92f3028db94a45041a08d76d99e558%7C686ea1d3bc2b4c6fa9 2cd99c5c301635%7C0%7C0%7C637098380050336719&sdata=NJTQlJNknn I3Dmi62e%2B06a%2BoI%2BzD8nT2DtXTS27c3SU%3D&reserved=0 <pkg>_SOURCE = firmware-cadence-$(<pkg>_VERSION).bindefine <pkg>_EXTRACT_CMDS
cd $(@D); \ sh $(<pkg>_DL_DIR)/$(<pkg>_SOURCE) --auto-accept endefpackage/freescale-qoriq/cadence/cadence.mk
Quoted 3 lines
package/freescale-qoriq/cadence/cadence.mk new file +3
-0+define CADENCE_INSTALL_IMAGES_CMDS + cp $(@D)/firmware-cadence-lsdk1909/dp/$(DP_BIN) +$(BINARIES_DIR)/;
Quoted 5 lines
Use:
$(INSTALL) -D -m 0644$(@D)/firmware-cadence-lsdk1909/dp/ls1028a-dp-fw.bin $(BINARIES_DIR)/ls1028a-dp-fw.bin
? I will following the download infrastructure.
Quoted 2 lines
Also, please add the appropriate licensing information, since there is a COPYING file in the archive.
Ok, will add the license information
Quoted 11 lines
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbootlin.c
om&data=02%7C01%7Cjerry.huang%40nxp.com%7C9c92f3028db94a4504 1a08d76d99e558%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637 098380050336719&sdata=1KYF0jJSSz75f%2FthSq5U3BPIoYst%2BqnqpVAe uYsMUD0%3D&reserved=0
[Buildroot] [EXT] Re: [PATCH 6/9] package/freescale-qoriq/cadence: new package
Hello,
Quoted 6 lines · On Wed, 20 Nov 2019 09:30:26 +0000 Jerry Huang <[email protected]> wrote:
Quoted 3 lines
Also, "cadence" is not descriptive enough as a package name. freescale-qoriq-cadence-dp-firmware perhaps? It's a bit long, but at least it's descriptive.
I think "cadence-dp-firmware" can be used for its name. Because it is under sub-directory " freescale-qoriq", we can remove the prefix " freescale-qoriq" from package name.
Being inside the freescale-qoriq doesn't improve things in any way: the namespace of package names (and therefore variables) is global in Buildroot.
Quoted 8 lines
Quoted 2 lines
Indentation is not correct, we also need a link to some upstream web site that gives details about this firmware.
Sure, I will adjust it.
Quoted 2 lines
Just curious: the DisplayPort really needs a firmware that runs on the main CPU, at EL3 ? This is pretty scary :-/ How does it get loaded ?
Yes, LS1028ARDB need this firmware for display port.
We used the command "hdp load" in uboot before starting Linux kernel.
OK. Where is this firmware image stored? You just install it to $(BINARIES_DIR). Should it be installed in the rootfs instead, so that U-Boot can pick it up from there ?
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
[Buildroot] [EXT] Re: [PATCH 6/9] package/freescale-qoriq/cadence: new package
Best Regards
Jerry Huang
Quoted 29 lines
-----Original Message-----
From: Thomas Petazzoni <[email protected]>
Sent: Wednesday, November 20, 2019 5:36 PM
To: Jerry Huang <[email protected]>
Cc: buildroot at busybox.net
Subject: Re: [EXT] Re: [Buildroot] [PATCH 6/9] package/freescale-qoriq/cadence:
new packageCaution: EXT Email
Hello,
Quoted 6 lines · On Wed, 20 Nov 2019 09:30:26 +0000 Jerry Huang <[email protected]> wrote:
Quoted 3 lines
Also, "cadence" is not descriptive enough as a package name. freescale-qoriq-cadence-dp-firmware perhaps? It's a bit long, but at least it's descriptive.
I think "cadence-dp-firmware" can be used for its name. Because it is under sub-directory " freescale-qoriq", we can remove the prefix " freescale-qoriq" from package name.
Being inside the freescale-qoriq doesn't improve things in any way: the namespace of package names (and therefore variables) is global in Buildroot.
Quoted 4 lines
Quoted 2 lines
Indentation is not correct, we also need a link to some upstream web site that gives details about this firmware.
Sure, I will adjust it.
Quoted 8 lines
Quoted 4 lines
Quoted 2 lines
Just curious: the DisplayPort really needs a firmware that runs on the main CPU, at EL3 ? This is pretty scary :-/ How does it get loaded ?
Yes, LS1028ARDB need this firmware for display port.
We used the command "hdp load" in uboot before starting Linux kernel.OK. Where is this firmware image stored? You just install it to $(BINARIES_DIR). Should it be installed in the rootfs instead, so that U-Boot can pick it up from there ?
The post image scripts will create one full images including uboot, rcw, firmware, kernel ITB/rootfs. This firmware is stored NOR flash if booting the board from QSPI/FlexSPI boot,
Or it is stored one partition on SD/eMMC when booting from SD card or eMMC chip.
Then, U-boot can pick it up from flash, SD or eMMC.
Quoted 11 lines
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbootlin.c
om&data=02%7C01%7Cjerry.huang%40nxp.com%7C7af319f85d8c4ad276 4008d76d9d1d2e%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637 098393876225198&sdata=%2F8LtHwidlTszcsesa9IwePY%2FUJQt7iuJQi%2F T%2BfSOu9w%3D&reserved=0
PATCH 7/9 package/rcw: Enable IIC5_PMUX and CLK_OUT_PMUX for GPIO
In reply to Changming HuangBecause GPIO is used as interrupt for eNETC PHY and Micro-bus, IIC5_PMUX and CLK_OUT_PMUX are enabled for GPIO.
--- ...5_PMUX-for-GPIO-function.patch.conditional | 42 +++++++++++++++++++ ...T_PMUX-for-GPIO-function.patch.conditional | 40 ++++++++++++++++++ package/rcw/rcw.mk | 7 ++++ 3 files changed, 89 insertions(+) create mode 100644 package/rcw/0001-ls1028ardb-Enable-IIC5_PMUX-for-GPIO-function.patch.conditional create mode 100644 package/rcw/0002-ls1028ardb-Enable-CLK_OUT_PMUX-for-GPIO-function.patch.conditional
package/rcw/0001-ls1028ardb-Enable-IIC5_PMUX-for-GPIO-function.patch.conditional new file +42 -0
@@ -0,0 +1,42 @@ +From 33b403cee1fa215927bc65dc14baf35a2fdbe7b3 Mon Sep 17 00:00:00 2001 +From: Jerry Huang <[email protected]> +Date: Thu, 19 Sep 2019 12:12:20 +0800 +Subject: [PATCH 1/2] ls1028ardb: Enable IIC5_PMUX for GPIO function + +Set IIC5_PMUX = 1 to enable GPIO function. + +Signed-off-by: Jianchao Wang <[email protected]> +Signed-off-by: Jerry Huang <[email protected]> +--- + ls1028ardb/R_SQPP_0x85bb/rcw_1300_emmcboot.rcw | 2 +- + ls1028ardb/R_SQPP_0x85bb/rcw_1300_sdboot.rcw | 2 +- + 2 files changed, 2 insertions(+), 2 deletions(-) + +diff --git a/ls1028ardb/R_SQPP_0x85bb/rcw_1300_emmcboot.rcw b/ls1028ardb/R_SQPP_0x85bb/rcw_1300_emmcboot.rcw +index b46ea2e..5466a63 100644 +--- a/ls1028ardb/R_SQPP_0x85bb/rcw_1300_emmcboot.rcw ++++ b/ls1028ardb/R_SQPP_0x85bb/rcw_1300_emmcboot.rcw +@@ -26,7 +26,7 @@ SYSCLK_FREQ=600 + IIC2_PMUX=6 + IIC3_PMUX=2 + IIC4_PMUX=2 +-IIC5_PMUX=2 ++IIC5_PMUX=1 + IIC6_PMUX=2 + CLK_OUT_PMUX=2 + EC1_SAI4_5_PMUX=5 +diff --git a/ls1028ardb/R_SQPP_0x85bb/rcw_1300_sdboot.rcw b/ls1028ardb/R_SQPP_0x85bb/rcw_1300_sdboot.rcw +index 04e2208..1908d8c 100644 +--- a/ls1028ardb/R_SQPP_0x85bb/rcw_1300_sdboot.rcw ++++ b/ls1028ardb/R_SQPP_0x85bb/rcw_1300_sdboot.rcw +@@ -26,7 +26,7 @@ SYSCLK_FREQ=600 + IIC2_PMUX=6 + IIC3_PMUX=2 + IIC4_PMUX=2 +-IIC5_PMUX=2 ++IIC5_PMUX=1 + IIC6_PMUX=3 + CLK_OUT_PMUX=2 + EC1_SAI4_5_PMUX=5 +-- +2.17.1
package/rcw/0002-ls1028ardb-Enable-CLK_OUT_PMUX-for-GPIO-function.patch.conditional new file +40 -0
@@ -0,0 +1,40 @@ +From 4a3c9ea5d0c7bf8eec8cb6276d6f4d940f3946db Mon Sep 17 00:00:00 2001 +From: Jerry Huang <[email protected]> +Date: Thu, 19 Sep 2019 12:13:48 +0800 +Subject: [PATCH 2/2] ls1028ardb/rcw: Enable CLK_OUT_PMUX for GPIO function + +Signed-off-by: Jianchao Wang <[email protected]> +Signed-off-by: Jerry Huang <[email protected]> +--- + ls1028ardb/R_SQPP_0x85bb/rcw_1300_emmcboot.rcw | 2 +- + ls1028ardb/R_SQPP_0x85bb/rcw_1300_sdboot.rcw | 2 +- + 2 files changed, 2 insertions(+), 2 deletions(-) + +diff --git a/ls1028ardb/R_SQPP_0x85bb/rcw_1300_emmcboot.rcw b/ls1028ardb/R_SQPP_0x85bb/rcw_1300_emmcboot.rcw +index 5466a63..a5ed4d4 100644 +--- a/ls1028ardb/R_SQPP_0x85bb/rcw_1300_emmcboot.rcw ++++ b/ls1028ardb/R_SQPP_0x85bb/rcw_1300_emmcboot.rcw +@@ -28,7 +28,7 @@ IIC3_PMUX=2 + IIC4_PMUX=2 + IIC5_PMUX=1 + IIC6_PMUX=2 +-CLK_OUT_PMUX=2 ++CLK_OUT_PMUX=1 + EC1_SAI4_5_PMUX=5 + EC1_SAI3_6_PMUX=5 + USB3_CLK_FSEL=39 +diff --git a/ls1028ardb/R_SQPP_0x85bb/rcw_1300_sdboot.rcw b/ls1028ardb/R_SQPP_0x85bb/rcw_1300_sdboot.rcw +index 1908d8c..c930b83 100644 +--- a/ls1028ardb/R_SQPP_0x85bb/rcw_1300_sdboot.rcw ++++ b/ls1028ardb/R_SQPP_0x85bb/rcw_1300_sdboot.rcw +@@ -28,7 +28,7 @@ IIC3_PMUX=2 + IIC4_PMUX=2 + IIC5_PMUX=1 + IIC6_PMUX=3 +-CLK_OUT_PMUX=2 ++CLK_OUT_PMUX=1 + EC1_SAI4_5_PMUX=5 + EC1_SAI3_6_PMUX=5 + USB3_CLK_FSEL=39 +-- +2.17.1
package/rcw/rcw.mk +7 -0
@@ -41,6 +41,13 @@ else RCW_BIN = $(call qstrip,$(BR2_PACKAGE_HOST_RCW_BIN)) RCW_PLATFORM = $(firstword $(subst /, ,$(RCW_BIN))) +ifeq ($(findstring ls1028ardb, $(BR2_TARGET_UBOOT_BOARDNAME)), ls1028ardb) +define HOST_RCW_CONFIGURE_CMDS + patch -p1 -s -d $(@D) < package/rcw/0001-ls1028ardb-Enable-IIC5_PMUX-for-GPIO-function.patch.conditional; \ + patch -p1 -s -d $(@D) < package/rcw/0002-ls1028ardb-Enable-CLK_OUT_PMUX-for-GPIO-function.patch.conditional +endef +endif + define HOST_RCW_BUILD_CMDS cd $(@D)/$(RCW_PLATFORM) && $(MAKE) endef
Signature · 1 line
2.17.1
PATCH 7/9 package/rcw: Enable IIC5_PMUX and CLK_OUT_PMUX for GPIO
Quoted 11 lines · On Wed, 20 Nov 2019 12:07:23 +0800 Changming Huang <[email protected]> wrote:
Because GPIO is used as interrupt for eNETC PHY and Micro-bus,
IIC5_PMUXandCLK_OUT_PMUXare enabled for GPIO.Signed-off-by Changming Huang <[email protected]>--- ...5_PMUX-for-GPIO-function.patch.conditional | 42 +++++++++++++++++++ ...T_PMUX-for-GPIO-function.patch.conditional | 40 ++++++++++++++++++ package/rcw/rcw.mk | 7 ++++ 3 files changed, 89 insertions(+) create mode 100644 package/rcw/0001-ls1028ardb-Enable-IIC5_PMUX-for-GPIO-function.patch.conditional create mode 100644 package/rcw/0002-ls1028ardb-Enable-CLK_OUT_PMUX-for-GPIO-function.patch.conditional
Sorry, but we really want to avoid conditional patches. Is there a better solution than this ?
The patches modify only files in ls1028ardb/, and you apply them when the board name is ls1028ardb, so basically, you could just as well apply the patches unconditionally, no ?
Quoted 1 line
+ifeq ($(findstring ls1028ardb, $(BR2_TARGET_UBOOT_BOARDNAME)), ls1028ardb)
We really don't want to look at BR2_TARGET_UBOOT_BOARDNAME from package/rcw/.
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
[Buildroot] [EXT] Re: [PATCH 7/9] package/rcw: Enable IIC5_PMUX and CLK_OUT_PMUX for GPIO
Hi, Thomas,
Best Regards
Jerry Huang
Quoted 28 lines
-----Original Message-----
From: Thomas Petazzoni <[email protected]>
Sent: Wednesday, November 20, 2019 5:15 PM
To: Jerry Huang <[email protected]>
Cc: buildroot at busybox.net
Subject: [EXT] Re: [Buildroot] [PATCH 7/9] package/rcw: EnableIIC5_PMUXandCLK_OUT_PMUXfor GPIOCaution: EXT Email
Quoted 7 lines · On Wed, 20 Nov 2019 12:07:23 +0800 Changming Huang <[email protected]> wrote:
Because GPIO is used as interrupt for eNETC PHY and Micro-bus,
IIC5_PMUXandCLK_OUT_PMUXare enabled for GPIO.Signed-off-by Changming Huang <[email protected]>--- ...5_PMUX-for-GPIO-function.patch.conditional | 42+++++++++++++++++++ ...T_PMUX-for-GPIO-function.patch.conditional | 40
++++++++++++++++++
Quoted 6 lines
package/rcw/rcw.mk | 7 ++++ 3 files changed, 89 insertions(+) create mode 100644
package/rcw/0001-ls1028ardb-Enable-IIC5_PMUX-for-GPIO-function.patch.conditional create mode 100644package/rcw/0002-ls1028ardb-Enable-CLK_OUT_PMUX-for-GPIO-function.patc
Quoted 8 lines
Quoted 1 line
h.conditional
Sorry, but we really want to avoid conditional patches. Is there a better solution than this ?
The patches modify only files in ls1028ardb/, and you apply them when the board name is ls1028ardb, so basically, you could just as well apply the patches unconditionally, no ?
I can change it to apply the patch unconfitionally.
Quoted 17 lines
Review
Quoted 2 lines
(quoted diff) +2
-0+ifeq ($(findstring ls1028ardb, $(BR2_TARGET_UBOOT_BOARDNAME)), +ls1028ardb)We really don't want to look at
BR2_TARGET_UBOOT_BOARDNAMEfrom package/rcw/.Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbootlin.c
om&data=02%7C01%7Cjerry.huang%40nxp.com%7C219d7748f90148ab5c d708d76d9a1a83%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637 098380943442208&sdata=C7gIJmLs7J8o6A2%2BlYs5HiKzQzSBMqUBWPET TiW1iWY%3D&reserved=0
[Buildroot] [EXT] Re: [PATCH 7/9] package/rcw: Enable IIC5_PMUX and CLK_OUT_PMUX for GPIO
Quoted 4 lines · On Wed, 20 Nov 2019 09:34:13 +0000 Jerry Huang <[email protected]> wrote:
Quoted 3 lines
The patches modify only files in ls1028ardb/, and you apply them when the board name is ls1028ardb, so basically, you could just as well apply the patches unconditionally, no ?
I can change it to apply the patch unconfitionally.
OK, thanks. Please make sure to submit the patch to the upstream rcw project, so that ultimately, we can drop the patches.
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
[Buildroot] [EXT] Re: [PATCH 7/9] package/rcw: Enable IIC5_PMUX and CLK_OUT_PMUX for GPIO
Thanks a lot for your suggestion.
Best Regards
Jerry Huang
Quoted 32 lines
-----Original Message-----
From: Thomas Petazzoni <[email protected]>
Sent: Wednesday, November 20, 2019 5:39 PM
To: Jerry Huang <[email protected]>
Cc: buildroot at busybox.net
Subject: Re: [EXT] Re: [Buildroot] [PATCH 7/9] package/rcw: EnableIIC5_PMUXandCLK_OUT_PMUXfor GPIOCaution: EXT Email
Quoted 4 lines · On Wed, 20 Nov 2019 09:34:13 +0000 Jerry Huang <[email protected]> wrote:
Quoted 3 lines
The patches modify only files in ls1028ardb/, and you apply them when the board name is ls1028ardb, so basically, you could just as well apply the patches unconditionally, no ?
I can change it to apply the patch unconfitionally.
OK, thanks. Please make sure to submit the patch to the upstream rcw project, so that ultimately, we can drop the patches.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbootlin.c
om&data=02%7C01%7Cjerry.huang%40nxp.com%7Cb7d1e0c04eef467887 dc08d76d9d7822%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637 098395434083898&sdata=JUgNCv0ZuKrsxcp%2F9rdqyK6ZFQ11Ic3NacjPuK lB6hc%3D&reserved=0
PATCH 8/9 board/freescale/common/ls: Add standard post image script for Layerscape processors
In reply to Changming HuangAdd the standard post image script for Layerscape processors (LS1028A and other processors).
--- board/freescale/common/ls/busybox.config | 9 ++ board/freescale/common/ls/post-image-spi.sh | 64 ++++++++++++++ board/freescale/common/ls/post-image.sh | 92 +++++++++++++++++++++ 3 files changed, 165 insertions(+) create mode 100644 board/freescale/common/ls/busybox.config create mode 100755 board/freescale/common/ls/post-image-spi.sh create mode 100755 board/freescale/common/ls/post-image.sh
board/freescale/common/ls/busybox.config new file +9 -0
@@ -0,0 +1,9 @@ +# +# Additional Busybox Settings +# +CONFIG_TASKSET=y +CONFIG_FEATURE_TASKSET_FANCY=y +CONFIG_FEATURE_DF_FANCY=y +CONFIG_FEATURE_SEAMLESS_GZ=y +CONFIG_FEATURE_SEAMLESS_BZ2=y +CONFIG_FEATURE_SEAMLESS_XZ=y
board/freescale/common/ls/post-image-spi.sh new file +64 -0
64 lines not on this page · raw message
board/freescale/common/ls/post-image.sh new file +92 -0
92 lines not on this page · raw message
Signature · 1 line
2.17.1
PATCH 9/9 configs/freescale_ls1028ardb*: new board
In reply to Changming HuangThis is to support Freescale/NXP LS1028ARDB in Buildroot. The board is setup to track the Linux at 4.19 via NXP LSDK-19.09.
The target will build uboot and RCW binary with arm-trusted-firmware support.
board/freescale/ls1028ardb/: scripts related with ls1028ardb freescale_ls1028ardb-emmc_defconfig: defconfig boot from emmc chip on board freescale_ls1028ardb-sd_defconfig: defconfig boot from SD card freescale_ls1028ardb-xspi_defconfig: defconfig boot from FlexSPI chip on board
--- .gitlab-ci.yml | 3 + DEVELOPERS | 6 + .../ls1028ardb/genimage.emmc.cfg.template | 52 +++++++ .../ls1028ardb/genimage.sd.cfg.template | 52 +++++++ .../ls1028ardb/genimage.xspi.cfg.template | 53 +++++++ board/freescale/ls1028ardb/kernel.its | 59 ++++++++ .../ls1028ardb/ls1028-10-network.rules | 16 +++ board/freescale/ls1028ardb/post-cfg-udev.sh | 10 ++ board/freescale/ls1028ardb/readme.txt | 61 ++++++++ .../ls1028ardb/u-boot-environment-emmc.txt | 19 +++ .../ls1028ardb/u-boot-environment-sd.txt | 18 +++ .../ls1028ardb/u-boot-environment-xspi.txt | 22 +++ configs/freescale_ls1028ardb-emmc_defconfig | 135 ++++++++++++++++++ configs/freescale_ls1028ardb-sd_defconfig | 133 +++++++++++++++++ configs/freescale_ls1028ardb-xspi_defconfig | 129 +++++++++++++++++ 15 files changed, 768 insertions(+) create mode 100644 board/freescale/ls1028ardb/genimage.emmc.cfg.template create mode 100644 board/freescale/ls1028ardb/genimage.sd.cfg.template create mode 100644 board/freescale/ls1028ardb/genimage.xspi.cfg.template create mode 100644 board/freescale/ls1028ardb/kernel.its create mode 100644 board/freescale/ls1028ardb/ls1028-10-network.rules create mode 100755 board/freescale/ls1028ardb/post-cfg-udev.sh create mode 100644 board/freescale/ls1028ardb/readme.txt create mode 100644 board/freescale/ls1028ardb/u-boot-environment-emmc.txt create mode 100644 board/freescale/ls1028ardb/u-boot-environment-sd.txt create mode 100644 board/freescale/ls1028ardb/u-boot-environment-xspi.txt create mode 100644 configs/freescale_ls1028ardb-emmc_defconfig create mode 100644 configs/freescale_ls1028ardb-sd_defconfig create mode 100644 configs/freescale_ls1028ardb-xspi_defconfig
.gitlab-ci.yml +3 -0
@@ -183,6 +183,9 @@ freescale_imx8qxpmek_defconfig: { extends: .defconfig } freescale_p1025twr_defconfig: { extends: .defconfig } freescale_t1040d4rdb_defconfig: { extends: .defconfig } freescale_t2080_qds_rdb_defconfig: { extends: .defconfig } +freescale_ls1028ardb-emmc_defconfig: { extends: .defconfig } +freescale_ls1028ardb-sd_defconfig: { extends: .defconfig } +freescale_ls1028ardb-xspi_defconfig: { extends: .defconfig } friendlyarm_nanopi_a64_defconfig: { extends: .defconfig } friendlyarm_nanopi_neo2_defconfig: { extends: .defconfig } friendlyarm_nanopi_neo_plus2_defconfig: { extends: .defconfig }
DEVELOPERS +6 -0
@@ -2543,3 +2543,9 @@ F: package/qjson/ F: package/quazip/ F: package/shapelib/ F: package/tinc/ + +N: Changming Huang <[email protected]> +F: package/freescale-qoriq/ +F: board/freescale/ls1028ardb/ +F: board/freescale/common/ls +F: configs/freescale_ls1028ardb*
board/freescale/ls1028ardb/genimage.emmc.cfg.template new file +52 -0
52 lines not on this page · raw message
board/freescale/ls1028ardb/genimage.sd.cfg.template new file +52 -0
52 lines not on this page · raw message
board/freescale/ls1028ardb/genimage.xspi.cfg.template new file +53 -0
53 lines not on this page · raw message
board/freescale/ls1028ardb/kernel.its new file +59 -0
59 lines not on this page · raw message
board/freescale/ls1028ardb/ls1028-10-network.rules new file +16 -0
@@ -0,0 +1,16 @@ +# ENETC rules +ACTION=="add", SUBSYSTEM=="net", KERNELS=="0000:00:00.0", DRIVERS=="fsl_enetc", NAME:="eno0" +ACTION=="add", SUBSYSTEM=="net", KERNELS=="0000:00:00.1", DRIVERS=="fsl_enetc", NAME:="eno1" +ACTION=="add", SUBSYSTEM=="net", KERNELS=="0000:00:00.2", DRIVERS=="fsl_enetc", NAME:="eno2" +ACTION=="add", SUBSYSTEM=="net", KERNELS=="0000:00:00.6", DRIVERS=="fsl_enetc", NAME:="eno3" +ACTION=="add", SUBSYSTEM=="net", KERNELS=="0000:00:01.0", DRIVERS=="fsl_enetc_vf", NAME:="eno0vf0" +ACTION=="add", SUBSYSTEM=="net", KERNELS=="0000:00:01.1", DRIVERS=="fsl_enetc_vf", NAME:="eno0vf1" +ACTION=="add", SUBSYSTEM=="net", KERNELS=="0000:00:01.2", DRIVERS=="fsl_enetc_vf", NAME:="eno1vf0" +ACTION=="add", SUBSYSTEM=="net", KERNELS=="0000:00:01.3", DRIVERS=="fsl_enetc_vf", NAME:="eno1vf1" +# LS1028 switch rules +ACTION=="add", SUBSYSTEM=="net", KERNELS=="0000:00:00.5", DRIVERS=="mscc_felix", ATTR{phys_port_name}=="p0", NAME="swp0" +ACTION=="add", SUBSYSTEM=="net", KERNELS=="0000:00:00.5", DRIVERS=="mscc_felix", ATTR{phys_port_name}=="p1", NAME="swp1" +ACTION=="add", SUBSYSTEM=="net", KERNELS=="0000:00:00.5", DRIVERS=="mscc_felix", ATTR{phys_port_name}=="p2", NAME="swp2" +ACTION=="add", SUBSYSTEM=="net", KERNELS=="0000:00:00.5", DRIVERS=="mscc_felix", ATTR{phys_port_name}=="p3", NAME="swp3" +ACTION=="add", SUBSYSTEM=="net", KERNELS=="0000:00:00.5", DRIVERS=="mscc_felix", ATTR{phys_port_name}=="p4", NAME="swp4" +ACTION=="add", SUBSYSTEM=="net", KERNELS=="0000:00:00.5", DRIVERS=="mscc_felix", ATTR{phys_port_name}=="p5", NAME="swp5"
board/freescale/ls1028ardb/post-cfg-udev.sh new file +10 -0
@@ -0,0 +1,10 @@ +#!/usr/bin/env bash + +main() +{ + cp board/freescale/ls1028ardb/ls1028-10-network.rules ${TARGET_DIR}/etc/udev/rules.d/10-network.rules + + exit $? +} + +main $@
board/freescale/ls1028ardb/readme.txt new file +61 -0
61 lines not on this page · raw message
board/freescale/ls1028ardb/u-boot-environment-emmc.txt new file +19 -0
@@ -0,0 +1,19 @@ +baudrate=115200 +bootcmd=setenv bootargs root=/dev/mmcblk1p2 rootwait rw earlycon=uart8250,0x21c0500 console=ttyS0,115200 cma=256M video=1920x1080-32 at 60;mmc dev 1;mmcinfo;fatload mmc 1:1 0x98000000 ls1028a-dp-fw.bin;hdp load 0x98000000 0x2000;fatload mmc 1:1 ${loadaddr} ${bootfile};fatload mmc 1:1 ${fdtaddr} ${fdtfile};booti ${loadaddr} - ${fdtaddr} +bootdelay=3 +bootfile=Image +fdtfile=fsl-ls1028a-rdb.dtb +eth2addr=00:1F:7B:63:35:E9 +ethact=FM1 at DTSEC3 +ethprime=FM1 at DTSEC3 +fdt_high=0xffffffffffffffff +fdtcontroladdr=ffc01550 +fman_ucode=ffc12090 +hwconfig=fsl_ddr:bank_intlv=auto +initrd_high=0xffffffffffffffff +loadaddr=0xa0000000 +fdtaddr=0xb0000000 +stderr=serial +stdin=serial +stdout=serial +rollbackboot=setenv bootargs root=/dev/ram0 rootwait rw earlycon=uart8250,0x21c0500 console=ttyS0,115200;mmcinfo;fatload mmc 0:1 ${loadaddr} ${bootfile};bootm ${loadaddr}
board/freescale/ls1028ardb/u-boot-environment-sd.txt new file +18 -0
@@ -0,0 +1,18 @@ +baudrate=115200 +bootcmd=setenv bootargs root=/dev/mmcblk0p2 rootwait rw earlycon=uart8250,0x21c0500 console=ttyS0,115200 cma=256M video=1920x1080-32 at 60;mmcinfo;fatload mmc 0:1 0x98000000 ls1028a-dp-fw.bin;hdp load 0x98000000 0x2000;fatload mmc 0:1 ${loadaddr} ${bootfile};fatload mmc 0:1 ${fdtaddr} ${fdtfile};booti ${loadaddr} - ${fdtaddr} +bootdelay=3 +bootfile=Image +fdtfile=fsl-ls1028a-rdb.dtb +eth2addr=00:1F:7B:63:35:E9 +ethact=FM1 at DTSEC3 +ethprime=FM1 at DTSEC3 +fdt_high=0xffffffffffffffff +fdtcontroladdr=ffc01550 +fman_ucode=ffc12090 +hwconfig=fsl_ddr:bank_intlv=auto +initrd_high=0xffffffffffffffff +loadaddr=0xa0000000 +fdtaddr=0xb0000000 +stderr=serial +stdin=serial +stdout=serial
board/freescale/ls1028ardb/u-boot-environment-xspi.txt new file +22 -0
@@ -0,0 +1,22 @@ +baudrate=115200 +bootcmd=setenv bootargs root=/dev/ram0 rw earlycon=uart8250,0x21c0500 console=ttyS0,115200 cma=256M video=1920x1080-32 at 60; sf probe 0:0; sf read $dp_load $dp_start $dp_size; hdp load $dp_load $dp_offset; sf read $kernel_load $kernel_start $kernel_size && bootm $kernel_load +bootdelay=3 +eth2addr=00:1F:7B:63:35:E9 +ethact=FM1 at DTSEC3 +ethprime=FM1 at DTSEC3 +fdt_high=0xffffffffffffffff +fdtcontroladdr=ffc01550 +fman_ucode=ffc12090 +hwconfig=fsl_ddr:bank_intlv=auto +initrd_high=0xffffffffffffffff +kernel_load=0xa0000000 +kernel_size=0x3000000 +kernel_start=0x1000000 +dp_load=0x90000000 +dp_start=0x940000 +dp_size=0x40000 +dp_offset=0x2000 +stderr=serial +stdin=serial +stdout=serial +rollbackboot=setenv bootargs root=/dev/ram0 rootwait rw earlycon=uart8250,0x21c0500 console=ttyS0,115200;mmcinfo;fatload mmc 0:1 ${loadaddr} ${bootfile};bootm $loadaddr
configs/freescale_ls1028ardb-emmc_defconfig new file +135 -0
135 lines not on this page · raw message
configs/freescale_ls1028ardb-sd_defconfig new file +133 -0
133 lines not on this page · raw message
configs/freescale_ls1028ardb-xspi_defconfig new file +129 -0
129 lines not on this page · raw message
Signature · 1 line
2.17.1