Skip to contentSkip to conversation

drm/amd/display/dc: Make dce110_validate_bandwidth static (v2)

PATCH In review Alex Deucher 3 participants 5 messages Aug 10, 2017 – Aug 11, 2017 4 messages not in the archive

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 drm/amd/display/dc: Make dce110_validate_bandwidth static (v2)

Not used outside of the dce110_resource.c.

v2: make a bunch of other functions static as well.

---
 drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c +4 -4
index c677f98..a7f30dc 100644
@@ -565,7 +565,7 @@ static const struct encoder_feature_support link_enc_feature = {
 		.flags.bits.IS_YCBCR_CAPABLE = true
 };
 
-struct link_encoder *dce110_link_encoder_create(
+static struct link_encoder *dce110_link_encoder_create(
 	const struct encoder_init_data *enc_init_data)
 {
 	struct dce110_link_encoder *enc110 =
@@ -813,7 +813,7 @@ static enum dc_status build_mapped_resource(
 	return DC_OK;
 }
 
-bool dce110_validate_bandwidth(
+static bool dce110_validate_bandwidth(
 	const struct core_dc *dc,
 	struct validate_context *context)
 {
@@ -927,7 +927,7 @@ static bool dce110_validate_surface_sets(
 	return true;
 }
 
-enum dc_status dce110_validate_with_context(
+static enum dc_status dce110_validate_with_context(
 		const struct core_dc *dc,
 		const struct dc_validation_set set[],
 		int set_count,
@@ -971,7 +971,7 @@ enum dc_status dce110_validate_with_context(
 	return result;
 }
 
-enum dc_status dce110_validate_guaranteed(
+static enum dc_status dce110_validate_guaranteed(
 		const struct core_dc *dc,
 		struct dc_stream_state *dc_stream,
 		struct validate_context *context)
Signature · 6 lines
2.5.5

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1502389342-915-1-git-send-email-alexander.deucher-5C7GfCeVMHo@public.gmane.org

#2 lore raw

PATCH 2/2 drm/amd/display/dc: make dce120_link_encoder_create static

Only used in dce120_resource.c.

---
 drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c +1 -1
index 6448d15..d4e9627 100644
@@ -535,7 +535,7 @@ static const struct encoder_feature_support link_enc_feature = {
 		.flags.bits.IS_YCBCR_CAPABLE = true
 };
 
-struct link_encoder *dce120_link_encoder_create(
+static struct link_encoder *dce120_link_encoder_create(
 	const struct encoder_init_data *enc_init_data)
 {
 	struct dce110_link_encoder *enc110 =
Signature · 6 lines
2.5.5

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1502389342-915-2-git-send-email-alexander.deucher-5C7GfCeVMHo@public.gmane.org

Reviewed-by
#4 lore raw

Re: [PATCH 2/2] drm/amd/display/dc: make dce120_link_encoder_create static

Both patches are

Harry

Quoted 13 lines · Alex Deucher

Only used in dce120_resource.c.

---
 drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c +0 -0
index 6448d15..d4e9627 100644

drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c static const struct encoder_feature_support link_enc_feature = { · line 541

Quoted 8 lines
drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c +1 -1
@@ -535,7 +535,7 @@ static const struct encoder_feature_support link_enc_feature = {
 		.flags.bits.IS_YCBCR_CAPABLE = true
 };
 
-struct link_encoder *dce120_link_encoder_create(
+static struct link_encoder *dce120_link_encoder_create(
 	const struct encoder_init_data *enc_init_data)
 {
 	struct dce110_link_encoder *enc110 =

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): d4cb0107-c16e-115e-f585-06c47ae4c2ec-5C7GfCeVMHo@public.gmane.org

#6 lore raw

RE: [PATCH 2/2] drm/amd/display/dc: make dce120_link_encoder_create static

Quoted 10 lines

-----Original Message-----
From: Wentland, Harry
Sent: Thursday, August 10, 2017 9:41 PM
To: Alex Deucher; [email protected]
Cc: Deucher, Alexander
Subject: Re: [PATCH 2/2] drm/amd/display/dc: make
dce120_link_encoder_create static

Both patches are

You want to take these through your tree?

Alex

Quoted 21 lines

Harry

Review

Quoted 8 lines · Alex Deucher

Only used in dce120_resource.c.

---
 drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c

drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c static const struct encoder_feature_support

Quoted 4 lines

index 6448d15..d4e9627 100644

drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c +0 -0
@@ -535,7 +535,7 @@ static const struct encoder_feature_support

link_enc_feature = {

Quoted 3 lines
drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c +0 -0
 		.flags.bits.IS_YCBCR_CAPABLE = true
 };
 
Quoted 6 lines

drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c static const struct encoder_feature_support link_enc_feature = { · line 541

Quoted 6 lines
drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c +1 -1
-struct link_encoder *dce120_link_encoder_create(
+static struct link_encoder *dce120_link_encoder_create(
 	const struct encoder_init_data *enc_init_data)
 {
 	struct dce110_link_encoder *enc110 =

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): BN6PR12MB1652FDB3B3AF9057D60653F6F7890-/b2+HYfkarQqUD6E6FAiowdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org

#8 lore raw

Re: [PATCH 2/2] drm/amd/display/dc: make dce120_link_encoder_create static

Quoted 8 lines · Alexander
Quoted 8 lines

-----Original Message-----
From: Wentland, Harry
Sent: Thursday, August 10, 2017 9:41 PM
To: Alex Deucher; [email protected]
Cc: Deucher, Alexander
Subject: Re: [PATCH 2/2] drm/amd/display/dc: make
dce120_link_encoder_create static

Quoted 5 lines
Quoted 2 lines

Both patches are

You want to take these through your tree?

Yes.

Harry

Quoted 23 lines

Alex

Quoted 21 lines

Harry

Review

Quoted 8 lines · Alex Deucher

Only used in dce120_resource.c.

---
 drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c

drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c static const struct encoder_feature_support

Quoted 4 lines

index 6448d15..d4e9627 100644

drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c +0 -0
@@ -535,7 +535,7 @@ static const struct encoder_feature_support

link_enc_feature = {

Quoted 3 lines
drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c +0 -0
 		.flags.bits.IS_YCBCR_CAPABLE = true
 };
 
Quoted 6 lines
Quoted 6 lines

drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c static const struct encoder_feature_support link_enc_feature = { · line 541

Quoted 6 lines
drivers/gpu/drm/amd/display/dc/dce120/dce120_resource.c +1 -1
-struct link_encoder *dce120_link_encoder_create(
+static struct link_encoder *dce120_link_encoder_create(
 	const struct encoder_init_data *enc_init_data)
 {
 	struct dce110_link_encoder *enc110 =

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx