Skip to contentSkip to conversation

KVM: s390: vsie: Return correct values for Invalid CRYCB format

PATCH Applied Pierre Morel 3 participants 7 messages Apr 26, 2019 – Apr 29, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 KVM: s390: vsie: Return correct values for Invalid CRYCB format

Let's use the correct validity number.

Fixes 55ded154b43 "KVM: s390: vsie: Allow CRYCB FORMAT-2"
---
 arch/s390/kvm/vsie.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/s390/kvm/vsie.c +1 -1
index ac411e9..076090f 100644
@@ -344,7 +344,7 @@ static int shadow_crycb(struct kvm_vcpu *vcpu, struct vsie_page *vsie_page)
 end:
 	switch (ret) {
 	case -EINVAL:
-		return set_validity_icpt(scb_s, 0x0020U);
+		return set_validity_icpt(scb_s, 0x0022U);
 	case -EFAULT:
 		return set_validity_icpt(scb_s, 0x0035U);
 	case -EACCES:
Signature · 1 line
2.7.4
#1 lore raw
Quoted 3 lines · Pierre Morel

Let's use the correct validity number.

Fixes 55ded154b43 "KVM: s390: vsie: Allow CRYCB FORMAT-2"

LANG=c git show 55ded154b43
fatal: ambiguous argument '55ded154b43': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:

Quoted 21 lines
---
 arch/s390/kvm/vsie.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/s390/kvm/vsie.c +1 -1
index ac411e9..076090f 100644
@@ -344,7 +344,7 @@ static int shadow_crycb(struct kvm_vcpu *vcpu, struct vsie_page *vsie_page)
 end:
 	switch (ret) {
 	case -EINVAL:
-		return set_validity_icpt(scb_s, 0x0020U);
+		return set_validity_icpt(scb_s, 0x0022U);
 	case -EFAULT:
 		return set_validity_icpt(scb_s, 0x0035U);
 	case -EACCES:
Signature · 3 lines
Thanks,

David / dhildenb
#2 lore raw
Quoted 10 lines · David Hildenbrand
Quoted 3 lines · Pierre Morel

Let's use the correct validity number.

Fixes 55ded154b43 "KVM: s390: vsie: Allow CRYCB FORMAT-2"

LANG=c git show 55ded154b43
fatal: ambiguous argument '55ded154b43': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:

I think this should be
56019f9aca2266edc7f304d91e4e772023b7aa14

Quoted 24 lines
Quoted 22 lines
---
 arch/s390/kvm/vsie.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/s390/kvm/vsie.c +1 -1
index ac411e9..076090f 100644
@@ -344,7 +344,7 @@ static int shadow_crycb(struct kvm_vcpu *vcpu, struct vsie_page *vsie_page)
 end:
 	switch (ret) {
 	case -EINVAL:
-		return set_validity_icpt(scb_s, 0x0020U);
+		return set_validity_icpt(scb_s, 0x0022U);
 	case -EFAULT:
 		return set_validity_icpt(scb_s, 0x0035U);
 	case -EACCES:
#3 lore raw
Quoted 8 lines · Christian Borntraeger
Quoted 5 lines · David Hildenbrand
Quoted 3 lines · Pierre Morel

Let's use the correct validity number.

Fixes 55ded154b43 "KVM: s390: vsie: Allow CRYCB FORMAT-2"
Quoted 8 lines
Quoted 5 lines

LANG=c git show 55ded154b43
fatal: ambiguous argument '55ded154b43': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:

I think this should be
56019f9aca2266edc7f304d91e4e772023b7aa14

Yes it is, sorry, forgot to adjust the hash

Quoted 26 lines
Quoted 25 lines
Quoted 23 lines
---
  arch/s390/kvm/vsie.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
arch/s390/kvm/vsie.c +1 -1
index ac411e9..076090f 100644
@@ -344,7 +344,7 @@ static int shadow_crycb(struct kvm_vcpu *vcpu, struct vsie_page *vsie_page)
  end:
  	switch (ret) {
  	case -EINVAL:
-		return set_validity_icpt(scb_s, 0x0020U);
+		return set_validity_icpt(scb_s, 0x0022U);
  	case -EFAULT:
  		return set_validity_icpt(scb_s, 0x0035U);
  	case -EACCES:
Signature · 2 lines
Pierre Morel
Linux/KVM/QEMU in Böblingen - Germany
Acked-by on v1 1/1
#4 lore raw
In reply to Pierre Morel
Quoted 16 lines · Pierre Morel

Let's use the correct validity number.

Fixes 55ded154b43 "KVM: s390: vsie: Allow CRYCB FORMAT-2"
---
 arch/s390/kvm/vsie.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/s390/kvm/vsie.c +0 -0
index ac411e9..076090f 100644

arch/s390/kvm/vsie.c static int shadow_crycb(struct kvm_vcpu *vcpu, struct vsie_page *vsie_page) · line 350

Quoted 8 lines
arch/s390/kvm/vsie.c +1 -1
@@ -344,7 +344,7 @@ static int shadow_crycb(struct kvm_vcpu *vcpu, struct vsie_page *vsie_page)
 end:
 	switch (ret) {
 	case -EINVAL:
-		return set_validity_icpt(scb_s, 0x0020U);
+		return set_validity_icpt(scb_s, 0x0022U);
 	case -EFAULT:
 		return set_validity_icpt(scb_s, 0x0035U);
 	case -EACCES:

Can't verify

Signature · 3 lines
Thanks,

David / dhildenb
#5 lore raw
Quoted 28 lines · David Hildenbrand
Quoted 16 lines · Pierre Morel

Let's use the correct validity number.

Fixes 55ded154b43 "KVM: s390: vsie: Allow CRYCB FORMAT-2"
---
  arch/s390/kvm/vsie.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
arch/s390/kvm/vsie.c +0 -0
index ac411e9..076090f 100644

arch/s390/kvm/vsie.c static int shadow_crycb(struct kvm_vcpu *vcpu, struct vsie_page *vsie_page) · line 350

Quoted 8 lines
arch/s390/kvm/vsie.c +1 -1
@@ -344,7 +344,7 @@ static int shadow_crycb(struct kvm_vcpu *vcpu, struct vsie_page *vsie_page)
  end:
  	switch (ret) {
  	case -EINVAL:
-		return set_validity_icpt(scb_s, 0x0020U);
+		return set_validity_icpt(scb_s, 0x0022U);
  	case -EFAULT:
  		return set_validity_icpt(scb_s, 0x0035U);
  	case -EACCES:

Can't verify

Quoted 2 lines

Thanks.

Signature · 2 lines
Pierre Morel
Linux/KVM/QEMU in Böblingen - Germany
#6 lore raw
In reply to Pierre Morel
Quoted 16 lines · Pierre Morel

Let's use the correct validity number.

Fixes 55ded154b43 "KVM: s390: vsie: Allow CRYCB FORMAT-2"
---
 arch/s390/kvm/vsie.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/s390/kvm/vsie.c +0 -0
index ac411e9..076090f 100644

arch/s390/kvm/vsie.c static int shadow_crycb(struct kvm_vcpu *vcpu, struct vsie_page *vsie_page) · line 350

Quoted 8 lines
arch/s390/kvm/vsie.c +1 -1
@@ -344,7 +344,7 @@ static int shadow_crycb(struct kvm_vcpu *vcpu, struct vsie_page *vsie_page)
 end:
 	switch (ret) {
 	case -EINVAL:
-		return set_validity_icpt(scb_s, 0x0020U);
+		return set_validity_icpt(scb_s, 0x0022U);
 	case -EFAULT:
 		return set_validity_icpt(scb_s, 0x0035U);
 	case -EACCES:

Thanks applied.