drm/amdkfd: Fix unchecked return value
Subsystems (3)
PATCH 1/1 drm/amdkfd: Fix unchecked return value
Assign return value of function amdgpu_bo_sync_wait() to variable ret for its further check.
Addresses-Coverity-ID: 1443914 ("Logically dead code")
--- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c +2 -1
@@ -906,7 +906,8 @@ static int init_kfd_vm(struct amdgpu_vm *vm, void **process_info,pr_err ("validate_pt_pd_bos() failed\n" ); goto validate_pd_fail; } -amdgpu_bo_sync_wait (vm->root.base.bo,AMDGPU_FENCE_OWNER_KFD , false); + ret =amdgpu_bo_sync_wait (vm->root.base.bo,AMDGPU_FENCE_OWNER_KFD , + false);if (ret) goto wait_pd_fail; amdgpu_bo_fence(vm->root.base.bo,
Signature · 6 lines
2.21.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Kuehling, Felix
maintainerAlex already applied an equivalent patch by Colin King (attached for reference).
Regards,
Felix
Quoted 15 lines · Gustavo A. R. Silva
Assign return value of function
amdgpu_bo_sync_wait()to variable ret for its further check.Addresses-Coverity-ID: 1443914 ("Logically dead code")
Fixes c60cd590cb7d ("drm/amdgpu: Replace ttm_bo_wait with amdgpu_bo_sync_wait")Signed-off-by Gustavo A. R. Silva <[email protected]>--- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c +0
-0
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c static int init_kfd_vm(struct amdgpu_vm *vm, void **process_info, · line 913
Quoted 9 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c +2
-1@@ -906,7 +906,8 @@ static int init_kfd_vm(struct amdgpu_vm *vm, void **process_info,pr_err ("validate_pt_pd_bos() failed\n" ); goto validate_pd_fail; } -amdgpu_bo_sync_wait (vm->root.base.bo,AMDGPU_FENCE_OWNER_KFD , false); + ret =amdgpu_bo_sync_wait (vm->root.base.bo,AMDGPU_FENCE_OWNER_KFD , + false);if (ret) goto wait_pd_fail; amdgpu_bo_fence(vm->root.base.bo,
From: Colin Ian King <[email protected]>
An earlier commit replaced ttm_bo_wait with amdgpu_bo_sync_wait and removed the error return assignment to variable ret. Fix this by adding the assignment back. Also break line to clean up checkpatch overly long line warning.
Detected by CoverityScan, CID#1477327 ("Logically dead code")
--- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c +2 -1
@@ -906,7 +906,8 @@ static int init_kfd_vm(struct amdgpu_vm *vm, void **process_info,pr_err ("validate_pt_pd_bos() failed\n" ); goto validate_pd_fail; } -amdgpu_bo_sync_wait (vm->root.base.bo,AMDGPU_FENCE_OWNER_KFD , false); + ret =amdgpu_bo_sync_wait (vm->root.base.bo, +AMDGPU_FENCE_OWNER_KFD , false);if (ret) goto wait_pd_fail; amdgpu_bo_fence(vm->root.base.bo,
Signature · 6 lines
2.20.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Quoted 3 lines · Felix
Alex already applied an equivalent patch by Colin King (attached for reference).
Oh, that's great. Good to know.
Thanks, Felix.
--
Gustavo
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel