Skip to contentSkip to conversation

ti-rpmsg-char-examples: Fix cross compile

PATCH Superseded Khem Raj 3 participants 14 messages Oct 25, 2020 – Oct 29, 2020 2 messages not in the archive

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/2 ti-rpmsg-char-examples: Fix cross compile

This fixes problems during cross compile where it starts to peek into build host's include and library paths and causes errors with clang and QA warnings with gcc

---
 ...-Remove-use-of-includedir-and-libdir.patch | 37 +++++++++++++++++++
 recipes-ti/ipc/ti-rpmsg-char-examples_git.bb  |  2 +
 2 files changed, 39 insertions(+)
 create mode 100644 recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch
recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch new file +37 -0
new file mode 100644
index 00000000..34807152
@@ -0,0 +1,37 @@
+From 1a26cb577ba54dd9214eeb94fed0ce3a0f4603b6 Mon Sep 17 00:00:00 2001
+From: Khem Raj <[email protected]>
+Date: Sat, 24 Oct 2020 23:46:39 -0700
+Subject: [PATCH] examples: Remove use of includedir and libdir
+
+These point to standard include and library paths which already are used
+from sysroot relative paths secondly, they use absolute paths which
+means we are asking to add -I/usr/include which might be ok in a native
+build but not in cross build. This helps mitigate QA errors found with
+OE build system since it finds it adding host include and library search
+paths to linker/compiler commandline
+
+Signed-off-by: Khem Raj <[email protected]>
+---
+ examples/Makefile.am | 5 +----
+ 1 file changed, 1 insertion(+), 4 deletions(-)
+
+diff --git a/examples/Makefile.am b/examples/Makefile.am
+index 5a9bedb..d547e41 100644
+--- a/examples/Makefile.am
++++ b/examples/Makefile.am
+@@ -1,6 +1,4 @@
+-INCLUDE = -I${includedir}
+-
+-AM_CFLAGS = -Wall -g -O2 $(INCLUDE)
++AM_CFLAGS = -Wall -g -O2
+ 
+ bin_PROGRAMS = rpmsg_char_simple
+ 
+@@ -8,4 +6,3 @@ bin_PROGRAMS = rpmsg_char_simple
+ rpmsg_char_simple_SOURCES = rpmsg_char_simple.c
+ rpmsg_char_simple_CPPFLAGS = $(AM_CFLAGS)
+ rpmsg_char_simple_LDADD = -lpthread -lti_rpmsg_char
+-rpmsg_char_simple_LDFLAGS = -L${libdir}
+-- 
+2.29.1
+
recipes-ti/ipc/ti-rpmsg-char-examples_git.bb +2 -0
index 142e5bf0..cbe4d7fd 100644
@@ -2,6 +2,8 @@ SUMMARY = "TI RPMsg Char Sample Applications and Tests"
 
 require ti-rpmsg-char.inc
 
+SRC_URI += "file://0001-examples-Remove-use-of-includedir-and-libdir.patch"
+
 DEPENDS = "ti-rpmsg-char"
 
 inherit autotools pkgconfig
Signature · 1 line
2.29.1
author
#1 lore raw

PATCH 2/2 ti-rpmsg-char: Mark these recipes to be TI SOC specific

---
 recipes-ti/ipc/ti-rpmsg-char.inc | 3 +++
 1 file changed, 3 insertions(+)
recipes-ti/ipc/ti-rpmsg-char.inc +3 -0
index b41e68eb..d08031cb 100644
@@ -13,3 +13,6 @@ SRCREV = "9be402c2bf4053900b6b9a8092fbb42e7e303108"
 PV = "0.1.0+git${SRCPV}"
 
 S = "${WORKDIR}/git"
+
+COMPATIBLE_HOST ?= "null"
+COMPATIBLE_HOST_ti-soc = "(.*)"
Signature · 1 line
2.29.1
#2 lore raw

Re: [meta-ti] [PATCH 2/2] ti-rpmsg-char: Mark these recipes to be TI SOC specific

Hi Raj,

Quoted 11 lines · Khem Raj
---
 recipes-ti/ipc/ti-rpmsg-char.inc | 3 +++
 1 file changed, 3 insertions(+)
recipes-ti/ipc/ti-rpmsg-char.inc +0 -0
index b41e68eb..d08031cb 100644

recipes-ti/ipc/ti-rpmsg-char.inc SRCREV = "9be402c2bf4053900b6b9a8092fbb42e7e303108" · line 18

Quoted 6 lines
recipes-ti/ipc/ti-rpmsg-char.inc +3 -0
@@ -13,3 +13,6 @@ SRCREV = "9be402c2bf4053900b6b9a8092fbb42e7e303108"
 PV = "0.1.0+git${SRCPV}"
 
 S = "${WORKDIR}/git"
+
+COMPATIBLE_HOST ?= "null"
+COMPATIBLE_HOST_ti-soc = "(.*)"

This looks ok, but I am trying to understand why this is needed in general (am still getting familiar with OE). Aren't the recipes processed only on packagegroups that include them?

regards
Suman

Quoted 4 lines
author
#3 lore raw

Re: [meta-ti] [PATCH 2/2] ti-rpmsg-char: Mark these recipes to be TI SOC specific

Quoted 16 lines · Suman Anna

Hi Raj,

Quoted 12 lines · Khem Raj
---
 recipes-ti/ipc/ti-rpmsg-char.inc | 3 +++
 1 file changed, 3 insertions(+)
recipes-ti/ipc/ti-rpmsg-char.inc +0 -0
index b41e68eb..d08031cb 100644
@@ -13,3 +13,6 @@ SRCREV = "9be402c2bf4053900b6b9a8092fbb42e7e303108"
 PV = "0.1.0+git${SRCPV}"
 
Quoted 9 lines

recipes-ti/ipc/ti-rpmsg-char.inc SRCREV = "9be402c2bf4053900b6b9a8092fbb42e7e303108" · line 18

Quoted 5 lines
recipes-ti/ipc/ti-rpmsg-char.inc +3 -0
 S = "${WORKDIR}/git"
+
+COMPATIBLE_HOST ?= "null"
+COMPATIBLE_HOST_ti-soc = "(.*)"

This looks ok, but I am trying to understand why this is needed in general (am still getting familiar with OE). Aren't the recipes processed only on packagegroups that include them?

on image builds yes. however in yoe distro CI builds we test multi-BSP setups and do world builds which catch
such issues, where BSP layers are exposing general packages which are not compatible with other BSPs.

Quoted 9 lines

regards
Suman

Quoted 4 lines
#4 lore raw

Re: [meta-ti] [PATCH 2/2] ti-rpmsg-char: Mark these recipes to be TI SOC specific

Quoted 27 lines · Khem Raj
Quoted 16 lines · Suman Anna

Hi Raj,

Quoted 12 lines · Khem Raj
---
 recipes-ti/ipc/ti-rpmsg-char.inc | 3 +++
 1 file changed, 3 insertions(+)
recipes-ti/ipc/ti-rpmsg-char.inc +0 -0
index b41e68eb..d08031cb 100644
@@ -13,3 +13,6 @@ SRCREV = "9be402c2bf4053900b6b9a8092fbb42e7e303108"
 PV = "0.1.0+git${SRCPV}"
 
Quoted 9 lines

recipes-ti/ipc/ti-rpmsg-char.inc SRCREV = "9be402c2bf4053900b6b9a8092fbb42e7e303108" · line 18

Quoted 5 lines
recipes-ti/ipc/ti-rpmsg-char.inc +3 -0
 S = "${WORKDIR}/git"
+
+COMPATIBLE_HOST ?= "null"
+COMPATIBLE_HOST_ti-soc = "(.*)"

This looks ok, but I am trying to understand why this is needed in general (am still getting familiar with OE). Aren't the recipes processed only on packagegroups that include them?

Quoted 4 lines

on image builds yes. however in yoe distro CI builds we test multi-BSP setups and do world builds which catch
such issues, where BSP layers are exposing general packages which are not compatible with other BSPs.

Thanks for the clarification!

regards
Suman

Quoted 10 lines
Quoted 10 lines

regards
Suman

Quoted 4 lines

A message that is not in the archive (sent off-list or not yet received): [email protected]

Reviewed-by
#6 lore raw

Re: [meta-ti] [PATCH 2/2] ti-rpmsg-char: Mark these recipes to be TI SOC specific

Quoted 28 lines · Suman Anna via lists.yoctoproject.org
Quoted 27 lines · Khem Raj
Quoted 25 lines · Suman Anna

Hi Raj,

Quoted 11 lines · Khem Raj
---
 recipes-ti/ipc/ti-rpmsg-char.inc | 3 +++
 1 file changed, 3 insertions(+)
recipes-ti/ipc/ti-rpmsg-char.inc +0 -0
index b41e68eb..d08031cb 100644

recipes-ti/ipc/ti-rpmsg-char.inc SRCREV = "9be402c2bf4053900b6b9a8092fbb42e7e303108" · line 18

Quoted 6 lines
recipes-ti/ipc/ti-rpmsg-char.inc +3 -0
@@ -13,3 +13,6 @@ SRCREV = "9be402c2bf4053900b6b9a8092fbb42e7e303108"
 PV = "0.1.0+git${SRCPV}"
 
 S = "${WORKDIR}/git"
+
+COMPATIBLE_HOST ?= "null"
+COMPATIBLE_HOST_ti-soc = "(.*)"

This looks ok, but I am trying to understand why this is needed in general (am still getting familiar with OE). Aren't the recipes processed only on packagegroups that include them?

Quoted 6 lines
Quoted 4 lines

on image builds yes. however in yoe distro CI builds we test multi-BSP setups and do world builds which catch
such issues, where BSP layers are exposing general packages which are not compatible with other BSPs.

Thanks for the clarification!

regards
Suman

#7 lore raw

Re: [meta-ti] [PATCH 2/2] ti-rpmsg-char: Mark these recipes to be TI SOC specific

In reply to Suman Anna
Quoted 15 lines · Suman Anna via lists.yoctoproject.org

Hi Raj,

Quoted 12 lines · Khem Raj
---
 recipes-ti/ipc/ti-rpmsg-char.inc | 3 +++
 1 file changed, 3 insertions(+)
recipes-ti/ipc/ti-rpmsg-char.inc +0 -0
index b41e68eb..d08031cb 100644
@@ -13,3 +13,6 @@ SRCREV = "9be402c2bf4053900b6b9a8092fbb42e7e303108"
 PV = "0.1.0+git${SRCPV}"
 
Quoted 9 lines

recipes-ti/ipc/ti-rpmsg-char.inc SRCREV = "9be402c2bf4053900b6b9a8092fbb42e7e303108" · line 18

Quoted 5 lines
recipes-ti/ipc/ti-rpmsg-char.inc +3 -0
 S = "${WORKDIR}/git"
+
+COMPATIBLE_HOST ?= "null"
+COMPATIBLE_HOST_ti-soc = "(.*)"

This looks ok, but I am trying to understand why this is needed in general (am still getting familiar with OE). Aren't the recipes processed only on packagegroups that include them?

Suman,

Some people like Khem do world builds - kind of like building kernel with "allyesconfig" to see any conflicts or incompatibilities...

Signature · 1 line
Denys
#8 lore raw
In reply to Khem Raj
Quoted 18 lines · Khem Raj

This fixes problems during cross compile where it starts to peek into build host's include and library paths and causes errors with clang and QA warnings with gcc

---
 ...-Remove-use-of-includedir-and-libdir.patch | 37 +++++++++++++++++++
 recipes-ti/ipc/ti-rpmsg-char-examples_git.bb  |  2 +
 2 files changed, 39 insertions(+)
 create mode 100644 recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch
recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch new file +1 -0
new file mode 100644
index 00000000..34807152
@@ -0,0 +1,37 @@
+From 1a26cb577ba54dd9214eeb94fed0ce3a0f4603b6 Mon Sep 17 00:00:00 2001

recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch line 11

Quoted 10 lines
recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch new file +10 -0
+From: Khem Raj <[email protected]>
+Date: Sat, 24 Oct 2020 23:46:39 -0700
+Subject: [PATCH] examples: Remove use of includedir and libdir
+
+These point to standard include and library paths which already are used
+from sysroot relative paths secondly, they use absolute paths which
+means we are asking to add -I/usr/include which might be ok in a native
+build but not in cross build. This helps mitigate QA errors found with
+OE build system since it finds it adding host include and library search
+paths to linker/compiler commandline

What's the Upstream-Status on this? Should it be "Inappropriate [OE-specific]"?

Quoted 45 lines
recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch new file +25 -0
+Signed-off-by: Khem Raj <[email protected]>
+---
+ examples/Makefile.am | 5 +----
+ 1 file changed, 1 insertion(+), 4 deletions(-)
+
+diff --git a/examples/Makefile.am b/examples/Makefile.am
+index 5a9bedb..d547e41 100644
+--- a/examples/Makefile.am
++++ b/examples/Makefile.am
+@@ -1,6 +1,4 @@
+-INCLUDE = -I${includedir}
+-
+-AM_CFLAGS = -Wall -g -O2 $(INCLUDE)
++AM_CFLAGS = -Wall -g -O2
+ 
+ bin_PROGRAMS = rpmsg_char_simple
+ 
+@@ -8,4 +6,3 @@ bin_PROGRAMS = rpmsg_char_simple
+ rpmsg_char_simple_SOURCES = rpmsg_char_simple.c
+ rpmsg_char_simple_CPPFLAGS = $(AM_CFLAGS)
+ rpmsg_char_simple_LDADD = -lpthread -lti_rpmsg_char
+-rpmsg_char_simple_LDFLAGS = -L${libdir}
+-- 
+2.29.1
+
recipes-ti/ipc/ti-rpmsg-char-examples_git.bb +2 -0
index 142e5bf0..cbe4d7fd 100644
@@ -2,6 +2,8 @@ SUMMARY = "TI RPMsg Char Sample Applications and Tests"
 
 require ti-rpmsg-char.inc
 
+SRC_URI += "file://0001-examples-Remove-use-of-includedir-and-libdir.patch"
+
 DEPENDS = "ti-rpmsg-char"
 
 inherit autotools pkgconfig
Signature · 1 line
2.29.1
author
#9 lore raw

I think it should be applied but then I don't know how else this component is used. maybe there are some toolchains which don't have sysrooots used to compile this

Quoted 80 lines · Denys Dmytriyenko
Quoted 18 lines · Khem Raj

This fixes problems during cross compile where it starts to peek into build host's include and library paths and causes errors with clang and QA warnings with gcc

---
 ...-Remove-use-of-includedir-and-libdir.patch | 37 +++++++++++++++++++
 recipes-ti/ipc/ti-rpmsg-char-examples_git.bb  |  2 +
 2 files changed, 39 insertions(+)
 create mode 100644 recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch
recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch new file +1 -0
new file mode 100644
index 00000000..34807152
@@ -0,0 +1,37 @@
+From 1a26cb577ba54dd9214eeb94fed0ce3a0f4603b6 Mon Sep 17 00:00:00 2001

recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch line 11

Quoted 10 lines
recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch new file +10 -0
+From: Khem Raj <[email protected]>
+Date: Sat, 24 Oct 2020 23:46:39 -0700
+Subject: [PATCH] examples: Remove use of includedir and libdir
+
+These point to standard include and library paths which already are used
+from sysroot relative paths secondly, they use absolute paths which
+means we are asking to add -I/usr/include which might be ok in a native
+build but not in cross build. This helps mitigate QA errors found with
+OE build system since it finds it adding host include and library search
+paths to linker/compiler commandline

What's the Upstream-Status on this? Should it be "Inappropriate [OE-specific]"?

Quoted 45 lines
recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch new file +25 -0
+Signed-off-by: Khem Raj <[email protected]>
+---
+ examples/Makefile.am | 5 +----
+ 1 file changed, 1 insertion(+), 4 deletions(-)
+
+diff --git a/examples/Makefile.am b/examples/Makefile.am
+index 5a9bedb..d547e41 100644
+--- a/examples/Makefile.am
++++ b/examples/Makefile.am
+@@ -1,6 +1,4 @@
+-INCLUDE = -I${includedir}
+-
+-AM_CFLAGS = -Wall -g -O2 $(INCLUDE)
++AM_CFLAGS = -Wall -g -O2
+
+ bin_PROGRAMS = rpmsg_char_simple
+
+@@ -8,4 +6,3 @@ bin_PROGRAMS = rpmsg_char_simple
+ rpmsg_char_simple_SOURCES = rpmsg_char_simple.c
+ rpmsg_char_simple_CPPFLAGS = $(AM_CFLAGS)
+ rpmsg_char_simple_LDADD = -lpthread -lti_rpmsg_char
+-rpmsg_char_simple_LDFLAGS = -L${libdir}
+--
+2.29.1
+
recipes-ti/ipc/ti-rpmsg-char-examples_git.bb +2 -1
index 142e5bf0..cbe4d7fd 100644
@@ -2,6 +2,8 @@ SUMMARY = "TI RPMsg Char Sample Applications and Tests"
 
 require ti-rpmsg-char.inc
 
+SRC_URI += "file://0001-examples-Remove-use-of-includedir-and-libdir.patch"
+
 DEPENDS = "ti-rpmsg-char"
 
 inherit autotools pkgconfig
--

2.29.1

#10 lore raw
Quoted 3 lines · Khem Raj

I think it should be applied but then I don't know how else this component is used. maybe there are some toolchains which don't have sysrooots used to compile this

This is meant to be cross-compiled for the target, in which case accessing host headers or libraries is a bad idea regardless of the toolchain...

Quoted 81 lines · Denys Dmytriyenko
Quoted 80 lines · Khem Raj
Quoted 18 lines

This fixes problems during cross compile where it starts to peek into build host's include and library paths and causes errors with clang and QA warnings with gcc

---
 ...-Remove-use-of-includedir-and-libdir.patch | 37 +++++++++++++++++++
 recipes-ti/ipc/ti-rpmsg-char-examples_git.bb  |  2 +
 2 files changed, 39 insertions(+)
 create mode 100644 recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch
recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch new file +1 -0
new file mode 100644
index 00000000..34807152
@@ -0,0 +1,37 @@
+From 1a26cb577ba54dd9214eeb94fed0ce3a0f4603b6 Mon Sep 17 00:00:00 2001

recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch line 11

Quoted 10 lines
recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch new file +10 -0
+From: Khem Raj <[email protected]>
+Date: Sat, 24 Oct 2020 23:46:39 -0700
+Subject: [PATCH] examples: Remove use of includedir and libdir
+
+These point to standard include and library paths which already are used
+from sysroot relative paths secondly, they use absolute paths which
+means we are asking to add -I/usr/include which might be ok in a native
+build but not in cross build. This helps mitigate QA errors found with
+OE build system since it finds it adding host include and library search
+paths to linker/compiler commandline

What's the Upstream-Status on this? Should it be "Inappropriate [OE-specific]"?

Quoted 45 lines
recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch new file +25 -0
+Signed-off-by: Khem Raj <[email protected]>
+---
+ examples/Makefile.am | 5 +----
+ 1 file changed, 1 insertion(+), 4 deletions(-)
+
+diff --git a/examples/Makefile.am b/examples/Makefile.am
+index 5a9bedb..d547e41 100644
+--- a/examples/Makefile.am
++++ b/examples/Makefile.am
+@@ -1,6 +1,4 @@
+-INCLUDE = -I${includedir}
+-
+-AM_CFLAGS = -Wall -g -O2 $(INCLUDE)
++AM_CFLAGS = -Wall -g -O2
+
+ bin_PROGRAMS = rpmsg_char_simple
+
+@@ -8,4 +6,3 @@ bin_PROGRAMS = rpmsg_char_simple
+ rpmsg_char_simple_SOURCES = rpmsg_char_simple.c
+ rpmsg_char_simple_CPPFLAGS = $(AM_CFLAGS)
+ rpmsg_char_simple_LDADD = -lpthread -lti_rpmsg_char
+-rpmsg_char_simple_LDFLAGS = -L${libdir}
+--
+2.29.1
+
recipes-ti/ipc/ti-rpmsg-char-examples_git.bb +2 -1
index 142e5bf0..cbe4d7fd 100644
@@ -2,6 +2,8 @@ SUMMARY = "TI RPMsg Char Sample Applications and Tests"
 
 require ti-rpmsg-char.inc
 
+SRC_URI += "file://0001-examples-Remove-use-of-includedir-and-libdir.patch"
+
 DEPENDS = "ti-rpmsg-char"
 
 inherit autotools pkgconfig
--

2.29.1

A message that is not in the archive (sent off-list or not yet received): [email protected]

#12 lore raw
Quoted 7 lines · Denys Dmytriyenko via lists.yoctoproject.org
Quoted 3 lines · Khem Raj

I think it should be applied but then I don't know how else this component is used. maybe there are some toolchains which don't have sysrooots used to compile this

This is meant to be cross-compiled for the target, in which case accessing host headers or libraries is a bad idea regardless of the toolchain...

Khem, Suman,

Any conclusion here? Should this change be taken upstream by Suman? Or should this reside here as a patch with "Upstream-Status: Inappropriate [OE-specific]"?

Denys

Quoted 85 lines
Quoted 81 lines · Denys Dmytriyenko
Quoted 80 lines · Khem Raj
Quoted 18 lines

This fixes problems during cross compile where it starts to peek into build host's include and library paths and causes errors with clang and QA warnings with gcc

---
 ...-Remove-use-of-includedir-and-libdir.patch | 37 +++++++++++++++++++
 recipes-ti/ipc/ti-rpmsg-char-examples_git.bb  |  2 +
 2 files changed, 39 insertions(+)
 create mode 100644 recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch
recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch new file +1 -0
new file mode 100644
index 00000000..34807152
@@ -0,0 +1,37 @@
+From 1a26cb577ba54dd9214eeb94fed0ce3a0f4603b6 Mon Sep 17 00:00:00 2001

recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch line 11

Quoted 10 lines
recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch new file +10 -0
+From: Khem Raj <[email protected]>
+Date: Sat, 24 Oct 2020 23:46:39 -0700
+Subject: [PATCH] examples: Remove use of includedir and libdir
+
+These point to standard include and library paths which already are used
+from sysroot relative paths secondly, they use absolute paths which
+means we are asking to add -I/usr/include which might be ok in a native
+build but not in cross build. This helps mitigate QA errors found with
+OE build system since it finds it adding host include and library search
+paths to linker/compiler commandline

What's the Upstream-Status on this? Should it be "Inappropriate [OE-specific]"?

Quoted 45 lines
recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch new file +25 -0
+Signed-off-by: Khem Raj <[email protected]>
+---
+ examples/Makefile.am | 5 +----
+ 1 file changed, 1 insertion(+), 4 deletions(-)
+
+diff --git a/examples/Makefile.am b/examples/Makefile.am
+index 5a9bedb..d547e41 100644
+--- a/examples/Makefile.am
++++ b/examples/Makefile.am
+@@ -1,6 +1,4 @@
+-INCLUDE = -I${includedir}
+-
+-AM_CFLAGS = -Wall -g -O2 $(INCLUDE)
++AM_CFLAGS = -Wall -g -O2
+
+ bin_PROGRAMS = rpmsg_char_simple
+
+@@ -8,4 +6,3 @@ bin_PROGRAMS = rpmsg_char_simple
+ rpmsg_char_simple_SOURCES = rpmsg_char_simple.c
+ rpmsg_char_simple_CPPFLAGS = $(AM_CFLAGS)
+ rpmsg_char_simple_LDADD = -lpthread -lti_rpmsg_char
+-rpmsg_char_simple_LDFLAGS = -L${libdir}
+--
+2.29.1
+
recipes-ti/ipc/ti-rpmsg-char-examples_git.bb +2 -1
index 142e5bf0..cbe4d7fd 100644
@@ -2,6 +2,8 @@ SUMMARY = "TI RPMsg Char Sample Applications and Tests"
 
 require ti-rpmsg-char.inc
 
+SRC_URI += "file://0001-examples-Remove-use-of-includedir-and-libdir.patch"
+
 DEPENDS = "ti-rpmsg-char"
 
 inherit autotools pkgconfig
--

2.29.1

author
#13 lore raw
Quoted 7 lines · Denys Dmytriyenko
Quoted 5 lines · Denys Dmytriyenko via lists.yoctoproject.org
Quoted 3 lines · Khem Raj

I think it should be applied but then I don't know how else this component is used. maybe there are some toolchains which don't have sysrooots used to compile this

Quoted 8 lines
Quoted 2 lines

This is meant to be cross-compiled for the target, in which case accessing host headers or libraries is a bad idea regardless of the toolchain...

Khem, Suman,

Any conclusion here? Should this change be taken upstream by Suman? Or should this reside here as a patch with "Upstream-Status: Inappropriate [OE-specific]"?

its needed in OE for sure. Other places I don't know so literally your call.

Quoted 89 lines

Denys

Quoted 85 lines
Quoted 81 lines · Denys Dmytriyenko
Quoted 80 lines · Khem Raj
Quoted 18 lines

This fixes problems during cross compile where it starts to peek into build host's include and library paths and causes errors with clang and QA warnings with gcc

---
 ...-Remove-use-of-includedir-and-libdir.patch | 37 +++++++++++++++++++
 recipes-ti/ipc/ti-rpmsg-char-examples_git.bb  |  2 +
 2 files changed, 39 insertions(+)
 create mode 100644 recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch
recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch new file +1 -0
new file mode 100644
index 00000000..34807152
@@ -0,0 +1,37 @@
+From 1a26cb577ba54dd9214eeb94fed0ce3a0f4603b6 Mon Sep 17 00:00:00 2001

recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch line 11

Quoted 10 lines
recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch new file +10 -0
+From: Khem Raj <[email protected]>
+Date: Sat, 24 Oct 2020 23:46:39 -0700
+Subject: [PATCH] examples: Remove use of includedir and libdir
+
+These point to standard include and library paths which already are used
+from sysroot relative paths secondly, they use absolute paths which
+means we are asking to add -I/usr/include which might be ok in a native
+build but not in cross build. This helps mitigate QA errors found with
+OE build system since it finds it adding host include and library search
+paths to linker/compiler commandline

What's the Upstream-Status on this? Should it be "Inappropriate [OE-specific]"?

Quoted 45 lines
recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch new file +25 -0
+Signed-off-by: Khem Raj <[email protected]>
+---
+ examples/Makefile.am | 5 +----
+ 1 file changed, 1 insertion(+), 4 deletions(-)
+
+diff --git a/examples/Makefile.am b/examples/Makefile.am
+index 5a9bedb..d547e41 100644
+--- a/examples/Makefile.am
++++ b/examples/Makefile.am
+@@ -1,6 +1,4 @@
+-INCLUDE = -I${includedir}
+-
+-AM_CFLAGS = -Wall -g -O2 $(INCLUDE)
++AM_CFLAGS = -Wall -g -O2
+
+ bin_PROGRAMS = rpmsg_char_simple
+
+@@ -8,4 +6,3 @@ bin_PROGRAMS = rpmsg_char_simple
+ rpmsg_char_simple_SOURCES = rpmsg_char_simple.c
+ rpmsg_char_simple_CPPFLAGS = $(AM_CFLAGS)
+ rpmsg_char_simple_LDADD = -lpthread -lti_rpmsg_char
+-rpmsg_char_simple_LDFLAGS = -L${libdir}
+--
+2.29.1
+
recipes-ti/ipc/ti-rpmsg-char-examples_git.bb +2 -1
index 142e5bf0..cbe4d7fd 100644
@@ -2,6 +2,8 @@ SUMMARY = "TI RPMsg Char Sample Applications and Tests"
 
 require ti-rpmsg-char.inc
 
+SRC_URI += "file://0001-examples-Remove-use-of-includedir-and-libdir.patch"
+
 DEPENDS = "ti-rpmsg-char"
 
 inherit autotools pkgconfig
--

2.29.1

#14 lore raw

Hi Denys,

Quoted 11 lines · Khem Raj
Quoted 10 lines · Denys Dmytriyenko
Quoted 7 lines · Denys Dmytriyenko via lists.yoctoproject.org
Quoted 3 lines · Khem Raj

I think it should be applied but then I don't know how else this component is used. maybe there are some toolchains which don't have sysrooots used to compile this

This is meant to be cross-compiled for the target, in which case accessing host headers or libraries is a bad idea regardless of the toolchain...

Quoted 7 lines
Quoted 5 lines

Khem, Suman,

Any conclusion here? Should this change be taken upstream by Suman? Or should this reside here as a patch with "Upstream-Status: Inappropriate [OE-specific]"?

its needed in OE for sure. Other places I don't know so literally your call.

If it is needed by OE, I am ok with this going in for now. I will leave it to your expertise for the ack for this patch.

I need to look into this a bit more to see if I need to revise the build stuff in the actual source repo, or I need to tweak the OE recipe to keep both happy. I also cross-compile on my host machine when directly using automake, and as such I don't use --prefix as /usr.

I need to have a successful OE environment for me to evaluate a proper fix, but I am currently running into various issues when building tisdk-default-image (tisdk-tiny-image and tisdk-base-image were ok).

regards
Suman

Quoted 94 lines
Quoted 94 lines

Denys

Quoted 85 lines
Quoted 81 lines · Denys Dmytriyenko
Quoted 80 lines · Khem Raj
Quoted 18 lines

This fixes problems during cross compile where it starts to peek into build host's include and library paths and causes errors with clang and QA warnings with gcc

---
 ...-Remove-use-of-includedir-and-libdir.patch | 37 +++++++++++++++++++
 recipes-ti/ipc/ti-rpmsg-char-examples_git.bb  |  2 +
 2 files changed, 39 insertions(+)
 create mode 100644 recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch
recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch new file +1 -0
new file mode 100644
index 00000000..34807152
@@ -0,0 +1,37 @@
+From 1a26cb577ba54dd9214eeb94fed0ce3a0f4603b6 Mon Sep 17 00:00:00 2001

recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch line 11

Quoted 10 lines
recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch new file +10 -0
+From: Khem Raj <[email protected]>
+Date: Sat, 24 Oct 2020 23:46:39 -0700
+Subject: [PATCH] examples: Remove use of includedir and libdir
+
+These point to standard include and library paths which already are used
+from sysroot relative paths secondly, they use absolute paths which
+means we are asking to add -I/usr/include which might be ok in a native
+build but not in cross build. This helps mitigate QA errors found with
+OE build system since it finds it adding host include and library search
+paths to linker/compiler commandline

What's the Upstream-Status on this? Should it be "Inappropriate [OE-specific]"?

Quoted 45 lines
recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch new file +25 -0
+Signed-off-by: Khem Raj <[email protected]>
+---
+ examples/Makefile.am | 5 +----
+ 1 file changed, 1 insertion(+), 4 deletions(-)
+
+diff --git a/examples/Makefile.am b/examples/Makefile.am
+index 5a9bedb..d547e41 100644
+--- a/examples/Makefile.am
++++ b/examples/Makefile.am
+@@ -1,6 +1,4 @@
+-INCLUDE = -I${includedir}
+-
+-AM_CFLAGS = -Wall -g -O2 $(INCLUDE)
++AM_CFLAGS = -Wall -g -O2
+
+ bin_PROGRAMS = rpmsg_char_simple
+
+@@ -8,4 +6,3 @@ bin_PROGRAMS = rpmsg_char_simple
+ rpmsg_char_simple_SOURCES = rpmsg_char_simple.c
+ rpmsg_char_simple_CPPFLAGS = $(AM_CFLAGS)
+ rpmsg_char_simple_LDADD = -lpthread -lti_rpmsg_char
+-rpmsg_char_simple_LDFLAGS = -L${libdir}
+--
+2.29.1
+
recipes-ti/ipc/ti-rpmsg-char-examples_git.bb +2 -1
index 142e5bf0..cbe4d7fd 100644
@@ -2,6 +2,8 @@ SUMMARY = "TI RPMsg Char Sample Applications and Tests"
 
 require ti-rpmsg-char.inc
 
+SRC_URI += "file://0001-examples-Remove-use-of-includedir-and-libdir.patch"
+
 DEPENDS = "ti-rpmsg-char"
 
 inherit autotools pkgconfig
--

2.29.1

#15 lore raw
Quoted 25 lines · Suman Anna

Hi Denys,

Quoted 11 lines · Khem Raj
Quoted 10 lines · Denys Dmytriyenko
Quoted 7 lines · Denys Dmytriyenko via lists.yoctoproject.org
Quoted 3 lines · Khem Raj

I think it should be applied but then I don't know how else this component is used. maybe there are some toolchains which don't have sysrooots used to compile this

This is meant to be cross-compiled for the target, in which case accessing host headers or libraries is a bad idea regardless of the toolchain...

Quoted 7 lines
Quoted 5 lines

Khem, Suman,

Any conclusion here? Should this change be taken upstream by Suman? Or should this reside here as a patch with "Upstream-Status: Inappropriate [OE-specific]"?

its needed in OE for sure. Other places I don't know so literally your call.

If it is needed by OE, I am ok with this going in for now. I will leave it to your expertise for the ack for this patch.

Quoted 8 lines

I need to look into this a bit more to see if I need to revise the build stuff in the actual source repo, or I need to tweak the OE recipe to keep both happy. I also cross-compile on my host machine when directly using automake, and as such I don't use --prefix as /usr.

I need to have a successful OE environment for me to evaluate a proper fix, but I am currently running into various issues when building tisdk-default-image (tisdk-tiny-image and tisdk-base-image were ok).

Thanks, Suman.

So I guess we can carry this patch in meta-ti for now, until you get a chance to look into it a bit closer.

Khem,

Do you want to send v2 with Upstream-Statu: either Pending or Inappropriate?

Denys

Quoted 98 lines

regards
Suman

Quoted 94 lines
Quoted 94 lines

Denys

Quoted 85 lines
Quoted 81 lines · Denys Dmytriyenko
Quoted 80 lines · Khem Raj
Quoted 18 lines

This fixes problems during cross compile where it starts to peek into build host's include and library paths and causes errors with clang and QA warnings with gcc

---
 ...-Remove-use-of-includedir-and-libdir.patch | 37 +++++++++++++++++++
 recipes-ti/ipc/ti-rpmsg-char-examples_git.bb  |  2 +
 2 files changed, 39 insertions(+)
 create mode 100644 recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch
recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch new file +1 -0
new file mode 100644
index 00000000..34807152
@@ -0,0 +1,37 @@
+From 1a26cb577ba54dd9214eeb94fed0ce3a0f4603b6 Mon Sep 17 00:00:00 2001

recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch line 11

Quoted 10 lines
recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch new file +10 -0
+From: Khem Raj <[email protected]>
+Date: Sat, 24 Oct 2020 23:46:39 -0700
+Subject: [PATCH] examples: Remove use of includedir and libdir
+
+These point to standard include and library paths which already are used
+from sysroot relative paths secondly, they use absolute paths which
+means we are asking to add -I/usr/include which might be ok in a native
+build but not in cross build. This helps mitigate QA errors found with
+OE build system since it finds it adding host include and library search
+paths to linker/compiler commandline

What's the Upstream-Status on this? Should it be "Inappropriate [OE-specific]"?

Quoted 45 lines
recipes-ti/ipc/ti-rpmsg-char-examples/0001-examples-Remove-use-of-includedir-and-libdir.patch new file +25 -0
+Signed-off-by: Khem Raj <[email protected]>
+---
+ examples/Makefile.am | 5 +----
+ 1 file changed, 1 insertion(+), 4 deletions(-)
+
+diff --git a/examples/Makefile.am b/examples/Makefile.am
+index 5a9bedb..d547e41 100644
+--- a/examples/Makefile.am
++++ b/examples/Makefile.am
+@@ -1,6 +1,4 @@
+-INCLUDE = -I${includedir}
+-
+-AM_CFLAGS = -Wall -g -O2 $(INCLUDE)
++AM_CFLAGS = -Wall -g -O2
+
+ bin_PROGRAMS = rpmsg_char_simple
+
+@@ -8,4 +6,3 @@ bin_PROGRAMS = rpmsg_char_simple
+ rpmsg_char_simple_SOURCES = rpmsg_char_simple.c
+ rpmsg_char_simple_CPPFLAGS = $(AM_CFLAGS)
+ rpmsg_char_simple_LDADD = -lpthread -lti_rpmsg_char
+-rpmsg_char_simple_LDFLAGS = -L${libdir}
+--
+2.29.1
+
recipes-ti/ipc/ti-rpmsg-char-examples_git.bb +2 -1
index 142e5bf0..cbe4d7fd 100644
@@ -2,6 +2,8 @@ SUMMARY = "TI RPMsg Char Sample Applications and Tests"
 
 require ti-rpmsg-char.inc
 
+SRC_URI += "file://0001-examples-Remove-use-of-includedir-and-libdir.patch"
+
 DEPENDS = "ti-rpmsg-char"
 
 inherit autotools pkgconfig
--

2.29.1