Skip to contentSkip to conversation

powerpc/8xx: select CPM1 for MPC8XXFADS

PATCH In review [email protected] 2 participants 3 messages Jun 1, 2021 – Jun 2, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powerpc/8xx: select CPM1 for MPC8XXFADS

From: Tom Rix <[email protected]>

With MPC8XXFADS, there is this linker error
ppc64-linux-ld: m8xx_setup.o: in function `cpm_cascade':
m8xx_setup.c: undefined reference to `cpm_get_irq'

cpm_get_irq() is conditionally complied by CPM1
So add a select, like the other plaforms

---
 arch/powerpc/platforms/8xx/Kconfig | 1 +
 1 file changed, 1 insertion(+)
arch/powerpc/platforms/8xx/Kconfig +1 -0
index 60cc5b537a98..919082cdb2f1 100644
@@ -10,6 +10,7 @@ choice
 
 config MPC8XXFADS
 	bool "FADS"
+	select CPM1
 
 config MPC86XADS
 	bool "MPC86XADS"
Signature · 1 line
2.26.3
#1 lore raw

Le 01/06/2021 à 19:53, [email protected] a écrit :

Quoted 5 lines

From: Tom Rix <[email protected]>

With MPC8XXFADS, there is this linker error
ppc64-linux-ld: m8xx_setup.o: in function `cpm_cascade':
m8xx_setup.c: undefined reference to `cpm_get_irq'

It looks like this config item is stale, it doesn't build any board support, there is no define_machine() for this config item, no file is linked to that config item.

I think you should just remove that item from the possible choices.

Christophe

Quoted 22 lines

cpm_get_irq() is conditionally complied by CPM1
So add a select, like the other plaforms

---
  arch/powerpc/platforms/8xx/Kconfig | 1 +
  1 file changed, 1 insertion(+)
arch/powerpc/platforms/8xx/Kconfig +1 -0
index 60cc5b537a98..919082cdb2f1 100644
@@ -10,6 +10,7 @@ choice
 
  config MPC8XXFADS
  	bool "FADS"
+	select CPM1
 
  config MPC86XADS
  	bool "MPC86XADS"
author
#2 lore raw
Quoted 5 lines · Christophe Leroy

Le 01/06/2021 à 19:53, [email protected] a écrit :

Quoted 2 lines

From: Tom Rix <[email protected]>

Quoted 8 lines
Quoted 3 lines

With MPC8XXFADS, there is this linker error
ppc64-linux-ld: m8xx_setup.o: in function `cpm_cascade':
m8xx_setup.c: undefined reference to `cpm_get_irq'

It looks like this config item is stale, it doesn't build any board support, there is no define_machine() for this config item, no file is linked to that config item.

I think you should just remove that item from the possible choices.

Yes, this looks like a dead config and removing it is what to do.

I withdraw this change.

I am looking at sweeping the tree of dead configs.

Up a dir, my finder shows

PPC_MMU_NOHASH_32

is another (maybe) dead config.

Thanks for pointing this out,

Tom

Quoted 24 lines

Christophe

Quoted 20 lines

cpm_get_irq() is conditionally complied by CPM1
So add a select, like the other plaforms

---
  arch/powerpc/platforms/8xx/Kconfig | 1 +

  1 file changed, 1 insertion(+)
arch/powerpc/platforms/8xx/Kconfig +0 -0
index 60cc5b537a98..919082cdb2f1 100644
@@ -10,6 +10,7 @@ choice

    config MPC8XXFADS
      bool "FADS"
+    select CPM1
    config MPC86XADS
      bool "MPC86XADS"