Skip to contentSkip to conversation

core/pkg-utils: add missing bracket/sep

PATCH Applied James Hilliard 2 participants 2 messages Jan 9, 2022

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 core/pkg-utils: add missing bracket/sep

This appears to have been incorrectly removed in:
03aa3e6ac71a0fe1ff87fe192c8de0b1acebd0df

Fixes:
package/pkg-utils.mk:212: *** unterminated call to function 'foreach': missing ')'. Stop.
make: *** [Makefile:84: _all] Error 2

---
Changes v1 -> v2:
- add sep as well

---
 package/pkg-utils.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/pkg-utils.mk +1 -1
index 6aa64a2096..7d1aea7710 100644
@@ -214,7 +214,7 @@ define per-package-rsync
 	$(foreach pkg,$(1),\
 		rsync -a --link-dest=$(PER_PACKAGE_DIR)/$(pkg)/$(2)/ \
 			$(PER_PACKAGE_DIR)/$(pkg)/$(2)/ \
-			$(3)
+			$(3)$(sep))
 endef
 
 # prepares the per-package HOST_DIR and TARGET_DIR of the current
Signature · 6 lines
2.25.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw
Quoted 8 lines · James Hilliard

This appears to have been incorrectly removed in:
03aa3e6ac71a0fe1ff87fe192c8de0b1acebd0df

Fixes:
package/pkg-utils.mk:212: *** unterminated call to function 'foreach': missing ')'. Stop.
make: *** [Makefile:84: _all] Error 2

Applied to master, thanks.

Regards,
Arnout

Quoted 13 lines

---
Changes v1 -> v2:
- add sep as well

---
  package/pkg-utils.mk | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
package/pkg-utils.mk +0 -0
index 6aa64a2096..7d1aea7710 100644

package/pkg-utils.mk define per-package-rsync · line 220

Quoted 8 lines
package/pkg-utils.mk +1 -1
@@ -214,7 +214,7 @@ define per-package-rsync
  	$(foreach pkg,$(1),\
  		rsync -a --link-dest=$(PER_PACKAGE_DIR)/$(pkg)/$(2)/ \
  			$(PER_PACKAGE_DIR)/$(pkg)/$(2)/ \
-			$(3)
+			$(3)$(sep))
  endef
 
  # prepares the per-package HOST_DIR and TARGET_DIR of the current

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot