Skip to contentSkip to conversation

myri10ge: Prefer unsigned int to bare use of unsigned

PATCH New [email protected] 1 participant 1 message Jul 17, 2023 1 message not in the archive

Subsystems (3)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 myri10ge: Prefer unsigned int to bare use of unsigned

Fix checkpatch warnings:

./drivers/net/ethernet/myricom/myri10ge/myri10ge.c:572: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' ./drivers/net/ethernet/myricom/myri10ge/myri10ge.c:579: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' ./drivers/net/ethernet/myricom/myri10ge/myri10ge.c:614: WARNING: Prefer 'unsigned int' to bare use of 'unsigned'

---
 drivers/net/ethernet/myricom/myri10ge/myri10ge.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/net/ethernet/myricom/myri10ge/myri10ge.c +0 -0
index 65d7057..8de2e5e 100644
@@ -569,14 +569,14 @@ static void myri10ge_dummy_rdma(struct myri10ge_priv *mgp, int enable)
 
 static int myri10ge_load_hotplug_firmware(struct myri10ge_priv *mgp, 

u32 * size)
{
- unsigned crc, reread_crc;

+    unsigned int crc, reread_crc;
     const struct firmware *fw;
     struct device *dev = &mgp->pdev->dev;
     unsigned char *fw_readback;
     struct mcp_gen_header *hdr;
     size_t hdr_offset;
     int status;

- unsigned i;
+ unsigned int i;

if (request_firmware(&fw, mgp->fw_name, dev) < 0) {
dev_err(dev, "Unable to load %s firmware image via hotplug\n",
@@ -611,7 +611,7 @@ static int myri10ge_load_hotplug_firmware(struct myri10ge_priv *mgp, u32 * size)

     for (i = 0; i < fw->size; i += 256) {
         myri10ge_pio_copy(mgp->sram + MYRI10GE_FW_OFFSET + i,
                   fw->data + i,
-                  min(256U, (unsigned)(fw->size - i)));
+                  min(256U, (unsigned int)(fw->size - i)));
         mb();
         readb(mgp->sram);
     }