amdgpu/amdgpu_ids: fix kmalloc_array not uses number as first arg
Subsystems (2)
PATCH 1/1 amdgpu/amdgpu_ids: fix kmalloc_array not uses number as first arg
Fix check_patch.pl warning:kmalloc_array uses number as first arg, sizeof is generally wrong. +fences = kmalloc_array(sizeof(void *), id_mgr->num_ids, GFP_KERNEL);
--- drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c +1 -1
@@ -208,7 +208,7 @@ static int amdgpu_vmid_grab_idle(struct amdgpu_vm *vm,if (ring->vmid_wait && !dma_fence_is_signaled (ring->vmid_wait))return amdgpu_sync_fence (sync, ring->vmid_wait); - fences =kmalloc_array (sizeof (void *), id_mgr->num_ids,GFP_KERNEL ); + fences =kmalloc_array (id_mgr->num_ids,sizeof (void *),GFP_KERNEL );if (!fences)return -ENOMEM ;
Signature · 6 lines
2.29.0 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Am 18.11.20 um 03:42 schrieb Bernard Zhao:
Quoted 6 lines
Fix check_patch.pl warning:
kmalloc_arrayuses number as first arg, sizeof is generally wrong. +fences =kmalloc_array(sizeof(void *), id_mgr->num_ids, GFP_KERNEL);Signed-off-by Bernard Zhao <[email protected]>
Quoted 9 lines
--- drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c +0
-0
drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c static int amdgpu_vmid_grab_idle(struct amdgpu_vm *vm, · line 214
Quoted 8 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c +1
-1@@ -208,7 +208,7 @@ static int amdgpu_vmid_grab_idle(struct amdgpu_vm *vm,if (ring->vmid_wait && !dma_fence_is_signaled (ring->vmid_wait))return amdgpu_sync_fence (sync, ring->vmid_wait); - fences =kmalloc_array (sizeof (void *), id_mgr->num_ids,GFP_KERNEL ); + fences =kmalloc_array (id_mgr->num_ids,sizeof (void *),GFP_KERNEL );if (!fences)return -ENOMEM ;
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Alex Deucher
AppliedApplied. Thanks!
Alex
Quoted 23 lines · Christian König
Am 18.11.20 um 03:42 schrieb Bernard Zhao:
Quoted 6 lines
Fix check_patch.pl warning:
kmalloc_arrayuses number as first arg, sizeof is generally wrong. +fences =kmalloc_array(sizeof(void *), id_mgr->num_ids, GFP_KERNEL);Signed-off-by Bernard Zhao <[email protected]>Reviewed-by Christian König <[email protected]>Quoted 12 lines
--- drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c +0
-0@@ -208,7 +208,7 @@ static int amdgpu_vmid_grab_idle(struct amdgpu_vm *vm,if (ring->vmid_wait && !dma_fence_is_signaled (ring->vmid_wait))return amdgpu_sync_fence (sync, ring->vmid_wait);
Quoted 10 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c static int amdgpu_vmid_grab_idle(struct amdgpu_vm *vm, · line 214
Quoted 5 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c +1
-1- fences =kmalloc_array (sizeof (void *), id_mgr->num_ids,GFP_KERNEL ); + fences =kmalloc_array (id_mgr->num_ids,sizeof (void *),GFP_KERNEL );if (!fences)return -ENOMEM ;_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx