ata: libata-sata: Use LBA from sense data descriptor
Niklas Cassel
maintainerPATCH 1/1 ata: libata-sata: Use LBA from sense data descriptor
The definition of the LBA field in the sense data descriptor is:
"If definition of the sense data to be returned when a command completes without an error includes an LBA value, then the LBA field contains the defined value. Otherwise, the LBA field contains a copy of the LBA field in the command inputs for the command that completed without an error and returned sense data."
Thus, the LBA field in the sense data descriptor can contain a LBA value that is different from the LBA field in the command input.
Therefore, just like how ata_eh_read_log_10h() overrides qc->result_tf with the LBA in the NCQ Command Error log, override qc->result_tf with the LBA in the Successful NCQ Commands log.
--- drivers/ata/libata-sata.c | 8 ++++++++ 1 file changed, 8 insertions(+)
drivers/ata/libata-sata.c +8 -0
@@ -1556,6 +1556,14 @@ int ata_eh_get_ncq_success_sense(struct ata_link *link)continue ; } +/* LBA in sense data desc can be different from LBA in qc->tf */ + qc->result_tf.lbal = sense[8 ]; + qc->result_tf.lbam = sense[9 ]; + qc->result_tf.lbah = sense[10 ]; + qc->result_tf.hob_lbal = sense[11 ]; + qc->result_tf.hob_lbam = sense[12 ]; + qc->result_tf.hob_lbah = sense[13 ]; +/* Set sense without also setting scsicmd->result */ scsi_build_sense_buffer(dev->flags & ATA_DFLAG_D_SENSE, qc->scsicmd->sense_buffer, sk,
Signature · 1 line
2.49.0
Damien Le Moal
maintainerQuoted 8 lines · Niklas Cassel
The definition of the LBA field in the sense data descriptor is:
"If definition of the sense data to be returned when a command completes without an error includes an LBA value, then the LBA field contains the defined value. Otherwise, the LBA field contains a copy of the LBA field in the command inputs for the command that completed without an error and returned sense data."
Quoted 8 lines
Thus, the LBA field in the sense data descriptor can contain a LBA value that is different from the LBA field in the command input.
Therefore, just like how
ata_eh_read_log_10h()overridesqc->result_tfwith the LBA in the NCQ Command Error log, overrideqc->result_tfwith the LBA in the Successful NCQ Commands log.Signed-off-by Niklas Cassel <[email protected]>
Looks OK to me. Do we want a fixes tag on this one though ? Technically, this is a bug, but no-one has stumbled on it...
Quoted 23 lines
--- drivers/ata/libata-sata.c | 8 ++++++++ 1 file changed, 8 insertions(+)drivers/ata/libata-sata.c +8
-0@@ -1556,6 +1556,14 @@ int ata_eh_get_ncq_success_sense(struct ata_link *link)continue ; } +/* LBA in sense data desc can be different from LBA in qc->tf */ + qc->result_tf.lbal = sense[8 ]; + qc->result_tf.lbam = sense[9 ]; + qc->result_tf.lbah = sense[10 ]; + qc->result_tf.hob_lbal = sense[11 ]; + qc->result_tf.hob_lbam = sense[12 ]; + qc->result_tf.hob_lbah = sense[13 ]; +/* Set sense without also setting scsicmd->result */ scsi_build_sense_buffer(dev->flags & ATA_DFLAG_D_SENSE, qc->scsicmd->sense_buffer, sk,
Signature · 2 lines
Damien Le Moal Western Digital Research